171885 2017-05-09 14:34:09 -0700 Web Inspector: Assertion failed: Cannot select item with unexpected parent bar. (at NavigationBar.js:132) 2017-05-09 15:18:58 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED P2 Normal --- 1 bburg bburg bburg commit-queue inspector-bugzilla-changes mattbaker oldest_to_newest 1306576 0 bburg 2017-05-09 14:34:09 -0700 Seems to be a legit bug, we are setting an identifier as the selected navigation item instead of a NavigationItem. 1306600 1 309546 bburg 2017-05-09 14:53:33 -0700 Created attachment 309546 Patch 1306601 2 309546 mattbaker 2017-05-09 14:56:22 -0700 Comment on attachment 309546 Patch r=me 1306610 3 309546 commit-queue 2017-05-09 15:18:56 -0700 Comment on attachment 309546 Patch Clearing flags on attachment: 309546 Committed r216546: <http://trac.webkit.org/changeset/216546> 1306611 4 commit-queue 2017-05-09 15:18:58 -0700 All reviewed patches have been landed. Closing bug. 309546 2017-05-09 14:53:33 -0700 2017-05-09 15:18:56 -0700 Patch bug-171885-20170509145333.patch text/plain 3487 bburg U3VidmVyc2lvbiBSZXZpc2lvbjogMjE2NTMyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVj dG9yVUkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZwppbmRleCAw NmRjYTM3YjQ3NzdkNWY1OGVlYTdmZTE1MzI5NGEyNjk1ZmI3YzIxLi43YTg4NzExOTEzZjY5ZGEy NmYxODgwNTBmODgyNTEzMTcyZDUxZjQzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9y VUkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwyMSBAQAorMjAxNy0wNS0wOSAgQnJpYW4gQnVyZyAgPGJidXJnQGFwcGxlLmNvbT4KKwor ICAgICAgICBXZWIgSW5zcGVjdG9yOiBBc3NlcnRpb24gZmFpbGVkOiBDYW5ub3Qgc2VsZWN0IGl0 ZW0gd2l0aCB1bmV4cGVjdGVkIHBhcmVudCBiYXIuIChhdCBOYXZpZ2F0aW9uQmFyLmpzOjEzMikK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE3MTg4NQor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRoaXMgbmV3 IGFzc2VydGlvbiByZXZlYWxlZCBhIHJlYWwgbWlzdXNlIG9mIHRoZSBOYXZpZ2F0aW9uQmFyIEFQ SS4KKworICAgICAgICAqIFVzZXJJbnRlcmZhY2UvVmlld3MvTmF2aWdhdGlvbkJhci5qczoKKyAg ICAgICAgKFdlYkluc3BlY3Rvci5OYXZpZ2F0aW9uQmFyLnByb3RvdHlwZS5zZXQgc2VsZWN0ZWRO YXZpZ2F0aW9uSXRlbSk6CisgICAgICAgIEltcHJvdmUgdGhpcyB0byBiZSBhbiBhc3NlcnRpb24g c28gaXQgY2FuIGJlIHBhdXNlZCBhdCB1c2luZyB0aGUgZGVidWdnZXIuCisKKyAgICAgICAgKiBV c2VySW50ZXJmYWNlL1ZpZXdzL1RpbWVsaW5lVGFiQ29udGVudFZpZXcuanM6CisgICAgICAgIChX ZWJJbnNwZWN0b3IuVGltZWxpbmVUYWJDb250ZW50Vmlldy5wcm90b3R5cGUuX2NoYW5nZVZpZXdN b2RlKToKKyAgICAgICAgV2UgbmVlZCB0byBzZXQgYSBOYXZpZ2F0aW9uSXRlbSBhcyB0aGUgc2Vs ZWN0ZWQgaXRlbSwgbm90IGl0cyBpZGVudGlmaWVyLgorICAgICAgICBMb29rIHVwIHRoZSBjb3Jy ZXNwb25kaW5nIGl0ZW0gZm9yIHRoZSBpZGVudGlmaWVyIHRoYXQgd2UgcmVjZWl2ZWQgKHRoZSB2 aWV3IG1vZGUpLgorCiAyMDE3LTA1LTA4ICBCcmlhbiBCdXJnICA8YmJ1cmdAYXBwbGUuY29tPgog CiAgICAgICAgIFdlYiBJbnNwZWN0b3I6IFJUTDogYm94IG1vZGVsIGxhYmVscyBoYXZlIGJhZCBh bGlnbm1lbnQKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNl L1ZpZXdzL05hdmlnYXRpb25CYXIuanMgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVy ZmFjZS9WaWV3cy9OYXZpZ2F0aW9uQmFyLmpzCmluZGV4IGFlZjBhZDgzYTE3MmZkMzA0NWQyZDk2 YzgzMjBhZDAxYzhiZWUwMjIuLjJjNGY5OGNiOTQ3NTI2ZmY2ZDQwMzNhMjViODRkMmUxMjc1MTQx YzAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdz L05hdmlnYXRpb25CYXIuanMKKysrIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZh Y2UvVmlld3MvTmF2aWdhdGlvbkJhci5qcwpAQCAtMTI4LDEwICsxMjgsMTAgQEAgV2ViSW5zcGVj dG9yLk5hdmlnYXRpb25CYXIgPSBjbGFzcyBOYXZpZ2F0aW9uQmFyIGV4dGVuZHMgV2ViSW5zcGVj dG9yLlZpZXcKIAogICAgIHNldCBzZWxlY3RlZE5hdmlnYXRpb25JdGVtKG5hdmlnYXRpb25JdGVt KQogICAgIHsKLSAgICAgICAgaWYgKG5hdmlnYXRpb25JdGVtICYmIG5hdmlnYXRpb25JdGVtLnBh cmVudE5hdmlnYXRpb25CYXIgIT09IHRoaXMpIHsKLSAgICAgICAgICAgIGNvbnNvbGUuZXJyb3Io IkNhbm5vdCBzZWxlY3QgaXRlbSB3aXRoIHVuZXhwZWN0ZWQgcGFyZW50IGJhci4iLCBuYXZpZ2F0 aW9uSXRlbSk7CisgICAgICAgIGxldCBuYXZpZ2F0aW9uSXRlbUhhc090aGVyUGFyZW50ID0gbmF2 aWdhdGlvbkl0ZW0gJiYgbmF2aWdhdGlvbkl0ZW0ucGFyZW50TmF2aWdhdGlvbkJhciAhPT0gdGhp czsKKyAgICAgICAgY29uc29sZS5hc3NlcnQoIW5hdmlnYXRpb25JdGVtSGFzT3RoZXJQYXJlbnQs ICJDYW5ub3Qgc2VsZWN0IGl0ZW0gd2l0aCB1bmV4cGVjdGVkIHBhcmVudCBiYXIuIiwgbmF2aWdh dGlvbkl0ZW0pOworICAgICAgICBpZiAobmF2aWdhdGlvbkl0ZW1IYXNPdGhlclBhcmVudCkKICAg ICAgICAgICAgIHJldHVybjsKLSAgICAgICAgfQogCiAgICAgICAgIC8vIE9ubHkgcmFkaW8gbmF2 aWdhdGlvbiBpdGVtcyBjYW4gYmUgc2VsZWN0ZWQuCiAgICAgICAgIGlmICghKG5hdmlnYXRpb25J dGVtIGluc3RhbmNlb2YgV2ViSW5zcGVjdG9yLlJhZGlvQnV0dG9uTmF2aWdhdGlvbkl0ZW0pKQpk aWZmIC0tZ2l0IGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvVGlt ZWxpbmVUYWJDb250ZW50Vmlldy5qcyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJm YWNlL1ZpZXdzL1RpbWVsaW5lVGFiQ29udGVudFZpZXcuanMKaW5kZXggMWM1NmNhNjI1Y2U3YTc4 NjgyZTAwMTE4YTg5YTI3MjAyODBiMzBkOC4uY2M5OTkzNjA2ZTNkZGM0YjY2YTVlYmVhZWMzZWEw YWYxZTZkZWY3OSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZh Y2UvVmlld3MvVGltZWxpbmVUYWJDb250ZW50Vmlldy5qcworKysgYi9Tb3VyY2UvV2ViSW5zcGVj dG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9UaW1lbGluZVRhYkNvbnRlbnRWaWV3LmpzCkBAIC01 MTMsOCArNTEzLDE0IEBAIFdlYkluc3BlY3Rvci5UaW1lbGluZVRhYkNvbnRlbnRWaWV3ID0gY2xh c3MgVGltZWxpbmVUYWJDb250ZW50VmlldyBleHRlbmRzIFdlYkluCiAgICAgICAgIGlmICh0aGlz Ll92aWV3TW9kZSA9PT0gbW9kZSkKICAgICAgICAgICAgIHJldHVybjsKIAorICAgICAgICBsZXQg bmF2aWdhdGlvbkl0ZW1Gb3JWaWV3TW9kZSA9IHRoaXMuY29udGVudEJyb3dzZXIubmF2aWdhdGlv bkJhci5maW5kTmF2aWdhdGlvbkl0ZW0obW9kZSk7CisgICAgICAgIGNvbnNvbGUuYXNzZXJ0KG5h dmlnYXRpb25JdGVtRm9yVmlld01vZGUsICJDb3VsZG4ndCBmaW5kIG5hdmlnYXRpb24gaXRlbSBm b3IgdGhpcyB2aWV3IG1vZGUuIik7CisgICAgICAgIGlmICghbmF2aWdhdGlvbkl0ZW1Gb3JWaWV3 TW9kZSkKKyAgICAgICAgICAgIHJldHVybjsKKwogICAgICAgICB0aGlzLl92aWV3TW9kZSA9IG1v ZGU7Ci0gICAgICAgIHRoaXMuY29udGVudEJyb3dzZXIubmF2aWdhdGlvbkJhci5zZWxlY3RlZE5h dmlnYXRpb25JdGVtID0gdGhpcy5fdmlld01vZGU7CisKKyAgICAgICAgdGhpcy5jb250ZW50QnJv d3Nlci5uYXZpZ2F0aW9uQmFyLnNlbGVjdGVkTmF2aWdhdGlvbkl0ZW0gPSBuYXZpZ2F0aW9uSXRl bUZvclZpZXdNb2RlOwogCiAgICAgICAgIGlmICghc2VsZWN0ZWRCeVVzZXIpCiAgICAgICAgICAg ICByZXR1cm47Cg==