171876 2017-05-09 12:24:36 -0700 REGRESSION(r213564): Flash audio playback failures 2017-05-15 17:50:54 -0700 1 1 1 Unclassified WebKit WebKit2 WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 bfulgham bfulgham achristensen ap bfulgham ggaren webkit-bug-importer oldest_to_newest 1306497 0 bfulgham 2017-05-09 12:24:36 -0700 Some Flash audio playback stopped working after r213564. This was caused by a syntax error in the regular expression that should have resolved to IOAudioEngineDescription. While reviewing these changes, I also discovered that "iokit-property" requires spaces to be escaped to get a proper match. This patch corrects both problems. 1306498 1 webkit-bug-importer 2017-05-09 12:24:59 -0700 <rdar://problem/32082745> 1307979 2 309923 bfulgham 2017-05-12 12:03:44 -0700 Created attachment 309923 Patch 1307997 3 bfulgham 2017-05-12 12:30:12 -0700 (In reply to Brent Fulgham from comment #2) > Created attachment 309923 [details] > Patch Note: After discussions with the Sandbox experts, I learned that it is NOT necessary to escape spaces in the sandbox rules. 1308026 4 309923 ap 2017-05-12 13:28:56 -0700 Comment on attachment 309923 Patch Unmaintainable. 1308035 5 bfulgham 2017-05-12 13:43:04 -0700 Committed r216790: <http://trac.webkit.org/changeset/216790> 1308909 6 bfulgham 2017-05-15 17:50:54 -0700 Note: Follow-up fixed landed in: Committed r216893: <http://trac.webkit.org/changeset/216893> 309923 2017-05-12 12:03:44 -0700 2017-05-12 13:28:56 -0700 Patch bug-171876-20170512120338.patch text/plain 1907 bfulgham SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDIxNjc3MikKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBACisyMDE3LTA1LTEyICBCcmVudCBG dWxnaGFtICA8YmZ1bGdoYW1AYXBwbGUuY29tPgorCisgICAgICAgIFJFR1JFU1NJT04ocjIxMzU2 NCk6IEZsYXNoIGF1ZGlvIHBsYXliYWNrIGZhaWx1cmVzCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNzE4NzYKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVt LzMyMDgyNzQ1PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgIFRoZSBJT0tpdCBwcm9wZXJ0eSBmaWx0ZXJzIGFkZGVkIGluIHIyMTM1NjQgbmVlZCB0byBi ZSBleHBhbmRlZCB0byBzdXBwb3J0CisgICAgICAgIHNvbWUgRmxhc2ggZmVhdHVyZXMuCisKKyAg ICAgICAgKiBQbHVnaW5Qcm9jZXNzL21hYy9jb20uYXBwbGUuV2ViS2l0LnBsdWdpbi1jb21tb24u c2IuaW46CisKIDIwMTctMDUtMTIgIENocmlzIER1bWV6ICA8Y2R1bWV6QGFwcGxlLmNvbT4KIAog ICAgICAgICBTdG9wIHVzaW5nIFBhc3NSZWZQdHIgdW5kZXIgV2ViS2l0Mi9TaGFyZWQKSW5kZXg6 IFNvdXJjZS9XZWJLaXQyL1BsdWdpblByb2Nlc3MvbWFjL2NvbS5hcHBsZS5XZWJLaXQucGx1Z2lu LWNvbW1vbi5zYi5pbgo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0Mi9QbHVnaW5Qcm9jZXNz L21hYy9jb20uYXBwbGUuV2ViS2l0LnBsdWdpbi1jb21tb24uc2IuaW4JKHJldmlzaW9uIDIxNjU2 MSkKKysrIFNvdXJjZS9XZWJLaXQyL1BsdWdpblByb2Nlc3MvbWFjL2NvbS5hcHBsZS5XZWJLaXQu cGx1Z2luLWNvbW1vbi5zYi5pbgkod29ya2luZyBjb3B5KQpAQCAtNjcsNiArNjcsNyBAQAogICAg IChpb2tpdC1wcm9wZXJ0eSAiSU9WQVJlbmRlcmVySUQiKQogICAgIChpb2tpdC1wcm9wZXJ0eS1y ZWdleCAjIl5NZXRhbFBsdWdpbihOYW1lfENsYXNzTmFtZSkiKQogICAgIChpb2tpdC1wcm9wZXJ0 eSAiTm9BdXRvUm91dGUiKQorICAgIChpb2tpdC1wcm9wZXJ0eSAiUHJvdG9jb2wgQ2hhcmFjdGVy aXN0aWNzIikKICAgICAoaW9raXQtcHJvcGVydHkgIlN1cHBvcnRBdWRpb0FVVUMiKQogICAgIChp b2tpdC1wcm9wZXJ0eSAiYm9hcmQtaWQiKQogICAgIChpb2tpdC1wcm9wZXJ0eSAiaWRQcm9kdWN0 IikKQEAgLTI3OSw2ICsyODAsNyBAQAogCiA7OyBWYXJpb3VzIHNlcnZpY2VzIHJlcXVpcmVkIGJ5 IEFwcEtpdCBhbmQgb3RoZXIgZnJhbWV3b3JrcwogKGFsbG93IG1hY2gtbG9va3VwCisgICAgKGds b2JhbC1uYW1lICJjb20uYXBwbGUuYXVkaW8uQXVkaW9Db21wb25lbnRSZWdpc3RyYXIiKQogICAg IChnbG9iYWwtbmFtZSAiY29tLmFwcGxlLkNvcmVTZXJ2aWNlcy5jb3Jlc2VydmljZXNkIikKICAg ICAoZ2xvYmFsLW5hbWUgImNvbS5hcHBsZS5EaXNrQXJiaXRyYXRpb24uZGlza2FyYml0cmF0aW9u ZCIpCiAgICAgKGdsb2JhbC1uYW1lICJjb20uYXBwbGUuRmlsZUNvb3JkaW5hdGlvbiIpCkBAIC0z MzYsNyArMzM4LDYgQEAKIChhbGxvdyBuZXR3b3JrLWluYm91bmQKICAgICAobG9jYWwgdWRwKSkK IAotCiA7OyBPcGVuIGFuZCBTYXZlIHBhbmVscwogKGRlZmluZSAod2Via2l0LXBvd2VyYm94KQog ICAgIChhbGxvdyBmaWxlLXJlYWQqIChsaXRlcmFsICIvTGlicmFyeS9QcmVmZXJlbmNlcy9jb20u YXBwbGUuVmlld0JyaWRnZS5wbGlzdCIpKQo=