171867 2017-05-09 11:03:08 -0700 -Wreturn-type warning triggered by WebAutomationSession.cpp:851 2017-05-22 11:11:59 -0700 1 1 1 Unclassified WebKit WebKit2 Other PC Linux RESOLVED FIXED P2 Trivial --- 1 mcatanzaro mcatanzaro bugs-noreply commit-queue mcatanzaro zan oldest_to_newest 1306458 0 mcatanzaro 2017-05-09 11:03:08 -0700 [3497/4357] Building CXX object Source.../Automation/WebAutomationSession.cpp.o ../../Source/WebKit2/UIProcess/Automation/WebAutomationSession.cpp: In function ‘WebKit::WebEvent::Modifiers WebKit::protocolModifierToWebEventModifier(Inspector::Protocol::Automation::KeyModifier)’: ../../Source/WebKit2/UIProcess/Automation/WebAutomationSession.cpp:858:1: warning: control reaches end of non-void function [-Wreturn-type] } ^ 1307047 1 309647 mcatanzaro 2017-05-10 15:28:03 -0700 Created attachment 309647 Patch 1311003 2 mcatanzaro 2017-05-20 08:05:31 -0700 Ping reviewers 1311441 3 309647 commit-queue 2017-05-22 11:11:57 -0700 Comment on attachment 309647 Patch Clearing flags on attachment: 309647 Committed r217226: <http://trac.webkit.org/changeset/217226> 1311442 4 commit-queue 2017-05-22 11:11:59 -0700 All reviewed patches have been landed. Closing bug. 309647 2017-05-10 15:28:03 -0700 2017-05-22 11:11:57 -0700 Patch bug-171867-20170510172802.patch text/plain 1337 mcatanzaro U3VidmVyc2lvbiBSZXZpc2lvbjogMjE2NjEwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggZDBjYmZhOGRhOWRhZTY2 NTc1YWE2NmE3ODg1NDUzNzExYjFiZmJlZi4uNjZlNGE1ZTUyYmEwZmIxYzAyNGQ1YmE4ZTRjOGNj ZmFkOWQ5MzM1MyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDE3LTA1LTEwICBNaWNo YWVsIENhdGFuemFybyAgPG1jYXRhbnphcm9AaWdhbGlhLmNvbT4KKworICAgICAgICAtV3JldHVy bi10eXBlIHdhcm5pbmcgdHJpZ2dlcmVkIGJ5IFdlYkF1dG9tYXRpb25TZXNzaW9uLmNwcDo4NTEK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE3MTg2Nwor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogVUlQcm9j ZXNzL0F1dG9tYXRpb24vV2ViQXV0b21hdGlvblNlc3Npb24uY3BwOgorICAgICAgICAoV2ViS2l0 Ojpwcm90b2NvbE1vZGlmaWVyVG9XZWJFdmVudE1vZGlmaWVyKToKKwogMjAxNy0wNS0wOSAgRGVh biBKYWNrc29uICA8ZGlub0BhcHBsZS5jb20+CiAKICAgICAgICAgRGlzYWJsZSBXZWJHTDIgYnkg ZGVmYXVsdApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0F1dG9tYXRpb24v V2ViQXV0b21hdGlvblNlc3Npb24uY3BwIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0F1dG9t YXRpb24vV2ViQXV0b21hdGlvblNlc3Npb24uY3BwCmluZGV4IDIyYTI1YzU0OTAzNmI4YjMzZmM4 ZTI4ZjE2NDVmMDEzYjNhMDU1OWEuLjFmOTU5NWY1ZGUxYjVkYWQ1MDc1MTliNGM2NTI1Y2U0YjU3 Y2U2ZDggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BdXRvbWF0aW9uL1dl YkF1dG9tYXRpb25TZXNzaW9uLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQXV0 b21hdGlvbi9XZWJBdXRvbWF0aW9uU2Vzc2lvbi5jcHAKQEAgLTg1NSw2ICs4NTUsOCBAQCBzdGF0 aWMgV2ViRXZlbnQ6Ok1vZGlmaWVycyBwcm90b2NvbE1vZGlmaWVyVG9XZWJFdmVudE1vZGlmaWVy KEluc3BlY3Rvcjo6UHJvdG9jbwogICAgIGNhc2UgSW5zcGVjdG9yOjpQcm90b2NvbDo6QXV0b21h dGlvbjo6S2V5TW9kaWZpZXI6OkNhcHNMb2NrOgogICAgICAgICByZXR1cm4gV2ViRXZlbnQ6OkNh cHNMb2NrS2V5OwogICAgIH0KKworICAgIFJFTEVBU0VfQVNTRVJUX05PVF9SRUFDSEVEKCk7CiB9 CiAjZW5kaWYgLy8gVVNFKEFQUEtJVCkKIAo=