171851 2017-05-09 00:27:28 -0700 [GTK] Fix compile warnings in CryptoKeyECGCrypt.cpp 2017-05-10 07:05:16 -0700 1 1 1 Unclassified WebKit WebKitGTK WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Minor --- 1 hyungwook.lee hyungwook.lee achristensen bugs-noreply buildbot commit-queue jiewen_tan mcatanzaro oldest_to_newest 1306300 0 hyungwook.lee 2017-05-09 00:27:28 -0700 ../../Source/WebCore/crypto/gcrypt/CryptoKeyECGCrypt.cpp: In function ‘size_t WebCore::curveSize(WebCore::CryptoKeyEC::NamedCurve)’: ../../Source/WebCore/crypto/gcrypt/CryptoKeyECGCrypt.cpp:48:1: warning: control reaches end of non-void function [-Wreturn-type] } ^ ../../Source/WebCore/crypto/gcrypt/CryptoKeyECGCrypt.cpp: In function ‘const char* WebCore::curveName(WebCore::CryptoKeyEC::NamedCurve)’: ../../Source/WebCore/crypto/gcrypt/CryptoKeyECGCrypt.cpp:58:1: warning: control reaches end of non-void function [-Wreturn-type] } ^ ../../Source/WebCore/crypto/gcrypt/CryptoKeyECGCrypt.cpp: In function ‘unsigned int WebCore::uncompressedPointSizeForCurve(WebCore::CryptoKeyEC::NamedCurve)’: ../../Source/WebCore/crypto/gcrypt/CryptoKeyECGCrypt.cpp:68:1: warning: control reaches end of non-void function [-Wreturn-type] } ^ ../../Source/WebCore/crypto/gcrypt/CryptoKeyECGCrypt.cpp: In function ‘unsigned int WebCore::uncompressedFieldElementSizeForCurve(WebCore::CryptoKeyEC::NamedCurve)’: ../../Source/WebCore/crypto/gcrypt/CryptoKeyECGCrypt.cpp:78:1: warning: control reaches end of non-void function [-Wreturn-type] 1306301 1 309483 hyungwook.lee 2017-05-09 00:31:09 -0700 Created attachment 309483 Patch 1306433 2 309483 mcatanzaro 2017-05-09 10:09:55 -0700 Comment on attachment 309483 Patch Actually, I'll make a topic about this on webkit-dev, since we should find a standard way of handling this very common cause of warnings. I've been fixing these by adding a RELEASE_ASSERT_NOT_REACHED() in the default case and not having any code below the switch. 1306496 3 mcatanzaro 2017-05-09 12:21:02 -0700 See https://lists.webkit.org/pipermail/webkit-dev/2017-May/029023.html So far, it looks like most people are favoring the approach you took here. 1306822 4 309483 commit-queue 2017-05-10 07:05:15 -0700 Comment on attachment 309483 Patch Clearing flags on attachment: 309483 Committed r216581: <http://trac.webkit.org/changeset/216581> 1306823 5 commit-queue 2017-05-10 07:05:16 -0700 All reviewed patches have been landed. Closing bug. 309483 2017-05-09 00:31:09 -0700 2017-05-10 07:05:15 -0700 Patch bug-171851-20170509163107.patch text/plain 2006 hyungwook.lee SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDIxNjQ4MSkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBACisyMDE3LTA1LTA5ICBIeXVuZ3dv b2sgTGVlICA8aHl1bmd3b29rLmxlZUBuYXZlcmNvcnAuY29tPgorCisgICAgICAgIFtHVEtdIEZp eCBjb21waWxlIHdhcm5pbmdzIGluIENyeXB0b0tleUVDR0NyeXB0LmNwcAorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTcxODUxCisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBjcnlwdG8vZ2NyeXB0L0NyeXB0 b0tleUVDR0NyeXB0LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OmN1cnZlU2l6ZSk6CisgICAgICAg IChXZWJDb3JlOjpjdXJ2ZU5hbWUpOgorICAgICAgICAoV2ViQ29yZTo6dW5jb21wcmVzc2VkUG9p bnRTaXplRm9yQ3VydmUpOgorICAgICAgICAoV2ViQ29yZTo6dW5jb21wcmVzc2VkRmllbGRFbGVt ZW50U2l6ZUZvckN1cnZlKToKKwogMjAxNy0wNS0wOCAgQ2hyaXMgRHVtZXogIDxjZHVtZXpAYXBw bGUuY29tPgogCiAgICAgICAgIFJlZmFjdG9yIC8gQ2xlYW4gdXAgRE9NV2luZG93LmlkbApJbmRl eDogU291cmNlL1dlYkNvcmUvY3J5cHRvL2djcnlwdC9DcnlwdG9LZXlFQ0dDcnlwdC5jcHAKPT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvY3J5cHRvL2djcnlwdC9DcnlwdG9LZXlFQ0dDcnlw dC5jcHAJKHJldmlzaW9uIDIxNjQ3NCkKKysrIFNvdXJjZS9XZWJDb3JlL2NyeXB0by9nY3J5cHQv Q3J5cHRvS2V5RUNHQ3J5cHQuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC00NSw2ICs0NSw5IEBAIHN0 YXRpYyBzaXplX3QgY3VydmVTaXplKENyeXB0b0tleUVDOjpOYW0KICAgICBjYXNlIENyeXB0b0tl eUVDOjpOYW1lZEN1cnZlOjpQMzg0OgogICAgICAgICByZXR1cm4gMzg0OwogICAgIH0KKworICAg IEFTU0VSVF9OT1RfUkVBQ0hFRCgpOworICAgIHJldHVybiAwOwogfQogCiBzdGF0aWMgY29uc3Qg Y2hhciogY3VydmVOYW1lKENyeXB0b0tleUVDOjpOYW1lZEN1cnZlIGN1cnZlKQpAQCAtNTUsNiAr NTgsOSBAQCBzdGF0aWMgY29uc3QgY2hhciogY3VydmVOYW1lKENyeXB0b0tleUVDCiAgICAgY2Fz ZSBDcnlwdG9LZXlFQzo6TmFtZWRDdXJ2ZTo6UDM4NDoKICAgICAgICAgcmV0dXJuICJOSVNUIFAt Mzg0IjsKICAgICB9CisKKyAgICBBU1NFUlRfTk9UX1JFQUNIRUQoKTsKKyAgICByZXR1cm4gbnVs bHB0cjsKIH0KIAogc3RhdGljIHVuc2lnbmVkIHVuY29tcHJlc3NlZFBvaW50U2l6ZUZvckN1cnZl KENyeXB0b0tleUVDOjpOYW1lZEN1cnZlIGN1cnZlKQpAQCAtNjUsNiArNzEsOSBAQCBzdGF0aWMg dW5zaWduZWQgdW5jb21wcmVzc2VkUG9pbnRTaXplRm9yCiAgICAgY2FzZSBDcnlwdG9LZXlFQzo6 TmFtZWRDdXJ2ZTo6UDM4NDoKICAgICAgICAgcmV0dXJuIDk3OwogICAgIH0KKworICAgIEFTU0VS VF9OT1RfUkVBQ0hFRCgpOworICAgIHJldHVybiAwOwogfQogCiBzdGF0aWMgdW5zaWduZWQgdW5j b21wcmVzc2VkRmllbGRFbGVtZW50U2l6ZUZvckN1cnZlKENyeXB0b0tleUVDOjpOYW1lZEN1cnZl IGN1cnZlKQpAQCAtNzUsNiArODQsOSBAQCBzdGF0aWMgdW5zaWduZWQgdW5jb21wcmVzc2VkRmll bGRFbGVtZW50CiAgICAgY2FzZSBDcnlwdG9LZXlFQzo6TmFtZWRDdXJ2ZTo6UDM4NDoKICAgICAg ICAgcmV0dXJuIDQ4OwogICAgIH0KKworICAgIEFTU0VSVF9OT1RfUkVBQ0hFRCgpOworICAgIHJl dHVybiAwOwogfQogCiBzdGF0aWMgVmVjdG9yPHVpbnQ4X3Q+IGV4dHJhY3RNUElEYXRhKGdjcnlf bXBpX3QgbXBpKQo=