171850 2017-05-09 00:09:16 -0700 [GTK] Fix compile warnings in PlatformImageCairo.cpp 2017-05-12 15:02:16 -0700 1 1 1 Unclassified WebKit WebKitGTK WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Minor --- 1 hyungwook.lee hyungwook.lee bugs-noreply cdumez commit-queue mcatanzaro oldest_to_newest 1306290 0 hyungwook.lee 2017-05-09 00:09:16 -0700 ../../Tools/ImageDiff/cairo/PlatformImageCairo.cpp:53:42: warning: ignoring return value of ‘size_t fread(void*, size_t, size_t, FILE*)’, declared with attribute warn_unused_result [-Wunused-result] fread(data, 1, length, stdin); 1306297 1 309481 hyungwook.lee 2017-05-09 00:19:44 -0700 Created attachment 309481 Patch 1306355 2 309481 mcatanzaro 2017-05-09 06:45:40 -0700 Comment on attachment 309481 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=309481&action=review > Tools/ImageDiff/cairo/PlatformImageCairo.cpp:54 > + return readBytes ? CAIRO_STATUS_SUCCESS : CAIRO_STATUS_READ_ERROR; I would be stricter: return readBytes == length ? CAIRO_STATUS_SUCCESS : CAIRO_STATUS_READ_ERROR; Note that only works because the second parameter, size, is 1. > Tools/ImageDiff/cairo/PlatformImageCairo.cpp:129 > + return writtenBytes ? CAIRO_STATUS_SUCCESS : CAIRO_STATUS_WRITE_ERROR; Ditto: return writtenBytes == length ? CAIRO_STATUS_SUCCESS : CAIRO_STATUS_WRITE_ERROR; 1306678 3 309563 hyungwook.lee 2017-05-09 17:05:14 -0700 Created attachment 309563 Patch 1306679 4 hyungwook.lee 2017-05-09 17:06:58 -0700 (In reply to Michael Catanzaro from comment #2) > Comment on attachment 309481 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=309481&action=review > > > Tools/ImageDiff/cairo/PlatformImageCairo.cpp:54 > > + return readBytes ? CAIRO_STATUS_SUCCESS : CAIRO_STATUS_READ_ERROR; > > I would be stricter: > > return readBytes == length ? CAIRO_STATUS_SUCCESS : CAIRO_STATUS_READ_ERROR; > > Note that only works because the second parameter, size, is 1. > > > Tools/ImageDiff/cairo/PlatformImageCairo.cpp:129 > > + return writtenBytes ? CAIRO_STATUS_SUCCESS : CAIRO_STATUS_WRITE_ERROR; > > Ditto: > > return writtenBytes == length ? CAIRO_STATUS_SUCCESS : > CAIRO_STATUS_WRITE_ERROR; Nice point, I've update the patch as you mentioned. 1306680 5 hyungwook.lee 2017-05-09 17:08:07 -0700 length 1308082 6 309563 commit-queue 2017-05-12 15:02:14 -0700 Comment on attachment 309563 Patch Clearing flags on attachment: 309563 Committed r216795: <http://trac.webkit.org/changeset/216795> 1308083 7 commit-queue 2017-05-12 15:02:16 -0700 All reviewed patches have been landed. Closing bug. 309481 2017-05-09 00:19:44 -0700 2017-05-09 17:05:08 -0700 Patch bug-171850-20170509161942.patch text/plain 2006 hyungwook.lee SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDIxNjQ4MCkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE0IEBACisyMDE3LTA1LTA5ICBIeXVuZ3dvb2sgTGVlICA8aHl1bmd3b29rLmxlZUBuYXZl cmNvcnAuY29tPgorCisgICAgICAgIFtHVEtdIEZpeCBjb21waWxlIHdhcm5pbmdzIGluIFBsYXRm b3JtSW1hZ2VDYWlyby5jcHAKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTE3MTg1MAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgICogSW1hZ2VEaWZmL2NhaXJvL1BsYXRmb3JtSW1hZ2VDYWlyby5jcHA6CisgICAg ICAgIChJbWFnZURpZmY6OlBsYXRmb3JtSW1hZ2U6OmNyZWF0ZUZyb21TdGRpbik6CisgICAgICAg IChJbWFnZURpZmY6OlBsYXRmb3JtSW1hZ2U6OndyaXRlQXNQTkdUb1N0ZG91dCk6CisKIDIwMTct MDUtMDggIEpvbmF0aGFuIEJlZGFyZCAgPGpiZWRhcmRAYXBwbGUuY29tPgogCiAgICAgICAgIElt cGxlbWVudCBQbGF0Zm9ybVdlYlZpZXc6OndpbmRvd1NuYXBzaG90SW1hZ2UgYW5kIGNyZWF0ZUJp dG1hcENvbnRleHRGcm9tV2ViVmlldyBmb3IgaU9TIGRldmljZXMKSW5kZXg6IFRvb2xzL0ltYWdl RGlmZi9jYWlyby9QbGF0Zm9ybUltYWdlQ2Fpcm8uY3BwCj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFRvb2xzL0lt YWdlRGlmZi9jYWlyby9QbGF0Zm9ybUltYWdlQ2Fpcm8uY3BwCShyZXZpc2lvbiAyMTY0NzQpCisr KyBUb29scy9JbWFnZURpZmYvY2Fpcm8vUGxhdGZvcm1JbWFnZUNhaXJvLmNwcAkod29ya2luZyBj b3B5KQpAQCAtNTAsOCArNTAsOCBAQCBzdGQ6OnVuaXF1ZV9wdHI8UGxhdGZvcm1JbWFnZT4gUGxh dGZvcm1JCiAgICAgICAgICAgICBhdXRvJiBjb250ZXh0ID0gKnN0YXRpY19jYXN0PFJlYWRDb250 ZXh0Kj4oY2xvc3VyZSk7CiAgICAgICAgICAgICBjb250ZXh0LnJlYWRCeXRlcyArPSBsZW5ndGg7 CiAKLSAgICAgICAgICAgIGZyZWFkKGRhdGEsIDEsIGxlbmd0aCwgc3RkaW4pOwotICAgICAgICAg ICAgcmV0dXJuIENBSVJPX1NUQVRVU19TVUNDRVNTOworICAgICAgICAgICAgc2l6ZV90IHJlYWRC eXRlcyA9IGZyZWFkKGRhdGEsIDEsIGxlbmd0aCwgc3RkaW4pOworICAgICAgICAgICAgcmV0dXJu IHJlYWRCeXRlcyA/IENBSVJPX1NUQVRVU19TVUNDRVNTIDogQ0FJUk9fU1RBVFVTX1JFQURfRVJS T1I7CiAgICAgICAgIH0sICZjb250ZXh0KTsKIAogICAgIGlmIChjYWlyb19zdXJmYWNlX3N0YXR1 cyhzdXJmYWNlKSAhPSBDQUlST19TVEFUVVNfU1VDQ0VTUykgewpAQCAtMTI1LDggKzEyNSw4IEBA IHZvaWQgUGxhdGZvcm1JbWFnZTo6d3JpdGVBc1BOR1RvU3Rkb3V0KCkKICAgICBmcHJpbnRmKHN0 ZG91dCwgIkNvbnRlbnQtTGVuZ3RoOiAlIiBGT1JNQVRfU0laRV9UICJcbiIsIGNvbnRleHQud3Jp dHRlbkJ5dGVzKTsKICAgICBjYWlyb19zdXJmYWNlX3dyaXRlX3RvX3BuZ19zdHJlYW0obV9pbWFn ZSwKICAgICAgICAgW10odm9pZCosIGNvbnN0IHVuc2lnbmVkIGNoYXIqIGRhdGEsIHVuc2lnbmVk IGxlbmd0aCkgLT4gY2Fpcm9fc3RhdHVzX3QgewotICAgICAgICAgICAgZndyaXRlKGRhdGEsIDEs IGxlbmd0aCwgc3Rkb3V0KTsKLSAgICAgICAgICAgIHJldHVybiBDQUlST19TVEFUVVNfU1VDQ0VT UzsKKyAgICAgICAgICAgIHNpemVfdCB3cml0dGVuQnl0ZXMgPSBmd3JpdGUoZGF0YSwgMSwgbGVu Z3RoLCBzdGRvdXQpOworICAgICAgICAgICAgcmV0dXJuIHdyaXR0ZW5CeXRlcyA/IENBSVJPX1NU QVRVU19TVUNDRVNTIDogQ0FJUk9fU1RBVFVTX1dSSVRFX0VSUk9SOwogICAgICAgICB9LCBudWxs cHRyKTsKIH0KIAo= 309563 2017-05-09 17:05:14 -0700 2017-05-12 15:02:14 -0700 Patch bug-171850-20170510090513.patch text/plain 2010 hyungwook.lee SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDIxNjU1NykKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE0IEBACisyMDE3LTA1LTA5ICBIeXVuZ3dvb2sgTGVlICA8aHl1bmd3b29rLmxlZUBuYXZl cmNvcnAuY29tPgorCisgICAgICAgIFtHVEtdIEZpeCBjb21waWxlIHdhcm5pbmdzIGluIFBsYXRm b3JtSW1hZ2VDYWlyby5jcHAKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTE3MTg1MAorCisgICAgICAgIFJldmlld2VkIGJ5IE1pY2hhZWwgQ2F0YW56YXJv LgorCisgICAgICAgICogSW1hZ2VEaWZmL2NhaXJvL1BsYXRmb3JtSW1hZ2VDYWlyby5jcHA6Cisg ICAgICAgIChJbWFnZURpZmY6OlBsYXRmb3JtSW1hZ2U6OmNyZWF0ZUZyb21TdGRpbik6CisgICAg ICAgIChJbWFnZURpZmY6OlBsYXRmb3JtSW1hZ2U6OndyaXRlQXNQTkdUb1N0ZG91dCk6CisKIDIw MTctMDUtMDkgIEpvbmF0aGFuIEJlZGFyZCAgPGpiZWRhcmRAYXBwbGUuY29tPgogCiAgICAgICAg IHdlYmtpdHB5OiBSZW1vdmUgdW5uZWVkZWQgY3Jhc2ggbG9nIHJldHJpZXZhbCwgcmVmYWN0b3Ig RGFyd2luIGNyYXNoIHJldHJpZXZhbApJbmRleDogVG9vbHMvSW1hZ2VEaWZmL2NhaXJvL1BsYXRm b3JtSW1hZ2VDYWlyby5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gVG9vbHMvSW1hZ2VEaWZmL2NhaXJvL1Bs YXRmb3JtSW1hZ2VDYWlyby5jcHAJKHJldmlzaW9uIDIxNjU1NykKKysrIFRvb2xzL0ltYWdlRGlm Zi9jYWlyby9QbGF0Zm9ybUltYWdlQ2Fpcm8uY3BwCSh3b3JraW5nIGNvcHkpCkBAIC01MCw4ICs1 MCw4IEBAIHN0ZDo6dW5pcXVlX3B0cjxQbGF0Zm9ybUltYWdlPiBQbGF0Zm9ybUkKICAgICAgICAg ICAgIGF1dG8mIGNvbnRleHQgPSAqc3RhdGljX2Nhc3Q8UmVhZENvbnRleHQqPihjbG9zdXJlKTsK ICAgICAgICAgICAgIGNvbnRleHQucmVhZEJ5dGVzICs9IGxlbmd0aDsKIAotICAgICAgICAgICAg ZnJlYWQoZGF0YSwgMSwgbGVuZ3RoLCBzdGRpbik7Ci0gICAgICAgICAgICByZXR1cm4gQ0FJUk9f U1RBVFVTX1NVQ0NFU1M7CisgICAgICAgICAgICBzaXplX3QgcmVhZEJ5dGVzID0gZnJlYWQoZGF0 YSwgMSwgbGVuZ3RoLCBzdGRpbik7CisgICAgICAgICAgICByZXR1cm4gcmVhZEJ5dGVzID09IGxl bmd0aCA/IENBSVJPX1NUQVRVU19TVUNDRVNTIDogQ0FJUk9fU1RBVFVTX1JFQURfRVJST1I7CiAg ICAgICAgIH0sICZjb250ZXh0KTsKIAogICAgIGlmIChjYWlyb19zdXJmYWNlX3N0YXR1cyhzdXJm YWNlKSAhPSBDQUlST19TVEFUVVNfU1VDQ0VTUykgewpAQCAtMTI1LDggKzEyNSw4IEBAIHZvaWQg UGxhdGZvcm1JbWFnZTo6d3JpdGVBc1BOR1RvU3Rkb3V0KCkKICAgICBmcHJpbnRmKHN0ZG91dCwg IkNvbnRlbnQtTGVuZ3RoOiAlIiBGT1JNQVRfU0laRV9UICJcbiIsIGNvbnRleHQud3JpdHRlbkJ5 dGVzKTsKICAgICBjYWlyb19zdXJmYWNlX3dyaXRlX3RvX3BuZ19zdHJlYW0obV9pbWFnZSwKICAg ICAgICAgW10odm9pZCosIGNvbnN0IHVuc2lnbmVkIGNoYXIqIGRhdGEsIHVuc2lnbmVkIGxlbmd0 aCkgLT4gY2Fpcm9fc3RhdHVzX3QgewotICAgICAgICAgICAgZndyaXRlKGRhdGEsIDEsIGxlbmd0 aCwgc3Rkb3V0KTsKLSAgICAgICAgICAgIHJldHVybiBDQUlST19TVEFUVVNfU1VDQ0VTUzsKKyAg ICAgICAgICAgIHNpemVfdCB3cml0dGVuQnl0ZXMgPSBmd3JpdGUoZGF0YSwgMSwgbGVuZ3RoLCBz dGRvdXQpOworICAgICAgICAgICAgcmV0dXJuIHdyaXR0ZW5CeXRlcyA9PSBsZW5ndGggPyBDQUlS T19TVEFUVVNfU1VDQ0VTUyA6IENBSVJPX1NUQVRVU19XUklURV9FUlJPUjsKICAgICAgICAgfSwg bnVsbHB0cik7CiB9CiAK