<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>171847</bug_id>
          
          <creation_ts>2017-05-08 22:03:03 -0700</creation_ts>
          <short_desc>[Win] ImageDiff isn&apos;t built since Bug 168945</short_desc>
          <delta_ts>2017-05-09 07:50:58 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Tools / Tests</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          <dependson>168945</dependson>
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Fujii Hironori">fujii</reporter>
          <assigned_to name="Fujii Hironori">fujii</assigned_to>
          <cc>achristensen</cc>
    
    <cc>bfulgham</cc>
    
    <cc>commit-queue</cc>
    
    <cc>jbedard</cc>
    
    <cc>lforschler</cc>
    
    <cc>pvollan</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1306256</commentid>
    <comment_count>0</comment_count>
    <who name="Fujii Hironori">fujii</who>
    <bug_when>2017-05-08 22:03:03 -0700</bug_when>
    <thetext>[Win] ImageDiff isn&apos;t built since Bug 168945

AppleWin port layout test fails:

https://build.webkit.org/builders/Apple%20Win%207%20Release%20%28Tests%29/builds/606/steps/layout-test/logs/stdio

&gt; 18:49:10.979 17924 Checking build ...
&gt; 18:49:11.010 17924 ImageDiff was not found at WebKitBuild/release/bin32/ImageDiff
&gt; 18:49:11.010 17924 Build check failed
&gt; 18:49:11.010 17924 Testing completed, Exit status: -1</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1306259</commentid>
    <comment_count>1</comment_count>
      <attachid>309470</attachid>
    <who name="Fujii Hironori">fujii</who>
    <bug_when>2017-05-08 22:12:49 -0700</bug_when>
    <thetext>Created attachment 309470
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1306365</commentid>
    <comment_count>2</comment_count>
      <attachid>309470</attachid>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2017-05-09 07:50:57 -0700</bug_when>
    <thetext>Comment on attachment 309470
Patch

Clearing flags on attachment: 309470

Committed r216504: &lt;http://trac.webkit.org/changeset/216504&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1306366</commentid>
    <comment_count>3</comment_count>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2017-05-09 07:50:58 -0700</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>309470</attachid>
            <date>2017-05-08 22:12:49 -0700</date>
            <delta_ts>2017-05-09 07:50:57 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-171847-20170509141248.patch</filename>
            <type>text/plain</type>
            <size>2154</size>
            <attacher name="Fujii Hironori">fujii</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjE2NDc0CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg
Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggNTdjZjFjMTliNjVkNTg3NThkOTYyNTBkN2UzYTY5MWI1
ZDYxYTNiMC4uZDUxZWFmOWYwODcyZGFiN2EyNDRjY2E0NTdlNjI0ZThhZGJkYzcxNCAxMDA2NDQK
LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0
IEBACisyMDE3LTA1LTA4ICBGdWppaSBIaXJvbm9yaSAgPEhpcm9ub3JpLkZ1amlpQHNvbnkuY29t
PgorCisgICAgICAgIFtXaW5dIEltYWdlRGlmZiBpc24ndCBidWlsdCBzaW5jZSBCdWcgMTY4OTQ1
CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNzE4NDcK
KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIENNYWtl
TGlzdHMudHh0OiBBZGQgJ0ltYWdlRGlmZicgc3ViLWRpcmVjdG9yeSB0byBidWlsZCBpZiBXSU4z
Mi4KKyAgICAgICAgKiBJbWFnZURpZmYvSW1hZ2VEaWZmLmNwcDogSW5jbHVkZSBzb21lIGhlYWRl
ciBmaWxlcyB0byBmaXggY29tcGlsYXRpb24gZXJyb3JzLgorICAgICAgICAqIEltYWdlRGlmZi9Q
bGF0Zm9ybVdpbi5jbWFrZTogRGVmaW5lIFVTRV9DQUlSTyBpZiBXaW5DYWlybyBwb3J0LgorCiAy
MDE3LTA1LTA4ICBKb25hdGhhbiBCZWRhcmQgIDxqYmVkYXJkQGFwcGxlLmNvbT4KIAogICAgICAg
ICBJbXBsZW1lbnQgUGxhdGZvcm1XZWJWaWV3Ojp3aW5kb3dTbmFwc2hvdEltYWdlIGFuZCBjcmVh
dGVCaXRtYXBDb250ZXh0RnJvbVdlYlZpZXcgZm9yIGlPUyBkZXZpY2VzCmRpZmYgLS1naXQgYS9U
b29scy9DTWFrZUxpc3RzLnR4dCBiL1Rvb2xzL0NNYWtlTGlzdHMudHh0CmluZGV4IGIzMDQ5Yjg4
NDFkNGNhMDMyZDNhMGExMTAzYzhmNzU3ODdmYTI3MDYuLjY1N2ZmNzU1NjdiNzU1YWM3MGRiNDIx
MmQyM2M4ZjU5NDJjN2M5ZmIgMTAwNjQ0Ci0tLSBhL1Rvb2xzL0NNYWtlTGlzdHMudHh0CisrKyBi
L1Rvb2xzL0NNYWtlTGlzdHMudHh0CkBAIC0yOSw2ICsyOSw3IEBAIGlmIChXSU4zMikKICAgICBh
ZGRfc3ViZGlyZWN0b3J5KER1bXBSZW5kZXJUcmVlKQogICAgIGFkZF9zdWJkaXJlY3RvcnkoVGVz
dFdlYktpdEFQSSkKICAgICBhZGRfc3ViZGlyZWN0b3J5KE1pbmlCcm93c2VyL3dpbikKKyAgICBh
ZGRfc3ViZGlyZWN0b3J5KEltYWdlRGlmZikKIGVuZGlmICgpCiAKIGlmIChFTkFCTEVfV0VCS0lU
MiBBTkQgRU5BQkxFX0FQSV9URVNUUykKZGlmZiAtLWdpdCBhL1Rvb2xzL0ltYWdlRGlmZi9JbWFn
ZURpZmYuY3BwIGIvVG9vbHMvSW1hZ2VEaWZmL0ltYWdlRGlmZi5jcHAKaW5kZXggOWY3Zjk3ZGRi
NjBiMWViZmMyYTE5ZTA2ZjcwMmJjNjgzOWQwMGM2NS4uZWIwYTgwNzljYTZjZjU1MmY0MDY3ZTFm
MjU0NzVmZjFhODU4OTgzNSAxMDA2NDQKLS0tIGEvVG9vbHMvSW1hZ2VEaWZmL0ltYWdlRGlmZi5j
cHAKKysrIGIvVG9vbHMvSW1hZ2VEaWZmL0ltYWdlRGlmZi5jcHAKQEAgLTMyLDYgKzMyLDExIEBA
CiAjaW5jbHVkZSA8c3RkaW8uaD4KICNpbmNsdWRlIDxzdHJpbmcuaD4KIAorI2lmIFBMQVRGT1JN
KFdJTikKKyNpbmNsdWRlIDxmY250bC5oPgorI2luY2x1ZGUgPGlvLmg+CisjZW5kaWYKKwogdXNp
bmcgbmFtZXNwYWNlIEltYWdlRGlmZjsKIAogI2lmIE9TKFdJTkRPV1MpCmRpZmYgLS1naXQgYS9U
b29scy9JbWFnZURpZmYvUGxhdGZvcm1XaW4uY21ha2UgYi9Ub29scy9JbWFnZURpZmYvUGxhdGZv
cm1XaW4uY21ha2UKaW5kZXggYzM4OWMyMTVkZWZjYWYwZjk2YWJjMjNmM2Q1ZWY5NDEwOTVhNTcw
Yi4uYWNhMTUyOGEyYmJkOTI0MGMzMWExNGVjMTk3YzJiZjFhNjk5NTkzOCAxMDA2NDQKLS0tIGEv
VG9vbHMvSW1hZ2VEaWZmL1BsYXRmb3JtV2luLmNtYWtlCisrKyBiL1Rvb2xzL0ltYWdlRGlmZi9Q
bGF0Zm9ybVdpbi5jbWFrZQpAQCAtMSw1ICsxLDYgQEAKIGlmICgke1dURl9QTEFURk9STV9XSU5f
Q0FJUk99KQorICAgIGFkZF9kZWZpbml0aW9ucygtRFVTRV9DQUlSTz0xKQogICAgIGluY2x1ZGUo
Q2Fpcm8uY21ha2UpCiBlbHNlICgpCiAgICAgaW5jbHVkZShQbGF0Zm9ybU1hYy5jbWFrZSkKLWVu
ZGlmICgpClwgTm8gbmV3bGluZSBhdCBlbmQgb2YgZmlsZQorZW5kaWYgKCkK
</data>

          </attachment>
      

    </bug>

</bugzilla>