171846 2017-05-08 21:22:18 -0700 Drop custom bindings code for Window.location setter 2017-05-09 13:01:12 -0700 1 1 1 Unclassified WebKit DOM WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=171843 https://html.spec.whatwg.org/#the-window-object P2 Normal --- 1 cdumez cdumez buildbot cdumez commit-queue darin esprehn+autocc ggaren kondapallykalyan rniwa sam oldest_to_newest 1306247 0 cdumez 2017-05-08 21:22:18 -0700 Drop custom code for Window.location setter. The custom code was needed to fix a bug that was fixed a long time ago (rdar://problem/5695330). 1306257 1 cdumez 2017-05-08 22:07:42 -0700 Grumph. PutForwards currently does not work for window.location because DOMWindow::location() can currently return null and our bindings generator does not handle that. We could add support in the bindings generator but I believe DOMWindow::location() is never supposed to return null. WebKit currently associates Location with the frame instead of the Window, which is not as per spec (and does not match Firefox or Chrome). 1306450 2 309514 cdumez 2017-05-09 10:48:53 -0700 Created attachment 309514 Patch 1306508 3 309514 sam 2017-05-09 12:48:18 -0700 Comment on attachment 309514 Patch v.nice 1306510 4 sam 2017-05-09 12:50:23 -0700 (In reply to Chris Dumez from comment #1) > Grumph. PutForwards currently does not work for window.location because > DOMWindow::location() can currently return null and our bindings generator > does not handle that. > > We could add support in the bindings generator but I believe > DOMWindow::location() is never supposed to return null. WebKit currently > associates Location with the frame instead of the Window, which is not as > per spec (and does not match Firefox or Chrome). We really need to fix up our window/document/frame mess. It's long past due. (Do we rename Frame to BrowsingContext like madmen?) 1306518 5 309514 cdumez 2017-05-09 13:01:10 -0700 Comment on attachment 309514 Patch Clearing flags on attachment: 309514 Committed r216534: <http://trac.webkit.org/changeset/216534> 1306519 6 cdumez 2017-05-09 13:01:12 -0700 All reviewed patches have been landed. Closing bug. 309514 2017-05-09 10:48:53 -0700 2017-05-09 13:01:10 -0700 Patch bug-171846-20170509104852.patch text/plain 4008 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjE2NTEyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZTYyZTQzYmViYmQ2MDE4 ZDhjN2VkNmI5YjFmYjNjOTI4MmUzMWYxNy4uYmUxZTZiYzAwYzQzYjMyM2UyNmVmYjdkOTcwNWM4 YzEyMDQ5OTg4NCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI3IEBACisyMDE3LTA1LTA5ICBDaHJp cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgRHJvcCBjdXN0b20gYmluZGlu Z3MgY29kZSBmb3IgV2luZG93LmxvY2F0aW9uIHNldHRlcgorICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTcxODQ2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgRHJvcCBjdXN0b20gYmluZGluZ3MgY29kZSBmb3Ig V2luZG93LmxvY2F0aW9uIHNldHRlciBhcyB0aGUgY3VzdG9tIGNvZGUgd2FzIG1lcmVseSBuZWVk ZWQKKyAgICAgICAgdG8gYWRkcmVzcyBhIHZlcnkgb2xkIE1hYyB3aWRnZXQgdGhhdCBoYXMgbG9u ZyBiZWVuIGZpeGVkIChyZGFyOi8vcHJvYmxlbS81Njk1MzMwKS4KKworICAgICAgICBObyBuZXcg dGVzdHMsIG5vIFdlYi1mYWNpbmcgYmVoYXZpb3IgY2hhbmdlLgorCisgICAgICAgICogYmluZGlu Z3MvanMvSlNET01XaW5kb3dDdXN0b20uY3BwOgorICAgICAgICAoV2ViQ29yZTo6SlNET01XaW5k b3c6OnNldExvY2F0aW9uKTogRGVsZXRlZC4KKyAgICAgICAgRHJvcCBjdXN0b20gY29kZS4KKwor ICAgICAgICAqIHBhZ2UvRE9NV2luZG93LmlkbDoKKyAgICAgICAgQWxpZ24gV2luZG93LmxvY2F0 aW9uIHdpdGggaHR0cHM6Ly9odG1sLnNwZWMud2hhdHdnLm9yZy8jdGhlLXdpbmRvdy1vYmplY3Q6 CisgICAgICAgIC0gTWFyayBwcm9wZXJ0eSBhcyByZWFkb25seS4KKyAgICAgICAgLSBBZGQgW1B1 dHNGb3J3YXJkPWhyZWZdIElETCBleHRlbmRlZCBhdHRyaWJ1dGUuCisgICAgICAgIEFsc28sIHdl IG5lZWQgdG8gbWFyayB0aGUgYXRyaWJ1dGUgYXMgbnVsbGFibGUgYXMgdGhpcyByZWZsZWN0cyBv dXIgY3VycmVudCBpbXBsZW1lbnRhdGlvbi4KKyAgICAgICAgV2UgY3VycmVudGx5IHJldHVybiBu dWxsIGlmIHRoZSBhc3NvY2lhdGVkIFdpbmRvdyBkb2VzIG5vdCBoYXZlIGEgZnJhbWUuIFRoaXMg ZG9lcyBub3QgbWF0Y2gKKyAgICAgICAgdGhlIHNwZWNpZmljYXRpb24gYW5kIHdlIHNob3VsZCB1 cGRhdGUgb3VyIGltcGxlbWVudGF0aW9uIGluIHRoZSBmdXR1cmUgdG8gbmV2ZXIgcmV0dXJuIG51 bGwuCisKIDIwMTctMDUtMDkgIEZyZWRlcmljIFdhbmcgIDxmd2FuZ0BpZ2FsaWEuY29tPgogCiAg ICAgICAgIFByaW50IG1vcmUgcHJvcGVydGllcyBpbiB0aGUgb3V0cHV0IG9mIHNjcm9sbGluZyB0 cmVlcwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvanMvSlNET01XaW5kb3dD dXN0b20uY3BwIGIvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvanMvSlNET01XaW5kb3dDdXN0b20u Y3BwCmluZGV4IGMwMDQ4NGFmNWZiMWE1NGUyZTBkNmQwNWMzNTk3Y2M3ZTdmMjAxOGEuLmJmMWVi OTkxNWY1ODc2M2NiZTAzYTM4MDM0ZjNiMjI1NjNkNmNhNWMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9X ZWJDb3JlL2JpbmRpbmdzL2pzL0pTRE9NV2luZG93Q3VzdG9tLmNwcAorKysgYi9Tb3VyY2UvV2Vi Q29yZS9iaW5kaW5ncy9qcy9KU0RPTVdpbmRvd0N1c3RvbS5jcHAKQEAgLTQ1MiwzMCArNDUyLDYg QEAgU3RyaW5nIEpTRE9NV2luZG93Ojp0b1N0cmluZ05hbWUoY29uc3QgSlNPYmplY3QqIG9iamVj dCwgRXhlY1N0YXRlKiBleGVjKQogCiAvLyBDdXN0b20gQXR0cmlidXRlcwogCi12b2lkIEpTRE9N V2luZG93OjpzZXRMb2NhdGlvbihFeGVjU3RhdGUmIHN0YXRlLCBKU1ZhbHVlIHZhbHVlKQotewot ICAgIFZNJiB2bSA9IHN0YXRlLnZtKCk7Ci0gICAgYXV0byBzY29wZSA9IERFQ0xBUkVfVEhST1df U0NPUEUodm0pOwotCi0jaWYgRU5BQkxFKERBU0hCT0FSRF9TVVBQT1JUKQotICAgIC8vIFRvIGF2 b2lkIGJyZWFraW5nIG9sZCB3aWRnZXRzLCBtYWtlICJ2YXIgbG9jYXRpb24gPSIgaW4gYSB0b3At bGV2ZWwgZnJhbWUgY3JlYXRlCi0gICAgLy8gYSBwcm9wZXJ0eSBuYW1lZCAibG9jYXRpb24iIGlu c3RlYWQgb2YgcGVyZm9ybWluZyBhIG5hdmlnYXRpb24gKDxyZGFyOi8vcHJvYmxlbS81Njg4MDM5 PikuCi0gICAgaWYgKEZyYW1lKiBhY3RpdmVGcmFtZSA9IGFjdGl2ZURPTVdpbmRvdygmc3RhdGUp LmZyYW1lKCkpIHsKLSAgICAgICAgaWYgKGFjdGl2ZUZyYW1lLT5zZXR0aW5ncygpLnVzZXNEYXNo Ym9hcmRCYWNrd2FyZENvbXBhdGliaWxpdHlNb2RlKCkgJiYgIWFjdGl2ZUZyYW1lLT50cmVlKCku cGFyZW50KCkpIHsKLSAgICAgICAgICAgIGlmIChCaW5kaW5nU2VjdXJpdHk6OnNob3VsZEFsbG93 QWNjZXNzVG9ET01XaW5kb3coJnN0YXRlLCB3cmFwcGVkKCkpKQotICAgICAgICAgICAgICAgIHB1 dERpcmVjdChzdGF0ZS52bSgpLCBJZGVudGlmaWVyOjpmcm9tU3RyaW5nKCZzdGF0ZSwgImxvY2F0 aW9uIiksIHZhbHVlKTsKLSAgICAgICAgICAgIHJldHVybjsKLSAgICAgICAgfQotICAgIH0KLSNl bmRpZgotCi0gICAgU3RyaW5nIGxvY2F0aW9uU3RyaW5nID0gdmFsdWUudG9XVEZTdHJpbmcoJnN0 YXRlKTsKLSAgICBSRVRVUk5fSUZfRVhDRVBUSU9OKHNjb3BlLCB2b2lkKCkpOwotCi0gICAgaWYg KExvY2F0aW9uKiBsb2NhdGlvbiA9IHdyYXBwZWQoKS5sb2NhdGlvbigpKQotICAgICAgICBsb2Nh dGlvbi0+c2V0SHJlZihhY3RpdmVET01XaW5kb3coJnN0YXRlKSwgZmlyc3RET01XaW5kb3coJnN0 YXRlKSwgbG9jYXRpb25TdHJpbmcpOwotfQotCiBKU1ZhbHVlIEpTRE9NV2luZG93OjpldmVudChF eGVjU3RhdGUmIHN0YXRlKSBjb25zdAogewogICAgIEV2ZW50KiBldmVudCA9IGN1cnJlbnRFdmVu dCgpOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGFnZS9ET01XaW5kb3cuaWRsIGIvU291 cmNlL1dlYkNvcmUvcGFnZS9ET01XaW5kb3cuaWRsCmluZGV4IDUzY2EwYzE0MWExZGNmMTlmYjM1 N2M4NzM5OGYyMWVhNGQ5ZjczMTMuLmZhN2EzODI0NWVjYTcxZTdhZWE5M2FjYWQ2OGMxMDVjYWNk ZDllZTQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BhZ2UvRE9NV2luZG93LmlkbAorKysg Yi9Tb3VyY2UvV2ViQ29yZS9wYWdlL0RPTVdpbmRvdy5pZGwKQEAgLTUzLDcgKzUzLDcgQEAgdHlw ZWRlZiBVU1ZTdHJpbmcgQ1NTT01TdHJpbmc7CiAgICAgW1JlcGxhY2VhYmxlLCBEb05vdENoZWNr U2VjdXJpdHlPbkdldHRlcl0gcmVhZG9ubHkgYXR0cmlidXRlIERPTVdpbmRvdyBzZWxmOwogICAg IFtVbmZvcmdlYWJsZV0gcmVhZG9ubHkgYXR0cmlidXRlIERvY3VtZW50IGRvY3VtZW50OwogICAg IGF0dHJpYnV0ZSBET01TdHJpbmcgbmFtZTsKLSAgICBbRG9Ob3RDaGVja1NlY3VyaXR5LCBDdXN0 b21TZXR0ZXIsIFVuZm9yZ2VhYmxlXSBhdHRyaWJ1dGUgTG9jYXRpb24gbG9jYXRpb247IC8vIEZJ WE1FOiBTaG91bGQgYmUgcmVhZG9ubHkgYW5kIFtQdXRGb3J3YXJkcz1ocmVmXS4KKyAgICBbRG9O b3RDaGVja1NlY3VyaXR5LCBQdXRGb3J3YXJkcz1ocmVmLCBVbmZvcmdlYWJsZV0gcmVhZG9ubHkg YXR0cmlidXRlIExvY2F0aW9uPyBsb2NhdGlvbjsgLy8gRklYTUU6IFNob3VsZCBub3QgYmUgbnVs bGFibGUuCiAgICAgcmVhZG9ubHkgYXR0cmlidXRlIEhpc3RvcnkgaGlzdG9yeTsKICAgICBbRW5h YmxlZEF0UnVudGltZT1DdXN0b21FbGVtZW50cywgSW1wbGVtZW50ZWRBcz1lbnN1cmVDdXN0b21F bGVtZW50UmVnaXN0cnldIHJlYWRvbmx5IGF0dHJpYnV0ZSBDdXN0b21FbGVtZW50UmVnaXN0cnkg Y3VzdG9tRWxlbWVudHM7CiAgICAgW1JlcGxhY2VhYmxlXSByZWFkb25seSBhdHRyaWJ1dGUgQmFy UHJvcCBsb2NhdGlvbmJhcjsK