171845 2017-05-08 21:04:29 -0700 Update DocumentOrShadowRoot.idl to match specifications 2017-05-09 08:04:17 -0700 1 1 1 Unclassified WebKit DOM WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 cdumez cdumez buildbot cdumez commit-queue dbates esprehn+autocc kangil.han kondapallykalyan rniwa oldest_to_newest 1306240 0 cdumez 2017-05-08 21:04:29 -0700 Update DocumentOrShadowRoot.idl to match specifications: - https://dom.spec.whatwg.org/#mixin-documentorshadowroot - https://w3c.github.io/webcomponents/spec/shadow/#extensions-to-the-documentorshadowroot-mixin - https://w3c.github.io/pointerlock/#extensions-to-the-documentorshadowroot-mixin 1306242 1 309464 cdumez 2017-05-08 21:09:02 -0700 Created attachment 309464 Patch 1306243 2 309464 rniwa 2017-05-08 21:15:57 -0700 Comment on attachment 309464 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=309464&action=review > Source/WebCore/dom/Document.idl:106 > + // FIXME: Should likely be moved to DocumentOrShadowRoot. Not sure if "likely" is necessary given the current spec says so. We can remove the comment if we change the spec. 1306244 3 309464 cdumez 2017-05-08 21:17:43 -0700 Comment on attachment 309464 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=309464&action=review >> Source/WebCore/dom/Document.idl:106 >> + // FIXME: Should likely be moved to DocumentOrShadowRoot. > > Not sure if "likely" is necessary given the current spec says so. We can remove the comment if we change the spec. Well, my issue is that https://w3c.github.io/webcomponents/spec/shadow/#extensions-to-the-documentorshadowroot-mixin & https://drafts.csswg.org/cssom/#extensions-to-the-document-interface disagree. 1306248 4 rniwa 2017-05-08 21:22:51 -0700 (In reply to Chris Dumez from comment #3) > Comment on attachment 309464 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=309464&action=review > > >> Source/WebCore/dom/Document.idl:106 > >> + // FIXME: Should likely be moved to DocumentOrShadowRoot. > > > > Not sure if "likely" is necessary given the current spec says so. We can remove the comment if we change the spec. > > Well, my issue is that > https://w3c.github.io/webcomponents/spec/shadow/#extensions-to-the- > documentorshadowroot-mixin & > https://drafts.csswg.org/cssom/#extensions-to-the-document-interface > disagree. Oh I see. 1306376 5 309464 commit-queue 2017-05-09 08:04:16 -0700 Comment on attachment 309464 Patch Clearing flags on attachment: 309464 Committed r216506: <http://trac.webkit.org/changeset/216506> 1306377 6 commit-queue 2017-05-09 08:04:17 -0700 All reviewed patches have been landed. Closing bug. 309464 2017-05-08 21:09:02 -0700 2017-05-09 08:04:16 -0700 Patch bug-171845-20170508210900.patch text/plain 4417 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjE2NDc1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggN2ZmMmMzNWY2MjBkZWM5 MThkODFmNjUwMDU0YTVjN2JmODdiOTNlMi4uODI3YWUxNDNlYWM4ZTI0OTliMjQyOGIxMDgzOWE2 ZmM3NWI3OTM5YiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDIzIEBACiAyMDE3LTA1LTA4ICBDaHJp cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CiAKKyAgICAgICAgVXBkYXRlIERvY3VtZW50T3JT aGFkb3dSb290LmlkbCB0byBtYXRjaCBzcGVjaWZpY2F0aW9ucworICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTcxODQ1CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVXBkYXRlIERvY3VtZW50T3JTaGFkb3dSb290 LmlkbCB0byBtYXRjaCBzcGVjaWZpY2F0aW9uczoKKyAgICAgICAgLSBodHRwczovL2RvbS5zcGVj LndoYXR3Zy5vcmcvI21peGluLWRvY3VtZW50b3JzaGFkb3dyb290CisgICAgICAgIC0gaHR0cHM6 Ly93M2MuZ2l0aHViLmlvL3dlYmNvbXBvbmVudHMvc3BlYy9zaGFkb3cvI2V4dGVuc2lvbnMtdG8t dGhlLWRvY3VtZW50b3JzaGFkb3dyb290LW1peGluCisgICAgICAgIC0gaHR0cHM6Ly93M2MuZ2l0 aHViLmlvL3BvaW50ZXJsb2NrLyNleHRlbnNpb25zLXRvLXRoZS1kb2N1bWVudG9yc2hhZG93cm9v dC1taXhpbgorCisgICAgICAgIE5vIFdlYi1mYWNpbmcgYmVoYXZpb3IgY2hhbmdlLiBUaGluZ3Mg dGhhdCBkbyBub3QgbWF0Y2ggdGhlIHNwZWNpZmljYXRpb24gd2VyZSBtZXJlbHkKKyAgICAgICAg YW5ub3RhdGVkIHdpdGggRklYTUUgY29tbWVudHMuCisKKyAgICAgICAgKiBkb20vRG9jdW1lbnQu aWRsOgorICAgICAgICAqIGRvbS9Eb2N1bWVudE9yU2hhZG93Um9vdC5pZGw6CisKKzIwMTctMDUt MDggIENocmlzIER1bWV6ICA8Y2R1bWV6QGFwcGxlLmNvbT4KKwogICAgICAgICBEcm9wIFtDRVJl YWN0aW9uc10gZnJvbSBDaGFyYWN0ZXJEYXRhIG9wZXJhdGlvbnMKICAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE3MTgxMwogCmRpZmYgLS1naXQgYS9Tb3Vy Y2UvV2ViQ29yZS9kb20vRG9jdW1lbnQuaWRsIGIvU291cmNlL1dlYkNvcmUvZG9tL0RvY3VtZW50 LmlkbAppbmRleCA5MjZhNDFjM2QxYzcyZjQzMmE3ODkzYTQ5YmRkOWViNmNiNzFkYmNkLi5jMDky NDM1ZjE3YWIxYTM1NGI1N2FkOGMwMDA2OGViODY4ZDQ5ZDlhIDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViQ29yZS9kb20vRG9jdW1lbnQuaWRsCisrKyBiL1NvdXJjZS9XZWJDb3JlL2RvbS9Eb2N1bWVu dC5pZGwKQEAgLTEwMywxNCArMTAzLDE0IEBACiAgICAgW0xlbmllbnRUaGlzXSBhdHRyaWJ1dGUg RXZlbnRIYW5kbGVyIG9ucmVhZHlzdGF0ZWNoYW5nZTsKIAogICAgIC8vIEV4dGVuc2lvbnMgZnJv bSB0aGUgQ1NTT00gc3BlY2lmaWNhdGlvbiAoaHR0cHM6Ly9kcmFmdHMuY3Nzd2cub3JnL2Nzc29t LyNleHRlbnNpb25zLXRvLXRoZS1kb2N1bWVudC1pbnRlcmZhY2UpLgorICAgIC8vIEZJWE1FOiBT aG91bGQgbGlrZWx5IGJlIG1vdmVkIHRvIERvY3VtZW50T3JTaGFkb3dSb290LgogICAgIHJlYWRv bmx5IGF0dHJpYnV0ZSBTdHlsZVNoZWV0TGlzdCBzdHlsZVNoZWV0czsgLy8gRklYTUU6IFNob3Vs ZCBiZSBbU2FtZU9iamVjdF0uCiAKICAgICAvLyBFeHRlbnNpb25zIGZyb20gdGhlIENTU09NLVZp ZXcgc3BlY2lmaWNhdGlvbiAoaHR0cHM6Ly9kcmFmdHMuY3Nzd2cub3JnL2Nzc29tLXZpZXcvI2V4 dGVuc2lvbnMtdG8tdGhlLWRvY3VtZW50LWludGVyZmFjZSkuCiAgICAgcmVhZG9ubHkgYXR0cmli dXRlIEVsZW1lbnQ/IHNjcm9sbGluZ0VsZW1lbnQ7Ci0gICAgLy8gc2VxdWVuY2U8RWxlbWVudD4g ZWxlbWVudHNGcm9tUG9pbnQoZG91YmxlIHgsIGRvdWJsZSB5KTsgIC8vIEZJWE1FOiBJbXBsZW1l bnQgdGhpcy4KLSAgICAvLyBDYXJldFBvc2l0aW9uPyBjYXJldFBvc2l0aW9uRnJvbVBvaW50KGRv dWJsZSB4LCBkb3VibGUgeSk7ICAvLyBGSVhNRTogSW1wbGVtZW50IHRoaXMuCiAKICAgICAvLyBF eHRlbnNpb25zIGZyb20gU2VsZWN0aW9uIEFQSSAoaHR0cHM6Ly93d3cudzMub3JnL1RSL3NlbGVj dGlvbi1hcGkvI2V4dGVuc2lvbnMtdG8tZG9jdW1lbnQtaW50ZXJmYWNlKS4KKyAgICAvLyBGSVhN RTogU2hvdWxkIGxpa2VseSBiZSBtb3ZlZCB0byBEb2N1bWVudE9yU2hhZG93Um9vdC4KICAgICBE T01TZWxlY3Rpb24/IGdldFNlbGVjdGlvbigpOwogCiAgICAgLy8gWFBhdGggZXh0ZW5zaW9ucyAo aHR0cHM6Ly93d3cudzMub3JnL1RSL0RPTS1MZXZlbC0zLVhQYXRoL3hwYXRoLmh0bWwjWFBhdGhF dmFsdWF0b3IpLgpAQCAtMTMzLDcgKzEzMyw2IEBACiAgICAgLy8gRXh0ZW5zaW9ucyBmcm9tIFBv aW50ZXIgTG9jayBBUEkgKGh0dHBzOi8vd3d3LnczLm9yZy9UUi9wb2ludGVybG9jay8jZXh0ZW5z aW9ucy10by10aGUtZG9jdW1lbnQtaW50ZXJmYWNlKS4KICAgICBbTm90RW51bWVyYWJsZSwgQ29u ZGl0aW9uYWw9UE9JTlRFUl9MT0NLXSBhdHRyaWJ1dGUgRXZlbnRIYW5kbGVyIG9ucG9pbnRlcmxv Y2tjaGFuZ2U7IC8vIEZJWE1FOiBTaG91bGQgYmUgZW51bWVyYWJsZS4KICAgICBbTm90RW51bWVy YWJsZSwgQ29uZGl0aW9uYWw9UE9JTlRFUl9MT0NLXSBhdHRyaWJ1dGUgRXZlbnRIYW5kbGVyIG9u cG9pbnRlcmxvY2tlcnJvcjsgLy8gRklYTUU6IFNob3VsZCBiZSBlbnVtZXJhYmxlLgotICAgIC8v IHJlYWRvbmx5IGF0dHJpYnV0ZSBFbGVtZW50PyBwb2ludGVyTG9ja0VsZW1lbnQ7IC8vIEZJWE1F OiBJbXBsZW1lbnQgdGhpcy4KICAgICBbQ29uZGl0aW9uYWw9UE9JTlRFUl9MT0NLXSB2b2lkIGV4 aXRQb2ludGVyTG9jaygpOwogCiAgICAgLy8gRXh0ZW5zaW9ucyBmcm9tIENTUyBGb250IExvYWRp bmcgQVBJIChodHRwczovL2RyYWZ0cy5jc3N3Zy5vcmcvY3NzLWZvbnQtbG9hZGluZy8jZm9udC1m YWNlLXNvdXJjZSkuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9kb20vRG9jdW1lbnRPclNo YWRvd1Jvb3QuaWRsIGIvU291cmNlL1dlYkNvcmUvZG9tL0RvY3VtZW50T3JTaGFkb3dSb290Lmlk bAppbmRleCA4MmJiNjE3MDEyOWY5MjA5ZTE0ZTMxNWY0YWY5MTE4MjEzMWE2NjJiLi45OTY2MWRm NWJmYzUwNDZjYThkNTgzYmJmOWY5NDc3YWY2YTkwMjE3IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2Vi Q29yZS9kb20vRG9jdW1lbnRPclNoYWRvd1Jvb3QuaWRsCisrKyBiL1NvdXJjZS9XZWJDb3JlL2Rv bS9Eb2N1bWVudE9yU2hhZG93Um9vdC5pZGwKQEAgLTI1LDExICsyNSwxNyBAQAogICovCiAKIC8v IGh0dHBzOi8vZG9tLnNwZWMud2hhdHdnLm9yZy8jZG9jdW1lbnRvcnNoYWRvd3Jvb3QKLS8vIGh0 dHBzOi8vd3d3LnczLm9yZy9UUi9zaGFkb3ctZG9tLyNleHRlbnNpb25zLXRvLXRoZS1kb2N1bWVu dG9yc2hhZG93cm9vdC1taXhpbgogWwogICAgIE5vSW50ZXJmYWNlT2JqZWN0LAogXSBpbnRlcmZh Y2UgRG9jdW1lbnRPclNoYWRvd1Jvb3QgeworICAgIC8vIEV4dGVuc2lvbnMgZnJvbSBTaGFkb3cg RE9NIEFQSSAoaHR0cHM6Ly93M2MuZ2l0aHViLmlvL3dlYmNvbXBvbmVudHMvc3BlYy9zaGFkb3cv I2V4dGVuc2lvbnMtdG8tdGhlLWRvY3VtZW50b3JzaGFkb3dyb290LW1peGluKS4KKyAgICAvLyBE T01TZWxlY3Rpb24/IGdldFNlbGVjdGlvbigpOyAvLyBGSVhNRTogV2UgY3VycmVudGx5IGhhdmUg dGhpcyBvbiBEb2N1bWVudCBvbmx5LgogICAgIEVsZW1lbnQ/IGVsZW1lbnRGcm9tUG9pbnQoZG91 YmxlIHgsIGRvdWJsZSB5KTsKKyAgICAvLyBzZXF1ZW5jZTxFbGVtZW50PiBlbGVtZW50c0Zyb21Q b2ludChkb3VibGUgeCwgZG91YmxlIHkpOyAvLyBGSVhNRTogSW1wbGVtZW50IHRoaXMuCisgICAg Ly8gQ2FyZXRQb3NpdGlvbj8gY2FyZXRQb3NpdGlvbkZyb21Qb2ludChkb3VibGUgeCwgZG91Ymxl IHkpOyAvLyBGSVhNRTogSW1wbGVtZW50IHRoaXMuCiAgICAgcmVhZG9ubHkgYXR0cmlidXRlIEVs ZW1lbnQ/IGFjdGl2ZUVsZW1lbnQ7CisgICAgLy8gcmVhZG9ubHkgYXR0cmlidXRlIFN0eWxlU2hl ZXRMaXN0IHN0eWxlU2hlZXRzOyAvLyBGSVhNRTogSW1wbGVtZW50IHRoaXMuCisKKyAgICAvLyBF eHRlbnNpb25zIGZyb20gUG9pbnRlciBMb2NrIEFQSSAoaHR0cHM6Ly93M2MuZ2l0aHViLmlvL3Bv aW50ZXJsb2NrLyNleHRlbnNpb25zLXRvLXRoZS1kb2N1bWVudG9yc2hhZG93cm9vdC1taXhpbiku CiAgICAgW0NvbmRpdGlvbmFsPVBPSU5URVJfTE9DS10gcmVhZG9ubHkgYXR0cmlidXRlIEVsZW1l bnQ/IHBvaW50ZXJMb2NrRWxlbWVudDsKIH07Cg==