171835 2017-05-08 15:59:33 -0700 build ImageDiff with host SDK from Make 2017-05-09 11:07:24 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 jbedard jbedard ap commit-queue lforschler webkit-bug-importer oldest_to_newest 1306107 0 jbedard 2017-05-08 15:59:33 -0700 Currently, Make will not build ImageDiff with the host SDK for iOS Simulator and iOS Device builds. Rather, it will build ImageDiff with the target SDK. 1306112 1 309430 jbedard 2017-05-08 16:04:43 -0700 Created attachment 309430 Patch 1306117 2 jbedard 2017-05-08 16:06:37 -0700 Split off from <https://bugs.webkit.org/show_bug.cgi?id=171788>. 1306130 3 jbedard 2017-05-08 16:16:33 -0700 To continue some of the discussion from bug 171788, I can't think of a circumstance where a user would not want to build ImageDiff when building other tools. I also cannot think of a circumstance where a user would want to build ImageDiff with SDKROOT as iphone or as iphonesimulator. 1306133 4 webkit-bug-importer 2017-05-08 16:18:52 -0700 <rdar://problem/32062953> 1306431 5 309509 jbedard 2017-05-09 10:00:24 -0700 Created attachment 309509 Patch 1306441 6 309511 jbedard 2017-05-09 10:21:15 -0700 Created attachment 309511 Patch 1306444 7 jbedard 2017-05-09 10:23:31 -0700 (In reply to Jonathan Bedard from comment #6) > Created attachment 309511 [details] > Patch This should be correct. It's taken from the code removed in <http://trac.webkit.org/changeset/212148> 1306460 8 309511 commit-queue 2017-05-09 11:07:23 -0700 Comment on attachment 309511 Patch Clearing flags on attachment: 309511 Committed r216528: <http://trac.webkit.org/changeset/216528> 1306461 9 commit-queue 2017-05-09 11:07:24 -0700 All reviewed patches have been landed. Closing bug. 309430 2017-05-08 16:04:43 -0700 2017-05-09 10:00:23 -0700 Patch bug-171835-20170508160442.patch text/plain 1116 jbedard SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDIxNjQ1NCkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE1IEBACisyMDE3LTA1LTA4ICBKb25hdGhhbiBCZWRhcmQgIDxqYmVkYXJkQGFwcGxlLmNv bT4KKworICAgICAgICBidWlsZCBJbWFnZURpZmYgd2l0aCBob3N0IFNESyBmcm9tIE1ha2UKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE3MTgzNQorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEltYWdlRGlmZiBz aG91bGQgYWx3YXlzIGJlIGJ1aWx0IGZvciB0aGUgZGVmYXVsdCBTREsgYW5kIGRlZmF1bHQKKyAg ICAgICAgYXJjaGl0ZWN0dXJlIHdoZW4gdGhlIFNES1JPT1QgaXMgc2V0IHRvIGVpdGhlciBpT1Mg ZGV2aWNlIG9yIGlPUyBzaW11bGF0b3IuCisKKyAgICAgICAgKiBJbWFnZURpZmYvTWFrZWZpbGU6 IFVzZSBNYWMgU0RLIHdoZW4gYnVpbGRpbmcgZm9yIGlPUyBTaW11bGF0b3Igb3IgaU9TIGRldmlj ZS4KKwogMjAxNy0wNS0wOCAgSm9uYXRoYW4gQmVkYXJkICA8amJlZGFyZEBhcHBsZS5jb20+CiAK ICAgICAgICAgYnVpbGRib3Q6IENsZWFudXAgc2ltdWxhdG9ycyBhZnRlciBydW5uaW5nIHRlc3Rz CkluZGV4OiBUb29scy9JbWFnZURpZmYvTWFrZWZpbGUKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gVG9vbHMvSW1h Z2VEaWZmL01ha2VmaWxlCShyZXZpc2lvbiAyMTY0NTQpCisrKyBUb29scy9JbWFnZURpZmYvTWFr ZWZpbGUJKHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSw4IEBACiBTQ1JJUFRTX1BBVEggPSAuLi9T Y3JpcHRzCiAKK2lmbmVxICgsJChmaW5kc3RyaW5nIGlwaG9uZSwkKFNES1JPT1QpKSkKKwlPVkVS UklERV9TREtST09UID0gZGVmYXVsdAorCU9WRVJSSURFX0FSQ0hTID0gZGVmYXVsdAorZW5kaWYK KwogaW5jbHVkZSAuLi8uLi9NYWtlZmlsZS5zaGFyZWQK 309509 2017-05-09 10:00:24 -0700 2017-05-09 10:21:14 -0700 Patch bug-171835-20170509100024.patch text/plain 1930 jbedard SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDIxNjUwOSkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE3IEBACisyMDE3LTA1LTA5ICBKb25hdGhhbiBCZWRhcmQgIDxqYmVkYXJkQGFwcGxlLmNv bT4KKworICAgICAgICBidWlsZCBJbWFnZURpZmYgd2l0aCBob3N0IFNESyBmcm9tIE1ha2UKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE3MTgzNQorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEltYWdlRGlmZiBz aG91bGQgYmUgYnVpbHQgZm9yIHRoZSBkZWZhdWx0IFNESyBhbmQgZGVmYXVsdCBhcmNoaXRlY3R1 cmUgd2hlbgorICAgICAgICB0aGUgU0RLUk9PVCBpcyBzZXQgdG8gZWl0aGVyIGlPUyBkZXZpY2Ug b3IgaU9TIHNpbXVsYXRvci4gQ2hlY2sgdGhlCisgICAgICAgIERPX05PVF9CVUlMRF9JTUFHRV9E SUZGIGZsYWcgdG8gc2tpcCB0aGUgSW1hZ2VEaWZmIGJ1aWxkLgorCisgICAgICAgICogSW1hZ2VE aWZmL01ha2VmaWxlOiBVc2UgTWFjIFNESyB3aGVuIGJ1aWxkaW5nIGZvciBpT1MgU2ltdWxhdG9y IG9yIGlPUyBkZXZpY2UuCisgICAgICAgICogTWFrZWZpbGU6IERvIG5vdCBidWlsZCBJbWFnZURp ZmYgaWYgdGhlIERPX05PVF9CVUlMRF9JTUFHRV9ESUZGIGZsYWcgaXMgc2V0LgorCiAyMDE3LTA1 LTA5ICBKb25hdGhhbiBCZWRhcmQgIDxqYmVkYXJkQGFwcGxlLmNvbT4KIAogICAgICAgICBSRUdS RVNTSU9OOiBJbWFnZURpZmYgbm90IGJ1aWxkaW5nIHdpdGggbWFrZQpJbmRleDogVG9vbHMvTWFr ZWZpbGUKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PQotLS0gVG9vbHMvTWFrZWZpbGUJKHJldmlzaW9uIDIxNjUwOSkKKysr IFRvb2xzL01ha2VmaWxlCSh3b3JraW5nIGNvcHkpCkBAIC0yLDExICsyLDE0IEBAIE1PRFVMRVMg PSBEdW1wUmVuZGVyVHJlZSBXZWJLaXRUZXN0UnVubmUKIAogaWZuZXEgKCwkKFNES1JPT1QpKQog CWlmZXEgKCwkKGZpbmRzdHJpbmcgbWFjb3N4LCQoU0RLUk9PVCkpKQotCQlNT0RVTEVTID0gRHVt cFJlbmRlclRyZWUgV2ViS2l0VGVzdFJ1bm5lciAuLi9Tb3VyY2UvVGhpcmRQYXJ0eS9ndGVzdC94 Y29kZSBUZXN0V2ViS2l0QVBJIEltYWdlRGlmZgorCQlNT0RVTEVTID0gRHVtcFJlbmRlclRyZWUg V2ViS2l0VGVzdFJ1bm5lciAuLi9Tb3VyY2UvVGhpcmRQYXJ0eS9ndGVzdC94Y29kZSBUZXN0V2Vi S2l0QVBJCiAJZW5kaWYKIAlpZm5lcSAoLCQoZmluZHN0cmluZyBpcGhvbmUsJChTREtST09UKSkp CiAJCU1PRFVMRVMgKz0gTW9iaWxlTWluaUJyb3dzZXIKIAllbmRpZgorCWlmZXEgKCwkKERPX05P VF9CVUlMRF9JTUFHRV9ESUZGKSkKKwkJTU9EVUxFUyArPSBMYXlvdXRUZXN0UmVsYXkKKwllbmRp ZgogZW5kaWYKIAogYWxsOgpJbmRleDogVG9vbHMvSW1hZ2VEaWZmL01ha2VmaWxlCj09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT0KLS0tIFRvb2xzL0ltYWdlRGlmZi9NYWtlZmlsZQkocmV2aXNpb24gMjE2NTA5KQorKysgVG9v bHMvSW1hZ2VEaWZmL01ha2VmaWxlCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsOCBAQAogU0NS SVBUU19QQVRIID0gLi4vU2NyaXB0cwogCitpZm5lcSAoLCQoZmluZHN0cmluZyBpcGhvbmUsJChT REtST09UKSkpCisJT1ZFUlJJREVfU0RLUk9PVCA9IGRlZmF1bHQKKwlPVkVSUklERV9BUkNIUyA9 IGRlZmF1bHQKK2VuZGlmCisKIGluY2x1ZGUgLi4vLi4vTWFrZWZpbGUuc2hhcmVkCg== 309511 2017-05-09 10:21:15 -0700 2017-05-09 11:07:23 -0700 Patch bug-171835-20170509102115.patch text/plain 2163 jbedard SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDIxNjUwOSkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE3IEBACisyMDE3LTA1LTA5ICBKb25hdGhhbiBCZWRhcmQgIDxqYmVkYXJkQGFwcGxlLmNv bT4KKworICAgICAgICBidWlsZCBJbWFnZURpZmYgd2l0aCBob3N0IFNESyBmcm9tIE1ha2UKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE3MTgzNQorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEltYWdlRGlmZiBz aG91bGQgYmUgYnVpbHQgZm9yIHRoZSBkZWZhdWx0IFNESyBhbmQgZGVmYXVsdCBhcmNoaXRlY3R1 cmUgd2hlbgorICAgICAgICB0aGUgU0RLUk9PVCBpcyBzZXQgdG8gZWl0aGVyIGlPUyBkZXZpY2Ug b3IgaU9TIHNpbXVsYXRvci4gQ2hlY2sgdGhlCisgICAgICAgIERPX05PVF9CVUlMRF9JTUFHRV9E SUZGIGZsYWcgdG8gc2tpcCB0aGUgSW1hZ2VEaWZmIGJ1aWxkLgorCisgICAgICAgICogSW1hZ2VE aWZmL01ha2VmaWxlOiBVc2UgTWFjIFNESyB3aGVuIGJ1aWxkaW5nIGZvciBpT1MgU2ltdWxhdG9y IG9yIGlPUyBkZXZpY2UuCisgICAgICAgICogTWFrZWZpbGU6IERvIG5vdCBidWlsZCBJbWFnZURp ZmYgaWYgdGhlIERPX05PVF9CVUlMRF9JTUFHRV9ESUZGIGZsYWcgaXMgc2V0LgorCiAyMDE3LTA1 LTA5ICBKb25hdGhhbiBCZWRhcmQgIDxqYmVkYXJkQGFwcGxlLmNvbT4KIAogICAgICAgICBSRUdS RVNTSU9OOiBJbWFnZURpZmYgbm90IGJ1aWxkaW5nIHdpdGggbWFrZQpJbmRleDogVG9vbHMvTWFr ZWZpbGUKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PQotLS0gVG9vbHMvTWFrZWZpbGUJKHJldmlzaW9uIDIxNjUwOSkKKysr IFRvb2xzL01ha2VmaWxlCSh3b3JraW5nIGNvcHkpCkBAIC0xLDEzICsxLDE2IEBACi1NT0RVTEVT ID0gRHVtcFJlbmRlclRyZWUgV2ViS2l0VGVzdFJ1bm5lciBNaW5pQnJvd3NlciAuLi9Tb3VyY2Uv VGhpcmRQYXJ0eS9ndGVzdC94Y29kZSBUZXN0V2ViS2l0QVBJIEltYWdlRGlmZgorTU9EVUxFUyA9 IER1bXBSZW5kZXJUcmVlIFdlYktpdFRlc3RSdW5uZXIgTWluaUJyb3dzZXIgLi4vU291cmNlL1Ro aXJkUGFydHkvZ3Rlc3QveGNvZGUgVGVzdFdlYktpdEFQSQogCiBpZm5lcSAoLCQoU0RLUk9PVCkp CiAJaWZlcSAoLCQoZmluZHN0cmluZyBtYWNvc3gsJChTREtST09UKSkpCi0JCU1PRFVMRVMgPSBE dW1wUmVuZGVyVHJlZSBXZWJLaXRUZXN0UnVubmVyIC4uL1NvdXJjZS9UaGlyZFBhcnR5L2d0ZXN0 L3hjb2RlIFRlc3RXZWJLaXRBUEkgSW1hZ2VEaWZmCisJCU1PRFVMRVMgPSBEdW1wUmVuZGVyVHJl ZSBXZWJLaXRUZXN0UnVubmVyIC4uL1NvdXJjZS9UaGlyZFBhcnR5L2d0ZXN0L3hjb2RlIFRlc3RX ZWJLaXRBUEkKIAllbmRpZgogCWlmbmVxICgsJChmaW5kc3RyaW5nIGlwaG9uZSwkKFNES1JPT1Qp KSkKIAkJTU9EVUxFUyArPSBNb2JpbGVNaW5pQnJvd3NlcgogCWVuZGlmCiBlbmRpZgoraWZlcSAo LCQoRE9fTk9UX0JVSUxEX0lNQUdFX0RJRkYpKQorCU1PRFVMRVMgKz0gSW1hZ2VEaWZmCitlbmRp ZgogCiBhbGw6CiAJQGZvciBkaXIgaW4gJChNT0RVTEVTKTsgZG8gJHtNQUtFfSAkQCAtQyAkJGRp cjsgZXhpdF9zdGF0dXM9JCQ/OyBcCkluZGV4OiBUb29scy9JbWFnZURpZmYvTWFrZWZpbGUKPT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PQotLS0gVG9vbHMvSW1hZ2VEaWZmL01ha2VmaWxlCShyZXZpc2lvbiAyMTY1MDkpCisr KyBUb29scy9JbWFnZURpZmYvTWFrZWZpbGUJKHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSw4IEBA CiBTQ1JJUFRTX1BBVEggPSAuLi9TY3JpcHRzCiAKK2lmbmVxICgsJChmaW5kc3RyaW5nIGlwaG9u ZSwkKFNES1JPT1QpKSkKKwlPVkVSUklERV9TREtST09UID0gZGVmYXVsdAorCU9WRVJSSURFX0FS Q0hTID0gZGVmYXVsdAorZW5kaWYKKwogaW5jbHVkZSAuLi8uLi9NYWtlZmlsZS5zaGFyZWQK