171823 2017-05-08 13:16:55 -0700 Update Chrome and Firefox versions in user agent quirks 2017-05-09 11:44:39 -0700 1 1 1 Unclassified WebKit WebCore Misc. Other PC Linux RESOLVED FIXED P2 Normal --- 1 mcatanzaro mcatanzaro bugs-noreply cgarcia clopez commit-queue mcatanzaro oldest_to_newest 1306021 0 mcatanzaro 2017-05-08 13:16:55 -0700 Update Chrome and Firefox versions in user agent quirks 1306023 1 mcatanzaro 2017-05-08 13:19:08 -0700 (I wonder what this will break.) 1306024 2 309404 mcatanzaro 2017-05-08 13:20:04 -0700 Created attachment 309404 Patch 1306277 3 cgarcia 2017-05-08 23:19:39 -0700 (In reply to Michael Catanzaro from comment #1) > (I wonder what this will break.) Why do we want this if you think it's going to break something? I don't think we should do this unless it fixes anything. 1306352 4 mcatanzaro 2017-05-09 06:38:37 -0700 Well we know websites are definitely going to break eventually if we don't do it. E.g. you'll get unsupported browser warnings in GMail. So we should do it. But I would err on the side of not backporting it to 2.16 until we know it's needed to fix something. 1306451 5 clopez 2017-05-09 10:53:21 -0700 Gmail will stop working with chrome53 https://gsuiteupdates.googleblog.com/2017/02/gmail-no-longer-supporting-chrome-v53.html Soon similar things will happen for chrome56, etc. I think keeping updated the version to the last one (or almost) is something sane. People running chrome or firefox are usually running the last version (they are evergreen browsers -- they update themselves automatically without asking the user). So sites that test for the chrome or firefox version usually do this as way to see if you don't have an obsolete browser. 1306452 6 309404 clopez 2017-05-09 10:54:35 -0700 Comment on attachment 309404 Patch r=me, but please test that this doesn't break any major site 1306473 7 mcatanzaro 2017-05-09 11:40:57 -0700 (In reply to Carlos Alberto Lopez Perez from comment #6) > Comment on attachment 309404 [details] > Patch > > r=me, but please test that this doesn't break any major site Note these versions are only used for our quirks, so Firefox UA bump only affects Google and the Chrome UA bump only affects TypeKit and Slack (but see bug #171869). 1306476 8 309404 commit-queue 2017-05-09 11:44:38 -0700 Comment on attachment 309404 Patch Clearing flags on attachment: 309404 Committed r216531: <http://trac.webkit.org/changeset/216531> 1306477 9 commit-queue 2017-05-09 11:44:39 -0700 All reviewed patches have been landed. Closing bug. 309404 2017-05-08 13:20:04 -0700 2017-05-09 11:44:38 -0700 Patch bug-171823-20170508152003.patch text/plain 1994 mcatanzaro U3VidmVyc2lvbiBSZXZpc2lvbjogMjE2NDMzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMWI0ZTMzNTRhODEzNGQx ZDViZjM5Y2Y4ZWNlYTdjN2U1NTAxNWMzMy4uMDI0MTgzNzcwMjY2ZTcyZmNkNzk4NzM5OThmOWIy YTJmNjM3Y2NhMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE2IEBACiAyMDE3LTA1LTA4ICBNaWNo YWVsIENhdGFuemFybyAgPG1jYXRhbnphcm9AaWdhbGlhLmNvbT4KIAorICAgICAgICBVcGRhdGUg Q2hyb21lIGFuZCBGaXJlZm94IHZlcnNpb25zIGluIHVzZXIgYWdlbnQgcXVpcmtzCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNzE4MjMKKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIHBsYXRmb3JtL1VzZXJB Z2VudFF1aXJrcy5jcHA6CisgICAgICAgIChXZWJDb3JlOjpVc2VyQWdlbnRRdWlya3M6OnN0cmlu Z0ZvclF1aXJrKToKKyAgICAgICAgKFdlYkNvcmU6OlVzZXJBZ2VudFF1aXJrczo6ZmlyZWZveFJl dmlzaW9uU3RyaW5nKToKKworMjAxNy0wNS0wOCAgTWljaGFlbCBDYXRhbnphcm8gIDxtY2F0YW56 YXJvQGlnYWxpYS5jb20+CisKICAgICAgICAgVW5yZXZpZXdlZCwgcm9sbGluZyBvdXQgcjIxNjQx OS4KIAogICAgICAgICBCcm9rZSA3MCBsYXlvdXQgdGVzdHMgb24gR1RLIGJvdApkaWZmIC0tZ2l0 IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vVXNlckFnZW50UXVpcmtzLmNwcCBiL1NvdXJjZS9X ZWJDb3JlL3BsYXRmb3JtL1VzZXJBZ2VudFF1aXJrcy5jcHAKaW5kZXggYTA1MDZiMWVlMzA3ZTFm NDY2YzUyZmQ0NDE1YTA0MmMyZmFhMjIxMi4uNGZlZWU0NjFhYThmZmQyNjc3MWJiYzMwYzIwYzIy Zjg3Y2VmYjIwNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vVXNlckFnZW50 UXVpcmtzLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9Vc2VyQWdlbnRRdWlya3Mu Y3BwCkBAIC0xMjcsMTAgKzEyNywxMCBAQCBTdHJpbmcgVXNlckFnZW50UXVpcmtzOjpzdHJpbmdG b3JRdWlyayhVc2VyQWdlbnRRdWlyayBxdWlyaykKICAgICBzd2l0Y2ggKHF1aXJrKSB7CiAgICAg Y2FzZSBOZWVkc0Nocm9tZUJyb3dzZXI6CiAgICAgICAgIC8vIEdldCB2ZXJzaW9ucyBmcm9tIGh0 dHBzOi8vY2hyb21pdW0uZ29vZ2xlc291cmNlLmNvbS9jaHJvbWl1bS9zcmMuZ2l0Ci0gICAgICAg IHJldHVybiBBU0NJSUxpdGVyYWwoIkNocm9tZS81Ni4wLjI4OTEuNCIpOworICAgICAgICByZXR1 cm4gQVNDSUlMaXRlcmFsKCJDaHJvbWUvNTguMC4zMDI5LjgxIik7CiAgICAgY2FzZSBOZWVkc0Zp cmVmb3hCcm93c2VyOgogICAgICAgICAvLyBHZWNrbyB2ZXJzaW9uIG5ldmVyIGNoYW5nZXMuIEZp cmVmb3ggdmVyc2lvbiBtdXN0IGJlIHVwZGF0ZWQgYmVsb3cuCi0gICAgICAgIHJldHVybiBBU0NJ SUxpdGVyYWwoIkdlY2tvLzIwMTAwMTAxIEZpcmVmb3gvNTAuMCIpOworICAgICAgICByZXR1cm4g QVNDSUlMaXRlcmFsKCJHZWNrby8yMDEwMDEwMSBGaXJlZm94LzUzLjAiKTsKICAgICBjYXNlIE5l ZWRzTWFjaW50b3NoUGxhdGZvcm06CiAgICAgICAgIHJldHVybiBBU0NJSUxpdGVyYWwoIk1hY2lu dG9zaDsgSW50ZWwgTWFjIE9TIFggMTBfMTIiKTsKICAgICBjYXNlIE5lZWRzTGludXhEZXNrdG9w UGxhdGZvcm06CkBAIC0xNDQsNyArMTQ0LDcgQEAgU3RyaW5nIFVzZXJBZ2VudFF1aXJrczo6c3Ry aW5nRm9yUXVpcmsoVXNlckFnZW50UXVpcmsgcXVpcmspCiAKIFN0cmluZyBVc2VyQWdlbnRRdWly a3M6OmZpcmVmb3hSZXZpc2lvblN0cmluZygpCiB7Ci0gICAgcmV0dXJuIEFTQ0lJTGl0ZXJhbCgi cnY6NTAuMCIpOworICAgIHJldHVybiBBU0NJSUxpdGVyYWwoInJ2OjUzLjAiKTsKIH0KIAogfQo=