171813 2017-05-08 10:34:55 -0700 Drop [CEReactions] from CharacterData operations 2017-05-08 19:46:31 -0700 1 1 1 Unclassified WebKit DOM WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=163969 https://dom.spec.whatwg.org/#interface-characterdata P2 Normal --- 171688 154907 1 cdumez cdumez achristensen buildbot cdumez commit-queue dbates esprehn+autocc ggaren kangil.han kling koivisto kondapallykalyan rniwa sam oldest_to_newest 1305931 0 cdumez 2017-05-08 10:34:55 -0700 Drop [CEReactions] from CharacterData operations to match the DOM specification: - https://dom.spec.whatwg.org/#interface-characterdata I believe WebKit had this because Attr used to have Text child nodes. Therefore, modifying those Text child nodes via the CharacterData API could modify the value of an attribute, requiring us to run attributeChangedCallback for Custom Elements. However, as of Bug 171688, Attr can no longer have Text child nodes. I have also verified that Blink does not have [CEReactions] for those methods. 1305988 1 309393 cdumez 2017-05-08 12:18:13 -0700 Created attachment 309393 Patch 1306221 2 309393 commit-queue 2017-05-08 19:46:29 -0700 Comment on attachment 309393 Patch Clearing flags on attachment: 309393 Committed r216474: <http://trac.webkit.org/changeset/216474> 1306222 3 commit-queue 2017-05-08 19:46:31 -0700 All reviewed patches have been landed. Closing bug. 309393 2017-05-08 12:18:13 -0700 2017-05-08 19:46:29 -0700 Patch bug-171813-20170508121813.patch text/plain 2886 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjE2NDMwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYjg0NTdiMjQxOGZhZDQ5 NDRmYzNkMjA2NjM2MGVlMTM0ODJmZmRjZC4uZGZkNmMxNTc1YmE5YWMxY2VkZGVjYmIzYjE0MWQ4 ZDM0MDk2ZTU4NSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI0IEBACisyMDE3LTA1LTA4ICBDaHJp cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgRHJvcCBbQ0VSZWFjdGlvbnNd IGZyb20gQ2hhcmFjdGVyRGF0YSBvcGVyYXRpb25zCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNzE4MTMKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBEcm9wIFtDRVJlYWN0aW9uc10gZnJvbSBDaGFyYWN0ZXJE YXRhIG9wZXJhdGlvbnMgdG8gbWF0Y2ggdGhlIERPTSBzcGVjaWZpY2F0aW9uOgorICAgICAgICAt IGh0dHBzOi8vZG9tLnNwZWMud2hhdHdnLm9yZy8jaW50ZXJmYWNlLWNoYXJhY3RlcmRhdGEKKwor ICAgICAgICBJIGJlbGlldmUgV2ViS2l0IGhhZCB0aGlzIGJlY2F1c2UgQXR0ciB1c2VkIHRvIGhh dmUgVGV4dCBjaGlsZCBub2Rlcy4gVGhlcmVmb3JlLCBtb2RpZnlpbmcKKyAgICAgICAgdGhvc2Ug VGV4dCBjaGlsZCBub2RlcyB2aWEgdGhlIENoYXJhY3RlckRhdGEgQVBJIGNvdWxkIG1vZGlmeSB0 aGUgdmFsdWUgb2YgYW4gYXR0cmlidXRlLAorICAgICAgICByZXF1aXJpbmcgdXMgdG8gcnVuIGF0 dHJpYnV0ZUNoYW5nZWRDYWxsYmFjayBmb3IgQ3VzdG9tIEVsZW1lbnRzLiBIb3dldmVyLCBhcyBv ZgorICAgICAgICA8aHR0cHM6Ly90cmFjLndlYmtpdC5vcmcvcjIxNjI1OT4sIEF0dHIgY2FuIG5v IGxvbmdlciBoYXZlIFRleHQgY2hpbGQgbm9kZXMuCisKKyAgICAgICAgSSBoYXZlIGFsc28gdmVy aWZpZWQgdGhhdCBCbGluayBkb2VzIG5vdCBoYXZlIFtDRVJlYWN0aW9uc10gZm9yIHRob3NlIG1l dGhvZHMuCisKKyAgICAgICAgTm8gbmV3IHRlc3RzLCBubyBleHBlY3RlZCBXZWItZmFjaW5nIGJl aGF2aW9yIGNoYW5nZS4KKworICAgICAgICAqIGRvbS9DaGFyYWN0ZXJEYXRhLmlkbDoKKwogMjAx Ny0wNS0wOCAgTWFyayBMYW0gIDxtYXJrLmxhbUBhcHBsZS5jb20+CiAKICAgICAgICAgSW50cm9k dWNlIEV4Y2VwdGlvblNjb3BlOjphc3NlcnROb0V4Y2VwdGlvbigpIGFuZCByZWxlYXNlQXNzZXJ0 Tm9FeGNlcHRpb24oKS4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2RvbS9DaGFyYWN0ZXJE YXRhLmlkbCBiL1NvdXJjZS9XZWJDb3JlL2RvbS9DaGFyYWN0ZXJEYXRhLmlkbAppbmRleCBiZWFh Njg0OTRmYjFjYWExZTBlMDBkYWM2ZDFkYjIxMGFmZjBiYWM2Li5kNDY4NGY1NzZmOTMwNzE4NWRi MWMyMTE0MmU4MWYzNzE2MGFmOGZmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9kb20vQ2hh cmFjdGVyRGF0YS5pZGwKKysrIGIvU291cmNlL1dlYkNvcmUvZG9tL0NoYXJhY3RlckRhdGEuaWRs CkBAIC0xOCwxMyArMTgsMTMgQEAKICAqLwogCiBpbnRlcmZhY2UgQ2hhcmFjdGVyRGF0YSA6IE5v ZGUgewotICAgIFtDRVJlYWN0aW9uc10gYXR0cmlidXRlIFtUcmVhdE51bGxBcz1FbXB0eVN0cmlu Z10gRE9NU3RyaW5nIGRhdGE7IC8vIEZJWE1FOiBOb3QgbWFya2VkIGFzIFtDRVJlYWN0aW9uc10g aW4gdGhlIHNwZWMuCisgICAgYXR0cmlidXRlIFtUcmVhdE51bGxBcz1FbXB0eVN0cmluZ10gRE9N U3RyaW5nIGRhdGE7CiAgICAgcmVhZG9ubHkgYXR0cmlidXRlIHVuc2lnbmVkIGxvbmcgbGVuZ3Ro OwogICAgIFtNYXlUaHJvd0V4Y2VwdGlvbl0gRE9NU3RyaW5nIHN1YnN0cmluZ0RhdGEodW5zaWdu ZWQgbG9uZyBvZmZzZXQsIHVuc2lnbmVkIGxvbmcgY291bnQpOwotICAgIFtDRVJlYWN0aW9uc10g dm9pZCBhcHBlbmREYXRhKERPTVN0cmluZyBkYXRhKTsgLy8gRklYTUU6IE5vdCBtYXJrZWQgYXMg W0NFUmVhY3Rpb25zXSBpbiB0aGUgc3BlYy4KLSAgICBbQ0VSZWFjdGlvbnMsIE1heVRocm93RXhj ZXB0aW9uXSB2b2lkIGluc2VydERhdGEodW5zaWduZWQgbG9uZyBvZmZzZXQsIERPTVN0cmluZyBk YXRhKTsgLy8gRklYTUU6IE5vdCBtYXJrZWQgYXMgW0NFUmVhY3Rpb25zXSBpbiB0aGUgc3BlYy4K LSAgICBbQ0VSZWFjdGlvbnMsIE1heVRocm93RXhjZXB0aW9uXSB2b2lkIGRlbGV0ZURhdGEodW5z aWduZWQgbG9uZyBvZmZzZXQsIHVuc2lnbmVkIGxvbmcgY291bnQpOyAvLyBGSVhNRTogTm90IG1h cmtlZCBhcyBbQ0VSZWFjdGlvbnNdIGluIHRoZSBzcGVjLgotICAgIFtDRVJlYWN0aW9ucywgTWF5 VGhyb3dFeGNlcHRpb25dIHZvaWQgcmVwbGFjZURhdGEodW5zaWduZWQgbG9uZyBvZmZzZXQsIHVu c2lnbmVkIGxvbmcgY291bnQsIERPTVN0cmluZyBkYXRhKTsgLy8gRklYTUU6IE5vdCBtYXJrZWQg YXMgW0NFUmVhY3Rpb25zXSBpbiB0aGUgc3BlYy4KKyAgICB2b2lkIGFwcGVuZERhdGEoRE9NU3Ry aW5nIGRhdGEpOworICAgIFtNYXlUaHJvd0V4Y2VwdGlvbl0gdm9pZCBpbnNlcnREYXRhKHVuc2ln bmVkIGxvbmcgb2Zmc2V0LCBET01TdHJpbmcgZGF0YSk7CisgICAgW01heVRocm93RXhjZXB0aW9u XSB2b2lkIGRlbGV0ZURhdGEodW5zaWduZWQgbG9uZyBvZmZzZXQsIHVuc2lnbmVkIGxvbmcgY291 bnQpOworICAgIFtNYXlUaHJvd0V4Y2VwdGlvbl0gdm9pZCByZXBsYWNlRGF0YSh1bnNpZ25lZCBs b25nIG9mZnNldCwgdW5zaWduZWQgbG9uZyBjb3VudCwgRE9NU3RyaW5nIGRhdGEpOwogfTsKIAog Q2hhcmFjdGVyRGF0YSBpbXBsZW1lbnRzIENoaWxkTm9kZTsK