171792 2017-05-07 05:58:09 -0700 [GTK] Test cases for typehead in form menu lists should start from known state 2017-05-30 20:21:59 -0700 1 1 1 Unclassified WebKit WebKitGTK Other Unspecified Unspecified RESOLVED FIXED P2 Normal --- 171492 1 aperez aperez bugs-noreply cgarcia clopez commit-queue mcatanzaro webkit-bug-importer oldest_to_newest 1305713 0 aperez 2017-05-07 05:58:09 -0700 See bug #171492 for details, in particular this comment: https://bugs.webkit.org/show_bug.cgi?id=171492#c2 The TL;DR is: * The “testTypeAheadFunction()“ function doesn't set an initial state: the result each call is dependent on the state in which previous calls left the element. * The fix for bug #170680 introduced pre-selection of the active element when the popup menu appears, to mimic the behavior of GtkComboBox. Before, when popping up the menu, the type-ahead search (which is implemented in GTK+) would always start from the beginning of the list. Now that we tell GTK+ to preactivate an item, it does not and the layout test breaks. 1305714 1 309321 aperez 2017-05-07 06:07:08 -0700 Created attachment 309321 Patch 1305715 2 309322 aperez 2017-05-07 06:08:51 -0700 Created attachment 309322 Patch 1305716 3 aperez 2017-05-07 09:59:04 -0700 (In reply to Adrian Perez from comment #0) > See bug #171492 for details, in particular this comment: > > https://bugs.webkit.org/show_bug.cgi?id=171492#c2 > > [...] > > Before, when popping up the menu, the type-ahead search (which > is implemented in GTK+) [...] Well, forget about this comment: I have just noticed that the type-ahead search is implemented in “WebPopupMenuProxyGtk::typeAheadFind()”. The fact that the test should start from a known state still applies :-P 1305738 4 mcatanzaro 2017-05-07 12:42:36 -0700 What is the blur for? 1305745 5 aperez 2017-05-07 13:32:55 -0700 (In reply to Michael Catanzaro from comment #4) > What is the blur for? It causes the HTML element to lose keyboard focus: https://developer.mozilla.org/en-US/docs/Web/API/HTMLElement/blur When the HTML for the layout test is loaded, the <select> element is not focused, so calling “.blur()” on it ensures that it is not focused before “testTypeAheadFunction()” starts sending mouse and keyboard events, regardless of the state it was left on previous uses of the function. (NB: It does not really make a difference here, but for consistency it seems like a good idea to remove the focus from the element as well to guarantee the same state as after page load.) 1305746 6 309327 aperez 2017-05-07 13:40:12 -0700 Created attachment 309327 Patch 1305747 7 aperez 2017-05-07 13:42:03 -0700 I did some double checking, and right after page load the first element is the selected one, so the patch is not updated to set “.selectedIndex=0”. 1313696 8 309327 cgarcia 2017-05-30 07:18:52 -0700 Comment on attachment 309327 Patch Wait, r171792 has nothing to do with this, it's a very old revision 1313697 9 cgarcia 2017-05-30 07:19:31 -0700 (In reply to Carlos Garcia Campos from comment #8) > Comment on attachment 309327 [details] > Patch > > Wait, r171792 has nothing to do with this, it's a very old revision It seems you used the bug number, instead of the revision number. 1313701 10 aperez 2017-05-30 07:28:01 -0700 (In reply to Carlos Garcia Campos from comment #9) > (In reply to Carlos Garcia Campos from comment #8) > > Comment on attachment 309327 [details] > > Patch > > > > Wait, r171792 has nothing to do with this, it's a very old revision > > It seems you used the bug number, instead of the revision number. You are right, the correct revision is r215188: http://trac.webkit.org/changeset/215188 I'll update the ChangeLog accordingly before landing this. 1313706 11 aperez 2017-05-30 07:33:28 -0700 Committed r217554: <http://trac.webkit.org/changeset/217554> 309321 2017-05-07 06:07:08 -0700 2017-05-07 06:08:36 -0700 Patch bug-171792-20170507160707.patch text/plain 1571 aperez U3VidmVyc2lvbiBSZXZpc2lvbjogMjE2MzQ3CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggOWMxYjk2MTFhZGVjYmEwZjFmYjQz YmMwZmYxMjUzOGY5N2Y3NzM3Ni4uZGRmMTFiMjVmMjc0MTQwZDg3Y2Q0OTRlOWYyNzM1MzUxZmJk YWYxMyAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDE3LTA1LTA3ICBBZHJpYW4gUGVyZXogZGUg Q2FzdHJvICA8YXBlcmV6QGlnYWxpYS5jb20+CisKKyAgICAgICAgW0dUS10gVGVzdCBjYXNlcyBm b3IgdHlwZWhlYWQgaW4gZm9ybSBtZW51IGxpc3RzIHNob3VsZCBzdGFydCBmcm9tIGtub3duIHN0 YXRlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNzE3 OTIKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIHBs YXRmb3JtL2d0ay9mYXN0L2Zvcm1zL21lbnVsaXN0LXR5cGVhaGVhZC1maW5kLmh0bWw6IFJlc2V0 IG1lbnUKKyAgICAgICAgbGlzdCB0byB0aGUgaW5pdGlhbCB3aXRoIG5vIGVsZW1lbnQgc2VsZWN0 ZWQgYXQgdGhlIGJlZ2lubmluZyBvZgorICAgICAgICB0ZXN0VHlwZUFoZWFkRnVuY3Rpb24oKS4K KwogMjAxNy0wNS0wNyAgU2FtIFdlaW5pZyAgPHNhbUB3ZWJraXQub3JnPgogCiAgICAgICAgIElt cGxlbWVudCBTdWJyZXNvdXJjZSBJbnRlZ3JpdHkgKFNSSSkKZGlmZiAtLWdpdCBhL0xheW91dFRl c3RzL3BsYXRmb3JtL2d0ay9mYXN0L2Zvcm1zL21lbnVsaXN0LXR5cGVhaGVhZC1maW5kLmh0bWwg Yi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9ndGsvZmFzdC9mb3Jtcy9tZW51bGlzdC10eXBlYWhlYWQt ZmluZC5odG1sCmluZGV4IDUyNjc3ZmIyOTNjMTQzOTEyOWJlN2M2NDQ4MzNhNGNjZTVmNTg0Y2Qu LmY5ODk3OWZjNzcyMzZkZjkwNjMzYzkxNmI1OThiMzk5YzllYzQ1ZGIgMTAwNjQ0Ci0tLSBhL0xh eW91dFRlc3RzL3BsYXRmb3JtL2d0ay9mYXN0L2Zvcm1zL21lbnVsaXN0LXR5cGVhaGVhZC1maW5k Lmh0bWwKKysrIGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0vZ3RrL2Zhc3QvZm9ybXMvbWVudWxpc3Qt dHlwZWFoZWFkLWZpbmQuaHRtbApAQCAtMjAsNiArMjAsMTAgQEAgZnVuY3Rpb24gdGVzdFR5cGVB aGVhZEZpbmQoa2V5cywgZXhwZWN0ZWRNZW51TGlzdFRleHQpCiAgICAgaWYgKCF3aW5kb3cuZXZl bnRTZW5kZXIpCiAgICAgICAgIHJldHVybjsKIAorICAgIC8vIFJlc2V0IG1lbnUgbGlzdCB0byBp bml0aWFsIHN0YXRlLgorICAgIG1lbnVsaXN0LnNlbGVjdGVkSW5kZXggPSAtMTsKKyAgICBtZW51 bGlzdC5ibHVyKCk7CisKICAgICBldmVudFNlbmRlci5tb3VzZU1vdmVUbyhtZW51bGlzdC5vZmZz ZXRMZWZ0ICsgKG1lbnVsaXN0Lm9mZnNldFdpZHRoIC8gMiksIG1lbnVsaXN0Lm9mZnNldFRvcCAr IChtZW51bGlzdC5vZmZzZXRIZWlnaHQgLyAyKSk7CiAgICAgZXZlbnRTZW5kZXIubW91c2VEb3du KCk7CiAgICAgZXZlbnRTZW5kZXIubW91c2VVcCgpOwo= 309322 2017-05-07 06:08:51 -0700 2017-05-07 13:40:08 -0700 Patch bug-171792-20170507160850.patch text/plain 1930 aperez U3VidmVyc2lvbiBSZXZpc2lvbjogMjE2MzQ3CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggOWMxYjk2MTFhZGVjYmEwZjFmYjQz YmMwZmYxMjUzOGY5N2Y3NzM3Ni4uMjVmMjdjY2NlYjA5MjgzYTNmZjZjNDdiNDUwYmEyZWFhYjJh MDI0OSAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDE3LTA1LTA3ICBBZHJpYW4gUGVyZXogZGUg Q2FzdHJvICA8YXBlcmV6QGlnYWxpYS5jb20+CisKKyAgICAgICAgW0dUS10gVGVzdCBjYXNlcyBm b3IgdHlwZWhlYWQgaW4gZm9ybSBtZW51IGxpc3RzIHNob3VsZCBzdGFydCBmcm9tIGtub3duIHN0 YXRlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNzE3 OTIKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBTaW5j ZSByMTcxNzkyIG9wZW5pbmcgYSBwb3B1cCBtZW51IGluIGEgZm9ybSBwcmUtc2VsZWN0cyB0aGUg YWN0aXZlCisgICAgICAgIGVsZW1lbnQgdG8gbWltaWMgR3RrQ29tYm94Qm94IGJlaGF2aW9yLCBi dXQgdGhlIGxheW91dCB0ZXN0IGltcGxpY2l0bHkKKyAgICAgICAgYXNzdW1lZCB0aGF0IHR5cGUg YWhlYWQgc2VhcmNoIGFsd2F5cyBzdGFydGVkIHRoZSBiZWdpbm5pbmcgb2YgdGhlCisgICAgICAg IGxpc3QsIHdoaWNoIGlzIG5vIGxvbmdlciB0cnVlIG5vdyB0aGF0IEdUSysgaXMgaW5mb3JtZWQg b2Ygd2hpY2ggb25lCisgICAgICAgIGlzIHRoZSBhY3RpdmUgZWxlbWVudC4KKworICAgICAgICAq IHBsYXRmb3JtL2d0ay9mYXN0L2Zvcm1zL21lbnVsaXN0LXR5cGVhaGVhZC1maW5kLmh0bWw6IFJl c2V0IG1lbnUKKyAgICAgICAgbGlzdCB0byB0aGUgaW5pdGlhbCBzdGF0ZSAobm8gZWxlbWVudCBz ZWxlY3RlZCwgdW5mb2N1c2VkKSBhdCB0aGUKKyAgICAgICAgYmVnaW5uaW5nIG9mIHRlc3RUeXBl QWhlYWRGdW5jdGlvbigpLgorCiAyMDE3LTA1LTA3ICBTYW0gV2VpbmlnICA8c2FtQHdlYmtpdC5v cmc+CiAKICAgICAgICAgSW1wbGVtZW50IFN1YnJlc291cmNlIEludGVncml0eSAoU1JJKQpkaWZm IC0tZ2l0IGEvTGF5b3V0VGVzdHMvcGxhdGZvcm0vZ3RrL2Zhc3QvZm9ybXMvbWVudWxpc3QtdHlw ZWFoZWFkLWZpbmQuaHRtbCBiL0xheW91dFRlc3RzL3BsYXRmb3JtL2d0ay9mYXN0L2Zvcm1zL21l bnVsaXN0LXR5cGVhaGVhZC1maW5kLmh0bWwKaW5kZXggNTI2NzdmYjI5M2MxNDM5MTI5YmU3YzY0 NDgzM2E0Y2NlNWY1ODRjZC4uZjk4OTc5ZmM3NzIzNmRmOTA2MzNjOTE2YjU5OGIzOTljOWVjNDVk YiAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvcGxhdGZvcm0vZ3RrL2Zhc3QvZm9ybXMvbWVudWxp c3QtdHlwZWFoZWFkLWZpbmQuaHRtbAorKysgYi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9ndGsvZmFz dC9mb3Jtcy9tZW51bGlzdC10eXBlYWhlYWQtZmluZC5odG1sCkBAIC0yMCw2ICsyMCwxMCBAQCBm dW5jdGlvbiB0ZXN0VHlwZUFoZWFkRmluZChrZXlzLCBleHBlY3RlZE1lbnVMaXN0VGV4dCkKICAg ICBpZiAoIXdpbmRvdy5ldmVudFNlbmRlcikKICAgICAgICAgcmV0dXJuOwogCisgICAgLy8gUmVz ZXQgbWVudSBsaXN0IHRvIGluaXRpYWwgc3RhdGUuCisgICAgbWVudWxpc3Quc2VsZWN0ZWRJbmRl eCA9IC0xOworICAgIG1lbnVsaXN0LmJsdXIoKTsKKwogICAgIGV2ZW50U2VuZGVyLm1vdXNlTW92 ZVRvKG1lbnVsaXN0Lm9mZnNldExlZnQgKyAobWVudWxpc3Qub2Zmc2V0V2lkdGggLyAyKSwgbWVu dWxpc3Qub2Zmc2V0VG9wICsgKG1lbnVsaXN0Lm9mZnNldEhlaWdodCAvIDIpKTsKICAgICBldmVu dFNlbmRlci5tb3VzZURvd24oKTsKICAgICBldmVudFNlbmRlci5tb3VzZVVwKCk7Cg== 309327 2017-05-07 13:40:12 -0700 2017-05-30 07:18:52 -0700 Patch bug-171792-20170507234010.patch text/plain 1929 aperez U3VidmVyc2lvbiBSZXZpc2lvbjogMjE2MzQ3CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggOWMxYjk2MTFhZGVjYmEwZjFmYjQz YmMwZmYxMjUzOGY5N2Y3NzM3Ni4uMjVmMjdjY2NlYjA5MjgzYTNmZjZjNDdiNDUwYmEyZWFhYjJh MDI0OSAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDE3LTA1LTA3ICBBZHJpYW4gUGVyZXogZGUg Q2FzdHJvICA8YXBlcmV6QGlnYWxpYS5jb20+CisKKyAgICAgICAgW0dUS10gVGVzdCBjYXNlcyBm b3IgdHlwZWhlYWQgaW4gZm9ybSBtZW51IGxpc3RzIHNob3VsZCBzdGFydCBmcm9tIGtub3duIHN0 YXRlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNzE3 OTIKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBTaW5j ZSByMTcxNzkyIG9wZW5pbmcgYSBwb3B1cCBtZW51IGluIGEgZm9ybSBwcmUtc2VsZWN0cyB0aGUg YWN0aXZlCisgICAgICAgIGVsZW1lbnQgdG8gbWltaWMgR3RrQ29tYm94Qm94IGJlaGF2aW9yLCBi dXQgdGhlIGxheW91dCB0ZXN0IGltcGxpY2l0bHkKKyAgICAgICAgYXNzdW1lZCB0aGF0IHR5cGUg YWhlYWQgc2VhcmNoIGFsd2F5cyBzdGFydGVkIHRoZSBiZWdpbm5pbmcgb2YgdGhlCisgICAgICAg IGxpc3QsIHdoaWNoIGlzIG5vIGxvbmdlciB0cnVlIG5vdyB0aGF0IEdUSysgaXMgaW5mb3JtZWQg b2Ygd2hpY2ggb25lCisgICAgICAgIGlzIHRoZSBhY3RpdmUgZWxlbWVudC4KKworICAgICAgICAq IHBsYXRmb3JtL2d0ay9mYXN0L2Zvcm1zL21lbnVsaXN0LXR5cGVhaGVhZC1maW5kLmh0bWw6IFJl c2V0IG1lbnUKKyAgICAgICAgbGlzdCB0byB0aGUgaW5pdGlhbCBzdGF0ZSAobm8gZWxlbWVudCBz ZWxlY3RlZCwgdW5mb2N1c2VkKSBhdCB0aGUKKyAgICAgICAgYmVnaW5uaW5nIG9mIHRlc3RUeXBl QWhlYWRGdW5jdGlvbigpLgorCiAyMDE3LTA1LTA3ICBTYW0gV2VpbmlnICA8c2FtQHdlYmtpdC5v cmc+CiAKICAgICAgICAgSW1wbGVtZW50IFN1YnJlc291cmNlIEludGVncml0eSAoU1JJKQpkaWZm IC0tZ2l0IGEvTGF5b3V0VGVzdHMvcGxhdGZvcm0vZ3RrL2Zhc3QvZm9ybXMvbWVudWxpc3QtdHlw ZWFoZWFkLWZpbmQuaHRtbCBiL0xheW91dFRlc3RzL3BsYXRmb3JtL2d0ay9mYXN0L2Zvcm1zL21l bnVsaXN0LXR5cGVhaGVhZC1maW5kLmh0bWwKaW5kZXggNTI2NzdmYjI5M2MxNDM5MTI5YmU3YzY0 NDgzM2E0Y2NlNWY1ODRjZC4uZDYyYjNkNDBlNGE3NTIwOTc2OWE2NGU2YzM4ZGZlNWQyZDg3MjVh MyAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvcGxhdGZvcm0vZ3RrL2Zhc3QvZm9ybXMvbWVudWxp c3QtdHlwZWFoZWFkLWZpbmQuaHRtbAorKysgYi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9ndGsvZmFz dC9mb3Jtcy9tZW51bGlzdC10eXBlYWhlYWQtZmluZC5odG1sCkBAIC0yMCw2ICsyMCwxMCBAQCBm dW5jdGlvbiB0ZXN0VHlwZUFoZWFkRmluZChrZXlzLCBleHBlY3RlZE1lbnVMaXN0VGV4dCkKICAg ICBpZiAoIXdpbmRvdy5ldmVudFNlbmRlcikKICAgICAgICAgcmV0dXJuOwogCisgICAgLy8gUmVz ZXQgbWVudSBsaXN0IHRvIGluaXRpYWwgc3RhdGUuCisgICAgbWVudWxpc3Quc2VsZWN0ZWRJbmRl eCA9IDA7CisgICAgbWVudWxpc3QuYmx1cigpOworCiAgICAgZXZlbnRTZW5kZXIubW91c2VNb3Zl VG8obWVudWxpc3Qub2Zmc2V0TGVmdCArIChtZW51bGlzdC5vZmZzZXRXaWR0aCAvIDIpLCBtZW51 bGlzdC5vZmZzZXRUb3AgKyAobWVudWxpc3Qub2Zmc2V0SGVpZ2h0IC8gMikpOwogICAgIGV2ZW50 U2VuZGVyLm1vdXNlRG93bigpOwogICAgIGV2ZW50U2VuZGVyLm1vdXNlVXAoKTsK