171788 2017-05-07 00:15:02 -0700 REGRESSION: ImageDiff not building with make 2017-05-09 09:24:57 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Local Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 ap jbedard achristensen ap commit-queue dbates jbedard lforschler webkit-bug-importer oldest_to_newest 1305695 0 ap 2017-05-07 00:15:02 -0700 I built WebKit with make, and tried to run tests: ap$ run-webkit-tests --no-build Using port 'mac-sierra-wk2' Test configuration: <sierra, x86_64, debug> ... ImageDiff was not found at /Users/ap/Safari/OpenSource/WebKitBuild/Debug/ImageDiff Build check failed 1305696 1 ap 2017-05-07 00:16:44 -0700 I get this message even when not passing --no-build, which is a separate issue, but may be easiest to address at the same time. ImageDiff was not found at /Users/ap/Safari/OpenSource/WebKitBuild/Debug/ImageDiff 1305858 2 jbedard 2017-05-08 08:07:38 -0700 (In reply to Alexey Proskuryakov from comment #1) > I get this message even when not passing --no-build, which is a separate > issue, but may be easiest to address at the same time. > > ImageDiff was not found at > /Users/ap/Safari/OpenSource/WebKitBuild/Debug/ImageDiff Is this an iOS Simulator build? Or Mac? It's definitely looking in the correct spot, it's just failing to actually build ImageDiff. 1305917 3 309375 jbedard 2017-05-08 10:22:27 -0700 Created attachment 309375 Patch 1305920 4 jbedard 2017-05-08 10:23:28 -0700 attachment 309375 should do the trick. Actually, no Apple platforms were building the correct ImageDiff through Make. 1305947 5 309375 ap 2017-05-08 10:58:39 -0700 Comment on attachment 309375 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=309375&action=review > Tools/ChangeLog:8 > + * ImageDiff/Makefile: Use Mac SDK when building for iOS Simulator or iOS device. Please explain that this is fixing a separate issue that you found while looking into this. 1306079 6 309420 jbedard 2017-05-08 15:12:41 -0700 Created attachment 309420 Patch 1306095 7 309420 ap 2017-05-08 15:32:24 -0700 Comment on attachment 309420 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=309420&action=review > Tools/ChangeLog:3 > + REGRESSION: ImageDiff not building with make I'm not sure if this is even a bug. In the past, we explicitly disabled LayoutTestRelay building with DO_NOT_BUILD_LAYOUT_TEST_RELAY variable (it's actually still in place in trunk). The rationale was that we wanted to maintain symmetry with production builds. But then I'm not sure about how testers would work. Really confused about the overall plan. > Tools/ChangeLog:14 > + * ImageDiff/Makefile: Use Mac SDK when building for iOS Simulator or iOS device. It's probably best to file a new bug about this, as it really seems like a separate issue. > Tools/ImageDiff/Makefile:5 > + OVERRIDE_SDKROOT = macosx > + OVERRIDE_ARCHS = "i386 x86_64" Here is what we used to have in LayoutTestRelay/Makefile, added in <https://trac.webkit.org/r192106>: OVERRIDE_ARCHS = default OVERRIDE_SDKROOT = default 1306103 8 jbedard 2017-05-08 15:57:02 -0700 (In reply to Alexey Proskuryakov from comment #7) > Comment on attachment 309420 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=309420&action=review > > > Tools/ChangeLog:3 > > + REGRESSION: ImageDiff not building with make > > I'm not sure if this is even a bug. In the past, we explicitly disabled > LayoutTestRelay building with DO_NOT_BUILD_LAYOUT_TEST_RELAY variable (it's > actually still in place in trunk). The rationale was that we wanted to > maintain symmetry with production builds. I think the difference with LayoutTestRelay and ImageDiff is that every platform needs an ImageDiff, it's just not always the one built with the target SDK. > It's probably best to file a new bug about this, as it really seems like a > separate issue. I can file a separate bug about the iOS Simulator/Device case 1306116 9 jbedard 2017-05-08 16:06:33 -0700 <https://bugs.webkit.org/show_bug.cgi?id=171835> is tracking the iOS device and iOS simulator bits. 1306120 10 309433 jbedard 2017-05-08 16:10:18 -0700 Created attachment 309433 Patch 1306132 11 webkit-bug-importer 2017-05-08 16:18:45 -0700 <rdar://problem/32062947> 1306362 12 achristensen 2017-05-09 07:25:41 -0700 https://bugs.webkit.org/show_bug.cgi?id=171847 fixes a similar problem on Linux and Windows. 1306369 13 309433 commit-queue 2017-05-09 07:53:05 -0700 Comment on attachment 309433 Patch Clearing flags on attachment: 309433 Committed r216505: <http://trac.webkit.org/changeset/216505> 1306370 14 commit-queue 2017-05-09 07:53:06 -0700 All reviewed patches have been landed. Closing bug. 1306411 15 ap 2017-05-09 09:24:57 -0700 Talking about this more, Jonathan and I think that this should be conditional, to match production builds. It's not right that release/debug builds ImageDiff, but production does not. 309375 2017-05-08 10:22:27 -0700 2017-05-08 15:12:40 -0700 Patch bug-171788-20170508102226.patch text/plain 1519 jbedard SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDIxNjQzMCkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDEzIEBACisyMDE3LTA1LTA4ICBKb25hdGhhbiBCZWRhcmQgIDxqYmVkYXJkQGFwcGxlLmNv bT4KKworICAgICAgICBSRUdSRVNTSU9OOiBJbWFnZURpZmYgbm90IGJ1aWxkaW5nIHdpdGggbWFr ZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTcxNzg4 CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBJbWFn ZURpZmYvTWFrZWZpbGU6IFVzZSBNYWMgU0RLIHdoZW4gYnVpbGRpbmcgZm9yIGlPUyBTaW11bGF0 b3Igb3IgaU9TIGRldmljZS4KKyAgICAgICAgKiBNYWtlZmlsZTogQnVpbGQgSW1hZ2VEaWZmIGZv ciBhbGwgcGxhdGZvcm1zLgorCiAyMDE3LTA1LTA4ICBDYXJsb3MgR2FyY2lhIENhbXBvcyAgPGNn YXJjaWFAaWdhbGlhLmNvbT4KIAogICAgICAgICBVbnJldmlld2VkLiBGaXggR1RLKyB0ZXN0IC93 ZWJraXQyL1dlYktpdENvbnNvbGVNZXNzYWdlL25ldHdvcmstZXJyb3IgYWZ0ZXIgcjIxNTU1Ni4K SW5kZXg6IFRvb2xzL01ha2VmaWxlCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFRvb2xzL01ha2VmaWxlCShyZXZp c2lvbiAyMTY0MjApCisrKyBUb29scy9NYWtlZmlsZQkod29ya2luZyBjb3B5KQpAQCAtMSw0ICsx LDQgQEAKLU1PRFVMRVMgPSBEdW1wUmVuZGVyVHJlZSBXZWJLaXRUZXN0UnVubmVyIE1pbmlCcm93 c2VyIC4uL1NvdXJjZS9UaGlyZFBhcnR5L2d0ZXN0L3hjb2RlIFRlc3RXZWJLaXRBUEkKK01PRFVM RVMgPSBEdW1wUmVuZGVyVHJlZSBXZWJLaXRUZXN0UnVubmVyIE1pbmlCcm93c2VyIC4uL1NvdXJj ZS9UaGlyZFBhcnR5L2d0ZXN0L3hjb2RlIFRlc3RXZWJLaXRBUEkgSW1hZ2VEaWZmCiAKIGlmbmVx ICgsJChTREtST09UKSkKIAlpZmVxICgsJChmaW5kc3RyaW5nIG1hY29zeCwkKFNES1JPT1QpKSkK SW5kZXg6IFRvb2xzL0ltYWdlRGlmZi9NYWtlZmlsZQo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9JbWFn ZURpZmYvTWFrZWZpbGUJKHJldmlzaW9uIDIxNjQyMCkKKysrIFRvb2xzL0ltYWdlRGlmZi9NYWtl ZmlsZQkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDggQEAKIFNDUklQVFNfUEFUSCA9IC4uL1Nj cmlwdHMKIAoraWZuZXEgKCwkKGZpbmRzdHJpbmcgaXBob25lLCQoU0RLUk9PVCkpKQorCU9WRVJS SURFX1NES1JPT1QgPSBtYWNvc3gKKwlPVkVSUklERV9BUkNIUyA9ICJpMzg2IHg4Nl82NCIKK2Vu ZGlmCisKIGluY2x1ZGUgLi4vLi4vTWFrZWZpbGUuc2hhcmVkCg== 309420 2017-05-08 15:12:41 -0700 2017-05-08 16:10:16 -0700 Patch bug-171788-20170508151241.patch text/plain 1831 jbedard SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDIxNjQ1NCkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE5IEBACisyMDE3LTA1LTA4ICBKb25hdGhhbiBCZWRhcmQgIDxqYmVkYXJkQGFwcGxlLmNv bT4KKworICAgICAgICBSRUdSRVNTSU9OOiBJbWFnZURpZmYgbm90IGJ1aWxkaW5nIHdpdGggbWFr ZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTcxNzg4 CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgRm9yIE1h YywgSW1hZ2VEaWZmIGlzIG5vdCBiZWluZyBidWlsdCB3aGVuIHVzaW5nIE1ha2UuIEZvciBpT1Mg U2ltdWxhdG9yCisgICAgICAgIGFuZCBpT1MgZGV2aWNlLCBJbWFnZURpZmYgaXMgYmVpbmcgYnVp bHQgd2l0aCB0aGUgU0RLIG9mIHRoZSB0YXJnZXQgd2hlbgorICAgICAgICBidWlsdCB0aHJvdWdo IG1ha2UuIEltYWdlRGlmZiBzaG91bGQgYWx3YXlzIGJlIGJ1aWx0IHdoZW4gdG9vbHMgYXJlIGJ1 aWx0CisgICAgICAgIHdpdGggTWFrZSBhbmQgaU9TIFNpbXVsYXRvciBhbmQgaU9TIERldmljZSBz aG91bGQgYnVpbGQgSW1hZ2VEaWZmIHdpdGggdGhlCisgICAgICAgIG1hY29zeCBTREsuCisKKyAg ICAgICAgKiBJbWFnZURpZmYvTWFrZWZpbGU6IFVzZSBNYWMgU0RLIHdoZW4gYnVpbGRpbmcgZm9y IGlPUyBTaW11bGF0b3Igb3IgaU9TIGRldmljZS4KKyAgICAgICAgKiBNYWtlZmlsZTogQnVpbGQg SW1hZ2VEaWZmIGZvciBhbGwgcGxhdGZvcm1zLgorCiAyMDE3LTA1LTA4ICBKb25hdGhhbiBCZWRh cmQgIDxqYmVkYXJkQGFwcGxlLmNvbT4KIAogICAgICAgICBidWlsZGJvdDogQ2xlYW51cCBzaW11 bGF0b3JzIGFmdGVyIHJ1bm5pbmcgdGVzdHMKSW5kZXg6IFRvb2xzL01ha2VmaWxlCj09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT0KLS0tIFRvb2xzL01ha2VmaWxlCShyZXZpc2lvbiAyMTY0NTQpCisrKyBUb29scy9NYWtlZmls ZQkod29ya2luZyBjb3B5KQpAQCAtMSw0ICsxLDQgQEAKLU1PRFVMRVMgPSBEdW1wUmVuZGVyVHJl ZSBXZWJLaXRUZXN0UnVubmVyIE1pbmlCcm93c2VyIC4uL1NvdXJjZS9UaGlyZFBhcnR5L2d0ZXN0 L3hjb2RlIFRlc3RXZWJLaXRBUEkKK01PRFVMRVMgPSBEdW1wUmVuZGVyVHJlZSBXZWJLaXRUZXN0 UnVubmVyIE1pbmlCcm93c2VyIC4uL1NvdXJjZS9UaGlyZFBhcnR5L2d0ZXN0L3hjb2RlIFRlc3RX ZWJLaXRBUEkgSW1hZ2VEaWZmCiAKIGlmbmVxICgsJChTREtST09UKSkKIAlpZmVxICgsJChmaW5k c3RyaW5nIG1hY29zeCwkKFNES1JPT1QpKSkKSW5kZXg6IFRvb2xzL0ltYWdlRGlmZi9NYWtlZmls ZQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09Ci0tLSBUb29scy9JbWFnZURpZmYvTWFrZWZpbGUJKHJldmlzaW9uIDIxNjQ1 NCkKKysrIFRvb2xzL0ltYWdlRGlmZi9NYWtlZmlsZQkod29ya2luZyBjb3B5KQpAQCAtMSwzICsx LDggQEAKIFNDUklQVFNfUEFUSCA9IC4uL1NjcmlwdHMKIAoraWZuZXEgKCwkKGZpbmRzdHJpbmcg aXBob25lLCQoU0RLUk9PVCkpKQorCU9WRVJSSURFX1NES1JPT1QgPSBtYWNvc3gKKwlPVkVSUklE RV9BUkNIUyA9ICJpMzg2IHg4Nl82NCIKK2VuZGlmCisKIGluY2x1ZGUgLi4vLi4vTWFrZWZpbGUu c2hhcmVkCg== 309433 2017-05-08 16:10:18 -0700 2017-05-09 07:53:05 -0700 Patch bug-171788-20170508161017.patch text/plain 1008 jbedard SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDIxNjQ2MCkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDEyIEBACisyMDE3LTA1LTA4ICBKb25hdGhhbiBCZWRhcmQgIDxqYmVkYXJkQGFwcGxlLmNv bT4KKworICAgICAgICBSRUdSRVNTSU9OOiBJbWFnZURpZmYgbm90IGJ1aWxkaW5nIHdpdGggbWFr ZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTcxNzg4 CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBNYWtl ZmlsZTogQnVpbGQgSW1hZ2VEaWZmIGZvciBhbGwgcGxhdGZvcm1zLgorCiAyMDE3LTA1LTA4ICBK b25hdGhhbiBCZWRhcmQgIDxqYmVkYXJkQGFwcGxlLmNvbT4KIAogICAgICAgICBidWlsZGJvdDog Q2xlYW51cCBzaW11bGF0b3JzIGFmdGVyIHJ1bm5pbmcgdGVzdHMKSW5kZXg6IFRvb2xzL01ha2Vm aWxlCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT0KLS0tIFRvb2xzL01ha2VmaWxlCShyZXZpc2lvbiAyMTY0NjApCisrKyBU b29scy9NYWtlZmlsZQkod29ya2luZyBjb3B5KQpAQCAtMSw0ICsxLDQgQEAKLU1PRFVMRVMgPSBE dW1wUmVuZGVyVHJlZSBXZWJLaXRUZXN0UnVubmVyIE1pbmlCcm93c2VyIC4uL1NvdXJjZS9UaGly ZFBhcnR5L2d0ZXN0L3hjb2RlIFRlc3RXZWJLaXRBUEkKK01PRFVMRVMgPSBEdW1wUmVuZGVyVHJl ZSBXZWJLaXRUZXN0UnVubmVyIE1pbmlCcm93c2VyIC4uL1NvdXJjZS9UaGlyZFBhcnR5L2d0ZXN0 L3hjb2RlIFRlc3RXZWJLaXRBUEkgSW1hZ2VEaWZmCiAKIGlmbmVxICgsJChTREtST09UKSkKIAlp ZmVxICgsJChmaW5kc3RyaW5nIG1hY29zeCwkKFNES1JPT1QpKSkK