171784 2017-05-06 20:01:59 -0700 fast/shadow-dom/link-element-in-shadow-tree.html is flaky 2020-01-18 13:17:25 -0800 1 1 1 Unclassified WebKit Tools / Tests WebKit Local Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 ap rniwa cdumez joepeck koivisto lforschler rniwa ryanhaddad simon.fraser tsavell webkit-bot-watchers-bugzilla webkit-bug-importer wenson_hsieh oldest_to_newest 1305670 0 ap 2017-05-06 20:01:59 -0700 @@ -1,5 +1,5 @@ -PASS Link elements should load stylesheets inside a connected shadow tree with closed mode +FAIL Link elements should load stylesheets inside a connected shadow tree with closed mode promise_test: Unhandled rejection with value: "timeout" PASS Link elements should load stylesheets inside a connected shadow tree with open mode PASS Link elements must not load stylesheets inside a disconnceted shadow tree with closed mode PASS Link elements must not load stylesheets inside a disconnceted shadow tree with open mode 1600894 1 tsavell 2019-12-20 13:22:45 -0800 This same failure still appears to happen. History: https://results.webkit.org/?suite=layout-tests&test=fast%2Fshadow-dom%2Flink-element-in-shadow-tree.html The diff is the exact same. 1600895 2 webkit-bug-importer 2019-12-20 13:23:11 -0800 <rdar://problem/58123584> 1600899 3 tsavell 2019-12-20 13:27:48 -0800 History shows this flakiness became a lot worse recently around r253500 1600904 4 tsavell 2019-12-20 13:45:51 -0800 marked test as failing in https://trac.webkit.org/changeset/253843/webkit 1606266 5 rniwa 2020-01-13 23:10:23 -0800 Hm... I can't reproduce this with: ./Tools/Scripts/run-webkit-tests --debug fast/shadow-dom/link-element-in-shadow-tree.html --iterations 100 --exit-after-n-failures=1 --no-show-results 1606279 6 387626 rniwa 2020-01-13 23:45:37 -0800 Created attachment 387626 Fixes the test 1606280 7 387626 koivisto 2020-01-13 23:51:11 -0800 Comment on attachment 387626 Fixes the test View in context: https://bugs.webkit.org/attachment.cgi?id=387626&action=review > LayoutTests/ChangeLog:10 > + Load and cache the styleshe before any test cases run to avoid this timeout. stylesheet 1606708 8 rniwa 2020-01-14 17:05:51 -0800 (In reply to Antti Koivisto from comment #7) > Comment on attachment 387626 [details] > Fixes the test > > View in context: > https://bugs.webkit.org/attachment.cgi?id=387626&action=review > > > LayoutTests/ChangeLog:10 > > + Load and cache the styleshe before any test cases run to avoid this timeout. > > stylesheet Oops, fixed. 1606711 9 rniwa 2020-01-14 17:09:39 -0800 Oops, also forgot to remove the flaky test expectation. Doing that in the same patch. 1606713 10 rniwa 2020-01-14 17:11:11 -0800 This isn't really a regression. As far as I can tell, this test had already been flaky. 1606714 11 rniwa 2020-01-14 17:11:15 -0800 Committed r254546: <https://trac.webkit.org/changeset/254546> 1608372 12 rniwa 2020-01-17 22:10:03 -0800 The test appears to be no longer flaky. 1608379 13 ap 2020-01-17 22:40:07 -0800 I do not concur. On open source bots, the test stopped failing even before this fix. On internal ones, I see failures even after the fix. PASS Link elements must not load stylesheets inside a disconnceted shadow tree with open mode PASS Style rules loaded inside a shadow tree with closed mode must apply to a div in the shadow tree PASS Style rules loaded inside a shadow tree with open mode must apply to a div in the shadow tree -PASS :host style rules loaded inside a shadow tree with closed mode must apply to the host element +FAIL :host style rules loaded inside a shadow tree with closed mode must apply to the host element promise_test: Unhandled rejection with value: "timeout" PASS :host style rules loaded inside a shadow tree with open mode must apply to the host element 1608380 14 ap 2020-01-17 22:43:31 -0800 Not sure if it's best to reopen or to have a new bug for a new fix in this case. And thank you for following up after landing the fix! 1608386 15 rniwa 2020-01-17 22:57:31 -0800 (In reply to Alexey Proskuryakov from comment #14) > Not sure if it's best to reopen or to have a new bug for a new fix in this > case. > > And thank you for following up after landing the fix! Oh, interesting. Maybe you can file a radar for the internal failure. I can follow up on that there. 1608474 16 ap 2020-01-18 13:17:25 -0800 Filed rdar://problem/58713068 387626 2020-01-13 23:45:37 -0800 2020-01-13 23:51:11 -0800 Fixes the test bug-171784-20200113234536.patch text/plain 2316 rniwa SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cJKHJldmlzaW9uIDI1NDQ5NykKKysrIExheW91dFRlc3RzL0NoYW5nZUxvZwkod29y a2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBACisyMDIwLTAxLTEzICBSeW9zdWtlIE5pd2EgIDxy bml3YUB3ZWJraXQub3JnPgorCisgICAgICAgIFJFR1JFU1NJT046IGZhc3Qvc2hhZG93LWRvbS9s aW5rLWVsZW1lbnQtaW4tc2hhZG93LXRyZWUuaHRtbCBpcyBmbGFreQorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTcxNzg0CisgICAgICAgIDxyZGFyOi8v cHJvYmxlbS81ODEyMzU4ND4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICBUaGUgdGltZW91dCBpcyBsaWtlbHkgY2F1c2VkIGJ5IHRoZSBzdHlsZXNoZWV0 IG5vdCBsb2FkaW5nIHdpdGhpbiAxMDBtcyB0aW1lb3V0IGluIHRoZSB2ZXJ5IGZpcnN0IHRlc3Qg Y2FzZS4KKyAgICAgICAgTG9hZCBhbmQgY2FjaGUgdGhlIHN0eWxlc2hlIGJlZm9yZSBhbnkgdGVz dCBjYXNlcyBydW4gdG8gYXZvaWQgdGhpcyB0aW1lb3V0LgorCisgICAgICAgICogZmFzdC9zaGFk b3ctZG9tL2xpbmstZWxlbWVudC1pbi1zaGFkb3ctdHJlZS5odG1sOgorCiAyMDIwLTAxLTEzICBT aW1vbiBGcmFzZXIgIDxzaW1vbi5mcmFzZXJAYXBwbGUuY29tPgogCiAgICAgICAgIFJFR1JFU1NJ T04gKENhdGFsaW5hKSBub24tc2Nyb2xsaW5nIGlmcmFtZSBwcmV2ZW50cyBkb2N1bWVudCBzY3Jv bGxpbmcKSW5kZXg6IExheW91dFRlc3RzL2Zhc3Qvc2hhZG93LWRvbS9saW5rLWVsZW1lbnQtaW4t c2hhZG93LXRyZWUuaHRtbAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9mYXN0L3NoYWRvdy1k b20vbGluay1lbGVtZW50LWluLXNoYWRvdy10cmVlLmh0bWwJKHJldmlzaW9uIDI1NDQ3MikKKysr IExheW91dFRlc3RzL2Zhc3Qvc2hhZG93LWRvbS9saW5rLWVsZW1lbnQtaW4tc2hhZG93LXRyZWUu aHRtbAkod29ya2luZyBjb3B5KQpAQCAtMjEsMTIgKzIxLDI5IEBAIGZ1bmN0aW9uIHdhaXRfZm9y X29ubG9hZChlbGVtZW50LCBjYWxsYmEKIH0KIAogbGV0IHRlc3RfaWZyYW1lOwotZnVuY3Rpb24g Y3JlYXRlX2lmcmFtZSgpIHsKK2xldCBzdHlsZXNoZWV0X3JlYWR5ID0gbnVsbDsKK2FzeW5jIGZ1 bmN0aW9uIGNyZWF0ZV9pZnJhbWUoKSB7CisgICAgaWYgKCFzdHlsZXNoZWV0X3JlYWR5KSB7IC8v IENhY2hlIHRoZSBzdHlsZXNoZWV0IGZpcnN0IHRvIGF2b2lkIHRpbWVvdXQgaW4gdGhlIHZlcnkg Zmlyc3QgdGVzdCBjYXNlLgorICAgICAgICBzdHlsZXNoZWV0X3JlYWR5ID0gbmV3IFByb21pc2Uo KHJlc29sdmUpID0+IHsKKyAgICAgICAgICAgIGNvbnN0IGxpbmsgPSBkb2N1bWVudC5jcmVhdGVF bGVtZW50KCdsaW5rJyk7CisgICAgICAgICAgICBsaW5rLnJlbCA9ICdzdHlsZXNoZWV0JzsKKyAg ICAgICAgICAgIGxpbmsuaHJlZiA9ICdyZXNvdXJjZXMvZ3JlZW4taG9zdC5jc3MnOworICAgICAg ICAgICAgbGluay5hZGRFdmVudExpc3RlbmVyKCdsb2FkJywgKCkgPT4geworICAgICAgICAgICAg ICAgIGxpbmsucmVtb3ZlKCk7CisgICAgICAgICAgICAgICAgcmVzb2x2ZSgpOworICAgICAgICAg ICAgfSk7CisgICAgICAgICAgICBkb2N1bWVudC5ib2R5LmFwcGVuZENoaWxkKGxpbmspOworICAg ICAgICB9KTsKKyAgICB9CisgICAgYXdhaXQgY3JlYXRlX2lmcmFtZTsKKwogICAgIGlmICh0ZXN0 X2lmcmFtZSkKICAgICAgICAgdGVzdF9pZnJhbWUucmVtb3ZlKCk7CiAKICAgICB0ZXN0X2lmcmFt ZSA9IGRvY3VtZW50LmNyZWF0ZUVsZW1lbnQoJ2lmcmFtZScpOwotICAgIHJldHVybiB3YWl0X2Zv cl9vbmxvYWQoKS50aGVuKCgpID0+IHRlc3RfaWZyYW1lLmNvbnRlbnRXaW5kb3csICgpID0+IHsK KyAgICByZXR1cm4gc3R5bGVzaGVldF9yZWFkeS50aGVuKCgpID0+IHsKKyAgICAgICAgcmV0dXJu IHdhaXRfZm9yX29ubG9hZCgpOworICAgIH0pLnRoZW4oKCkgPT4gdGVzdF9pZnJhbWUuY29udGVu dFdpbmRvdywgKCkgPT4gewogICAgICAgICBkb2N1bWVudC5ib2R5LmFwcGVuZENoaWxkKHRlc3Rf aWZyYW1lKTsKICAgICB9KS50aGVuKGZ1bmN0aW9uICgpIHsKICAgICAgICAgY29uc3QgZG9jID0g dGVzdF9pZnJhbWUuY29udGVudFdpbmRvdy5kb2N1bWVudDsK