17178 2008-02-04 14:44:29 -0800 [curl] when using winsock, downloadTimerCallback bails 2008-02-10 11:03:24 -0800 1 1 1 Unclassified WebKit WebKit Misc. 528+ (Nightly build) PC Windows XP RESOLVED FIXED Curl, Wx P2 Normal --- 1 kevino webkit-unassigned oldest_to_newest 69395 0 kevino 2008-02-04 14:44:29 -0800 When building/running CURL with MSVC/winsock, we're seeing curl_multi_fdset return -1 for maxfd (which means there are no valid file descriptors), and this leads to an error when select() is called. That causes the download to bail out, meaning we can't even load pages. If we do not call select() in this case, all downloads start and complete successfully. Having this fixed is pretty critical for the wx port on Windows. Attached is a fix for the problem. 69396 1 18919 kevino 2008-02-04 14:45:12 -0800 Created attachment 18919 On Win, don't call select unless we have a valid file descriptor 69424 2 18919 mrowe 2008-02-04 20:09:09 -0800 Comment on attachment 18919 On Win, don't call select unless we have a valid file descriptor That doesn't look right as it makes it possible for rc to be tested before being initialized. Why does it make sense to call select on non-Windows platforms when there are no file descriptors? 69640 3 18978 kevino 2008-02-06 21:24:13 -0800 Created attachment 18978 Don't call select when there are no valid file descriptors on any platform Good point, I did some more testing and not calling select() seems to work fine on Unix platforms too, so I've taken out the #if PLATFORM(WIN_OS) and I've also initialized rc to 0 so that it won't be used uninitialized. 70070 4 18978 eric 2008-02-10 10:44:48 -0800 Comment on attachment 18978 Don't call select when there are no valid file descriptors on any platform Looks fine to me. 70081 5 kevino 2008-02-10 11:03:24 -0800 Landed in r30121. Thanks! 18919 2008-02-04 14:45:12 -0800 2008-02-06 21:24:13 -0800 On Win, don't call select unless we have a valid file descriptor curl-select.patch text/plain 1538 kevino SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiAyOTk3OSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTQgQEAKKzIwMDgtMDItMDQgIEtldmluIE9sbGl2aWVyICA8a2V2aW5vQHRoZW9s bGl2aWVycy5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgQ2FsbGluZyBzZWxlY3QoKSB3aGVuIGFsbCB0aGUgZmlsZSBkZXNjcmlwdG9ycyBhcmUg TlVMTAorICAgICAgICBzdG9wcyB0aGUgZmlsZSBkb3dubG9hZCBvbiBXaW5kb3dzLiBBcyBhIHJl c3VsdCwgZG8gbm90CisgICAgICAgIGNhbGwgc2VsZWN0KCkgd2hlbiB0aGVyZSBhcmUgbm8gdmFs aWQgZGVzY3JpcHRvcnMuIAorCisgICAgICAgICogcGxhdGZvcm0vbmV0d29yay9jdXJsL1Jlc291 cmNlSGFuZGxlTWFuYWdlci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpSZXNvdXJjZUhhbmRsZU1h bmFnZXI6OmRvd25sb2FkVGltZXJDYWxsYmFjayk6CisKIDIwMDgtMDItMDQgIEpvbiBIb25leWN1 dHQgIDxqaG9uZXljdXR0QGFwcGxlLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBEYXJpbi4K SW5kZXg6IFdlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9jdXJsL1Jlc291cmNlSGFuZGxlTWFuYWdl ci5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL2N1cmwvUmVzb3Vy Y2VIYW5kbGVNYW5hZ2VyLmNwcAkocmV2aXNpb24gMjk5NTcpCisrKyBXZWJDb3JlL3BsYXRmb3Jt L25ldHdvcmsvY3VybC9SZXNvdXJjZUhhbmRsZU1hbmFnZXIuY3BwCSh3b3JraW5nIGNvcHkpCkBA IC0yNzcsNiArMjc3LDEyIEBACiAgICAgICAgIEZEX1pFUk8oJmZkd3JpdGUpOwogICAgICAgICBG RF9aRVJPKCZmZGV4Y2VwKTsKICAgICAgICAgY3VybF9tdWx0aV9mZHNldChtX2N1cmxNdWx0aUhh bmRsZSwgJmZkcmVhZCwgJmZkd3JpdGUsICZmZGV4Y2VwLCAmbWF4ZmQpOworI2lmIFBMQVRGT1JN KFdJTl9PUykKKyAgICAgICAgLy8gV2hlbiB0aGUgMyBmaWxlIGRlc2NyaXB0b3JzIGFyZSBlbXB0 eSwgd2luc29jayB3aWxsIHJldHVybiAtMQorICAgICAgICAvLyBhbmQgYmFpbCBvdXQsIHN0b3Bw aW5nIHRoZSBmaWxlIGRvd25sb2FkLiBTbyBtYWtlIHN1cmUgd2UKKyAgICAgICAgLy8gaGF2ZSB2 YWxpZCBmaWxlIGRlc2NyaXB0b3JzIGJlZm9yZSBjYWxsaW5nIHNlbGVjdC4KKyAgICAgICAgaWYg KG1heGZkID49IDApCisjZW5kaWYKICAgICAgICAgcmMgPSA6OnNlbGVjdChtYXhmZCArIDEsICZm ZHJlYWQsICZmZHdyaXRlLCAmZmRleGNlcCwgJnRpbWVvdXQpOwogICAgIH0gd2hpbGUgKHJjID09 IC0xICYmIGVycm5vID09IEVJTlRSKTsKICAgICBzZXREZWZlcnJpbmdUaW1lcnMoZmFsc2UpOwo= 18978 2008-02-06 21:24:13 -0800 2008-02-10 10:44:48 -0800 Don't call select when there are no valid file descriptors on any platform curl-select2.patch text/plain 1876 kevino SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiAzMDA2MCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDUgKzEsMTYgQEAKIDIwMDgtMDItMDYgIEtldmluIE9sbGl2aWVyICA8a2V2aW5vQHRoZW9s bGl2aWVycy5jb20+CiAKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgQ2FsbGluZyBzZWxlY3QoKSB3aGVuIGFsbCB0aGUgZmlsZSBkZXNjcmlwdG9ycyBhcmUg TlVMTAorICAgICAgICBzdG9wcyB0aGUgZmlsZSBkb3dubG9hZCBvbiBXaW5kb3dzLiBBcyBhIHJl c3VsdCwgZG8gbm90CisgICAgICAgIGNhbGwgc2VsZWN0KCkgd2hlbiB0aGVyZSBhcmUgbm8gdmFs aWQgZGVzY3JpcHRvcnMuIAorCisgICAgICAgICogcGxhdGZvcm0vbmV0d29yay9jdXJsL1Jlc291 cmNlSGFuZGxlTWFuYWdlci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpSZXNvdXJjZUhhbmRsZU1h bmFnZXI6OmRvd25sb2FkVGltZXJDYWxsYmFjayk6CisKKzIwMDgtMDItMDYgIEtldmluIE9sbGl2 aWVyICA8a2V2aW5vQHRoZW9sbGl2aWVycy5jb20+CisKICAgICAgICAgUmV2aWV3ZWQgYnkgRGFy aW4gQWRsZXIuCiAKICAgICAgICAgUmF0aGVyIHRoYW4gZGlyZWN0bHkgaGFuZGluZyBzY3JvbGwg d2hlZWwgZXZlbnRzLCB1c2UKSW5kZXg6IFdlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9jdXJsL1Jl c291cmNlSGFuZGxlTWFuYWdlci5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9wbGF0Zm9ybS9u ZXR3b3JrL2N1cmwvUmVzb3VyY2VIYW5kbGVNYW5hZ2VyLmNwcAkocmV2aXNpb24gMzAwNjApCisr KyBXZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvY3VybC9SZXNvdXJjZUhhbmRsZU1hbmFnZXIuY3Bw CSh3b3JraW5nIGNvcHkpCkBAIC0yNzEsMTMgKzI3MSwxNyBAQAogCiAgICAgLy8gVGVtcG9yYXJp bHkgZGlzYWJsZSB0aW1lcnMgc2luY2Ugc2lnbmFscyBtYXkgaW50ZXJydXB0IHNlbGVjdCgpLCBy YWlzaW5nIEVJTlRSIGVycm9ycyBvbiBzb21lIHBsYXRmb3JtcwogICAgIHNldERlZmVycmluZ1Rp bWVycyh0cnVlKTsKLSAgICBpbnQgcmM7CisgICAgaW50IHJjID0gMDsKICAgICBkbyB7CiAgICAg ICAgIEZEX1pFUk8oJmZkcmVhZCk7CiAgICAgICAgIEZEX1pFUk8oJmZkd3JpdGUpOwogICAgICAg ICBGRF9aRVJPKCZmZGV4Y2VwKTsKICAgICAgICAgY3VybF9tdWx0aV9mZHNldChtX2N1cmxNdWx0 aUhhbmRsZSwgJmZkcmVhZCwgJmZkd3JpdGUsICZmZGV4Y2VwLCAmbWF4ZmQpOwotICAgICAgICBy YyA9IDo6c2VsZWN0KG1heGZkICsgMSwgJmZkcmVhZCwgJmZkd3JpdGUsICZmZGV4Y2VwLCAmdGlt ZW91dCk7CisgICAgICAgIC8vIFdoZW4gdGhlIDMgZmlsZSBkZXNjcmlwdG9ycyBhcmUgZW1wdHks IHdpbnNvY2sgd2lsbCByZXR1cm4gLTEKKyAgICAgICAgLy8gYW5kIGJhaWwgb3V0LCBzdG9wcGlu ZyB0aGUgZmlsZSBkb3dubG9hZC4gU28gbWFrZSBzdXJlIHdlCisgICAgICAgIC8vIGhhdmUgdmFs aWQgZmlsZSBkZXNjcmlwdG9ycyBiZWZvcmUgY2FsbGluZyBzZWxlY3QuCisgICAgICAgIGlmICht YXhmZCA+PSAwKQorICAgICAgICAgICAgcmMgPSA6OnNlbGVjdChtYXhmZCArIDEsICZmZHJlYWQs ICZmZHdyaXRlLCAmZmRleGNlcCwgJnRpbWVvdXQpOwogICAgIH0gd2hpbGUgKHJjID09IC0xICYm IGVycm5vID09IEVJTlRSKTsKICAgICBzZXREZWZlcnJpbmdUaW1lcnMoZmFsc2UpOwogCg==