17175 2008-02-04 08:26:02 -0800 Use of C++ compiler flags in CFLAGS 2008-02-04 19:28:13 -0800 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) PC All RESOLVED FIXED P2 Normal --- 1 dobey webkit-unassigned mrowe oldest_to_newest 69350 0 dobey 2008-02-04 08:26:02 -0800 Currently, the autotools build adds -fno-rtti and -fvisibility-inlines-hidden to CFLAGS, but they are only valid for C++ as gcc warns during the build. We also need to add -I$(srcdir)/WebCore to the global_cppflags so that the proper config.h gets found by code under WebCore. The attached patch fixes these issues. 69351 1 18908 dobey 2008-02-04 08:27:09 -0800 Created attachment 18908 Patch to resolve CFLAGS vs. CXXFLAGS issues 69352 2 18908 dobey 2008-02-04 08:42:29 -0800 Comment on attachment 18908 Patch to resolve CFLAGS vs. CXXFLAGS issues Doh. Was just pointed out that global_cppflags is for CPPFLAGS not CXXFLAGS, and the content of global_cppflags confused me. 69353 3 18908 alp 2008-02-04 08:43:49 -0800 Comment on attachment 18908 Patch to resolve CFLAGS vs. CXXFLAGS issues >Index: ChangeLog >=================================================================== >--- ChangeLog (revision 29961) >+++ ChangeLog (working copy) >@@ -1,3 +1,13 @@ >+2008-02-04 Rodney Dawes <dobey@wayofthemonkey.com> >+ >+ Reviewed by NOBODY (OOPS!!) >+ >+ Only use -fno-rtti and $(SYMBOL_VISIBILITY_INLINES) with >+ global_cppflags as gcc complains they aren't valid for C >+ Add -I$(srcdir)/WebCore to global_cppflags to get the right config.h >+ >+ * GNUmakefile.am: >+ > 2008-02-04 Alp Toker <alp@atoker.com> > > Rubber-stamped by Mark Rowe. >Index: GNUmakefile.am >=================================================================== >--- GNUmakefile.am (revision 29961) >+++ GNUmakefile.am (working copy) >@@ -47,9 +47,11 @@ EXTRA_DIST := > > # > # Global flags to CPP >-global_cppflags := >+global_cppflags := \ >+ $(SYMBOL_VISIBILITY_INLINES) cppflags is for preprocessor options, not C++ flags. This won't help. Better solution is to clean up the flags and layout of the build modules. 69354 4 18909 dobey 2008-02-04 08:55:05 -0800 Created attachment 18909 Updated patch that adds and uses global_cxxflags 69355 5 18909 alp 2008-02-04 09:01:08 -0800 Comment on attachment 18909 Updated patch that adds and uses global_cxxflags >Index: JavaScriptCore/GNUmakefile.am >=================================================================== >--- JavaScriptCore/GNUmakefile.am (revision 29961) >+++ JavaScriptCore/GNUmakefile.am (working copy) >@@ -149,14 +149,14 @@ Programs_minidom_SOURCES = \ > JavaScriptCore/API/NodeList.c \ > JavaScriptCore/API/minidom.c > Programs_minidom_CPPFLAGS = $(global_cppflags) >-Programs_minidom_CXXFLAGS = $(global_cflags) >+Programs_minidom_CXXFLAGS = $(globacl_cxxflags) $(global_cflags) Typo. Please test before requesting review. 69358 6 18910 dobey 2008-02-04 09:07:18 -0800 Created attachment 18910 Fix typo 69418 7 18910 alp 2008-02-04 18:06:39 -0800 Comment on attachment 18910 Fix typo Looks good 69419 8 18910 mrowe 2008-02-04 18:08:57 -0800 Comment on attachment 18910 Fix typo It seems that this patch will cause JavaScriptCore to use WebCore's config.h. Why is that any better than WebCore using JavaScriptCore's config.h? 69420 9 18910 alp 2008-02-04 18:11:34 -0800 Comment on attachment 18910 Fix typo Clearing r+, I missed the -I addition which doesn't look right. 69421 10 mrowe 2008-02-04 18:26:55 -0800 The -IWebCore and -I JavaScriptCore's in global_cppflags look incorrect. There are no headers in the top-level JavaScriptCore folder, and JavaScriptCore should definitely not be looking for any headers inside WebCore. If there's an issue there that needs fixed it should be addressed separately. A patch without that change would be great to get landed. 69422 11 mrowe 2008-02-04 19:28:13 -0800 I landed the relevant portion of this in r29986. 18908 2008-02-04 08:27:09 -0800 2008-02-04 08:55:05 -0800 Patch to resolve CFLAGS vs. CXXFLAGS issues webkit-cxxflags.patch text/plain 1471 dobey SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDaGFuZ2VMb2cJKHJldmlzaW9uIDI5OTYx KQorKysgQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTMgQEAKKzIwMDgtMDIt MDQgIFJvZG5leSBEYXdlcyAgPGRvYmV5QHdheW9mdGhlbW9ua2V5LmNvbT4KKworCVJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEhKQorCisJT25seSB1c2UgLWZuby1ydHRpIGFuZCAkKFNZTUJPTF9W SVNJQklMSVRZX0lOTElORVMpIHdpdGgKKwlnbG9iYWxfY3BwZmxhZ3MJYXMgZ2NjIGNvbXBsYWlu cyB0aGV5IGFyZW4ndCB2YWxpZCBmb3IgQworCUFkZCAtSSQoc3JjZGlyKS9XZWJDb3JlIHRvIGds b2JhbF9jcHBmbGFncyB0byBnZXQgdGhlIHJpZ2h0IGNvbmZpZy5oCisKKwkqIEdOVW1ha2VmaWxl LmFtOgorCiAyMDA4LTAyLTA0ICBBbHAgVG9rZXIgIDxhbHBAYXRva2VyLmNvbT4KIAogICAgICAg ICBSdWJiZXItc3RhbXBlZCBieSBNYXJrIFJvd2UuCkluZGV4OiBHTlVtYWtlZmlsZS5hbQo9PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09Ci0tLSBHTlVtYWtlZmlsZS5hbQkocmV2aXNpb24gMjk5NjEpCisrKyBHTlVtYWtlZmls ZS5hbQkod29ya2luZyBjb3B5KQpAQCAtNDcsOSArNDcsMTEgQEAgRVhUUkFfRElTVCA6PQogCiAj CiAjIEdsb2JhbCBmbGFncyB0byBDUFAKLWdsb2JhbF9jcHBmbGFncyA6PQorZ2xvYmFsX2NwcGZs YWdzIDo9IFwKKwkkKFNZTUJPTF9WSVNJQklMSVRZX0lOTElORVMpCiAKIGdsb2JhbF9jcHBmbGFn cyArPSBcCisJLUkkKHNyY2RpcikvV2ViQ29yZSBcCiAJLUkkKHNyY2RpcikvSmF2YVNjcmlwdENv cmUgXAogCS1JJChzcmNkaXIpL0phdmFTY3JpcHRDb3JlL0ZvcndhcmRpbmdIZWFkZXJzIFwKIAkt SSQoc3JjZGlyKS9KYXZhU2NyaXB0Q29yZS93dGYgXApAQCAtNjEsMTIgKzYzLDE1IEBAIGdsb2Jh bF9jZmxhZ3MgOj0gXAogCS1XYWxsIC1XIC1XY2FzdC1hbGlnbiAtV2NoYXItc3Vic2NyaXB0cyAt V3JldHVybi10eXBlIFwKIAktV2Zvcm1hdCAtV2Zvcm1hdC1zZWN1cml0eSAtV25vLWZvcm1hdC15 MmsgLVd1bmRlZiBcCiAJLVdtaXNzaW5nLWZvcm1hdC1hdHRyaWJ1dGUgLVdwb2ludGVyLWFyaXRo IC1Xd3JpdGUtc3RyaW5ncyBcCi0JLVduby11bnVzZWQtcGFyYW1ldGVyICQoU1lNQk9MX1ZJU0lC SUxJVFlfSU5MSU5FUykKKwktV25vLXVudXNlZC1wYXJhbWV0ZXIKIAogaWYgIUVOQUJMRV9ERUJV RwogZ2xvYmFsX2NmbGFncyArPSBcCi0JLWZuby1ydHRpIC1mbm8tZXhjZXB0aW9ucyBcCisJLWZu by1leGNlcHRpb25zIFwKIAkkKFNZTUJPTF9WSVNJQklMSVRZKQorCitnbG9iYWxfY3BwZmxhZ3Mg Kz0gXAorCS1mbm8tcnR0aQogZW5kaWYKIAogIyBTaGFyZWQgbGlicmFyaWVzCg== 18909 2008-02-04 08:55:05 -0800 2008-02-04 09:07:18 -0800 Updated patch that adds and uses global_cxxflags webkit-cxxflags.patch text/plain 5273 dobey SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDaGFuZ2VMb2cJKHJldmlzaW9uIDI5OTYx KQorKysgQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTQgQEAKKzIwMDgtMDIt MDQgIFJvZG5leSBEYXdlcyAgPGRvYmV5QHdheW9mdGhlbW9ua2V5LmNvbT4KKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhISkKKworICAgICAgICBBZGQgZ2xvYmFsX2N4eGZsYWdz IGRlZmluaXRpb24gZm9yIGluY2x1c2lvbiBpbiBDWFhGTEFHUyB2YXJpYWJsZXMKKyAgICAgICAg T25seSB1c2UgLWZuby1ydHRpIGFuZCAkKFNZTUJPTF9WSVNJQklMSVRZX0lOTElORVMpIHdpdGgK KyAgICAgICAgZ2xvYmFsX2N4eGZsYWdzICAgICAgICBhcyBnY2MgY29tcGxhaW5zIHRoZXkgYXJl bid0IHZhbGlkIGZvciBDCisgICAgICAgIEFkZCAtSSQoc3JjZGlyKS9XZWJDb3JlIHRvIGdsb2Jh bF9jcHBmbGFncyB0byBnZXQgdGhlIHJpZ2h0IGNvbmZpZy5oCisKKyAgICAgICAgKiBHTlVtYWtl ZmlsZS5hbToKKwogMjAwOC0wMi0wNCAgQWxwIFRva2VyICA8YWxwQGF0b2tlci5jb20+CiAKICAg ICAgICAgUnViYmVyLXN0YW1wZWQgYnkgTWFyayBSb3dlLgpJbmRleDogR05VbWFrZWZpbGUuYW0K PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PQotLS0gR05VbWFrZWZpbGUuYW0JKHJldmlzaW9uIDI5OTYxKQorKysgR05VbWFr ZWZpbGUuYW0JKHdvcmtpbmcgY29weSkKQEAgLTIxLDggKzIxLDEwIEBACiAjCiAjIGdsb2JhbF9j cHBmbGFncyAgID0gQ1BQRkxBR1MgdGhhdCBhcHBseSB0byBKU0MsIFdlYkNvcmUsIGFuZCB0byBh bnkKICMgICAgICAgICAgICAgICAgICAgICBzcGVjaWZpYyBwb3J0Ci0jIGdsb2JhbF9jZmxhZ3Mg ICAgID0gQ0ZMQUdTIGFuZCBDWFhGTEFHUyB0aGF0IGFwcGx5IHRvIEpTQywgV2ViQ29yZSwgYW5k IHRvCisjIGdsb2JhbF9jZmxhZ3MgICAgID0gQ0ZMQUdTIHRoYXQgYXBwbHkgdG8gSlNDLCBXZWJD b3JlLCBhbmQgdG8KICMgICAgICAgICAgICAgICAgICAgICBhbnkgc3BlY2lmaWMgcG9ydAorIyBn bG9iYWxfY3h4ZmxhZ3MgICA9IENYWEZMQUdTIHRoYXQgYXBwbHkgdG8gSlNDLCBXZWJDb3JlLCBh bmQgdG8gYW55CisjICAgICAgICAgICAgICAgICAgICAgc3BlY2lmaWMgcG9ydAogCiBzcmNkaXIg PSBAc3JjZGlyQAogVlBBVEggPSBAc3JjZGlyQApAQCAtNTAsNiArNTIsNyBAQCBFWFRSQV9ESVNU IDo9CiBnbG9iYWxfY3BwZmxhZ3MgOj0KIAogZ2xvYmFsX2NwcGZsYWdzICs9IFwKKwktSSQoc3Jj ZGlyKS9XZWJDb3JlIFwKIAktSSQoc3JjZGlyKS9KYXZhU2NyaXB0Q29yZSBcCiAJLUkkKHNyY2Rp cikvSmF2YVNjcmlwdENvcmUvRm9yd2FyZGluZ0hlYWRlcnMgXAogCS1JJChzcmNkaXIpL0phdmFT Y3JpcHRDb3JlL3d0ZiBcCkBAIC02MSwxMiArNjQsMTggQEAgZ2xvYmFsX2NmbGFncyA6PSBcCiAJ LVdhbGwgLVcgLVdjYXN0LWFsaWduIC1XY2hhci1zdWJzY3JpcHRzIC1XcmV0dXJuLXR5cGUgXAog CS1XZm9ybWF0IC1XZm9ybWF0LXNlY3VyaXR5IC1Xbm8tZm9ybWF0LXkyayAtV3VuZGVmIFwKIAkt V21pc3NpbmctZm9ybWF0LWF0dHJpYnV0ZSAtV3BvaW50ZXItYXJpdGggLVd3cml0ZS1zdHJpbmdz IFwKLQktV25vLXVudXNlZC1wYXJhbWV0ZXIgJChTWU1CT0xfVklTSUJJTElUWV9JTkxJTkVTKQor CS1Xbm8tdW51c2VkLXBhcmFtZXRlcgorCitnbG9iYWxfY3h4ZmxhZ3MgOj0gXAorCSQoU1lNQk9M X1ZJU0lCSUxJVFlfSU5MSU5FUykKIAogaWYgIUVOQUJMRV9ERUJVRwogZ2xvYmFsX2NmbGFncyAr PSBcCi0JLWZuby1ydHRpIC1mbm8tZXhjZXB0aW9ucyBcCisJLWZuby1leGNlcHRpb25zIFwKIAkk KFNZTUJPTF9WSVNJQklMSVRZKQorCitnbG9iYWxfY3h4ZmxhZ3MgKz0gXAorCS1mbm8tcnR0aQog ZW5kaWYKIAogIyBTaGFyZWQgbGlicmFyaWVzCkBAIC05Niw3ICsxMDUsNyBAQCBsaWJKYXZhU2Ny aXB0Q29yZV9sYV9TT1VSQ0VTID0gXAogCiBsaWJKYXZhU2NyaXB0Q29yZV9sYV9MREZMQUdTID0g JChJQ1VfTElCUykgLWxwdGhyZWFkCiAKLWxpYkphdmFTY3JpcHRDb3JlX2xhX0NYWEZMQUdTID0g JChnbG9iYWxfY2ZsYWdzKSAtZnN0cmljdC1hbGlhc2luZworbGliSmF2YVNjcmlwdENvcmVfbGFf Q1hYRkxBR1MgPSAkKGdsb2JhbF9jeHhmbGFncykgJChnbG9iYWxfY2ZsYWdzKSAtZnN0cmljdC1h bGlhc2luZwogCiBsaWJKYXZhU2NyaXB0Q29yZV9sYV9DRkxBR1MgPSAkKGdsb2JhbF9jZmxhZ3Mp IC1mc3RyaWN0LWFsaWFzaW5nCiAKQEAgLTEzOSw2ICsxNDgsNyBAQCBsaWJXZWJLaXRHdGtfbGFf U09VUkNFUyA9IFwKIAogbGliV2ViS2l0R3RrX2xhX0NYWEZMQUdTID0gXAogCS1mbm8tc3RyaWN0 LWFsaWFzaW5nIFwKKwkkKGdsb2JhbF9jeHhmbGFncykgXAogCSQoZ2xvYmFsX2NmbGFncykgXAog CSQoREVQRU5ERU5DSUVTX0NGTEFHUykgXAogCSQoTElCQ1VSTF9DRkxBR1MpIFwKSW5kZXg6IEph dmFTY3JpcHRDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBKYXZhU2NyaXB0Q29yZS9DaGFu Z2VMb2cJKHJldmlzaW9uIDI5OTYxKQorKysgSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCSh3b3Jr aW5nIGNvcHkpCkBAIC0xLDMgKzEsMTEgQEAKKzIwMDgtMDItMDQgIFJvZG5leSBEYXdlcyAgPGRv YmV5QHdheW9mdGhlbW9ua2V5LmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhISkKKworICAgICAgICBVc2UgZ2xvYmFsX2N4eGZsYWdzIGFzIHdlbGwgYXMgZ2xvYmFsX2Nm bGFncyBpbiBDWFhGTEFHUworCisgICAgICAgICogR05VbWFrZWZpbGUuYW06CisKIDIwMDgtMDIt MDQgIEFscCBUb2tlciAgPGFscEBhdG9rZXIuY29tPgogCiAgICAgICAgIFJ1YmJlci1zdGFtcGVk IGJ5IE1hcmsgUm93ZS4KQEAgLTE3LDcgKzI1LDcgQEAKICAgICAgICAgR2VvZmYncyB0aGVvcnkg aXMgdGhhdCB0aGUgc2xvd2Rvd24gd2FzIGR1ZSB0byBjb3B5aW5nIGhhc2ggdGFibGVzIHdoZW4K ICAgICAgICAgcHV0dGluZyB0aGluZ3MgaW50byB0aGUgYmFjay9mb3J3YXJkIGNhY2hlLiBJZiB0 aGF0J3MgdHJ1ZSwgdGhlbiB0aGlzCiAgICAgICAgIHNob3VsZCBmaXggdGhlIHByb2JsZW0uCi0g ICAgICAgIAorCiAgICAgICAgIChBY2NvcmRpbmcgdG8gR2VvZmYncyBtZWFzdXJlbWVudHMsIGlu IGEgUExUIHRoYXQgZXhhZ2dlcmF0ZXMgdGhlCiAgICAgICAgIGltcG9ydGFuY2Ugb2Ygc3ltYm9s IHRhYmxlIHNhdmluZyBkdXJpbmcgY2FjaGVkIHBhZ2UgY3JlYXRpb24sIHRoaXMKICAgICAgICAg cGF0Y2ggaXMgYSB+M1ggc3BlZWR1cCBpbiBjYWNoZWQgcGFnZSBjcmVhdGlvbiwgYW5kIGEgOSUg c3BlZWR1cCBvdmVyYWxsLikKSW5kZXg6IEphdmFTY3JpcHRDb3JlL0dOVW1ha2VmaWxlLmFtCj09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT0KLS0tIEphdmFTY3JpcHRDb3JlL0dOVW1ha2VmaWxlLmFtCShyZXZpc2lvbiAyOTk2 MSkKKysrIEphdmFTY3JpcHRDb3JlL0dOVW1ha2VmaWxlLmFtCSh3b3JraW5nIGNvcHkpCkBAIC0x NDksMTQgKzE0OSwxNCBAQCBQcm9ncmFtc19taW5pZG9tX1NPVVJDRVMgPSBcCiAJSmF2YVNjcmlw dENvcmUvQVBJL05vZGVMaXN0LmMgXAogCUphdmFTY3JpcHRDb3JlL0FQSS9taW5pZG9tLmMKIFBy b2dyYW1zX21pbmlkb21fQ1BQRkxBR1MgPSAkKGdsb2JhbF9jcHBmbGFncykKLVByb2dyYW1zX21p bmlkb21fQ1hYRkxBR1MgPSAkKGdsb2JhbF9jZmxhZ3MpCitQcm9ncmFtc19taW5pZG9tX0NYWEZM QUdTID0gJChnbG9iYWNsX2N4eGZsYWdzKSAkKGdsb2JhbF9jZmxhZ3MpCiBQcm9ncmFtc19taW5p ZG9tX0xEQUREID0gbGliSmF2YVNjcmlwdENvcmUubGEKIFByb2dyYW1zX21pbmlkb21fTERGTEFH UyA9IC1ycGF0aCAkKENVUkRJUikvLmxpYnMKIAogIyB0ZXN0a2pzCiBQcm9ncmFtc190ZXN0a2pz X1NPVVJDRVMgPSBKYXZhU2NyaXB0Q29yZS9ranMvdGVzdGtqcy5jcHAKIFByb2dyYW1zX3Rlc3Rr anNfQ1BQRkxBR1MgPSAkKGdsb2JhbF9jcHBmbGFncykKLVByb2dyYW1zX3Rlc3RranNfQ1hYRkxB R1MgPSAkKGdsb2JhbF9jZmxhZ3MpCitQcm9ncmFtc190ZXN0a2pzX0NYWEZMQUdTID0gJChnbG9i YWNsX2N4eGZsYWdzKSAkKGdsb2JhbF9jZmxhZ3MpCiBQcm9ncmFtc190ZXN0a2pzX0xEQUREID0g bGliSmF2YVNjcmlwdENvcmUubGEKIFByb2dyYW1zX3Rlc3RranNfTERGTEFHUyA9IC1ycGF0aCAk KENVUkRJUikvLmxpYnMKIApJbmRleDogV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCj09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0K LS0tIFdlYktpdFRvb2xzL0NoYW5nZUxvZwkocmV2aXNpb24gMjk5NjEpCisrKyBXZWJLaXRUb29s cy9DaGFuZ2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwxMSBAQAorMjAwOC0wMi0wNCAg Um9kbmV5IERhd2VzICA8ZG9iZXlAd2F5b2Z0aGVtb25rZXkuY29tPgorCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEhKQorCisgICAgICAgIFVzZSBnbG9iYWxfY3h4ZmxhZ3MgYXMg d2VsbCBhcyBnbG9iYWxfY2ZsYWdzIGluIENYWEZMQUdTCisKKyAgICAgICAgKiBHTlVtYWtlZmls ZS5hbToKKwogMjAwOC0wMi0wNCAgQWxwIFRva2VyICA8YWxwQGF0b2tlci5jb20+CiAKICAgICAg ICAgUnViYmVyLXN0YW1wZWQgYnkgTWFyayBSb3dlLgpJbmRleDogV2ViS2l0VG9vbHMvR05VbWFr ZWZpbGUuYW0KPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0VG9vbHMvR05VbWFrZWZpbGUuYW0JKHJldmlz aW9uIDI5OTYxKQorKysgV2ViS2l0VG9vbHMvR05VbWFrZWZpbGUuYW0JKHdvcmtpbmcgY29weSkK QEAgLTM5LDYgKzM5LDcgQEAgUHJvZ3JhbXNfRHVtcFJlbmRlclRyZWVfU09VUkNFUyA9IFwKIAog UHJvZ3JhbXNfRHVtcFJlbmRlclRyZWVfQ1hYRkxBR1MgPSBcCiAJJChERVBFTkRFTkNJRVNfQ0ZM QUdTKSBcCisJJChnbG9iYWxfY3h4ZmxhZ3MpIFwKIAkkKGdsb2JhbF9jZmxhZ3MpCiAKIFByb2dy YW1zX0R1bXBSZW5kZXJUcmVlX0xEQUREID0gXAo= 18910 2008-02-04 09:07:18 -0800 2008-02-04 18:22:59 -0800 Fix typo webkit-cxxflags.patch text/plain 5271 dobey SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDaGFuZ2VMb2cJKHJldmlzaW9uIDI5OTYx KQorKysgQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTQgQEAKKzIwMDgtMDIt MDQgIFJvZG5leSBEYXdlcyAgPGRvYmV5QHdheW9mdGhlbW9ua2V5LmNvbT4KKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhISkKKworICAgICAgICBBZGQgZ2xvYmFsX2N4eGZsYWdz IGRlZmluaXRpb24gZm9yIGluY2x1c2lvbiBpbiBDWFhGTEFHUyB2YXJpYWJsZXMKKyAgICAgICAg T25seSB1c2UgLWZuby1ydHRpIGFuZCAkKFNZTUJPTF9WSVNJQklMSVRZX0lOTElORVMpIHdpdGgK KyAgICAgICAgZ2xvYmFsX2N4eGZsYWdzICAgICAgICBhcyBnY2MgY29tcGxhaW5zIHRoZXkgYXJl bid0IHZhbGlkIGZvciBDCisgICAgICAgIEFkZCAtSSQoc3JjZGlyKS9XZWJDb3JlIHRvIGdsb2Jh bF9jcHBmbGFncyB0byBnZXQgdGhlIHJpZ2h0IGNvbmZpZy5oCisKKyAgICAgICAgKiBHTlVtYWtl ZmlsZS5hbToKKwogMjAwOC0wMi0wNCAgQWxwIFRva2VyICA8YWxwQGF0b2tlci5jb20+CiAKICAg ICAgICAgUnViYmVyLXN0YW1wZWQgYnkgTWFyayBSb3dlLgpJbmRleDogR05VbWFrZWZpbGUuYW0K PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PQotLS0gR05VbWFrZWZpbGUuYW0JKHJldmlzaW9uIDI5OTYxKQorKysgR05VbWFr ZWZpbGUuYW0JKHdvcmtpbmcgY29weSkKQEAgLTIxLDggKzIxLDEwIEBACiAjCiAjIGdsb2JhbF9j cHBmbGFncyAgID0gQ1BQRkxBR1MgdGhhdCBhcHBseSB0byBKU0MsIFdlYkNvcmUsIGFuZCB0byBh bnkKICMgICAgICAgICAgICAgICAgICAgICBzcGVjaWZpYyBwb3J0Ci0jIGdsb2JhbF9jZmxhZ3Mg ICAgID0gQ0ZMQUdTIGFuZCBDWFhGTEFHUyB0aGF0IGFwcGx5IHRvIEpTQywgV2ViQ29yZSwgYW5k IHRvCisjIGdsb2JhbF9jZmxhZ3MgICAgID0gQ0ZMQUdTIHRoYXQgYXBwbHkgdG8gSlNDLCBXZWJD b3JlLCBhbmQgdG8KICMgICAgICAgICAgICAgICAgICAgICBhbnkgc3BlY2lmaWMgcG9ydAorIyBn bG9iYWxfY3h4ZmxhZ3MgICA9IENYWEZMQUdTIHRoYXQgYXBwbHkgdG8gSlNDLCBXZWJDb3JlLCBh bmQgdG8gYW55CisjICAgICAgICAgICAgICAgICAgICAgc3BlY2lmaWMgcG9ydAogCiBzcmNkaXIg PSBAc3JjZGlyQAogVlBBVEggPSBAc3JjZGlyQApAQCAtNTAsNiArNTIsNyBAQCBFWFRSQV9ESVNU IDo9CiBnbG9iYWxfY3BwZmxhZ3MgOj0KIAogZ2xvYmFsX2NwcGZsYWdzICs9IFwKKwktSSQoc3Jj ZGlyKS9XZWJDb3JlIFwKIAktSSQoc3JjZGlyKS9KYXZhU2NyaXB0Q29yZSBcCiAJLUkkKHNyY2Rp cikvSmF2YVNjcmlwdENvcmUvRm9yd2FyZGluZ0hlYWRlcnMgXAogCS1JJChzcmNkaXIpL0phdmFT Y3JpcHRDb3JlL3d0ZiBcCkBAIC02MSwxMiArNjQsMTggQEAgZ2xvYmFsX2NmbGFncyA6PSBcCiAJ LVdhbGwgLVcgLVdjYXN0LWFsaWduIC1XY2hhci1zdWJzY3JpcHRzIC1XcmV0dXJuLXR5cGUgXAog CS1XZm9ybWF0IC1XZm9ybWF0LXNlY3VyaXR5IC1Xbm8tZm9ybWF0LXkyayAtV3VuZGVmIFwKIAkt V21pc3NpbmctZm9ybWF0LWF0dHJpYnV0ZSAtV3BvaW50ZXItYXJpdGggLVd3cml0ZS1zdHJpbmdz IFwKLQktV25vLXVudXNlZC1wYXJhbWV0ZXIgJChTWU1CT0xfVklTSUJJTElUWV9JTkxJTkVTKQor CS1Xbm8tdW51c2VkLXBhcmFtZXRlcgorCitnbG9iYWxfY3h4ZmxhZ3MgOj0gXAorCSQoU1lNQk9M X1ZJU0lCSUxJVFlfSU5MSU5FUykKIAogaWYgIUVOQUJMRV9ERUJVRwogZ2xvYmFsX2NmbGFncyAr PSBcCi0JLWZuby1ydHRpIC1mbm8tZXhjZXB0aW9ucyBcCisJLWZuby1leGNlcHRpb25zIFwKIAkk KFNZTUJPTF9WSVNJQklMSVRZKQorCitnbG9iYWxfY3h4ZmxhZ3MgKz0gXAorCS1mbm8tcnR0aQog ZW5kaWYKIAogIyBTaGFyZWQgbGlicmFyaWVzCkBAIC05Niw3ICsxMDUsNyBAQCBsaWJKYXZhU2Ny aXB0Q29yZV9sYV9TT1VSQ0VTID0gXAogCiBsaWJKYXZhU2NyaXB0Q29yZV9sYV9MREZMQUdTID0g JChJQ1VfTElCUykgLWxwdGhyZWFkCiAKLWxpYkphdmFTY3JpcHRDb3JlX2xhX0NYWEZMQUdTID0g JChnbG9iYWxfY2ZsYWdzKSAtZnN0cmljdC1hbGlhc2luZworbGliSmF2YVNjcmlwdENvcmVfbGFf Q1hYRkxBR1MgPSAkKGdsb2JhbF9jeHhmbGFncykgJChnbG9iYWxfY2ZsYWdzKSAtZnN0cmljdC1h bGlhc2luZwogCiBsaWJKYXZhU2NyaXB0Q29yZV9sYV9DRkxBR1MgPSAkKGdsb2JhbF9jZmxhZ3Mp IC1mc3RyaWN0LWFsaWFzaW5nCiAKQEAgLTEzOSw2ICsxNDgsNyBAQCBsaWJXZWJLaXRHdGtfbGFf U09VUkNFUyA9IFwKIAogbGliV2ViS2l0R3RrX2xhX0NYWEZMQUdTID0gXAogCS1mbm8tc3RyaWN0 LWFsaWFzaW5nIFwKKwkkKGdsb2JhbF9jeHhmbGFncykgXAogCSQoZ2xvYmFsX2NmbGFncykgXAog CSQoREVQRU5ERU5DSUVTX0NGTEFHUykgXAogCSQoTElCQ1VSTF9DRkxBR1MpIFwKSW5kZXg6IEph dmFTY3JpcHRDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBKYXZhU2NyaXB0Q29yZS9DaGFu Z2VMb2cJKHJldmlzaW9uIDI5OTYxKQorKysgSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCSh3b3Jr aW5nIGNvcHkpCkBAIC0xLDMgKzEsMTEgQEAKKzIwMDgtMDItMDQgIFJvZG5leSBEYXdlcyAgPGRv YmV5QHdheW9mdGhlbW9ua2V5LmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhISkKKworICAgICAgICBVc2UgZ2xvYmFsX2N4eGZsYWdzIGFzIHdlbGwgYXMgZ2xvYmFsX2Nm bGFncyBpbiBDWFhGTEFHUworCisgICAgICAgICogR05VbWFrZWZpbGUuYW06CisKIDIwMDgtMDIt MDQgIEFscCBUb2tlciAgPGFscEBhdG9rZXIuY29tPgogCiAgICAgICAgIFJ1YmJlci1zdGFtcGVk IGJ5IE1hcmsgUm93ZS4KQEAgLTE3LDcgKzI1LDcgQEAKICAgICAgICAgR2VvZmYncyB0aGVvcnkg aXMgdGhhdCB0aGUgc2xvd2Rvd24gd2FzIGR1ZSB0byBjb3B5aW5nIGhhc2ggdGFibGVzIHdoZW4K ICAgICAgICAgcHV0dGluZyB0aGluZ3MgaW50byB0aGUgYmFjay9mb3J3YXJkIGNhY2hlLiBJZiB0 aGF0J3MgdHJ1ZSwgdGhlbiB0aGlzCiAgICAgICAgIHNob3VsZCBmaXggdGhlIHByb2JsZW0uCi0g ICAgICAgIAorCiAgICAgICAgIChBY2NvcmRpbmcgdG8gR2VvZmYncyBtZWFzdXJlbWVudHMsIGlu IGEgUExUIHRoYXQgZXhhZ2dlcmF0ZXMgdGhlCiAgICAgICAgIGltcG9ydGFuY2Ugb2Ygc3ltYm9s IHRhYmxlIHNhdmluZyBkdXJpbmcgY2FjaGVkIHBhZ2UgY3JlYXRpb24sIHRoaXMKICAgICAgICAg cGF0Y2ggaXMgYSB+M1ggc3BlZWR1cCBpbiBjYWNoZWQgcGFnZSBjcmVhdGlvbiwgYW5kIGEgOSUg c3BlZWR1cCBvdmVyYWxsLikKSW5kZXg6IEphdmFTY3JpcHRDb3JlL0dOVW1ha2VmaWxlLmFtCj09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT0KLS0tIEphdmFTY3JpcHRDb3JlL0dOVW1ha2VmaWxlLmFtCShyZXZpc2lvbiAyOTk2 MSkKKysrIEphdmFTY3JpcHRDb3JlL0dOVW1ha2VmaWxlLmFtCSh3b3JraW5nIGNvcHkpCkBAIC0x NDksMTQgKzE0OSwxNCBAQCBQcm9ncmFtc19taW5pZG9tX1NPVVJDRVMgPSBcCiAJSmF2YVNjcmlw dENvcmUvQVBJL05vZGVMaXN0LmMgXAogCUphdmFTY3JpcHRDb3JlL0FQSS9taW5pZG9tLmMKIFBy b2dyYW1zX21pbmlkb21fQ1BQRkxBR1MgPSAkKGdsb2JhbF9jcHBmbGFncykKLVByb2dyYW1zX21p bmlkb21fQ1hYRkxBR1MgPSAkKGdsb2JhbF9jZmxhZ3MpCitQcm9ncmFtc19taW5pZG9tX0NYWEZM QUdTID0gJChnbG9iYWxfY3h4ZmxhZ3MpICQoZ2xvYmFsX2NmbGFncykKIFByb2dyYW1zX21pbmlk b21fTERBREQgPSBsaWJKYXZhU2NyaXB0Q29yZS5sYQogUHJvZ3JhbXNfbWluaWRvbV9MREZMQUdT ID0gLXJwYXRoICQoQ1VSRElSKS8ubGlicwogCiAjIHRlc3RranMKIFByb2dyYW1zX3Rlc3RranNf U09VUkNFUyA9IEphdmFTY3JpcHRDb3JlL2tqcy90ZXN0a2pzLmNwcAogUHJvZ3JhbXNfdGVzdGtq c19DUFBGTEFHUyA9ICQoZ2xvYmFsX2NwcGZsYWdzKQotUHJvZ3JhbXNfdGVzdGtqc19DWFhGTEFH UyA9ICQoZ2xvYmFsX2NmbGFncykKK1Byb2dyYW1zX3Rlc3RranNfQ1hYRkxBR1MgPSAkKGdsb2Jh bF9jeHhmbGFncykgJChnbG9iYWxfY2ZsYWdzKQogUHJvZ3JhbXNfdGVzdGtqc19MREFERCA9IGxp YkphdmFTY3JpcHRDb3JlLmxhCiBQcm9ncmFtc190ZXN0a2pzX0xERkxBR1MgPSAtcnBhdGggJChD VVJESVIpLy5saWJzCiAKSW5kZXg6IFdlYktpdFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0t LSBXZWJLaXRUb29scy9DaGFuZ2VMb2cJKHJldmlzaW9uIDI5OTYxKQorKysgV2ViS2l0VG9vbHMv Q2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTEgQEAKKzIwMDgtMDItMDQgIFJv ZG5leSBEYXdlcyAgPGRvYmV5QHdheW9mdGhlbW9ua2V5LmNvbT4KKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhISkKKworICAgICAgICBVc2UgZ2xvYmFsX2N4eGZsYWdzIGFzIHdl bGwgYXMgZ2xvYmFsX2NmbGFncyBpbiBDWFhGTEFHUworCisgICAgICAgICogR05VbWFrZWZpbGUu YW06CisKIDIwMDgtMDItMDQgIEFscCBUb2tlciAgPGFscEBhdG9rZXIuY29tPgogCiAgICAgICAg IFJ1YmJlci1zdGFtcGVkIGJ5IE1hcmsgUm93ZS4KSW5kZXg6IFdlYktpdFRvb2xzL0dOVW1ha2Vm aWxlLmFtCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT0KLS0tIFdlYktpdFRvb2xzL0dOVW1ha2VmaWxlLmFtCShyZXZpc2lv biAyOTk2MSkKKysrIFdlYktpdFRvb2xzL0dOVW1ha2VmaWxlLmFtCSh3b3JraW5nIGNvcHkpCkBA IC0zOSw2ICszOSw3IEBAIFByb2dyYW1zX0R1bXBSZW5kZXJUcmVlX1NPVVJDRVMgPSBcCiAKIFBy b2dyYW1zX0R1bXBSZW5kZXJUcmVlX0NYWEZMQUdTID0gXAogCSQoREVQRU5ERU5DSUVTX0NGTEFH UykgXAorCSQoZ2xvYmFsX2N4eGZsYWdzKSBcCiAJJChnbG9iYWxfY2ZsYWdzKQogCiBQcm9ncmFt c19EdW1wUmVuZGVyVHJlZV9MREFERCA9IFwK