171748 2017-05-05 14:10:28 -0700 [Cocoa] Converting from WebCore::Cookie to NSHTTPCookie always marks cookies as session cookies 2017-05-05 16:45:09 -0700 1 1 1 Unclassified WebKit WebKit2 WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 bburg bburg ap bburg beidson commit-queue mcatanzaro webkit-bug-importer oldest_to_newest 1305301 0 bburg 2017-05-05 14:10:28 -0700 I'm going to temporarily make the assertion wrong so this can be investigated separately from the "secure" flag bug (https://bugs.webkit.org/show_bug.cgi?id=171700). The test fix for that exposed this unexpected failing test assertion. 1305310 1 bburg 2017-05-05 14:15:57 -0700 Committed r216272: <http://trac.webkit.org/changeset/216272> 1305312 2 bburg 2017-05-05 14:16:39 -0700 Un-closing, going to track the fix here too. 1305319 3 bburg 2017-05-05 14:23:24 -0700 Looks like another round tripping issue: (lldb) po cookie <NSHTTPCookie version:1 name:"OtherCookieName" value:"OtherCookieValue" expiresDate:(null) created:2017-05-05 21:18:10 +0000 sessionOnly:TRUE domain:".www.w3c.org" partition:"none" path:"/path" isSecure:TRUE> (lldb) po cookie2.get() <NSHTTPCookie version:0 name:"OtherCookieName" value:"OtherCookieValue" expiresDate:2017-05-06 00:04:50 +0000 created:2017-05-05 21:18:10 +0000 sessionOnly:FALSE domain:".www.w3c.org" partition:"none" path:"/path" isSecure:FALSE> Also note that the expires date is getting dropped, afaict. Is that something we are supposed to preserve? 1305324 4 mcatanzaro 2017-05-05 14:29:52 -0700 I think it's sessionOnly if it doesn't have an expiresDate... then the expiration date is when you close the browser. 1305331 5 bburg 2017-05-05 14:40:23 -0700 The NS equivalent here is NSHTTPCookieDiscard: https://developer.apple.com/reference/foundation/nshttpcookiediscard "String value must be either "TRUE" or "FALSE". This cookie attribute is optional. The default is "FALSE", unless this cookie is version 1 or greater and a value for NSHTTPCookieMaximumAge is not specified, in which case it is assumed to be "TRUE"." 1305345 6 beidson 2017-05-05 15:08:13 -0700 (In reply to Brian Burg from comment #5) > The NS equivalent here is NSHTTPCookieDiscard: > > https://developer.apple.com/reference/foundation/nshttpcookiediscard > > "String value must be either "TRUE" or "FALSE". This cookie attribute is > optional. The default is "FALSE", unless this cookie is version 1 or greater > and a value for NSHTTPCookieMaximumAge is not specified, in which case it is > assumed to be "TRUE"." Ignore the discard thing, I think. 1305349 7 beidson 2017-05-05 15:15:34 -0700 (In reply to Michael Catanzaro from comment #4) > I think it's sessionOnly if it doesn't have an expiresDate... then the > expiration date is when you close the browser. Michael is right. If it has an expires date, it's a persistent cookies. If it doesn't, it's session. 1305352 8 beidson 2017-05-05 15:17:26 -0700 Yah, the test does the discard thing, but in reality having an expires date is what defines session or not. 1305353 9 beidson 2017-05-05 15:17:57 -0700 Except the docs say: "A boolean value that indicates whether the receiver should be discarded at the end of the session (regardless of expiration date)." lol wut. 1305373 10 webkit-bug-importer 2017-05-05 15:42:54 -0700 <rdar://problem/32027327> 1305388 11 309232 bburg 2017-05-05 16:05:37 -0700 Created attachment 309232 Patch 1305414 12 309232 commit-queue 2017-05-05 16:45:08 -0700 Comment on attachment 309232 Patch Clearing flags on attachment: 309232 Committed r216292: <http://trac.webkit.org/changeset/216292> 1305415 13 commit-queue 2017-05-05 16:45:09 -0700 All reviewed patches have been landed. Closing bug. 309232 2017-05-05 16:05:37 -0700 2017-05-05 16:45:08 -0700 Patch bug-171748-20170505160536.patch text/plain 3963 bburg U3VidmVyc2lvbiBSZXZpc2lvbjogMjE2MjcyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYjBhMzMyYTY5OGI1NjRk OWQwN2JiYTc1NGQ2MzAwODgxMTczOTI1ZC4uYWFkOTMxNWQxMTc5ZDVlOTlhMTgwOGZlNGVhMDgw MWEyZDM3MmEyNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDI3IEBACiAyMDE3LTA1LTA1ICBCcmlh biBCdXJnICA8YmJ1cmdAYXBwbGUuY29tPgogCisgICAgICAgIFtDb2NvYV0gQ29udmVydGluZyBm cm9tIFdlYkNvcmU6OkNvb2tpZSB0byBOU0hUVFBDb29raWUgYWx3YXlzIG1hcmtzIGNvb2tpZXMg YXMgc2Vzc2lvbiBjb29raWVzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD0xNzE3NDgKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzMyMDI3MzI3PgorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRoZSBmdW5jdGlv biB0aGF0IHdlIHVzZSB0byBjb252ZXJ0IGZyb20gV2ViQ29yZTo6Q29va2llIHRvIE5TSFRUUENv b2tpZSB3YXMKKyAgICAgICAgYWxzbyBtaXN1c2luZyB0aGUgTlNIVFRQQ29va2llRGlzY2FyZCBw cm9wZXJ0eS4gSWYgYW55IHZhbHVlIGlzIHByb3ZpZGVkIGZvcgorICAgICAgICB0aGlzIGtleSwg ZXZlbiBATk8sIENGTmV0d29yayBpbnRlcnByZXRzIHRoYXQgdG8gbWVhbiB0aGF0IHRoZSBjb29r aWUgaGFzIHRoZQorICAgICAgICAic2Vzc2lvbiIgZmxhZy4KKworICAgICAgICBUaGlzIGlzIGtu b3duIHRvIGFmZmVjdCBjb29raWVzIHNldCB2aWEgV2ViQ29va2llTWFuYWdlciwgV0tIVFRQQ29v a2llU3RvcmUsCisgICAgICAgIGFuZCBXZWJBdXRvbWF0aW9uU2Vzc2lvbi4KKworICAgICAgICBU aGlzIGlzIGNvdmVyZWQgYnkgZXhpc3RpbmcgdGVzdCBXZWJLaXQyLldLSFRUUENvb2tpZVN0b3Jl LgorCisgICAgICAgICogcGxhdGZvcm0vbmV0d29yay9jb2NvYS9Db29raWVDb2NvYS5tbToKKyAg ICAgICAgKFdlYkNvcmU6OkNvb2tpZTo6b3BlcmF0b3IgTlNIVFRQQ29va2llICopOgorICAgICAg ICBEb24ndCBpbmNsdWRlIHRoZSBwcm9wZXJ0eSBpZiB0aGUgY29va2llIGlzIG5vdCBhIHNlc3Np b24gY29va2llLgorCisyMDE3LTA1LTA1ICBCcmlhbiBCdXJnICA8YmJ1cmdAYXBwbGUuY29tPgor CiAgICAgICAgIENyYXNoVHJhY2VyOiBbVVNFUl0gY29tLmFwcGxlLldlYktpdC5XZWJDb250ZW50 LkRldmVsb3BtZW50IGF0IGNvbS5hcHBsZS5XZWJDb3JlOiBXZWJDb3JlOjpjb21tb25WTVNsb3cg KyA1NwogICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTcx NjY5CiAgICAgICAgIDxyZGFyOi8vcHJvYmxlbS8zMTk2NzY4ND4KZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvY29jb2EvQ29va2llQ29jb2EubW0gYi9Tb3VyY2Uv V2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL2NvY29hL0Nvb2tpZUNvY29hLm1tCmluZGV4IDg0ODBk YTRmMTQxMzk5MDRlMWUzNjBhZjkzZThjOTk4MDNmYzg2OGYuLjM2MDk2NjFhNTZhY2NiYTUzOWMw ZjVkNDU2NTExNzdiZDFjZDhmNmMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3Jt L25ldHdvcmsvY29jb2EvQ29va2llQ29jb2EubW0KKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZv cm0vbmV0d29yay9jb2NvYS9Db29raWVDb2NvYS5tbQpAQCAtOTgsNyArOTgsOSBAQCBDb29raWU6 Om9wZXJhdG9yIE5TSFRUUENvb2tpZSAqKCkgY29uc3QKICAgICBpZiAoc2VjdXJlKQogICAgICAg ICBbcHJvcGVydGllcyBzZXRPYmplY3Q6QFlFUyBmb3JLZXk6TlNIVFRQQ29va2llU2VjdXJlXTsK IAotICAgIFtwcm9wZXJ0aWVzIHNldE9iamVjdDooc2Vzc2lvbiA/IEAiVFJVRSIgOiBAIkZBTFNF IikgZm9yS2V5Ok5TSFRUUENvb2tpZURpc2NhcmRdOworICAgIGlmIChzZXNzaW9uKQorICAgICAg ICBbcHJvcGVydGllcyBzZXRPYmplY3Q6QFlFUyBmb3JLZXk6TlNIVFRQQ29va2llRGlzY2FyZF07 CisKICAgICBbcHJvcGVydGllcyBzZXRPYmplY3Q6QCIxIiBmb3JLZXk6TlNIVFRQQ29va2llVmVy c2lvbl07CiAKICAgICByZXR1cm4gW05TSFRUUENvb2tpZSBjb29raWVXaXRoUHJvcGVydGllczpw cm9wZXJ0aWVzXTsKZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxv ZwppbmRleCAzOWQyN2QzZjRiMDhkZDBhYWViYjBlYzk2YWNlNjNhYjQ5ODZjNDBiLi5hOTdmY2I5 ZWNmNTQwMzY1MDA1MjBlYzhlYmM1OWJlNzgyYWYxZmNiIDEwMDY0NAotLS0gYS9Ub29scy9DaGFu Z2VMb2cKKysrIGIvVG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMTggQEAKIDIwMTctMDUtMDUg IEJyaWFuIEJ1cmcgIDxiYnVyZ0BhcHBsZS5jb20+CiAKKyAgICAgICAgW0NvY29hXSBDb252ZXJ0 aW5nIGZyb20gV2ViQ29yZTo6Q29va2llIHRvIE5TSFRUUENvb2tpZSBhbHdheXMgbWFya3MgY29v a2llcyBhcyBzZXNzaW9uIGNvb2tpZXMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTE3MTc0OAorICAgICAgICA8cmRhcjovL3Byb2JsZW0vMzIwMjczMjc+ CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgUmVtb3Zl IHRlbXBvcmFyeSB3b3JrYXJvdW5kIG5vdyB0aGF0IHRoZSBhc3NlcnRpb24gZmFpbHVyZSBpcyBm aXhlZC4KKworICAgICAgICAqIFRlc3RXZWJLaXRBUEkvVGVzdHMvV2ViS2l0MkNvY29hL1dLSFRU UENvb2tpZVN0b3JlLm1tOgorICAgICAgICAoVEVTVCk6CisKKzIwMTctMDUtMDUgIEJyaWFuIEJ1 cmcgIDxiYnVyZ0BhcHBsZS5jb20+CisKICAgICAgICAgQVBJIHRlc3QgV2ViS2l0Mi5XS0hUVFBD b29raWVTdG9yZSBmYWlscyBkdWUgdG8gcG9zc2libGUgaXNzdWUgd2l0aCBoYW5kbGluZyBub24t c2Vzc2lvbiBjb29raWVzCiAgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0xNzE3NDgKIApkaWZmIC0tZ2l0IGEvVG9vbHMvVGVzdFdlYktpdEFQSS9UZXN0cy9X ZWJLaXQyQ29jb2EvV0tIVFRQQ29va2llU3RvcmUubW0gYi9Ub29scy9UZXN0V2ViS2l0QVBJL1Rl c3RzL1dlYktpdDJDb2NvYS9XS0hUVFBDb29raWVTdG9yZS5tbQppbmRleCAxMDQyNjY1ZTYxNWJk ZWY2ZGU4ZGZhMjFlNTAzZjcxMGU4MmZkMzA4Li4xNWI2NzlmODI1MWE0NjI4YTBhMWEyMjhkMDYz MTk2MWE1M2E2NGVhIDEwMDY0NAotLS0gYS9Ub29scy9UZXN0V2ViS2l0QVBJL1Rlc3RzL1dlYktp dDJDb2NvYS9XS0hUVFBDb29raWVTdG9yZS5tbQorKysgYi9Ub29scy9UZXN0V2ViS2l0QVBJL1Rl c3RzL1dlYktpdDJDb2NvYS9XS0hUVFBDb29raWVTdG9yZS5tbQpAQCAtMTMxLDggKzEzMSw3IEBA IFRFU1QoV2ViS2l0MiwgV0tIVFRQQ29va2llU3RvcmUpCiAgICAgICAgICAgICBBU1NFUlRfVFJV RShbY29va2llMi5nZXQoKS5uYW1lIGlzRXF1YWxUb1N0cmluZzpjb29raWUubmFtZV0pOwogICAg ICAgICAgICAgQVNTRVJUX1RSVUUoW2Nvb2tpZTIuZ2V0KCkuZG9tYWluIGlzRXF1YWxUb1N0cmlu Zzpjb29raWUuZG9tYWluXSk7CiAgICAgICAgICAgICBBU1NFUlRfRkFMU0UoY29va2llLnNlY3Vy ZSk7Ci0gICAgICAgICAgICAvLyBGSVhNRTogdGhpcyBzaG91bGQgYmUgQVNTRVJUX0ZBTFNFLiBJ bnZlc3RpZ2F0aW5nIGluIDxodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MTcxNzQ4Pi4KLSAgICAgICAgICAgIEFTU0VSVF9UUlVFKGNvb2tpZS5zZXNzaW9uT25seSk7Cisg ICAgICAgICAgICBBU1NFUlRfRkFMU0UoY29va2llLnNlc3Npb25Pbmx5KTsKICAgICAgICAgfQog ICAgIH0KICAgICBbY29va2llcyByZWxlYXNlXTsK