171739 2017-05-05 11:16:20 -0700 LayoutTest js/Promise-types.html is a flaky failure (Unhandled Promise Rejection messages) 2017-05-19 15:26:31 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 ryanhaddad ryanhaddad ap commit-queue fpizlo jlewis3 joepeck oldest_to_newest 1305216 0 ryanhaddad 2017-05-05 11:16:20 -0700 LayoutTest js/Promise-types.html is a flaky failure https://build.webkit.org/results/Apple%20Sierra%20Debug%20WK2%20(Tests)/r216244%20(831)/results.html https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=js%2FPromise-types.html --- /Volumes/Data/slave/sierra-debug-tests-wk2/build/layout-test-results/js/Promise-types-expected.txt +++ /Volumes/Data/slave/sierra-debug-tests-wk2/build/layout-test-results/js/Promise-types-actual.txt @@ -1,3 +1,5 @@ +CONSOLE MESSAGE: Unhandled Promise Rejection: 1 +CONSOLE MESSAGE: Unhandled Promise Rejection: 1 Promises - Test basic types / exceptions. On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE". 1305218 1 ryanhaddad 2017-05-05 11:17:01 -0700 I'm guessing this test needs the same treatment applied to the tests in https://bugs.webkit.org/show_bug.cgi?id=171445 1309848 2 jlewis3 2017-05-17 15:02:40 -0700 reproduced locally on Sierra debug with: run-webkit-tests js/Promise-types.html -f --iterations=500 --no-retry-failure -g --debug 1309916 3 joepeck 2017-05-17 17:00:27 -0700 (In reply to Ryan Haddad from comment #1) > I'm guessing this test needs the same treatment applied to the tests in > https://bugs.webkit.org/show_bug.cgi?id=171445 Correct that would be sufficient. 1310423 4 310600 ryanhaddad 2017-05-18 20:18:16 -0700 Created attachment 310600 Patch 1310685 5 310600 joepeck 2017-05-19 11:40:32 -0700 Comment on attachment 310600 Patch r=me 1310700 6 310600 commit-queue 2017-05-19 12:09:38 -0700 Comment on attachment 310600 Patch Clearing flags on attachment: 310600 Committed r217140: <http://trac.webkit.org/changeset/217140> 1310701 7 commit-queue 2017-05-19 12:09:39 -0700 All reviewed patches have been landed. Closing bug. 1310757 8 ryanhaddad 2017-05-19 13:48:34 -0700 My change managed to break the test when it is run as part of the JSC tests: jsc-layout-tests.yaml/js/script-tests/Promise-types.js.layout-no-cjit: Exception: ReferenceError: Can't find variable: window https://build.webkit.org/builders/Apple%20Sierra%20Release%20JSC%20%28Tests%29/builds/1434 1310759 9 joepeck 2017-05-19 13:58:34 -0700 (In reply to Ryan Haddad from comment #8) > My change managed to break the test when it is run as part of the JSC tests: > > jsc-layout-tests.yaml/js/script-tests/Promise-types.js.layout-no-cjit: > Exception: ReferenceError: Can't find variable: window > > > https://build.webkit.org/builders/ > Apple%20Sierra%20Release%20JSC%20%28Tests%29/builds/1434 Ahh yes, I should have realized. You could actually just do: onunhandledrejection = () => false; Without the `window.` portion. 1310760 10 310600 fpizlo 2017-05-19 14:08:01 -0700 Comment on attachment 310600 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=310600&action=review > LayoutTests/js/script-tests/Promise-types.js:10 > +// Silence unhandled rejection messages. > +window.onunhandledrejection = () => false; > + This caused the test to always fail in jsc tests. 1310805 11 ryanhaddad 2017-05-19 15:18:29 -0700 (In reply to Joseph Pecoraro from comment #9) > (In reply to Ryan Haddad from comment #8) > > My change managed to break the test when it is run as part of the JSC tests: > > > > jsc-layout-tests.yaml/js/script-tests/Promise-types.js.layout-no-cjit: > > Exception: ReferenceError: Can't find variable: window > > > > > > https://build.webkit.org/builders/ > > Apple%20Sierra%20Release%20JSC%20%28Tests%29/builds/1434 > > Ahh yes, I should have realized. > > You could actually just do: > > onunhandledrejection = () => false; > > Without the `window.` portion. I verified that making this change fixes the test failure when run locally. I will land a follow up fix to correct my error. 1310808 12 ryanhaddad 2017-05-19 15:26:31 -0700 Fixed in https://trac.webkit.org/r217155 310600 2017-05-18 20:18:16 -0700 2017-05-19 12:09:38 -0700 Patch bug-171739-20170518201815.patch text/plain 1317 ryanhaddad U3VidmVyc2lvbiBSZXZpc2lvbjogMjE3MDkwCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggMTVmZTg0ZDVjZDUzOWQ5YmJkNzIz YzNmYTg2OGQxZmExNDFjYTcxNi4uMDllZjliOTVkMWM3ODQzNDU3NjdiOTMxZDM3MjllMGM3MWI1 M2ExNiAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDE3LTA1LTE4ICBSeWFuIEhhZGRhZCAgPHJ5 YW5oYWRkYWRAYXBwbGUuY29tPgorCisgICAgICAgIExheW91dFRlc3QganMvUHJvbWlzZS10eXBl cy5odG1sIGlzIGEgZmxha3kgZmFpbHVyZSAoVW5oYW5kbGVkIFByb21pc2UgUmVqZWN0aW9uIG1l c3NhZ2VzKQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MTcxNzM5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg U2lsZW5jZSB0aGUgY29uc29sZSBtZXNzYWdlcyBmb3IgdW5oYW5kbGVkIHJlamVjdGlvbnMgaW4g dGhpcyBMYXlvdXRUZXN0LgorCisgICAgICAgICoganMvc2NyaXB0LXRlc3RzL1Byb21pc2UtdHlw ZXMuanM6CisKIDIwMTctMDUtMTggIEFuZHkgRXN0ZXMgIDxhZXN0ZXNAYXBwbGUuY29tPgogCiAg ICAgICAgIFVucmV2aWV3ZWQgZ2FyZGVuaW5nIG9uIEFwcGxlUGF5U2Vzc2lvbi5odG1sIGFmdGVy IHIyMTcwNzguCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9qcy9zY3JpcHQtdGVzdHMvUHJvbWlz ZS10eXBlcy5qcyBiL0xheW91dFRlc3RzL2pzL3NjcmlwdC10ZXN0cy9Qcm9taXNlLXR5cGVzLmpz CmluZGV4IDkzMTFlNmNjMjM5NjYwNjhhMDhjMTJiY2JiZjBlODIyOWEzNjJmNjYuLmU3ZjhhYTUx NTM1ZmZlN2M1MjRhNmJkZjgyMDQ5Y2E1NTlkMWNhMDQgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3Rz L2pzL3NjcmlwdC10ZXN0cy9Qcm9taXNlLXR5cGVzLmpzCisrKyBiL0xheW91dFRlc3RzL2pzL3Nj cmlwdC10ZXN0cy9Qcm9taXNlLXR5cGVzLmpzCkBAIC01LDYgKzUsOSBAQCBkZWJ1ZygiIik7CiBk ZWJ1ZygiUHJvbWlzZXMiKTsKIGRlYnVnKCIiKTsKIAorLy8gU2lsZW5jZSB1bmhhbmRsZWQgcmVq ZWN0aW9uIG1lc3NhZ2VzLgord2luZG93Lm9udW5oYW5kbGVkcmVqZWN0aW9uID0gKCkgPT4gZmFs c2U7CisKIC8vIFByb21pc2VzIHNob3VsZCBiZSBvZiB0eXBlIFByb21pc2UuCiAKIHZhciBhUHJv bWlzZSA9IG5ldyBQcm9taXNlKGZ1bmN0aW9uKHJlc29sdmUsIHJlamVjdCkgeyByZXNvbHZlKDEp OyB9KTsK