<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>171735</bug_id>
          
          <creation_ts>2017-05-05 10:29:36 -0700</creation_ts>
          <short_desc>[GTK] Add WebKitWebView can-go-back and can-go-forward properties</short_desc>
          <delta_ts>2018-05-02 12:57:11 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebKitGTK</component>
          <version>Other</version>
          <rep_platform>PC</rep_platform>
          <op_sys>Linux</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>WONTFIX</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>Gtk</keywords>
          <priority>P3</priority>
          <bug_severity>Enhancement</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Sébastien Wilmet">swilmet</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>aperez</cc>
    
    <cc>bugs-noreply</cc>
    
    <cc>janousek.jiri</cc>
    
    <cc>mcatanzaro</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1305169</commentid>
    <comment_count>0</comment_count>
    <who name="Sébastien Wilmet">swilmet</who>
    <bug_when>2017-05-05 10:29:36 -0700</bug_when>
    <thetext>It would be nice to have WebKitWebView can-go-back and can-go-forward boolean properties, to update the sensitivity of previous/next buttons.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1305174</commentid>
    <comment_count>1</comment_count>
    <who name="Sébastien Wilmet">swilmet</who>
    <bug_when>2017-05-05 10:36:20 -0700</bug_when>
    <thetext>See the following bug in Devhelp to know why I&apos;ve filed this bug.

https://bugzilla.gnome.org/show_bug.cgi?id=775175</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1305224</commentid>
    <comment_count>2</comment_count>
    <who name="Michael Catanzaro">mcatanzaro</who>
    <bug_when>2017-05-05 11:31:20 -0700</bug_when>
    <thetext>Hm, this should be easy to implement by connecting to the &quot;changed&quot; signal of the WebKitBackForwardList and then calling webkit_web_view_can_go_back() and webkit_web_view_can_go_forward(). That&apos;s what Epiphany does, and it&apos;s what you could do in Devhelp in the meantime.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1305276</commentid>
    <comment_count>3</comment_count>
    <who name="Sébastien Wilmet">swilmet</who>
    <bug_when>2017-05-05 13:15:51 -0700</bug_when>
    <thetext>Thanks for the hint, the &quot;changed&quot; signal of WebKitBackForwardList is actually quite convenient to use. With the properties it would anyway not be possible to bind them directly to the GtkButtons sensitivity, because there are several tabs.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1419730</commentid>
    <comment_count>4</comment_count>
    <who name="Adrian Perez">aperez</who>
    <bug_when>2018-05-02 10:49:18 -0700</bug_when>
    <thetext>(In reply to Sébastien Wilmet from comment #3)
&gt; Thanks for the hint, the &quot;changed&quot; signal of WebKitBackForwardList is
&gt; actually quite convenient to use. With the properties it would anyway not be
&gt; possible to bind them directly to the GtkButtons sensitivity, because there
&gt; are several tabs.

Hi Sébastien! If I understand correctly, here you agreed that using
the ::changed signal and calculating whether the buttons should be
sensitive ended up being better, isn&apos;t it? If that&apos;s the case, then
I think we can close this as WONTFIX.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1419768</commentid>
    <comment_count>5</comment_count>
    <who name="Sébastien Wilmet">swilmet</who>
    <bug_when>2018-05-02 11:55:04 -0700</bug_when>
    <thetext>Yes in Devhelp it&apos;s actually easier with the ::changed signal.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1419802</commentid>
    <comment_count>6</comment_count>
    <who name="Adrian Perez">aperez</who>
    <bug_when>2018-05-02 12:57:11 -0700</bug_when>
    <thetext>(In reply to Sébastien Wilmet from comment #5)
&gt; Yes in Devhelp it&apos;s actually easier with the ::changed signal.

Great, thanks for closing the issue!</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>