171733 2017-05-05 09:55:48 -0700 std::min used without including algorithm 2017-05-12 15:05:29 -0700 1 1 1 Unclassified WebKit Web Template Framework WebKit Local Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 lantw44 webkit-unassigned benjamin buildbot cdumez cmarcelo commit-queue dbates oldest_to_newest 1305158 0 lantw44 2017-05-05 09:55:48 -0700 This causes compilation error on FreeBSD: In file included from /path/to/WebKit/Source/WebCore/html/track/VTTScanner.cpp:31: In file included from /path/to/WebKit/Source/WebCore/html/track/VTTScanner.h:32: In file included from /path/to/WebKit/Source/WebCore/html/parser/ParsingUtilities.h:33: /path/to/WebKit/Source/WTF/wtf/text/StringCommon.h:482:21: error: no member named 'min' in namespace 'std' return std::min(startOffset, sourceStringLength); ~~~~~^ /path/to/WebKit/Source/WTF/wtf/text/StringCommon.h:567:21: error: no member named 'min' in namespace 'std' return std::min(start, haystack.length()); ~~~~~^ 2 errors generated. 1305160 1 309179 lantw44 2017-05-05 09:59:03 -0700 Created attachment 309179 Patch 1308084 2 309179 commit-queue 2017-05-12 15:05:28 -0700 Comment on attachment 309179 Patch Clearing flags on attachment: 309179 Committed r216796: <http://trac.webkit.org/changeset/216796> 1308085 3 commit-queue 2017-05-12 15:05:29 -0700 All reviewed patches have been landed. Closing bug. 309179 2017-05-05 09:59:03 -0700 2017-05-12 15:05:28 -0700 Patch bug-171733-20170506005827.patch text/plain 1019 lantw44 U3VidmVyc2lvbiBSZXZpc2lvbjogMjE2MjQ2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IGNhMmUzNzVlZGJkNWVlZjgxNDJkNzE1 OTc0ZTRhY2RlMDMzZGNhYjEuLjk0OWFjNjY1MzViYWNhMTEwOTVhNDAzYjhmNTdjMWVkNmRlZTk3 MjEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTIgQEAKKzIwMTctMDUtMDUgIFRpbmctV2VpIExhbiAgPGxhbnR3 NDRAZ21haWwuY29tPgorCisgICAgICAgIEluY2x1ZGUgYWxnb3JpdGhtIGJlZm9yZSB1c2luZyBz dGQ6Om1pbgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MTcxNzMzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg KiB3dGYvdGV4dC9TdHJpbmdDb21tb24uaDoKKwogMjAxNy0wNS0wNCAgQ29tbWl0IFF1ZXVlICA8 Y29tbWl0LXF1ZXVlQHdlYmtpdC5vcmc+CiAKICAgICAgICAgVW5yZXZpZXdlZCwgcm9sbGluZyBv dXQgcjIxNjIwNi4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XVEYvd3RmL3RleHQvU3RyaW5nQ29tbW9u LmggYi9Tb3VyY2UvV1RGL3d0Zi90ZXh0L1N0cmluZ0NvbW1vbi5oCmluZGV4IGJiNjY0YWVhOThj MjkyZmQ4MzMyN2E5NDkwM2VkMDZlMDc5ZDU4MjMuLjkzMzI5NTdjMDE1YmVlM2E2YTNjYzIwMzU4 OTk3ZmQzOWJlZDU2Y2QgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvd3RmL3RleHQvU3RyaW5nQ29t bW9uLmgKKysrIGIvU291cmNlL1dURi93dGYvdGV4dC9TdHJpbmdDb21tb24uaApAQCAtMjYsNiAr MjYsNyBAQAogI2lmbmRlZiBTdHJpbmdDb21tb25faAogI2RlZmluZSBTdHJpbmdDb21tb25faAog CisjaW5jbHVkZSA8YWxnb3JpdGhtPgogI2luY2x1ZGUgPHVuaWNvZGUvdWNoYXIuaD4KICNpbmNs dWRlIDx3dGYvQVNDSUlDVHlwZS5oPgogI2luY2x1ZGUgPHd0Zi9Ob3RGb3VuZC5oPgo=