171724 2017-05-05 05:22:04 -0700 [GTK] TestController timeout source callback should return G_SOURCE_REMOVE 2017-05-05 06:20:26 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED Gtk P2 Normal --- 1 cgarcia webkit-unassigned bugs-noreply lforschler mcatanzaro oldest_to_newest 1305082 0 cgarcia 2017-05-05 05:22:04 -0700 It's currently returning CONTINUE which causes it to be called again even if the run loop has been stopped. 1305083 1 309165 cgarcia 2017-05-05 05:23:50 -0700 Created attachment 309165 Patch 1305085 2 309165 mcatanzaro 2017-05-05 05:43:40 -0700 Comment on attachment 309165 Patch Wow. How much does this fix? Wouldn't this have caused full CPU usage for as long as the test controller is running? 1305092 3 cgarcia 2017-05-05 06:03:33 -0700 (In reply to Michael Catanzaro from comment #2) > Comment on attachment 309165 [details] > Patch > > Wow. > > How much does this fix? Wouldn't this have caused full CPU usage for as long > as the test controller is running? Yes, only for some time, fortunately the WTR is killed by the python script when it times out. 1305093 4 cgarcia 2017-05-05 06:20:26 -0700 Committed r216241: <http://trac.webkit.org/changeset/216241> 309165 2017-05-05 05:23:50 -0700 2017-05-05 05:43:40 -0700 Patch wk-test-timeout.diff text/plain 1487 cgarcia ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCA2MTI3 MzRiMDUzZC4uOGQ5YzVhM2UyNzggMTAwNjQ0Ci0tLSBhL1Rvb2xzL0NoYW5nZUxvZworKysgYi9U b29scy9DaGFuZ2VMb2cKQEAgLTEsNSArMSwxNyBAQAogMjAxNy0wNS0wNSAgQ2FybG9zIEdhcmNp YSBDYW1wb3MgIDxjZ2FyY2lhQGlnYWxpYS5jb20+CiAKKyAgICAgICAgW0dUS10gVGVzdENvbnRy b2xsZXIgdGltZW91dCBzb3VyY2UgY2FsbGJhY2sgc2hvdWxkIHJldHVybiBHX1NPVVJDRV9SRU1P VkUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE3MTcy NAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEl0J3Mg Y3VycmVudGx5IHJldHVybmluZyBDT05USU5VRSB3aGljaCBjYXVzZXMgaXQgdG8gYmUgY2FsbGVk IGFnYWluIGV2ZW4gaWYgdGhlIHJ1biBsb29wIGhhcyBiZWVuIHN0b3BwZWQuCisKKyAgICAgICAg KiBXZWJLaXRUZXN0UnVubmVyL2d0ay9UZXN0Q29udHJvbGxlckd0ay5jcHA6CisgICAgICAgIChX VFI6OnRpbWVvdXRTb3VyY2UpOgorCisyMDE3LTA1LTA1ICBDYXJsb3MgR2FyY2lhIENhbXBvcyAg PGNnYXJjaWFAaWdhbGlhLmNvbT4KKwogICAgICAgICBVbnJldmlld2VkLiBGaXggd3JvbmcgYXNz ZXJ0IGFmdGVyIHIyMTUxNzYuCiAKICAgICAgICAgQ2Fpcm8gc3VyZmFjZSByZWNlaXZlZCBieSBj b21wdXRlTUQ1SGFzaFN0cmluZ0ZvckNhaXJvU3VyZmFjZSgpIGRvZXNuJ3QgbmVlZCB0byBiZSBB UkdCMzIgc2luY2UgcjIxNTE3NiwgaXQKZGlmZiAtLWdpdCBhL1Rvb2xzL1dlYktpdFRlc3RSdW5u ZXIvZ3RrL1Rlc3RDb250cm9sbGVyR3RrLmNwcCBiL1Rvb2xzL1dlYktpdFRlc3RSdW5uZXIvZ3Rr L1Rlc3RDb250cm9sbGVyR3RrLmNwcAppbmRleCBkNzg0OTcyMmEyOS4uNTBkMzA3YzM5MmMgMTAw NjQ0Ci0tLSBhL1Rvb2xzL1dlYktpdFRlc3RSdW5uZXIvZ3RrL1Rlc3RDb250cm9sbGVyR3RrLmNw cAorKysgYi9Ub29scy9XZWJLaXRUZXN0UnVubmVyL2d0ay9UZXN0Q29udHJvbGxlckd0ay5jcHAK QEAgLTQ4LDcgKzQ4LDcgQEAgc3RhdGljIEdTb3VyY2UqIHRpbWVvdXRTb3VyY2UoKQogICAgICAg ICAgICAgZ19zb3VyY2Vfc2V0X3JlYWR5X3RpbWUoc3RhdGljX2Nhc3Q8R1NvdXJjZSo+KHVzZXJE YXRhKSwgLTEpOwogICAgICAgICAgICAgZnByaW50ZihzdGRlcnIsICJGQUlMOiBUZXN0Q29udHJv bGxlclJ1bkxvb3AgdGltZWQgb3V0LlxuIik7CiAgICAgICAgICAgICBSdW5Mb29wOjptYWluKCku c3RvcCgpOwotICAgICAgICAgICAgcmV0dXJuIEdfU09VUkNFX0NPTlRJTlVFOworICAgICAgICAg ICAgcmV0dXJuIEdfU09VUkNFX1JFTU9WRTsKICAgICAgICAgfSwgc291cmNlLmdldCgpLCBudWxs cHRyKTsKICAgICAgICAgZ19zb3VyY2VfYXR0YWNoKHNvdXJjZS5nZXQoKSwgbnVsbHB0cik7CiAg ICAgfQo=