171721 2017-05-05 03:54:49 -0700 [GStreamer] Fix handling of gst errors in MediaPlayerPrivateGStreamer::handleMessage 2017-05-05 05:59:48 -0700 1 1 1 Unclassified WebKit Platform WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 cgarcia webkit-unassigned bugs-noreply calvaris mcatanzaro oldest_to_newest 1305054 0 cgarcia 2017-05-05 03:54:49 -0700 We are checking the errors only by their code, which can be the same in other domains. We should always check both the domain and the code. 1305055 1 309157 cgarcia 2017-05-05 03:56:43 -0700 Created attachment 309157 Patch 1305072 2 309157 calvaris 2017-05-05 04:54:34 -0700 Comment on attachment 309157 Patch I am curious, what does this fix? 1305076 3 cgarcia 2017-05-05 04:59:16 -0700 I noticed this while working on bug #171722, so I don't know what it fixed, but for example, if we receive a GST_RESOURCE_ERROR_OPEN_WRITE error, it will be handled as a format error because the code is the same as GST_STREAM_ERROR_CODEC_NOT_FOUND. 1305080 4 cgarcia 2017-05-05 05:02:44 -0700 Committed r216239: <http://trac.webkit.org/changeset/216239> 1305086 5 mcatanzaro 2017-05-05 05:45:58 -0700 It would be good to grep for other uses of GStreamer error codes to ensure we didn't make this same mistake in other places. 1305090 6 cgarcia 2017-05-05 05:59:48 -0700 (In reply to Michael Catanzaro from comment #5) > It would be good to grep for other uses of GStreamer error codes to ensure > we didn't make this same mistake in other places. I did it when I noticed the problem. 309157 2017-05-05 03:56:43 -0700 2017-05-05 04:54:34 -0700 Patch wk-gst-errors.diff text/plain 3057 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBkMjI5ZGNhNWRiNi4uNmY1NTIwMGI4YzYgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNiBAQAorMjAxNy0wNS0wNSAgQ2FybG9zIEdhcmNpYSBDYW1wb3MgIDxjZ2FyY2lhQGln YWxpYS5jb20+CisKKyAgICAgICAgW0dTdHJlYW1lcl0gRml4IGhhbmRsaW5nIG9mIGdzdCBlcnJv cnMgaW4gTWVkaWFQbGF5ZXJQcml2YXRlR1N0cmVhbWVyOjpoYW5kbGVNZXNzYWdlCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNzE3MjEKKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBXZSBhcmUgY2hlY2tpbmcg dGhlIEdFcnJvciBvbmx5IGNvbXBhcmluZyB0aGUgY29kZSwgYW5kIGlnbm9yaW5nIHRoZSBkb21h aW4gaW4gc29tZSBjYXNlcy4gVXNlIGdfZXJyb3JfbWF0Y2hlcygpCisgICAgICAgIGluIHRob3Nl IGNhc2VzIGluc3RlYWQgb2Ygb25seSBjaGVja2luZyB0aGUgY29kZS4KKworICAgICAgICAqIHBs YXRmb3JtL2dyYXBoaWNzL2dzdHJlYW1lci9NZWRpYVBsYXllclByaXZhdGVHU3RyZWFtZXIuY3Bw OgorICAgICAgICAoV2ViQ29yZTo6TWVkaWFQbGF5ZXJQcml2YXRlR1N0cmVhbWVyOjpoYW5kbGVN ZXNzYWdlKToKKwogMjAxNy0wNS0wNCAgQ29tbWl0IFF1ZXVlICA8Y29tbWl0LXF1ZXVlQHdlYmtp dC5vcmc+CiAKICAgICAgICAgVW5yZXZpZXdlZCwgcm9sbGluZyBvdXQgcjIxNjIwNi4KZGlmZiAt LWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2dzdHJlYW1lci9NZWRpYVBs YXllclByaXZhdGVHU3RyZWFtZXIuY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhp Y3MvZ3N0cmVhbWVyL01lZGlhUGxheWVyUHJpdmF0ZUdTdHJlYW1lci5jcHAKaW5kZXggOWQyYWNk NGUxZWQuLmY4M2ZhOTVjYTFlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9n cmFwaGljcy9nc3RyZWFtZXIvTWVkaWFQbGF5ZXJQcml2YXRlR1N0cmVhbWVyLmNwcAorKysgYi9T b3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9nc3RyZWFtZXIvTWVkaWFQbGF5ZXJQcml2 YXRlR1N0cmVhbWVyLmNwcApAQCAtOTQ3LDIwICs5NDcsMTkgQEAgdm9pZCBNZWRpYVBsYXllclBy aXZhdGVHU3RyZWFtZXI6OmhhbmRsZU1lc3NhZ2UoR3N0TWVzc2FnZSogbWVzc2FnZSkKICAgICAg ICAgR1NUX0RFQlVHX0JJTl9UT19ET1RfRklMRV9XSVRIX1RTKEdTVF9CSU4obV9waXBlbGluZS5n ZXQoKSksIEdTVF9ERUJVR19HUkFQSF9TSE9XX0FMTCwgIndlYmtpdC12aWRlby5lcnJvciIpOwog CiAgICAgICAgIGVycm9yID0gTWVkaWFQbGF5ZXI6OkVtcHR5OwotICAgICAgICBpZiAoZXJyLT5j b2RlID09IEdTVF9TVFJFQU1fRVJST1JfQ09ERUNfTk9UX0ZPVU5ECi0gICAgICAgICAgICB8fCBl cnItPmNvZGUgPT0gR1NUX1NUUkVBTV9FUlJPUl9XUk9OR19UWVBFCi0gICAgICAgICAgICB8fCBl cnItPmNvZGUgPT0gR1NUX1NUUkVBTV9FUlJPUl9GQUlMRUQKLSAgICAgICAgICAgIHx8IGVyci0+ Y29kZSA9PSBHU1RfQ09SRV9FUlJPUl9NSVNTSU5HX1BMVUdJTgotICAgICAgICAgICAgfHwgZXJy LT5jb2RlID09IEdTVF9SRVNPVVJDRV9FUlJPUl9OT1RfRk9VTkQpCisgICAgICAgIGlmIChnX2Vy cm9yX21hdGNoZXMoZXJyLmdldCgpLCBHU1RfU1RSRUFNX0VSUk9SLCBHU1RfU1RSRUFNX0VSUk9S X0NPREVDX05PVF9GT1VORCkKKyAgICAgICAgICAgIHx8IGdfZXJyb3JfbWF0Y2hlcyhlcnIuZ2V0 KCksIEdTVF9TVFJFQU1fRVJST1IsIEdTVF9TVFJFQU1fRVJST1JfV1JPTkdfVFlQRSkKKyAgICAg ICAgICAgIHx8IGdfZXJyb3JfbWF0Y2hlcyhlcnIuZ2V0KCksIEdTVF9TVFJFQU1fRVJST1IsIEdT VF9TVFJFQU1fRVJST1JfRkFJTEVEKQorICAgICAgICAgICAgfHwgZ19lcnJvcl9tYXRjaGVzKGVy ci5nZXQoKSwgR1NUX0NPUkVfRVJST1IsIEdTVF9DT1JFX0VSUk9SX01JU1NJTkdfUExVR0lOKQor ICAgICAgICAgICAgfHwgZ19lcnJvcl9tYXRjaGVzKGVyci5nZXQoKSwgR1NUX1JFU09VUkNFX0VS Uk9SLCBHU1RfUkVTT1VSQ0VfRVJST1JfTk9UX0ZPVU5EKSkKICAgICAgICAgICAgIGVycm9yID0g TWVkaWFQbGF5ZXI6OkZvcm1hdEVycm9yOwotICAgICAgICBlbHNlIGlmIChlcnItPmRvbWFpbiA9 PSBHU1RfU1RSRUFNX0VSUk9SKSB7CisgICAgICAgIGVsc2UgaWYgKGdfZXJyb3JfbWF0Y2hlcyhl cnIuZ2V0KCksIEdTVF9TVFJFQU1fRVJST1IsIEdTVF9TVFJFQU1fRVJST1JfVFlQRV9OT1RfRk9V TkQpKSB7CiAgICAgICAgICAgICAvLyBMZXQgdGhlIG1lZGlhUGxheWVyQ2xpZW50IGhhbmRsZSB0 aGUgc3RyZWFtIGVycm9yLCBpbgogICAgICAgICAgICAgLy8gdGhpcyBjYXNlIHRoZSBIVE1MTWVk aWFFbGVtZW50IHdpbGwgZW1pdCBhIHN0YWxsZWQKICAgICAgICAgICAgIC8vIGV2ZW50LgotICAg ICAgICAgICAgaWYgKGVyci0+Y29kZSA9PSBHU1RfU1RSRUFNX0VSUk9SX1RZUEVfTk9UX0ZPVU5E KSB7Ci0gICAgICAgICAgICAgICAgR1NUX0VSUk9SKCJEZWNvZGUgZXJyb3IsIGxldCB0aGUgTWVk aWEgZWxlbWVudCBlbWl0IGEgc3RhbGxlZCBldmVudC4iKTsKLSAgICAgICAgICAgICAgICBicmVh azsKLSAgICAgICAgICAgIH0KKyAgICAgICAgICAgIEdTVF9FUlJPUigiRGVjb2RlIGVycm9yLCBs ZXQgdGhlIE1lZGlhIGVsZW1lbnQgZW1pdCBhIHN0YWxsZWQgZXZlbnQuIik7CisgICAgICAgICAg ICBicmVhazsKKyAgICAgICAgfSBlbHNlIGlmIChlcnItPmRvbWFpbiA9PSBHU1RfU1RSRUFNX0VS Uk9SKSB7CiAgICAgICAgICAgICBlcnJvciA9IE1lZGlhUGxheWVyOjpEZWNvZGVFcnJvcjsKICAg ICAgICAgICAgIGF0dGVtcHROZXh0TG9jYXRpb24gPSB0cnVlOwogICAgICAgICB9IGVsc2UgaWYg KGVyci0+ZG9tYWluID09IEdTVF9SRVNPVVJDRV9FUlJPUikK