171719 2017-05-05 02:04:52 -0700 Link drag images for apple.com front page links have a lot of spurious whitespace 2017-05-05 11:13:40 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 thorton thorton bdakin simon.fraser wenson_hsieh oldest_to_newest 1305046 0 thorton 2017-05-05 02:04:52 -0700 Link drag images for apple.com front page links have a lot of spurious whitespace 1305047 1 309153 thorton 2017-05-05 02:05:11 -0700 Created attachment 309153 Patch 1305058 2 309153 wenson_hsieh 2017-05-05 04:28:01 -0700 Comment on attachment 309153 Patch r=me! 1305211 3 thorton 2017-05-05 11:13:40 -0700 https://trac.webkit.org/changeset/216250/webkit 309153 2017-05-05 02:05:11 -0700 2017-05-05 04:28:01 -0700 Patch bug-171719-20170505020510.patch text/plain 3252 thorton U3VidmVyc2lvbiBSZXZpc2lvbjogMjE2MjM0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZDIyOWRjYTVkYjY5YWVk ZmZlMTNlMzAxNDhlYWQ3ZWQ3OWZiNWM1ZC4uNDEyYmQ2MWRiOTU3YmRiYWJhMDZlNWExMzAyMGI3 YWNhNmJmZGUyNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDE3LTA1LTA1ICBUaW0g SG9ydG9uICA8dGltb3RoeV9ob3J0b25AYXBwbGUuY29tPgorCisgICAgICAgIExpbmsgZHJhZyBp bWFnZXMgZm9yIGFwcGxlLmNvbSBmcm9udCBwYWdlIGxpbmtzIGhhdmUgYSBsb3Qgb2Ygc3B1cmlv dXMgd2hpdGVzcGFjZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MTcxNzE5CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS8zMjAxMDg1ND4KKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIHBhZ2UvRHJhZ0NvbnRy b2xsZXIuY3BwOgorICAgICAgICAoV2ViQ29yZTo6RHJhZ0NvbnRyb2xsZXI6OnN0YXJ0RHJhZyk6 CisgICAgICAgIFVzZSB0aGUgd2hpdGUtc3BhY2Utc2ltcGxpZmllZCBzdHJpbmcgdGhhdCB3ZSBw dXQgb24gdGhlIHBhc3RlYm9hcmQKKyAgICAgICAgZm9yIHRoZSBkcmFnIGltYWdlLCB0b28hCisK IDIwMTctMDUtMDQgIENvbW1pdCBRdWV1ZSAgPGNvbW1pdC1xdWV1ZUB3ZWJraXQub3JnPgogCiAg ICAgICAgIFVucmV2aWV3ZWQsIHJvbGxpbmcgb3V0IHIyMTYyMDYuCmRpZmYgLS1naXQgYS9Tb3Vy Y2UvV2ViQ29yZS9wYWdlL0RyYWdDb250cm9sbGVyLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BhZ2Uv RHJhZ0NvbnRyb2xsZXIuY3BwCmluZGV4IGRjYTVkNzY4MzA2ZDhhNzg4YWEzOTQyYzg3OGNlYThi YzVjMmNmN2EuLmQ4NGNkY2Q0ODY3OTQzNDEyMjQzZTQzNjY4ODU5OTYxYjgxMzYzMjUgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BhZ2UvRHJhZ0NvbnRyb2xsZXIuY3BwCisrKyBiL1NvdXJj ZS9XZWJDb3JlL3BhZ2UvRHJhZ0NvbnRyb2xsZXIuY3BwCkBAIC0xMDAxLDEzICsxMDAxLDE1IEBA IGJvb2wgRHJhZ0NvbnRyb2xsZXI6OnN0YXJ0RHJhZyhGcmFtZSYgc3JjLCBjb25zdCBEcmFnU3Rh dGUmIHN0YXRlLCBEcmFnT3BlcmF0aW9uCiAgICAgaWYgKCFsaW5rVVJMLmlzRW1wdHkoKSAmJiAo bV9kcmFnU291cmNlQWN0aW9uICYgRHJhZ1NvdXJjZUFjdGlvbkxpbmspKSB7CiAgICAgICAgIFBh c3RlYm9hcmRXcml0ZXJEYXRhIHBhc3RlYm9hcmRXcml0ZXJEYXRhOwogCisgICAgICAgIFN0cmlu ZyB0ZXh0Q29udGVudFdpdGhTaW1wbGlmaWVkV2hpdGVTcGFjZSA9IGhpdFRlc3RSZXN1bHQudGV4 dENvbnRlbnQoKS5zaW1wbGlmeVdoaXRlU3BhY2UoKTsKKwogICAgICAgICBpZiAoIWRhdGFUcmFu c2Zlci5wYXN0ZWJvYXJkKCkuaGFzRGF0YSgpKSB7CiAgICAgICAgICAgICAvLyBTaW1wbGlmeSB3 aGl0ZXNwYWNlIHNvIHRoZSB0aXRsZSBwdXQgb24gdGhlIGRhdGFUcmFuc2ZlciByZXNlbWJsZXMg d2hhdCB0aGUgdXNlciBzZWVzCiAgICAgICAgICAgICAvLyBvbiB0aGUgd2ViIHBhZ2UuIFRoaXMg aW5jbHVkZXMgcmVwbGFjaW5nIG5ld2xpbmVzIHdpdGggc3BhY2VzLgogICAgICAgICAgICAgaWYg KG11c3RVc2VMZWdhY3lEcmFnQ2xpZW50KQotICAgICAgICAgICAgICAgIHNyYy5lZGl0b3IoKS5j b3B5VVJMKGxpbmtVUkwsIGhpdFRlc3RSZXN1bHQudGV4dENvbnRlbnQoKS5zaW1wbGlmeVdoaXRl U3BhY2UoKSwgZGF0YVRyYW5zZmVyLnBhc3RlYm9hcmQoKSk7CisgICAgICAgICAgICAgICAgc3Jj LmVkaXRvcigpLmNvcHlVUkwobGlua1VSTCwgdGV4dENvbnRlbnRXaXRoU2ltcGxpZmllZFdoaXRl U3BhY2UsIGRhdGFUcmFuc2Zlci5wYXN0ZWJvYXJkKCkpOwogICAgICAgICAgICAgZWxzZQotICAg ICAgICAgICAgICAgIHBhc3RlYm9hcmRXcml0ZXJEYXRhLnNldFVSTChzcmMuZWRpdG9yKCkucGFz dGVib2FyZFdyaXRlclVSTChsaW5rVVJMLCBoaXRUZXN0UmVzdWx0LnRleHRDb250ZW50KCkuc2lt cGxpZnlXaGl0ZVNwYWNlKCkpKTsKKyAgICAgICAgICAgICAgICBwYXN0ZWJvYXJkV3JpdGVyRGF0 YS5zZXRVUkwoc3JjLmVkaXRvcigpLnBhc3RlYm9hcmRXcml0ZXJVUkwobGlua1VSTCwgdGV4dENv bnRlbnRXaXRoU2ltcGxpZmllZFdoaXRlU3BhY2UpKTsKICAgICAgICAgfSBlbHNlIHsKICAgICAg ICAgICAgIC8vIE1ha2Ugc3VyZSB0aGUgcGFzdGVib2FyZCBhbHNvIGNvbnRhaW5zIHRydXN0d29y dGh5IGxpbmsgZGF0YQogICAgICAgICAgICAgLy8gYnV0IGRvbid0IG92ZXJ3cml0ZSBtb3JlIGdl bmVyYWwgcGFzdGVib2FyZCB0eXBlcy4KQEAgLTEwMzEsNyArMTAzMyw3IEBAIGJvb2wgRHJhZ0Nv bnRyb2xsZXI6OnN0YXJ0RHJhZyhGcmFtZSYgc3JjLCBjb25zdCBEcmFnU3RhdGUmIHN0YXRlLCBE cmFnT3BlcmF0aW9uCiAgICAgICAgIG1fY2xpZW50LndpbGxQZXJmb3JtRHJhZ1NvdXJjZUFjdGlv bihEcmFnU291cmNlQWN0aW9uTGluaywgZHJhZ09yaWdpbiwgZGF0YVRyYW5zZmVyKTsKICAgICAg ICAgaWYgKCFkcmFnSW1hZ2UpIHsKICAgICAgICAgICAgIFRleHRJbmRpY2F0b3JEYXRhIHRleHRJ bmRpY2F0b3I7Ci0gICAgICAgICAgICBkcmFnSW1hZ2UgPSBEcmFnSW1hZ2UgeyBjcmVhdGVEcmFn SW1hZ2VGb3JMaW5rKGVsZW1lbnQsIGxpbmtVUkwsIGhpdFRlc3RSZXN1bHQudGV4dENvbnRlbnQo KSwgdGV4dEluZGljYXRvciwgc3JjLnNldHRpbmdzKCkuZm9udFJlbmRlcmluZ01vZGUoKSwgbV9w YWdlLmRldmljZVNjYWxlRmFjdG9yKCkpIH07CisgICAgICAgICAgICBkcmFnSW1hZ2UgPSBEcmFn SW1hZ2UgeyBjcmVhdGVEcmFnSW1hZ2VGb3JMaW5rKGVsZW1lbnQsIGxpbmtVUkwsIHRleHRDb250 ZW50V2l0aFNpbXBsaWZpZWRXaGl0ZVNwYWNlLCB0ZXh0SW5kaWNhdG9yLCBzcmMuc2V0dGluZ3Mo KS5mb250UmVuZGVyaW5nTW9kZSgpLCBtX3BhZ2UuZGV2aWNlU2NhbGVGYWN0b3IoKSkgfTsKICAg ICAgICAgICAgIGlmIChkcmFnSW1hZ2UpIHsKICAgICAgICAgICAgICAgICBJbnRTaXplIHNpemUg PSBkcmFnSW1hZ2VTaXplKGRyYWdJbWFnZS5nZXQoKSk7CiAgICAgICAgICAgICAgICAgbV9kcmFn T2Zmc2V0ID0gSW50UG9pbnQoLXNpemUud2lkdGgoKSAvIDIsIC1MaW5rRHJhZ0JvcmRlckluc2V0 KTsK