171717 2017-05-04 23:48:26 -0700 ASSERTION FAILED: !frame().document()->inRenderTreeUpdate() in WebCore::FrameView::layout(bool) 2017-05-05 11:39:35 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=171643 https://bugs.webkit.org/show_bug.cgi?id=171729 InRadar P2 Normal --- 1 ryanhaddad webkit-unassigned bfulgham buildbot cdumez commit-queue dbates japhet koivisto webkit-bug-importer zalan oldest_to_newest 1305033 0 ryanhaddad 2017-05-04 23:48:26 -0700 ASSERTION FAILED: !frame().document()->inRenderTreeUpdate() /Volumes/Data/slave/ios-simulator-10-debug/build/Source/WebCore/page/FrameView.cpp(1291) : void WebCore::FrameView::layout(bool) 1 0x1188c034d WTFCrash 2 0x1188c0369 WTFCrashWithSecurityImplication 3 0x11b63c578 WebCore::FrameView::layout(bool) 4 0x11b25f57c WebCore::Document::implicitClose() 5 0x11b60728b WebCore::FrameLoader::checkCallImplicitClose() 6 0x11b606f95 WebCore::FrameLoader::checkCompleted() 7 0x11b606ff5 WebCore::FrameLoader::loadDone() 8 0x11ada8949 WebCore::CachedResourceLoader::loadDone(bool) 9 0x11d2cfa98 WebCore::SubresourceLoader::notifyDone() 10 0x11d2cffe8 WebCore::SubresourceLoader::didCancel(WebCore::ResourceError const&) 11 0x11cf946d4 WebCore::ResourceLoader::cancel(WebCore::ResourceError const&) 12 0x11cf92adf WebCore::ResourceLoader::cancel() 13 0x11d2cd864 WebCore::SubresourceLoader::willSendRequestInternal(WebCore::ResourceRequest&, WebCore::ResourceResponse const&) 14 0x11cf9299c WebCore::ResourceLoader::init(WebCore::ResourceRequest const&) 15 0x11d2ccc07 WebCore::SubresourceLoader::init(WebCore::ResourceRequest const&) 16 0x11d2ccac3 WebCore::SubresourceLoader::create(WebCore::Frame&, WebCore::CachedResource&, WebCore::ResourceRequest const&, WebCore::ResourceLoaderOptions const&) 17 0x10e6e07fe WebKit::WebLoaderStrategy::loadResource(WebCore::Frame&, WebCore::CachedResource&, WebCore::ResourceRequest const&, WebCore::ResourceLoaderOptions const&) 18 0x11ad91f4c WebCore::CachedResource::load(WebCore::CachedResourceLoader&) 19 0x11ad80d34 WebCore::CachedImage::load(WebCore::CachedResourceLoader&) 20 0x11ada3f38 WebCore::CachedResourceLoader::requestResource(WebCore::CachedResource::Type, WebCore::CachedResourceRequest&&, WebCore::CachedResourceLoader::ForPreload, WebCore::CachedResourceLoader::DeferOption) 21 0x11ada2a41 WebCore::CachedResourceLoader::requestImage(WebCore::CachedResourceRequest&&) 22 0x11b0821bd WebCore::CSSImageValue::loadImage(WebCore::CachedResourceLoader&, WebCore::ResourceLoaderOptions const&) 23 0x11d24364a WebCore::StyleCachedImage::load(WebCore::CachedResourceLoader&, WebCore::ResourceLoaderOptions const&) 24 0x11d24d04e WebCore::Style::loadPendingImage(WebCore::Document&, WebCore::StyleImage const*, WebCore::Element const*, WebCore::Style::LoadPolicy) 25 0x11d24cd4d WebCore::Style::loadPendingResources(WebCore::RenderStyle&, WebCore::Document&, WebCore::Element const*) 26 0x11ccd0327 WebCore::RenderElement::getUncachedPseudoStyle(WebCore::PseudoStyleRequest const&, WebCore::RenderStyle const*, WebCore::RenderStyle const*) const 27 0x11ccc7955 WebCore::RenderElement::getCachedPseudoStyle(WebCore::PseudoId, WebCore::RenderStyle const*) const 28 0x11cf45509 WebCore::needsPseudoElement(WebCore::Element&, WebCore::PseudoId) 29 0x11cf4371a WebCore::RenderTreeUpdater::updateBeforeOrAfterPseudoElement(WebCore::Element&, WebCore::PseudoId) 30 0x11cf434db WebCore::RenderTreeUpdater::pushParent(WebCore::Element&, WebCore::Style::Change) 31 0x11cf42b42 WebCore::RenderTreeUpdater::updateRenderTree(WebCore::ContainerNode&) This assertion failure is seen with the following tests on iOS simulator: fast/ruby/before-block-doesnt-crash.html fast/ruby/before-table-doesnt-crash.html fast/ruby/generated-before-counter-doesnt-crash.html https://build.webkit.org/results/Apple%20iOS%2010%20Simulator%20Debug%20WK2%20(Tests)/r216233%20(1109)/results.html 1305045 1 309152 koivisto 2017-05-05 01:43:33 -0700 Created attachment 309152 patch 1305117 2 309152 bfulgham 2017-05-05 08:33:33 -0700 Comment on attachment 309152 patch View in context: https://bugs.webkit.org/attachment.cgi?id=309152&action=review lgtm. r=me. > Source/WebCore/loader/FrameLoader.cpp:796 > + // FIXME: It would be better if resource loads were kicked off after render tree update (or didn't complete synchronously). Can you file a Bugzilla for this and include the number here? 1305142 3 309175 koivisto 2017-05-05 09:18:56 -0700 Created attachment 309175 patch 1305154 4 webkit-bug-importer 2017-05-05 09:37:39 -0700 <rdar://problem/32017392> 1305228 5 309175 commit-queue 2017-05-05 11:39:33 -0700 Comment on attachment 309175 patch Clearing flags on attachment: 309175 Committed r216253: <http://trac.webkit.org/changeset/216253> 1305229 6 commit-queue 2017-05-05 11:39:35 -0700 All reviewed patches have been landed. Closing bug. 309152 2017-05-05 01:43:33 -0700 2017-05-05 09:18:56 -0700 patch check-complete-render-tree-update.patch text/plain 1414 koivisto SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDIxNjIzNikKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDE3LTA1LTA1ICBBbnR0aSBL b2l2aXN0byAgPGFudHRpQGFwcGxlLmNvbT4KKworICAgICAgICBBU1NFUlRJT04gRkFJTEVEOiAh ZnJhbWUoKS5kb2N1bWVudCgpLT5pblJlbmRlclRyZWVVcGRhdGUoKSBpbiBXZWJDb3JlOjpGcmFt ZVZpZXc6OmxheW91dChib29sKQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MTcxNzE3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgKiBsb2FkZXIvRnJhbWVMb2FkZXIuY3BwOgorICAgICAgICAoV2ViQ29yZTo6 RnJhbWVMb2FkZXI6OmNoZWNrQ29tcGxldGVkKToKKworICAgICAgICAgICAgRG9uJ3QgYWxsb3cg ZnJhbWUgbG9hZCB0byBjb21wbGV0ZSBpbiB0aGUgbWlkZGxlIG9mIGEgcmVuZGVyIHRyZWUgdXBk YXRlLiBJbnN0ZWFkIGRlbGF5IHRoZSBjaGVjay4KKwogMjAxNy0wNS0wNCAgQ29tbWl0IFF1ZXVl ICA8Y29tbWl0LXF1ZXVlQHdlYmtpdC5vcmc+CiAKICAgICAgICAgVW5yZXZpZXdlZCwgcm9sbGlu ZyBvdXQgcjIxNjIwNi4KSW5kZXg6IFNvdXJjZS9XZWJDb3JlL2xvYWRlci9GcmFtZUxvYWRlci5j cHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvbG9hZGVyL0ZyYW1lTG9hZGVyLmNwcAko cmV2aXNpb24gMjE2MTc5KQorKysgU291cmNlL1dlYkNvcmUvbG9hZGVyL0ZyYW1lTG9hZGVyLmNw cAkod29ya2luZyBjb3B5KQpAQCAtNzkzLDYgKzc5MywxMiBAQCB2b2lkIEZyYW1lTG9hZGVyOjpj aGVja0NvbXBsZXRlZCgpCiAgICAgaWYgKG1faXNDb21wbGV0ZSkKICAgICAgICAgcmV0dXJuOwog CisgICAgLy8gRklYTUU6IEl0IHdvdWxkIGJlIGJldHRlciBpZiByZXNvdXJjZSBsb2FkcyB3ZXJl IGtpY2tlZCBvZmYgYWZ0ZXIgcmVuZGVyIHRyZWUgdXBkYXRlIChvciBkaWRuJ3QgY29tcGxldGUg c3luY2hyb25vdXNseSkuCisgICAgaWYgKG1fZnJhbWUuZG9jdW1lbnQoKS0+aW5SZW5kZXJUcmVl VXBkYXRlKCkpIHsKKyAgICAgICAgc2NoZWR1bGVDaGVja0NvbXBsZXRlZCgpOworICAgICAgICBy ZXR1cm47CisgICAgfQorCiAgICAgLy8gQXJlIHdlIHN0aWxsIHBhcnNpbmc/CiAgICAgaWYgKG1f ZnJhbWUuZG9jdW1lbnQoKS0+cGFyc2luZygpKQogICAgICAgICByZXR1cm47Cg== 309175 2017-05-05 09:18:56 -0700 2017-05-05 11:39:33 -0700 patch check-complete-render-tree-update-2.patch text/plain 1475 koivisto SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDIxNjIzNikKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDE3LTA1LTA1ICBBbnR0aSBL b2l2aXN0byAgPGFudHRpQGFwcGxlLmNvbT4KKworICAgICAgICBBU1NFUlRJT04gRkFJTEVEOiAh ZnJhbWUoKS5kb2N1bWVudCgpLT5pblJlbmRlclRyZWVVcGRhdGUoKSBpbiBXZWJDb3JlOjpGcmFt ZVZpZXc6OmxheW91dChib29sKQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MTcxNzE3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgQnJlbnQgRnVsZ2hhbS4K KworICAgICAgICAqIGxvYWRlci9GcmFtZUxvYWRlci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpG cmFtZUxvYWRlcjo6Y2hlY2tDb21wbGV0ZWQpOgorCisgICAgICAgICAgICBEb24ndCBhbGxvdyBm cmFtZSBsb2FkIHRvIGNvbXBsZXRlIGluIHRoZSBtaWRkbGUgb2YgYSByZW5kZXIgdHJlZSB1cGRh dGUuIEluc3RlYWQgZGVsYXkgdGhlIGNoZWNrLgorCiAyMDE3LTA1LTA0ICBDb21taXQgUXVldWUg IDxjb21taXQtcXVldWVAd2Via2l0Lm9yZz4KIAogICAgICAgICBVbnJldmlld2VkLCByb2xsaW5n IG91dCByMjE2MjA2LgpJbmRleDogU291cmNlL1dlYkNvcmUvbG9hZGVyL0ZyYW1lTG9hZGVyLmNw cAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9sb2FkZXIvRnJhbWVMb2FkZXIuY3BwCShy ZXZpc2lvbiAyMTYxNzkpCisrKyBTb3VyY2UvV2ViQ29yZS9sb2FkZXIvRnJhbWVMb2FkZXIuY3Bw CSh3b3JraW5nIGNvcHkpCkBAIC03OTMsNiArNzkzLDEzIEBAIHZvaWQgRnJhbWVMb2FkZXI6OmNo ZWNrQ29tcGxldGVkKCkKICAgICBpZiAobV9pc0NvbXBsZXRlKQogICAgICAgICByZXR1cm47CiAK KyAgICAvLyBGSVhNRTogSXQgd291bGQgYmUgYmV0dGVyIGlmIHJlc291cmNlIGxvYWRzIHdlcmUg a2lja2VkIG9mZiBhZnRlciByZW5kZXIgdHJlZSB1cGRhdGUgKG9yIGRpZG4ndCBjb21wbGV0ZSBz eW5jaHJvbm91c2x5KS4KKyAgICAvLyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTE3MTcyOQorICAgIGlmIChtX2ZyYW1lLmRvY3VtZW50KCktPmluUmVuZGVy VHJlZVVwZGF0ZSgpKSB7CisgICAgICAgIHNjaGVkdWxlQ2hlY2tDb21wbGV0ZWQoKTsKKyAgICAg ICAgcmV0dXJuOworICAgIH0KKwogICAgIC8vIEFyZSB3ZSBzdGlsbCBwYXJzaW5nPwogICAgIGlm IChtX2ZyYW1lLmRvY3VtZW50KCktPnBhcnNpbmcoKSkKICAgICAgICAgcmV0dXJuOwo=