171713 2017-05-04 21:32:51 -0700 Web Automation: cookie-related commands don't work correctly 2022-03-01 02:37:33 -0800 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 bburg bburg bburg beidson inspector-bugzilla-changes webkit-bug-importer oldest_to_newest 1304997 0 bburg 2017-05-04 21:32:51 -0700 . 1304998 1 bburg 2017-05-04 21:33:04 -0700 <rdar://problem/29829930> 1304999 2 309142 bburg 2017-05-04 21:38:04 -0700 Created attachment 309142 Patch 1305005 3 309142 ap 2017-05-04 22:31:34 -0700 Comment on attachment 309142 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=309142&action=review > Source/WebKit2/UIProcess/Automation/WebAutomationSession.cpp:826 > + if (error != CallbackBase::Error::None) > + callback->sendFailure(STRING_FOR_PREDEFINED_ERROR_NAME(InternalError)); > + else > + callback->sendSuccess(); It seems slightly better to start with success case - avoiding negation makes code a bit easier to understand. 1305258 4 bburg 2017-05-05 12:31:27 -0700 Committed r216261: <http://trac.webkit.org/changeset/216261> 309142 2017-05-04 21:38:04 -0700 2022-03-01 02:37:33 -0800 Patch bug-171713-20170504213803.patch text/plain 3174 bburg U3VidmVyc2lvbiBSZXZpc2lvbjogMjE2MjMyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggNGExNzc0NTcwMzZhNGYy NzI2ZTg4YTNjZWQxMmYyMWYxZDJkYjMzYi4uZGE1NDNjY2VjNzkyMGQxMjc5NWYyMTBiMDBiMjRj NTg1ZDUyZjVhZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDI1IEBACiAyMDE3LTA1LTA0ICBCcmlh biBCdXJnICA8YmJ1cmdAYXBwbGUuY29tPgogCisgICAgICAgIFdlYiBBdXRvbWF0aW9uOiBjb29r aWUtcmVsYXRlZCBjb21tYW5kcyBkb24ndCB3b3JrIGNvcnJlY3RseQorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTcxNzEzCisgICAgICAgIDxyZGFyOi8v cHJvYmxlbS8yOTgyOTkzMD4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICBDb21tYW5kcyB0aGF0IHVzZSBXZWJDb29raWVNYW5hZ2VyIGRpcmVjdGx5IHNo b3VsZCBjb21wbGV0ZSB3aGVuCisgICAgICAgIHRoZSBtYW5hZ2VyJ3MgY29tcGxldGlvbiBoYW5k bGVyIGlzIGNhbGxlZC4gT3RoZXJ3aXNlLCB0aGlzIHdpbGwgcmFjZQorICAgICAgICB3aXRoIHN1 YnNlcXVlbnQgYWNjZXNzZXMgdG8gY29va2llcyB2aWEgdGhlIHdlYiBwcm9jZXNzIChkb2N1bWVu dC5jb29raWUpLgorCisgICAgICAgIEFsc28sIHRoZXNlIGNvbW1hbmRzIG5lZWQgdG8gdXNlIHRo ZSBhY3RpdmUgYnJvd3NpbmcgY29udGV4dCdzIHNlc3Npb24gSUQuCisgICAgICAgIFRoZXkgY3Vy cmVudGx5IHVzZSB0aGUgcHJvY2VzcyBwb29sJ3Mgc3RvcmFnZSBzZXNzaW9uLCB3aGljaCBpcyB3 cm9uZworICAgICAgICBzaW5jZSB3ZSBzcGVjaWFsbHkgY29uZmlndXJlIGF1dG9tYXRpb24gaW5z dGFuY2VzIHdpdGggYW4gZXBoZW1lcmFsIHN0b3JlLgorCisgICAgICAgICogVUlQcm9jZXNzL0F1 dG9tYXRpb24vV2ViQXV0b21hdGlvblNlc3Npb24uY3BwOgorICAgICAgICAoV2ViS2l0OjpXZWJB dXRvbWF0aW9uU2Vzc2lvbjo6YWRkU2luZ2xlQ29va2llKToKKyAgICAgICAgKFdlYktpdDo6V2Vi QXV0b21hdGlvblNlc3Npb246OmRlbGV0ZUFsbENvb2tpZXMpOgorCisyMDE3LTA1LTA0ICBCcmlh biBCdXJnICA8YmJ1cmdAYXBwbGUuY29tPgorCiAgICAgICAgIENyYXNoVHJhY2VyOiBbVVNFUl0g Y29tLmFwcGxlLldlYktpdC5XZWJDb250ZW50LkRldmVsb3BtZW50IGF0IGNvbS5hcHBsZS5XZWJD b3JlOiBXZWJDb3JlOjpjb21tb25WTVNsb3cgKyA1NwogICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTcxNjY5CiAgICAgICAgIDxyZGFyOi8vcHJvYmxlbS8z MTk2NzY4ND4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BdXRvbWF0aW9u L1dlYkF1dG9tYXRpb25TZXNzaW9uLmNwcCBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BdXRv bWF0aW9uL1dlYkF1dG9tYXRpb25TZXNzaW9uLmNwcAppbmRleCBmOWY5ZGYyMDgyZDI4NjYxOThi ZWFiNzQ0ZDdiNjI4NDRjZTUyYTZkLi5iM2NiNzAwNDI0NWQ3NTU5MzFkOGI4YzU2ZjVlYjI2ZTll MGE1MTQ3IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQXV0b21hdGlvbi9X ZWJBdXRvbWF0aW9uU2Vzc2lvbi5jcHAKKysrIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0F1 dG9tYXRpb24vV2ViQXV0b21hdGlvblNlc3Npb24uY3BwCkBAIC04MTksOSArODE5LDEyIEBAIHZv aWQgV2ViQXV0b21hdGlvblNlc3Npb246OmFkZFNpbmdsZUNvb2tpZShFcnJvclN0cmluZyYgZXJy b3JTdHJpbmcsIGNvbnN0IFN0cmluCiAKICAgICAvLyBGSVhNRTogVXNpbmcgYWN0aXZlVVJMIGhl cmUgdHdpY2UgaXMgYmFzaWNhbGx5IHNheWluZyAidGhpcyBpcyBhbHdheXMgaW4gdGhlIGNvbnRl eHQgb2YgdGhlIG1haW4gZG9jdW1lbnQiCiAgICAgLy8gd2hpY2ggcHJvYmFibHkgaXNuJ3QgYWNj dXJhdGUuCi0gICAgY29va2llTWFuYWdlci0+c2V0Q29va2llcyhXZWJDb3JlOjpTZXNzaW9uSUQ6 OmRlZmF1bHRTZXNzaW9uSUQoKSwgeyBjb29raWUgfSwgYWN0aXZlVVJMLCBhY3RpdmVVUkwsIFtd KENhbGxiYWNrQmFzZTo6RXJyb3Ipe30pOwotCi0gICAgY2FsbGJhY2stPnNlbmRTdWNjZXNzKCk7 CisgICAgY29va2llTWFuYWdlci0+c2V0Q29va2llcyhwYWdlLT53ZWJzaXRlRGF0YVN0b3JlKCku c2Vzc2lvbklEKCksIHsgY29va2llIH0sIGFjdGl2ZVVSTCwgYWN0aXZlVVJMLCBbY2FsbGJhY2sg PSBjYWxsYmFjay5jb3B5UmVmKCldKENhbGxiYWNrQmFzZTo6RXJyb3IgZXJyb3IpIHsKKyAgICAg ICAgaWYgKGVycm9yICE9IENhbGxiYWNrQmFzZTo6RXJyb3I6Ok5vbmUpCisgICAgICAgICAgICBj YWxsYmFjay0+c2VuZEZhaWx1cmUoU1RSSU5HX0ZPUl9QUkVERUZJTkVEX0VSUk9SX05BTUUoSW50 ZXJuYWxFcnJvcikpOworICAgICAgICBlbHNlCisgICAgICAgICAgICBjYWxsYmFjay0+c2VuZFN1 Y2Nlc3MoKTsKKyAgICB9KTsKIH0KIAogdm9pZCBXZWJBdXRvbWF0aW9uU2Vzc2lvbjo6ZGVsZXRl QWxsQ29va2llcyhFcnJvclN0cmluZyYgZXJyb3JTdHJpbmcsIGNvbnN0IFN0cmluZyYgYnJvd3Np bmdDb250ZXh0SGFuZGxlKQpAQCAtODM0LDcgKzgzNyw3IEBAIHZvaWQgV2ViQXV0b21hdGlvblNl c3Npb246OmRlbGV0ZUFsbENvb2tpZXMoRXJyb3JTdHJpbmcmIGVycm9yU3RyaW5nLCBjb25zdCBT dHJpCiAgICAgQVNTRVJUKGFjdGl2ZVVSTC5pc1ZhbGlkKCkpOwogCiAgICAgV2ViQ29va2llTWFu YWdlclByb3h5KiBjb29raWVNYW5hZ2VyID0gbV9wcm9jZXNzUG9vbC0+c3VwcGxlbWVudDxXZWJD b29raWVNYW5hZ2VyUHJveHk+KCk7Ci0gICAgY29va2llTWFuYWdlci0+ZGVsZXRlQ29va2llc0Zv ckhvc3RuYW1lKFdlYkNvcmU6OlNlc3Npb25JRDo6ZGVmYXVsdFNlc3Npb25JRCgpLCBhY3RpdmVV UkwuaG9zdCgpKTsKKyAgICBjb29raWVNYW5hZ2VyLT5kZWxldGVDb29raWVzRm9ySG9zdG5hbWUo cGFnZS0+d2Vic2l0ZURhdGFTdG9yZSgpLnNlc3Npb25JRCgpLCBhY3RpdmVVUkwuaG9zdCgpKTsK IH0KIAogI2lmIFVTRShBUFBLSVQpIHx8IFBMQVRGT1JNKEdUSykK