171699 2017-05-04 15:55:37 -0700 Ensure a good experience for ARES-6 error reporting 2017-06-01 22:55:52 -0700 1 1 1 Unclassified WebKit WebKit Website Other Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 jond saam buildbot cdumez fpizlo jond rniwa saam oldest_to_newest 1304875 0 jond 2017-05-04 15:55:37 -0700 We should make sure ARES-6 does a good job of reporting errors to users. 1314370 1 saam 2017-05-31 15:31:04 -0700 I'll try to fix this. 1314746 2 311736 saam 2017-06-01 11:44:14 -0700 Created attachment 311736 patch 1314805 3 rniwa 2017-06-01 13:42:18 -0700 Note that in order to update the content in browserbench.org, you have to manually update the contents in Websites/browserbench.org. 1314806 4 saam 2017-06-01 13:43:27 -0700 (In reply to Ryosuke Niwa from comment #3) > Note that in order to update the content in browserbench.org, you have to > manually update the contents in Websites/browserbench.org. Thanks for letting me know, I'll copy the changes over. 1314976 5 saam 2017-06-01 22:55:52 -0700 landed in: https://trac.webkit.org/changeset/217701/webkit 311736 2017-06-01 11:44:14 -0700 2017-06-01 12:16:28 -0700 patch a-backup.diff text/plain 6143 saam SW5kZXg6IFBlcmZvcm1hbmNlVGVzdHMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFBlcmZvcm1h bmNlVGVzdHMvQ2hhbmdlTG9nCShyZXZpc2lvbiAyMTc2NjkpCisrKyBQZXJmb3JtYW5jZVRlc3Rz L0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDM5IEBACisyMDE3LTA2LTAxICBT YWFtIEJhcmF0aSAgPHNiYXJhdGlAYXBwbGUuY29tPgorCisgICAgICAgIEVuc3VyZSBhIGdvb2Qg ZXhwZXJpZW5jZSBmb3IgQVJFUy02IGVycm9yIHJlcG9ydGluZworICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTcxNjk5CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhpcyBwYXRjaCBmaXhlcyBhIGJ1ZyB3aGVy ZSB3ZSB3b3VsZCBzaWxlbnRseSBmYWlsLiBUaGUgYnVnCisgICAgICAgIHdhcyB0aGF0IHdlIHdl cmUgY2FsbGluZyByZXBvcnRFcnJvciB3aXRoIHRoZSB3cm9uZyB8dGhpc3wgdmFsdWUuCisgICAg ICAgIEkgYWxzbyBjbGVhbmVkIHVwIGEgYml0IG9mIHRoZSBjb2RlIGFyb3VuZCBlcnJvciByZXBv cnRpbmcuIFdlCisgICAgICAgIG5vdyBpbmRpY2F0ZSB3aGljaCB0ZXN0IGZhaWxlZCwgYW5kIHVw ZGF0ZSB0aGUgc3RhdHVzIHRvIHJlZmxlY3QKKyAgICAgICAgdGhhdCBhIGZhaWx1cmUgaGFwcGVu ZWQuCisgICAgICAgIAorICAgICAgICBUaGlzIHBhdGNoIGFsc28gbW9kaWZpZXMgdGhlIENTUyBh IGJpdCB0byB3b3JrIGJldHRlciBvbiBzbWFsbGVyCisgICAgICAgIHNjcmVlbmVkIGRldmljZXMu IFRoZSBDU1MgcHJldmVudHMgdGhlIHN0YXR1cyBmcm9tIGhhdmluZyBhIGxpbmUKKyAgICAgICAg YnJlYWsgYm90aCB3aGVuIGFuIGVycm9yIGlzIHJlcG9ydGVkIGFuZCB3aGVuIHdlJ3JlIHJ1bm5p bmcgdGhlIAorICAgICAgICBiZW5jaG1hcmsuCisKKyAgICAgICAgKiBBUkVTLTYvZHJpdmVyLmpz OgorICAgICAgICAoRHJpdmVyKToKKyAgICAgICAgKERyaXZlci5wcm90b3R5cGUucmVwb3J0RXJy b3IpOgorICAgICAgICAqIEFSRVMtNi9yZXN1bHRzLmpzOgorICAgICAgICAoUmVzdWx0cy5wcm90 b3R5cGUucmVwb3J0RXJyb3IpOgorICAgICAgICAoUmVzdWx0cyk6CisgICAgICAgICogQVJFUy02 L3N0eWxlcy5jc3M6CisgICAgICAgICguc3RhcnQpOgorICAgICAgICAoI3N0YXR1cyk6CisgICAg ICAgICguZmFpbGVkKToKKyAgICAgICAgKCNzdGF0dXMuZmFpbGVkKToKKyAgICAgICAgKC50ZXN0 IC5mYWlsZWQ6YmVmb3JlKToKKyAgICAgICAgKCNtYWdpYyk6CisgICAgICAgIChAbWVkaWEgb25s eSBzY3JlZW4gYW5kIChtYXgtd2lkdGg6IDc4NHB4KSk6CisgICAgICAgICgudGVzdCk6CisgICAg ICAgIChwKToKKyAgICAgICAgKEBtZWRpYSBvbmx5IHNjcmVlbiBhbmQgKG1heC13aWR0aDogMzIw cHgpKToKKwogMjAxNy0wNS0xOSAgUnlvc3VrZSBOaXdhICA8cm5pd2FAd2Via2l0Lm9yZz4KIAog ICAgICAgICBSRUdSRVNTSU9OKHIyMTcxMTgpOiBTcGVlZG9tZXRlciAyLjA6IEZsaWdodC5qcyB0 ZXN0IGlzIGJyb2tlbgpJbmRleDogUGVyZm9ybWFuY2VUZXN0cy9BUkVTLTYvZHJpdmVyLmpzCj09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT0KLS0tIFBlcmZvcm1hbmNlVGVzdHMvQVJFUy02L2RyaXZlci5qcwkocmV2aXNpb24g MjE3NjYyKQorKysgUGVyZm9ybWFuY2VUZXN0cy9BUkVTLTYvZHJpdmVyLmpzCSh3b3JraW5nIGNv cHkpCkBAIC0zNCw3ICszNCw2IEBAIGNsYXNzIERyaXZlciB7CiAgICAgICAgIHRoaXMuX21hZ2lj Q2VsbCA9IG1hZ2ljQ2VsbDsKICAgICAgICAgdGhpcy5fc3VtbWFyeSA9IG5ldyBTdGF0cyhzdW1t YXJ5Q2VsbCwgInN1bW1hcnkiKTsKICAgICAgICAgdGhpcy5fa2V5ID0ga2V5OwotICAgICAgICB0 aGlzLl9oYWRFcnJvcnMgPSBmYWxzZTsKICAgICAgICAgaWYgKGlzSW5Ccm93c2VyKQogICAgICAg ICAgICAgd2luZG93W2tleV0gPSB0aGlzOwogICAgIH0KQEAgLTgzLDEwICs4MiwxNiBAQCBjbGFz cyBEcml2ZXIgewogICAgIAogICAgIHJlcG9ydEVycm9yKC4uLmFyZ3MpCiAgICAgeworICAgICAg ICBpZiAoaXNJbkJyb3dzZXIpCisgICAgICAgICAgICBjb25zb2xlLmxvZygiRXJyb3IgZW5jb3Vu dGVyZWQ6ICIsIC4uLmFyZ3MpOworCiAgICAgICAgIHRoaXMuX2JlbmNobWFya3MuZ2V0KHRoaXMu X2JlbmNobWFyaykucmVwb3J0RXJyb3IoLi4uYXJncyk7Ci0gICAgICAgIHRoaXMuX3JlY29tcHV0 ZVN1bW1hcnkoKTsKLSAgICAgICAgdGhpcy5faGFkRXJyb3JzID0gdHJ1ZTsKLSAgICAgICAgdGhp cy5faXRlcmF0ZSgpOworCisgICAgICAgIGlmIChpc0luQnJvd3NlcikgeworICAgICAgICAgICAg dGhpcy5fc3RhdHVzQ2VsbC5pbm5lckhUTUwgPSAiVGVzdCBmYWlsdXJlIFx1MjAxNCBlcnJvciBp biBjb25zb2xlIjsKKyAgICAgICAgICAgIHRoaXMuX3N0YXR1c0NlbGwuY2xhc3NMaXN0LmFkZCgi ZmFpbGVkIik7CisgICAgICAgIH0gZWxzZQorICAgICAgICAgICAgcHJpbnQoIlRlc3QgZmFpbHVy ZSIpOwogICAgIH0KICAgICAKICAgICBfcmVjb21wdXRlU3VtbWFyeSgpCkBAIC0xMzcsMTEgKzE0 MiwxMCBAQCBjbGFzcyBEcml2ZXIgewogICAgICAgICBpZiAoIXRoaXMuX2JlbmNobWFyaykgewog ICAgICAgICAgICAgaWYgKCF0aGlzLl9udW1JdGVyYXRpb25zKSB7CiAgICAgICAgICAgICAgICAg aWYgKGlzSW5Ccm93c2VyKSB7Ci0gICAgICAgICAgICAgICAgICAgIHRoaXMuX3N0YXR1c0NlbGwu aW5uZXJIVE1MID0KLSAgICAgICAgICAgICAgICAgICAgICAgICh0aGlzLl9oYWRFcnJvcnMgPyAi RmFpbHVyZXMgZW5jb3VudGVyZWQhIiA6ICJSZXN0YXJ0Iik7CisgICAgICAgICAgICAgICAgICAg IHRoaXMuX3N0YXR1c0NlbGwuaW5uZXJIVE1MID0gIlJlc3RhcnQiOwogICAgICAgICAgICAgICAg ICAgICB0aGlzLnJlYWR5VHJpZ2dlcigpOwogICAgICAgICAgICAgICAgIH0gZWxzZQotICAgICAg ICAgICAgICAgICAgICBwcmludCh0aGlzLl9oYWRFcnJvcnMgPyAiRmFpbHVyZXMgZW5jb3VudGVy ZWQhIiA6ICJTdWNjZXNzISBCZW5jaG1hcmsgaXMgbm93IGZpbmlzaGVkLiIpOworICAgICAgICAg ICAgICAgICAgICBwcmludCgiU3VjY2VzcyEgQmVuY2htYXJrIGlzIG5vdyBmaW5pc2hlZC4iKTsK ICAgICAgICAgICAgICAgICByZXR1cm47CiAgICAgICAgICAgICB9CiAgICAgICAgICAgICB0aGlz Ll9udW1JdGVyYXRpb25zLS07CkBAIC0xNjUsNyArMTY5LDcgQEAgY2xhc3MgRHJpdmVyIHsKICAg ICAgICAgICAgICAgICBtYWdpY0ZyYW1lLmNvbnRlbnREb2N1bWVudC5vcGVuKCk7CiAgICAgICAg ICAgICAgICAgbWFnaWNGcmFtZS5jb250ZW50RG9jdW1lbnQud3JpdGUoCiAgICAgICAgICAgICAg ICAgICAgIGA8IURPQ1RZUEUgaHRtbD48aGVhZD48dGl0bGU+YmVuY2htYXJrIHBheWxvYWQ8L3Rp dGxlPjwvaGVhZD48Ym9keT48c2NyaXB0PmAgKwotICAgICAgICAgICAgICAgICAgICBgd2luZG93 Lm9uZXJyb3IgPSB0b3AuJHt0aGlzLl9rZXl9LnJlcG9ydEVycm9yO1xuYCArCisgICAgICAgICAg ICAgICAgICAgIGB3aW5kb3cub25lcnJvciA9IHRvcC4ke3RoaXMuX2tleX0ucmVwb3J0RXJyb3Iu YmluZCh0b3AuJHt0aGlzLl9rZXl9KTtcbmAgKwogICAgICAgICAgICAgICAgICAgICBgZnVuY3Rp b24gcmVwb3J0UmVzdWx0KClcbmAgKwogICAgICAgICAgICAgICAgICAgICBge1xuYCArCiAgICAg ICAgICAgICAgICAgICAgIGAgICAgdmFyIGRyaXZlciA9IHRvcC4ke3RoaXMuX2tleX07XG5gICsK SW5kZXg6IFBlcmZvcm1hbmNlVGVzdHMvQVJFUy02L3Jlc3VsdHMuanMKPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0g UGVyZm9ybWFuY2VUZXN0cy9BUkVTLTYvcmVzdWx0cy5qcwkocmV2aXNpb24gMjE3NjYyKQorKysg UGVyZm9ybWFuY2VUZXN0cy9BUkVTLTYvcmVzdWx0cy5qcwkod29ya2luZyBjb3B5KQpAQCAtNjYs MTAgKzY2LDExIEBAIGNsYXNzIFJlc3VsdHMgewogICAgIAogICAgIHJlcG9ydEVycm9yKG1lc3Nh Z2UsIHVybCwgbGluZU51bWJlcikKICAgICB7Ci0gICAgICAgIGZvciAobGV0IHN1YlJlc3VsdCBv ZiBSZXN1bHRzLnN1YlJlc3VsdHMpCi0gICAgICAgICAgICB0aGlzW3N1YlJlc3VsdF0ucmVwb3J0 UmVzdWx0KFN0YXRzLmVycm9yKTsKLSAgICAgICAgaWYgKGlzSW5Ccm93c2VyKQotICAgICAgICAg ICAgdGhpcy5fYmVuY2htYXJrLmNlbGxzLm1lc3NhZ2UuaW5uZXJIVE1MID0gdXJsICsgIjoiICsg bGluZU51bWJlciArICI6ICIgKyBtZXNzYWdlOworICAgICAgICBpZiAoaXNJbkJyb3dzZXIpIHsK KyAgICAgICAgICAgIHRoaXMuX2JlbmNobWFyay5jZWxscy5tZXNzYWdlLmNsYXNzTGlzdC5yZW1v dmUoJ3J1bm5pbmcnKTsKKyAgICAgICAgICAgIHRoaXMuX2JlbmNobWFyay5jZWxscy5tZXNzYWdl LmNsYXNzTGlzdC5hZGQoJ2ZhaWxlZCcpOworICAgICAgICB9IGVsc2UKKyAgICAgICAgICAgIHBy aW50KCJGYWlsZWQgcnVubmluZyBiZW5jaG1hcmsiKTsKICAgICB9CiB9CiAKSW5kZXg6IFBlcmZv cm1hbmNlVGVzdHMvQVJFUy02L3N0eWxlcy5jc3MKPT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gUGVyZm9ybWFuY2VU ZXN0cy9BUkVTLTYvc3R5bGVzLmNzcwkocmV2aXNpb24gMjE3NjYyKQorKysgUGVyZm9ybWFuY2VU ZXN0cy9BUkVTLTYvc3R5bGVzLmNzcwkod29ya2luZyBjb3B5KQpAQCAtOTEsNyArOTEsNiBAQCBw IHsKICAgICBiYWNrZ3JvdW5kLWNvbG9yOiB0cmFuc3BhcmVudDsKICAgICBib3JkZXI6IDVweCBz b2xpZCAjRTdCMTM1OwogICAgIGZvbnQtc2l6ZTogMi40cmVtOwotICAgIGxpbmUtaGVpZ2h0OiA1 LjRyZW07CiAgICAgZm9udC13ZWlnaHQ6IDYwMDsKICAgICB0ZXh0LXRyYW5zZm9ybTogdXBwZXJj YXNlOwogICAgIGNvbG9yOiAjRTdCMTM1OwpAQCAtMTU5LDYgKzE1OCwyMiBAQCBwIHsKICAgICBj b2xvcjogI2ZmZmZmZjsKIH0KIAorI3N0YXR1cyB7CisgICAgbGluZS1oZWlnaHQ6IDUuNHJlbTsK K30KKworLmZhaWxlZCB7CisgICAgY29sb3I6ICNmZjU3NDQ7Cit9CisKKyNzdGF0dXMuZmFpbGVk IHsKKyAgICBmb250LXNpemU6IDEuNXJlbTsKK30KKworLnRlc3QgLmZhaWxlZDpiZWZvcmUgewor ICAgIGNvbnRlbnQ6ICdcMjcxNic7Cit9CisKIC50ZXN0IC5ydW5uaW5nOmJlZm9yZSB7CiAgICAg Y29udGVudDogJ1wyNWI4JzsKIH0KQEAgLTI0OSw2ICsyNjQsMTAgQEAgcCB7CiAgICAgYm9yZGVy LWxlZnQ6IDAgc29saWQgdHJhbnNwYXJlbnQ7CiB9CiAKKyNtYWdpYyB7CisgICAgb3BhY2l0eTog MDsKK30KKwogQGtleWZyYW1lcyBmYWRlLWluIHsKICAgMCUgICB7IG9wYWNpdHk6IDA7IH0KICAg MTAwJSB7IG9wYWNpdHk6IDE7IH0KQEAgLTI4NCwxMCArMzAzLDM1IEBAIHAgewogICAgIC5zdGFy dCB7CiAgICAgICAgIHdpZHRoOiAxMDAlOwogICAgIH0KLQogICAgIC50ZXN0IHsKICAgICAgICAg ZmxleDogbm9uZTsKLQogICAgICAgICB3aWR0aDogMTAwJTsKICAgICB9CisgICAgI3N0YXR1cyB7 CisgICAgICAgIGxpbmUtaGVpZ2h0OiA0LjNyZW07CisgICAgfQorICAgIC5zdGFydCB7CisgICAg ICAgIGZvbnQtc2l6ZTogMi4xcmVtOworICAgIH0KKyAgICAjc3RhdHVzLmZhaWxlZCB7CisgICAg ICAgIGZvbnQtc2l6ZTogMS40cmVtOworICAgIH0KKyAgICBwIHsKKyAgICAgICAgZm9udC1zaXpl OiAxLjZyZW07CisgICAgfQorfQorCitAbWVkaWEgb25seSBzY3JlZW4gYW5kIChtYXgtd2lkdGg6 IDMyMHB4KSB7CisgICAgI3N0YXR1cyB7CisgICAgICAgIGxpbmUtaGVpZ2h0OiAzLjhyZW07Cisg ICAgfQorICAgIC5zdGFydCB7CisgICAgICAgIGZvbnQtc2l6ZTogMS45cmVtOworICAgIH0KKyAg ICAjc3RhdHVzLmZhaWxlZCB7CisgICAgICAgIGZvbnQtc2l6ZTogMS4xcmVtOworICAgIH0KKyAg ICBwIHsKKyAgICAgICAgZm9udC1zaXplOiAxLjRyZW07CisgICAgfQogfQo=