171697 2017-05-04 15:45:25 -0700 REGRESSION(r216138): Web Inspector: ASSERT(!content.isNull()) when checking for source map url opening inspector 2017-05-04 16:04:57 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 joepeck joepeck bburg commit-queue inspector-bugzilla-changes joepeck mattbaker webkit-bug-importer oldest_to_newest 1304868 0 joepeck 2017-05-04 15:45:25 -0700 Summary: ASSERT(!content.isNull()) when checking for source map url opening inspector Regressed with r216138 which returned String() instead of emptyString(). Steps to Reproduce: 1. Inspect netflix.com => ASSERT Crashes in Release: Thread 0 Crashed:: Dispatch queue: com.apple.main-thread 0 JSC::Yarr::interpret(JSC::Yarr::BytecodePattern*, WTF::String const&, unsigned int, unsigned int*) + 11 1 Inspector::ContentSearchUtilities::findStylesheetSourceMapURL(WTF::String const&) + 375 2 WebCore::InspectorPageAgent::sourceMapURLForResource(WebCore::CachedResource*) + 350 3 WebCore::InspectorPageAgent::buildObjectForFrameTree(WebCore::Frame*) + 988 4 non-virtual thunk to WebCore::InspectorPageAgent::getResourceTree(WTF::String&, WTF::RefPtr<Inspector::Protocol::Page::FrameResourceTree>&) + 33 5 Inspector::PageBackendDispatcher::getResourceTree(long, WTF::RefPtr<Inspector::InspectorObject>&&) + 93 6 Inspector::PageBackendDispatcher::dispatch(long, WTF::String const&, WTF::Ref<Inspector::InspectorObject>&&) + 570 1304869 1 joepeck 2017-05-04 15:45:33 -0700 <rdar://problem/31999512> 1304871 2 309108 joepeck 2017-05-04 15:47:29 -0700 Created attachment 309108 [PATCH] Proposed Fix 1304877 3 309108 mattbaker 2017-05-04 15:56:55 -0700 Comment on attachment 309108 [PATCH] Proposed Fix r=me 1304879 4 309108 bburg 2017-05-04 15:59:23 -0700 Comment on attachment 309108 [PATCH] Proposed Fix r=mews too 1304883 5 joepeck 2017-05-04 16:04:57 -0700 <https://trac.webkit.org/r216215> 309108 2017-05-04 15:47:29 -0700 2017-05-04 15:59:11 -0700 [PATCH] Proposed Fix assert-1.patch text/plain 1717 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBjNDFjNDEzMDkyYy4uMjc4YWM5ZTFlNTQgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNiBAQAorMjAxNy0wNS0wNCAgSm9zZXBoIFBlY29yYXJvICA8cGVjb3Jhcm9AYXBwbGUu Y29tPgorCisgICAgICAgIFJFR1JFU1NJT04ocjIxNjEzOCk6IFdlYiBJbnNwZWN0b3I6IEFTU0VS VCghY29udGVudC5pc051bGwoKSkgd2hlbiBjaGVja2luZyBmb3Igc291cmNlIG1hcCB1cmwgb3Bl bmluZyBpbnNwZWN0b3IKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTE3MTY5NworICAgICAgICA8cmRhcjovL3Byb2JsZW0vMzE5OTk1MTI+CisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBpbnNwZWN0b3IvSW5z cGVjdG9yUGFnZUFnZW50LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6Okluc3BlY3RvclBhZ2VBZ2Vu dDo6Y2FjaGVkUmVzb3VyY2VDb250ZW50KToKKyAgICAgICAgQWx3YXlzIHNldCBiYXNlNjRFbmNv ZGVkIHdoZW4gcmV0dXJuaW5nIHRydWUuIFJldHVybiB0aGUgZW1wdHkKKyAgICAgICAgc3RyaW5n IGluc3RlYWQgb2YgYSBudWxsIHN0cmluZyBtYXRjaGluZyBwcmV2aW91cyBiZWhhdmlvci4KKwog MjAxNy0wNS0wNCAgSmVyZW15IEpvbmVzICA8amVyZW15akBhcHBsZS5jb20+CiAKICAgICAgICAg Q3Jhc2ggd2hlbiBwb2ludGVyIGxvY2sgZWxlbWVudCBpcyByZW1vdmVkIGJlZm9yZSBwb2ludGVy IGxvY2sgYWxsb3dlZCBhcnJpdmVzLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvaW5zcGVj dG9yL0luc3BlY3RvclBhZ2VBZ2VudC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvSW5z cGVjdG9yUGFnZUFnZW50LmNwcAppbmRleCA1YmNhMzFlMjZiMC4uMTJjODkyOGY1MWEgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9JbnNwZWN0b3JQYWdlQWdlbnQuY3BwCisr KyBiL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9JbnNwZWN0b3JQYWdlQWdlbnQuY3BwCkBAIC0x MTUsMTIgKzExNSwxMyBAQCBib29sIEluc3BlY3RvclBhZ2VBZ2VudDo6Y2FjaGVkUmVzb3VyY2VD b250ZW50KENhY2hlZFJlc291cmNlKiBjYWNoZWRSZXNvdXJjZSwgUwogICAgIGlmICghY2FjaGVk UmVzb3VyY2UpCiAgICAgICAgIHJldHVybiBmYWxzZTsKIAotICAgIGlmICghY2FjaGVkUmVzb3Vy Y2UtPmVuY29kZWRTaXplKCkpIHsKLSAgICAgICAgKnJlc3VsdCA9IFN0cmluZygpOwotICAgICAg ICByZXR1cm4gdHJ1ZTsKLSAgICB9Ci0KICAgICAqYmFzZTY0RW5jb2RlZCA9ICFoYXNUZXh0Q29u dGVudChjYWNoZWRSZXNvdXJjZSk7CisKKyAgICBpZiAoIWNhY2hlZFJlc291cmNlLT5lbmNvZGVk U2l6ZSgpKSB7CisgICAgICAgICpyZXN1bHQgPSBlbXB0eVN0cmluZygpOworICAgICAgICByZXR1 cm4gdHJ1ZTsKKyAgICB9CisKICAgICBpZiAoKmJhc2U2NEVuY29kZWQpIHsKICAgICAgICAgaWYg KGF1dG8qIGJ1ZmZlciA9IGNhY2hlZFJlc291cmNlLT5yZXNvdXJjZUJ1ZmZlcigpKSB7CiAgICAg ICAgICAgICAqcmVzdWx0ID0gYmFzZTY0RW5jb2RlKGJ1ZmZlci0+ZGF0YSgpLCBidWZmZXItPnNp emUoKSk7Cg==