171669 2017-05-04 09:52:03 -0700 CrashTracer: [USER] com.apple.WebKit.WebContent.Development at com.apple.WebCore: WebCore::commonVMSlow + 57 2017-05-05 12:51:22 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 bburg bburg bburg inspector-bugzilla-changes joepeck mark.lam webkit-bug-importer oldest_to_newest 1304671 0 bburg 2017-05-04 09:52:03 -0700 Triggered by safaridriver's 'AutomaticInspection' capability after recent changes to add the interrupt dispatcher. 1304672 1 bburg 2017-05-04 09:52:22 -0700 <rdar://problem/31967684> 1304675 2 309058 bburg 2017-05-04 09:58:10 -0700 Created attachment 309058 Patch 1304682 3 309058 mark.lam 2017-05-04 10:07:52 -0700 Comment on attachment 309058 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=309058&action=review r=me with suggestion for improvement. > Source/WebKit2/WebProcess/WebPage/WebInspectorInterruptDispatcher.cpp:59 > + if (!WebCore::g_commonVMOrNull) While the global can be accessed directly (I suspect just for linkage purposes), I prefer it if you can introduce a WebCore::commonVMOrNull() inline function in CommonVM.h, and use that instead. I prefer that we don't encourage use of direct access to a global var. 1304704 4 bburg 2017-05-04 11:11:54 -0700 (In reply to Mark Lam from comment #3) > Comment on attachment 309058 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=309058&action=review > > r=me with suggestion for improvement. > > > Source/WebKit2/WebProcess/WebPage/WebInspectorInterruptDispatcher.cpp:59 > > + if (!WebCore::g_commonVMOrNull) > > While the global can be accessed directly (I suspect just for linkage > purposes), I prefer it if you can introduce a WebCore::commonVMOrNull() > inline function in CommonVM.h, and use that instead. I prefer that we don't > encourage use of direct access to a global var. OK 1305268 5 bburg 2017-05-05 12:44:53 -0700 Committed r216263: <http://trac.webkit.org/changeset/216263> 309058 2017-05-04 09:58:10 -0700 2017-05-05 12:51:22 -0700 Patch bug-171669-20170504095810.patch text/plain 2769 bburg U3VidmVyc2lvbiBSZXZpc2lvbjogMjE2MDkyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggYjY0YTMzM2NhYmJkMjM5 NTMwNGUzZjhkZTg2MDhjNzczODZmNzRiOC4uOGQ1MzU4NDEzNjFmNjhmYmM5NzZhNTk1N2UxMGRh N2NiOTA3NTVjOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI0IEBACisyMDE3LTA1LTA0ICBCcmlh biBCdXJnICA8YmJ1cmdAYXBwbGUuY29tPgorCisgICAgICAgIENyYXNoVHJhY2VyOiBbVVNFUl0g Y29tLmFwcGxlLldlYktpdC5XZWJDb250ZW50LkRldmVsb3BtZW50IGF0IGNvbS5hcHBsZS5XZWJD b3JlOiBXZWJDb3JlOjpjb21tb25WTVNsb3cgKyA1NworICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTcxNjY5CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS8z MTk2NzY4ND4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBzYWZhcmlkcml2ZXIncyBBdXRvbWF0aWNJbnNwZWN0aW9uIGNhcGFiaWxpdHkgY2F1c2VzIHVz IHRvIGNhbGwgV2ViSW5zcGVjdG9yUHJveHk6OmNvbm5lY3QoKQorICAgICAgICB1bmRlcm5lYXRo IHRoZSBBdXRvbWF0aW9uLmluc3BlY3RCcm93c2luZ0NvbnRleHQgY29tbWFuZC4gVGhpcyBmaXJl cyBhIE5lZWREZWJ1Z2dlckJyZWFrCisgICAgICAgIGludGVycnVwdCBmb3IgdGhlIHdlYiBjb250 ZW50J3MgVk0sIGJ1dCB0aGlzIGlzIHJhY3kgYmVjYXVzZSB0aGUgd2ViIGNvbnRlbnQgcHJvY2Vz cyBtYXkKKyAgICAgICAgbm90IHlldCBiZSBmdWxseSBpbml0aWFsaXplZCB3aGVuIHRoaXMgaW50 ZXJydXB0IGlzIGhhbmRsZWQuCisKKyAgICAgICAgVG8gd29yayBhcm91bmQgdGhpcywganVzdCBk b24ndCBkZWxpdmVyIGFueSBpbnRlcnJ1cHRzIGlmIHRoZSBWTSBzaW5nbGV0b24gaXMgc3RpbGwg bnVsbC4KKyAgICAgICAgVGhpcyBpcyBhIHJlbGlhYmxlIHNpZ25hbCB0aGF0IHRoZSB3ZWIgY29u dGVudCBwcm9jZXNzIGlzIG5vdCBmdWxseSBpbml0aWFsaXplZCB5ZXQuIE5vdCBkZWxpdmVyaW5n CisgICAgICAgIGlzIGhhcm1sZXNzOyB0aGUgaW50ZXJydXB0IG9ubHkgZXhpc3RzIHRvIGJyZWFr IG91dCBvZiBpbmZpbml0ZSBsb29wcyBpbiBKUyBjb2RlLCBidXQgdGhlcmUKKyAgICAgICAgY291 bGQgbm90IGJlIGFueSBzdWNoIGluZmluaXRlIGxvb3AgeWV0IGlmIHRoZSB3ZWIgY29udGVudCBw cm9jZXNzIGlzIG5vdCBmdWxseSBpbml0aWFsaXplZC4KKworICAgICAgICAqIFdlYlByb2Nlc3Mv V2ViUGFnZS9XZWJJbnNwZWN0b3JJbnRlcnJ1cHREaXNwYXRjaGVyLmNwcDoKKyAgICAgICAgKFdl YktpdDo6V2ViSW5zcGVjdG9ySW50ZXJydXB0RGlzcGF0Y2hlcjo6bm90aWZ5TmVlZERlYnVnZ2Vy QnJlYWspOgorCiAyMDE3LTA1LTAyICBBbmR5IEVzdGVzICA8YWVzdGVzQGFwcGxlLmNvbT4KIAog ICAgICAgICBSRUdSRVNTSU9OIChyMjEzMDM2KTogQ3Jhc2ggaW4gLVtXS0NvbnRlbnRWaWV3IF93 ZWJUb3VjaEV2ZW50c1JlY29nbml6ZWQ6XSB3aGVuIGEgdG91Y2ggZXZlbnQgYXJyaXZlcyBhZnRl ciBhIFdlYlBhZ2VQcm94eSBoYXMgYmVlbiBpbnZhbGlkYXRlZApkaWZmIC0tZ2l0IGEvU291cmNl L1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJQYWdlL1dlYkluc3BlY3RvckludGVycnVwdERpc3BhdGNo ZXIuY3BwIGIvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJQYWdlL1dlYkluc3BlY3Rvcklu dGVycnVwdERpc3BhdGNoZXIuY3BwCmluZGV4IGNjYTY4ZGZlNzQxNzFiZWNiMWJiODkwZWY4Y2M0 NWMzYmJhNjM2ZTAuLmRiNTlkMGUyZDhmNDVjMTY0ZTQxOWYzZGM5MmFjODMwOGI3NWVlOWMgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViUGFnZS9XZWJJbnNwZWN0b3JJ bnRlcnJ1cHREaXNwYXRjaGVyLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dl YlBhZ2UvV2ViSW5zcGVjdG9ySW50ZXJydXB0RGlzcGF0Y2hlci5jcHAKQEAgLTMyLDcgKzMyLDcg QEAKICNpbmNsdWRlIDx3dGYvV29ya1F1ZXVlLmg+CiAKIG5hbWVzcGFjZSBXZWJLaXQgewotICAg IAorCiBSZWY8V2ViSW5zcGVjdG9ySW50ZXJydXB0RGlzcGF0Y2hlcj4gV2ViSW5zcGVjdG9ySW50 ZXJydXB0RGlzcGF0Y2hlcjo6Y3JlYXRlKCkKIHsKICAgICByZXR1cm4gYWRvcHRSZWYoKm5ldyBX ZWJJbnNwZWN0b3JJbnRlcnJ1cHREaXNwYXRjaGVyKTsKQEAgLTU0LDYgKzU0LDExIEBAIHZvaWQg V2ViSW5zcGVjdG9ySW50ZXJydXB0RGlzcGF0Y2hlcjo6aW5pdGlhbGl6ZUNvbm5lY3Rpb24oSVBD OjpDb25uZWN0aW9uKiBjb25uCiAKIHZvaWQgV2ViSW5zcGVjdG9ySW50ZXJydXB0RGlzcGF0Y2hl cjo6bm90aWZ5TmVlZERlYnVnZ2VyQnJlYWsoKQogeworICAgIC8vIElmIHRoZSB3ZWIgcHJvY2Vz cyBoYXMgbm90IGJlZW4gZnVsbHkgaW5pdGlhbGl6ZWQgeWV0LCB0aGVuIHRoZXJlCisgICAgLy8g aXMgbm8gVk0gdG8gYmUgbm90aWZpZWQgYW5kIHRodXMgbm8gaW5maW5pdGUgbG9vcCB0byBicmVh ay4gQmFpbCBvdXQuCisgICAgaWYgKCFXZWJDb3JlOjpnX2NvbW1vblZNT3JOdWxsKQorICAgICAg ICByZXR1cm47CisKICAgICBKU0M6OlZNJiB2bSA9IFdlYkNvcmU6OmNvbW1vblZNKCk7CiAgICAg dm0ubm90aWZ5TmVlZERlYnVnZ2VyQnJlYWsoKTsKIH0K