171639 2017-05-03 17:48:04 -0700 Maintain interaction information imageURL as a URL, not a string 2017-05-04 10:51:52 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 thorton thorton bdakin commit-queue sam simon.fraser wenson_hsieh oldest_to_newest 1304434 0 thorton 2017-05-03 17:48:04 -0700 Maintain interaction information imageURL as a URL, not a string 1304435 1 308993 thorton 2017-05-03 17:48:13 -0700 Created attachment 308993 Patch 1304437 2 308993 sam 2017-05-03 17:58:10 -0700 Comment on attachment 308993 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=308993&action=review > Source/WebKit2/ChangeLog:4 > + Maintain interaction information imageURL as a URL, not a string > + https://bugs.webkit.org/show_bug.cgi?id=171639 Ok. But why? Just because it is better? 1304444 3 thorton 2017-05-03 18:06:17 -0700 (In reply to Sam Weinig from comment #2) > Comment on attachment 308993 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=308993&action=review > > > Source/WebKit2/ChangeLog:4 > > + Maintain interaction information imageURL as a URL, not a string > > + https://bugs.webkit.org/show_bug.cgi?id=171639 > > Ok. But why? Just because it is better? Is that so bad? :) But no, there is a good reason (for url, not for imageURL, but no point changing one and not the other). 1304464 4 308993 commit-queue 2017-05-03 19:03:02 -0700 Comment on attachment 308993 Patch Clearing flags on attachment: 308993 Committed r216168: <http://trac.webkit.org/changeset/216168> 1304465 5 commit-queue 2017-05-03 19:03:03 -0700 All reviewed patches have been landed. Closing bug. 1304692 6 sam 2017-05-04 10:51:52 -0700 (In reply to Tim Horton from comment #3) > (In reply to Sam Weinig from comment #2) > > Comment on attachment 308993 [details] > > Patch > > > > View in context: > > https://bugs.webkit.org/attachment.cgi?id=308993&action=review > > > > > Source/WebKit2/ChangeLog:4 > > > + Maintain interaction information imageURL as a URL, not a string > > > + https://bugs.webkit.org/show_bug.cgi?id=171639 > > > > Ok. But why? Just because it is better? > > Is that so bad? :) Nope. Consistency is a fine reason. > But no, there is a good reason (for url, not for > imageURL, but no point changing one and not the other). What was the reason? 308993 2017-05-03 17:48:13 -0700 2017-05-03 19:03:02 -0700 Patch bug-171639-20170503174813.patch text/plain 5154 thorton U3VidmVyc2lvbiBSZXZpc2lvbjogMjE2MTUzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggZWViM2RiZjFkZGVhOGFh MjUyMGIwM2FiNmYwZGY3ZDAxY2Q2MWI0ZC4uNzA0Nzc2NzQwZDQyZjJmYTZjZTQ5NjM4MWFmY2Zm MzViYWQ0ZWEwYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDE3LTA1LTAzICBUaW1v dGh5IEhvcnRvbiAgPHRpbW90aHlfaG9ydG9uQGFwcGxlLmNvbT4KKworICAgICAgICBNYWludGFp biBpbnRlcmFjdGlvbiBpbmZvcm1hdGlvbiBpbWFnZVVSTCBhcyBhIFVSTCwgbm90IGEgc3RyaW5n CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNzE2MzkK KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFNoYXJl ZC9pb3MvSW50ZXJhY3Rpb25JbmZvcm1hdGlvbkF0UG9zaXRpb24uaDoKKyAgICAgICAgKiBVSVBy b2Nlc3MvaW9zL1dLQ29udGVudFZpZXdJbnRlcmFjdGlvbi5tbToKKyAgICAgICAgKC1bV0tDb250 ZW50VmlldyBfZGF0YUZvclByZXZpZXdJdGVtQ29udHJvbGxlcjphdFBvc2l0aW9uOnR5cGU6XSk6 CisgICAgICAgICgtW1dLQ29udGVudFZpZXcgX3ByZXZpZXdJdGVtQ29udHJvbGxlcjpjb21taXRQ cmV2aWV3Ol0pOgorICAgICAgICAqIFdlYlByb2Nlc3MvV2ViUGFnZS9pb3MvV2ViUGFnZUlPUy5t bToKKyAgICAgICAgKFdlYktpdDo6V2ViUGFnZTo6Z2V0UG9zaXRpb25JbmZvcm1hdGlvbik6CisK IDIwMTctMDUtMDMgIFRpbSBIb3J0b24gIDx0aW1vdGh5X2hvcnRvbkBhcHBsZS5jb20+CiAKICAg ICAgICAgTWFpbnRhaW4gaW50ZXJhY3Rpb24gaW5mb3JtYXRpb24gVVJMIGFzIGEgVVJMLCBub3Qg YSBzdHJpbmcKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1NoYXJlZC9pb3MvSW50ZXJhY3Rp b25JbmZvcm1hdGlvbkF0UG9zaXRpb24uaCBiL1NvdXJjZS9XZWJLaXQyL1NoYXJlZC9pb3MvSW50 ZXJhY3Rpb25JbmZvcm1hdGlvbkF0UG9zaXRpb24uaAppbmRleCA3NDc1MTQ2MTQ5ZGY2ODcyYTMx NzM1ODRkOTQ4MzVlMTYwMjc3M2Q4Li45ZjY3ODNlOTIyODU3ZWU0MDJjN2VmMmQzM2QxNDQxMzkz NWE5YzQ4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9TaGFyZWQvaW9zL0ludGVyYWN0aW9u SW5mb3JtYXRpb25BdFBvc2l0aW9uLmgKKysrIGIvU291cmNlL1dlYktpdDIvU2hhcmVkL2lvcy9J bnRlcmFjdGlvbkluZm9ybWF0aW9uQXRQb3NpdGlvbi5oCkBAIC01OCw3ICs1OCw3IEBAIHN0cnVj dCBJbnRlcmFjdGlvbkluZm9ybWF0aW9uQXRQb3NpdGlvbiB7CiAjZW5kaWYKICAgICBXZWJDb3Jl OjpGbG9hdFBvaW50IGFkanVzdGVkUG9pbnRGb3JOb2RlUmVzcG9uZGluZ1RvQ2xpY2tFdmVudHM7 CiAgICAgV2ViQ29yZTo6VVJMIHVybDsKLSAgICBTdHJpbmcgaW1hZ2VVUkw7CisgICAgV2ViQ29y ZTo6VVJMIGltYWdlVVJMOwogICAgIFN0cmluZyB0aXRsZTsKICAgICBTdHJpbmcgaWRBdHRyaWJ1 dGU7CiAgICAgV2ViQ29yZTo6SW50UmVjdCBib3VuZHM7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi S2l0Mi9VSVByb2Nlc3MvaW9zL1dLQ29udGVudFZpZXdJbnRlcmFjdGlvbi5tbSBiL1NvdXJjZS9X ZWJLaXQyL1VJUHJvY2Vzcy9pb3MvV0tDb250ZW50Vmlld0ludGVyYWN0aW9uLm1tCmluZGV4IGVm NzFkMzQzYzliMzU1MDExZGY1OTUwOWY1NDcxOWMyZDJmZjU2MTkuLjRhZGVjY2ZkOGZhNzY1Mjk2 YmYyMjkwZWNkNGI3NzNiYjFhYjkxNzAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJv Y2Vzcy9pb3MvV0tDb250ZW50Vmlld0ludGVyYWN0aW9uLm1tCisrKyBiL1NvdXJjZS9XZWJLaXQy L1VJUHJvY2Vzcy9pb3MvV0tDb250ZW50Vmlld0ludGVyYWN0aW9uLm1tCkBAIC00Mjc3LDcgKzQy NzcsNyBAQCBzdGF0aWMgYm9vbCBpc0Fzc2lzdGFibGVJbnB1dFR5cGUoSW5wdXRUeXBlIHR5cGUp CiAgICAgaWYgKGNhblNob3dMaW5rUHJldmlldykgewogICAgICAgICAqdHlwZSA9IFVJUHJldmll d0l0ZW1UeXBlTGluazsKICAgICAgICAgaWYgKHVzZUltYWdlVVJMRm9yTGluaykKLSAgICAgICAg ICAgIGRhdGFGb3JQcmV2aWV3W1VJUHJldmlld0RhdGFMaW5rXSA9IFtOU1VSTCBfd2ViX1VSTFdp dGhXVEZTdHJpbmc6X3Bvc2l0aW9uSW5mb3JtYXRpb24uaW1hZ2VVUkxdOworICAgICAgICAgICAg ZGF0YUZvclByZXZpZXdbVUlQcmV2aWV3RGF0YUxpbmtdID0gKE5TVVJMICopX3Bvc2l0aW9uSW5m b3JtYXRpb24uaW1hZ2VVUkw7CiAgICAgICAgIGVsc2UKICAgICAgICAgICAgIGRhdGFGb3JQcmV2 aWV3W1VJUHJldmlld0RhdGFMaW5rXSA9IChOU1VSTCAqKWxpbmtVUkw7CiAgICAgICAgIGlmIChf cG9zaXRpb25JbmZvcm1hdGlvbi5pc0RhdGFEZXRlY3RvckxpbmspIHsKQEAgLTQzMDYsNyArNDMw Niw3IEBAIHN0YXRpYyBib29sIGlzQXNzaXN0YWJsZUlucHV0VHlwZShJbnB1dFR5cGUgdHlwZSkK ICAgICAgICAgfQogICAgIH0gZWxzZSBpZiAoY2FuU2hvd0ltYWdlUHJldmlldykgewogICAgICAg ICAqdHlwZSA9IFVJUHJldmlld0l0ZW1UeXBlSW1hZ2U7Ci0gICAgICAgIGRhdGFGb3JQcmV2aWV3 W1VJUHJldmlld0RhdGFMaW5rXSA9IFtOU1VSTCBfd2ViX1VSTFdpdGhXVEZTdHJpbmc6X3Bvc2l0 aW9uSW5mb3JtYXRpb24uaW1hZ2VVUkxdOworICAgICAgICBkYXRhRm9yUHJldmlld1tVSVByZXZp ZXdEYXRhTGlua10gPSAoTlNVUkwgKilfcG9zaXRpb25JbmZvcm1hdGlvbi5pbWFnZVVSTDsKICAg ICB9IGVsc2UgaWYgKGNhblNob3dBdHRhY2htZW50UHJldmlldykgewogI2lmIF9fSVBIT05FX09T X1ZFUlNJT05fTUlOX1JFUVVJUkVEID49IDEwMDAwMAogICAgICAgICAqdHlwZSA9IFVJUHJldmll d0l0ZW1UeXBlQXR0YWNobWVudDsKQEAgLTQ0NDAsMTAgKzQ0NDAsMTAgQEAgc3RhdGljIE5TU3Ry aW5nICpwcmV2aWV3SWRlbnRpZmllckZvckVsZW1lbnRBY3Rpb24oX1dLRWxlbWVudEFjdGlvbiAq YWN0aW9uKQogICAgIGlkIDxXS1VJRGVsZWdhdGVQcml2YXRlPiB1aURlbGVnYXRlID0gc3RhdGlj X2Nhc3Q8aWQgPFdLVUlEZWxlZ2F0ZVByaXZhdGU+PihbX3dlYlZpZXcgVUlEZWxlZ2F0ZV0pOwog ICAgIGlmIChbX3ByZXZpZXdJdGVtQ29udHJvbGxlciB0eXBlXSA9PSBVSVByZXZpZXdJdGVtVHlw ZUltYWdlKSB7CiAgICAgICAgIGlmIChbdWlEZWxlZ2F0ZSByZXNwb25kc1RvU2VsZWN0b3I6QHNl bGVjdG9yKF93ZWJWaWV3OmNvbW1pdFByZXZpZXdlZEltYWdlV2l0aFVSTDopXSkgewotICAgICAg ICAgICAgU3RyaW5nIGFic29sdXRlSW1hZ2VVUkwgPSBfcG9zaXRpb25JbmZvcm1hdGlvbi5pbWFn ZVVSTDsKLSAgICAgICAgICAgIGlmIChhYnNvbHV0ZUltYWdlVVJMLmlzRW1wdHkoKSB8fCAhKFdl YkNvcmU6OnByb3RvY29sSXNJbkhUVFBGYW1pbHkoYWJzb2x1dGVJbWFnZVVSTCkgfHwgV2ViQ29y ZTo6cHJvdG9jb2xJcyhhYnNvbHV0ZUltYWdlVVJMLCAiZGF0YSIpKSkKKyAgICAgICAgICAgIGNv bnN0IFVSTCYgaW1hZ2VVUkwgPSBfcG9zaXRpb25JbmZvcm1hdGlvbi5pbWFnZVVSTDsKKyAgICAg ICAgICAgIGlmIChpbWFnZVVSTC5pc0VtcHR5KCkgfHwgIShpbWFnZVVSTC5wcm90b2NvbElzSW5I VFRQRmFtaWx5KCkgfHwgaW1hZ2VVUkwucHJvdG9jb2xJcygiZGF0YSIpKSkKICAgICAgICAgICAg ICAgICByZXR1cm47Ci0gICAgICAgICAgICBbdWlEZWxlZ2F0ZSBfd2ViVmlldzpfd2ViVmlldyBj b21taXRQcmV2aWV3ZWRJbWFnZVdpdGhVUkw6W05TVVJMIF93ZWJfVVJMV2l0aFdURlN0cmluZzph YnNvbHV0ZUltYWdlVVJMXV07CisgICAgICAgICAgICBbdWlEZWxlZ2F0ZSBfd2ViVmlldzpfd2Vi VmlldyBjb21taXRQcmV2aWV3ZWRJbWFnZVdpdGhVUkw6KE5TVVJMICopaW1hZ2VVUkxdOwogICAg ICAgICAgICAgcmV0dXJuOwogICAgICAgICB9CiAgICAgICAgIHJldHVybjsKZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViUGFnZS9pb3MvV2ViUGFnZUlPUy5tbSBiL1Nv dXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViUGFnZS9pb3MvV2ViUGFnZUlPUy5tbQppbmRleCBl NjBlNjNmYWM0ODVhZTQ2YWVjYzIyOWFmZDNlNjRiYTRjYjQ3ODUzLi42NWYwZTJiNjZhZWY0NzVm YTM5YmY4NmY2NGYyMDc0NWE1M2E3YTY3IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9XZWJQ cm9jZXNzL1dlYlBhZ2UvaW9zL1dlYlBhZ2VJT1MubW0KKysrIGIvU291cmNlL1dlYktpdDIvV2Vi UHJvY2Vzcy9XZWJQYWdlL2lvcy9XZWJQYWdlSU9TLm1tCkBAIC0yNDk5LDcgKzI0OTksNyBAQCB2 b2lkIFdlYlBhZ2U6OmdldFBvc2l0aW9uSW5mb3JtYXRpb24oY29uc3QgSW50ZXJhY3Rpb25JbmZv cm1hdGlvblJlcXVlc3QmIHJlcXVlcwogICAgICAgICAgICAgICAgICAgICBpZiAocmVuZGVySW1h Z2UuY2FjaGVkSW1hZ2UoKSAmJiAhcmVuZGVySW1hZ2UuY2FjaGVkSW1hZ2UoKS0+ZXJyb3JPY2N1 cnJlZCgpKSB7CiAgICAgICAgICAgICAgICAgICAgICAgICBpZiAoSW1hZ2UqIGltYWdlID0gcmVu ZGVySW1hZ2UuY2FjaGVkSW1hZ2UoKS0+aW1hZ2VGb3JSZW5kZXJlcigmcmVuZGVySW1hZ2UpKSB7 CiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgaWYgKGltYWdlLT53aWR0aCgpID4gMSAmJiBp bWFnZS0+aGVpZ2h0KCkgPiAxKSB7Ci0gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGlu Zm8uaW1hZ2VVUkwgPSBbKE5TVVJMICopZWxlbWVudC0+ZG9jdW1lbnQoKS5jb21wbGV0ZVVSTChy ZW5kZXJJbWFnZS5jYWNoZWRJbWFnZSgpLT51cmwoKSkgYWJzb2x1dGVTdHJpbmddOworICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICBpbmZvLmltYWdlVVJMID0gZWxlbWVudC0+ZG9jdW1l bnQoKS5jb21wbGV0ZVVSTChyZW5kZXJJbWFnZS5jYWNoZWRJbWFnZSgpLT51cmwoKSk7CiAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgIGluZm8uaXNBbmltYXRlZEltYWdlID0gaW1hZ2Ut PmlzQW5pbWF0ZWQoKTsKIAogICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBpZiAocmVx dWVzdC5pbmNsdWRlU25hcHNob3QpIHsK