<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>171631</bug_id>
          
          <creation_ts>2017-05-03 16:21:01 -0700</creation_ts>
          <short_desc>[Cocoa] Stop exporting symbols for ivars that were made private</short_desc>
          <delta_ts>2017-05-03 18:37:51 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebKit Misc.</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          <see_also>https://bugs.webkit.org/show_bug.cgi?id=171208</see_also>
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Joseph Pecoraro">joepeck</reporter>
          <assigned_to name="Joseph Pecoraro">joepeck</assigned_to>
          <cc>aakash_jain</cc>
    
    <cc>ap</cc>
    
    <cc>commit-queue</cc>
    
    <cc>joepeck</cc>
    
    <cc>mitz</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1304350</commentid>
    <comment_count>0</comment_count>
    <who name="Joseph Pecoraro">joepeck</who>
    <bug_when>2017-05-03 16:21:01 -0700</bug_when>
    <thetext>Stop exporting symbols for ivars that were made private.

Bug 171208: &lt;https://trac.webkit.org/r215685&gt; made all of these ivars private, so they should not need to be exported anymore.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1304353</commentid>
    <comment_count>1</comment_count>
      <attachid>308980</attachid>
    <who name="Joseph Pecoraro">joepeck</who>
    <bug_when>2017-05-03 16:21:47 -0700</bug_when>
    <thetext>Created attachment 308980
[PATCH] Proposed Fix</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1304364</commentid>
    <comment_count>2</comment_count>
    <who name="Aakash Jain">aakash_jain</who>
    <bug_when>2017-05-03 16:28:31 -0700</bug_when>
    <thetext>looks fine to me. but probably mitz should review as well.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1304457</commentid>
    <comment_count>3</comment_count>
      <attachid>308980</attachid>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2017-05-03 18:37:48 -0700</bug_when>
    <thetext>Comment on attachment 308980
[PATCH] Proposed Fix

Clearing flags on attachment: 308980

Committed r216165: &lt;http://trac.webkit.org/changeset/216165&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1304458</commentid>
    <comment_count>4</comment_count>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2017-05-03 18:37:51 -0700</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>308980</attachid>
            <date>2017-05-03 16:21:47 -0700</date>
            <delta_ts>2017-05-03 18:37:48 -0700</delta_ts>
            <desc>[PATCH] Proposed Fix</desc>
            <filename>symbols-1.patch</filename>
            <type>text/plain</type>
            <size>1661</size>
            <attacher name="Joseph Pecoraro">joepeck</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvbWFjL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQv
bWFjL0NoYW5nZUxvZwppbmRleCAwNjNmNTRlYTdlZi4uZDQ0MGE2YzhlYWMgMTAwNjQ0Ci0tLSBh
L1NvdXJjZS9XZWJLaXQvbWFjL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViS2l0L21hYy9DaGFu
Z2VMb2cKQEAgLTEsMyArMSwxMiBAQAorMjAxNy0wNS0wMyAgSm9zZXBoIFBlY29yYXJvICA8cGVj
b3Jhcm9AYXBwbGUuY29tPgorCisgICAgICAgIFtDb2NvYV0gU3RvcCBleHBvcnRpbmcgc3ltYm9s
cyBmb3IgaXZhcnMgdGhhdCB3ZXJlIG1hZGUgcHJpdmF0ZQorICAgICAgICBodHRwczovL2J1Z3Mu
d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTcxNjMxCisKKyAgICAgICAgUmV2aWV3ZWQgYnkg
Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBXZWJLaXQuZXhwOgorCiAyMDE3LTA1LTAxICBD
aHJpcyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CiAKICAgICAgICAgUmVtb3ZlIHNvbWUgdXNh
Z2Ugb2YgUGFzc1JlZlB0ciBpbiBlZGl0aW5nIGNvZGUKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJL
aXQvbWFjL1dlYktpdC5leHAgYi9Tb3VyY2UvV2ViS2l0L21hYy9XZWJLaXQuZXhwCmluZGV4IGU2
OWM5ZDc1MDQ5Li5jZTU5NjNiNmQ0MSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9tYWMvV2Vi
S2l0LmV4cAorKysgYi9Tb3VyY2UvV2ViS2l0L21hYy9XZWJLaXQuZXhwCkBAIC0yNTYsMTkgKzI1
NiwzIEBAIF9fV2ViQ3JlYXRlRnJhZ21lbnQKIF9fV2ViSFRNTFZpZXdQcmludGluZ01heGltdW1T
aHJpbmtGYWN0b3IKIF9fV2ViSFRNTFZpZXdQcmludGluZ01pbmltdW1TaHJpbmtGYWN0b3IKIF9f
V2ViVmlld0RpZFN0YXJ0QWNjZWxlcmF0ZWRDb21wb3NpdGluZ05vdGlmaWNhdGlvbgotX09CSkNf
SVZBUl8kX1dlYkRhdGFiYXNlUXVvdGFNYW5hZ2VyLl9vcmlnaW4KLV9PQkpDX0lWQVJfJF9XZWJE
ZXZpY2VPcmllbnRhdGlvbi5tX2ludGVybmFsCi1fT0JKQ19JVkFSXyRfV2ViRGV2aWNlT3JpZW50
YXRpb25Qcm92aWRlck1vY2subV9pbnRlcm5hbAotX09CSkNfSVZBUl8kX1dlYkdlb2xvY2F0aW9u
UG9zaXRpb24uX2ludGVybmFsCi1fT0JKQ19JVkFSXyRfV2ViSFRNTFJlcHJlc2VudGF0aW9uLl9w
cml2YXRlCi1fT0JKQ19JVkFSXyRfV2ViSW5zcGVjdG9yLl9mcm9udGVuZAotX09CSkNfSVZBUl8k
X1dlYkluc3BlY3Rvci5faW5zcGVjdGVkV2ViVmlldwotX09CSkNfSVZBUl8kX1dlYk5vdGlmaWNh
dGlvbi5fcHJpdmF0ZQotX09CSkNfSVZBUl8kX1dlYlBsdWdpbkRhdGFiYXNlLnBsdWdJblBhdGhz
Ci1fT0JKQ19JVkFSXyRfV2ViUGx1Z2luRGF0YWJhc2UucGx1Z2luSW5zdGFuY2VWaWV3cwotX09C
SkNfSVZBUl8kX1dlYlBsdWdpbkRhdGFiYXNlLnBsdWdpbnMKLV9PQkpDX0lWQVJfJF9XZWJQbHVn
aW5EYXRhYmFzZS5yZWdpc3RlcmVkTUlNRVR5cGVzCi1fT0JKQ19JVkFSXyRfV2ViU2VjdXJpdHlP
cmlnaW4uX2FwcGxpY2F0aW9uQ2FjaGVRdW90YU1hbmFnZXIKLV9PQkpDX0lWQVJfJF9XZWJTZWN1
cml0eU9yaWdpbi5fZGF0YWJhc2VRdW90YU1hbmFnZXIKLV9PQkpDX0lWQVJfJF9XZWJTZWN1cml0
eU9yaWdpbi5fcHJpdmF0ZQotX09CSkNfSVZBUl8kX1dlYlVzZXJDb250ZW50VVJMUGF0dGVybi5f
cHJpdmF0ZQo=
</data>

          </attachment>
      

    </bug>

</bugzilla>