171607 2017-05-03 11:08:58 -0700 Handle KVO updating of the "hasOnlySecureContent" before a page results in an HTTP auth challenge 2017-05-03 12:27:11 -0700 1 1 1 Unclassified WebKit WebKit2 WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 beidson beidson aestes commit-queue oldest_to_newest 1304130 0 beidson 2017-05-03 11:08:58 -0700 Handle KVO updating of the "hasOnlySecureContent" before a page results in an HTTP auth challenge <rdar://problem/28867282> 1304136 1 308930 beidson 2017-05-03 11:18:07 -0700 Created attachment 308930 Patch 1304138 2 308930 aestes 2017-05-03 11:20:13 -0700 Comment on attachment 308930 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=308930&action=review > Source/WebKit2/UIProcess/PageLoadState.cpp:209 > + if (data.state == State::Provisional) > + return WebCore::protocolIs(data.provisionalURL, "https"); Feels like a blank line belongs at the end of this. 1304155 3 308934 beidson 2017-05-03 11:56:40 -0700 Created attachment 308934 Patch 1304179 4 308934 commit-queue 2017-05-03 12:27:09 -0700 Comment on attachment 308934 Patch Clearing flags on attachment: 308934 Committed r216132: <http://trac.webkit.org/changeset/216132> 1304180 5 commit-queue 2017-05-03 12:27:11 -0700 All reviewed patches have been landed. Closing bug. 308930 2017-05-03 11:18:07 -0700 2017-05-03 11:56:39 -0700 Patch bug-171607-20170503111806.patch text/plain 1522 beidson U3VidmVyc2lvbiBSZXZpc2lvbjogMjE2MTA3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggNDY3YTY0YTE2YjI1N2Jj M2MxNDNiMzhlNTdiNjRkY2IzNGE0MjhhZC4uYTc4MTJlMmQxMjRkZGRiOGU1NmI2M2NlNjMxNWJk NTIyYzE3ODUxMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDE3LTA1LTAzICBCcmFk eSBFaWRzb24gIDxiZWlkc29uQGFwcGxlLmNvbT4KKworICAgICAgICBIYW5kbGUgS1ZPIHVwZGF0 aW5nIG9mIHRoZSAiaGFzT25seVNlY3VyZUNvbnRlbnQiIGJlZm9yZSBhIHBhZ2UgcmVzdWx0cyBp biBhbiBIVFRQIGF1dGggY2hhbGxlbmdlLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MTcxNjA3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisgICAgICAgIAorICAgICAgICBUbyB0ZXN0IHRoaXMgZml4IHdlJ2QgbmVlZCB0aGUg Y29tYmluYXRpb24gb2YgYW4gSFRUUEQgaW5zaWRlIEFQSSB0ZXN0cywgc28gbm8gdGVzdCBmb3Ig bm93LgorCisgICAgICAgICogVUlQcm9jZXNzL1BhZ2VMb2FkU3RhdGUuY3BwOgorICAgICAgICAo V2ViS2l0OjpQYWdlTG9hZFN0YXRlOjpoYXNPbmx5U2VjdXJlQ29udGVudCk6IElmIHRoZSBzdGF0 ZSBpcyBwcm92aXNpb25hbCwgY2hlY2sgdGhlIHByb3Zpc2lvbmFsIFVSTCBpbnN0ZWFkLgorCiAy MDE3LTA1LTAyICBTaW1vbiBGcmFzZXIgIDxzaW1vbi5mcmFzZXJAYXBwbGUuY29tPgogCiAgICAg ICAgIER5bmFtaWNhbGx5IGFkZGVkIHBvc2l0aW9uOmZpeGVkIGVsZW1lbnQgaXMgaW4gdGhlIHdy b25nIHBsYWNlCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvUGFnZUxvYWRT dGF0ZS5jcHAgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvUGFnZUxvYWRTdGF0ZS5jcHAKaW5k ZXggZGQ5ZDRjN2Q5YmUzNDA3NWQzZGJmMDM2NDE0YmJkNGM2YWYyMzcxZC4uYzRlZGZhNzllYjEy NmFiYzQwYjQ0N2M3MGVlYzEzOTkxYmM4YjI4NSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIv VUlQcm9jZXNzL1BhZ2VMb2FkU3RhdGUuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vz cy9QYWdlTG9hZFN0YXRlLmNwcApAQCAtMjA1LDYgKzIwNSw4IEBAIGJvb2wgUGFnZUxvYWRTdGF0 ZTo6aGFzT25seVNlY3VyZUNvbnRlbnQoY29uc3QgRGF0YSYgZGF0YSkKICAgICBpZiAoZGF0YS5o YXNJbnNlY3VyZUNvbnRlbnQpCiAgICAgICAgIHJldHVybiBmYWxzZTsKIAorICAgIGlmIChkYXRh LnN0YXRlID09IFN0YXRlOjpQcm92aXNpb25hbCkKKyAgICAgICAgcmV0dXJuIFdlYkNvcmU6OnBy b3RvY29sSXMoZGF0YS5wcm92aXNpb25hbFVSTCwgImh0dHBzIik7CiAgICAgcmV0dXJuIFdlYkNv cmU6OnByb3RvY29sSXMoZGF0YS51cmwsICJodHRwcyIpOwogfQogCg== 308934 2017-05-03 11:56:40 -0700 2017-05-03 12:27:09 -0700 Patch bug-171607-20170503115639.patch text/plain 1520 beidson U3VidmVyc2lvbiBSZXZpc2lvbjogMjE2MTA3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggNDY3YTY0YTE2YjI1N2Jj M2MxNDNiMzhlNTdiNjRkY2IzNGE0MjhhZC4uMjA5NzU3ZWNkMTk0ZjIwNzhlYTYxMDg0MmM2MTVm NGYzZDcyYWM3MyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDE3LTA1LTAzICBCcmFk eSBFaWRzb24gIDxiZWlkc29uQGFwcGxlLmNvbT4KKworICAgICAgICBIYW5kbGUgS1ZPIHVwZGF0 aW5nIG9mIHRoZSAiaGFzT25seVNlY3VyZUNvbnRlbnQiIGJlZm9yZSBhIHBhZ2UgcmVzdWx0cyBp biBhbiBIVFRQIGF1dGggY2hhbGxlbmdlLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MTcxNjA3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgQW5keSBFc3Rl cy4KKyAgICAgICAgCisgICAgICAgIFRvIHRlc3QgdGhpcyBmaXggd2UnZCBuZWVkIHRoZSBjb21i aW5hdGlvbiBvZiBhbiBIVFRQRCBpbnNpZGUgQVBJIHRlc3RzLCBzbyBubyB0ZXN0IGZvciBub3cu CisKKyAgICAgICAgKiBVSVByb2Nlc3MvUGFnZUxvYWRTdGF0ZS5jcHA6CisgICAgICAgIChXZWJL aXQ6OlBhZ2VMb2FkU3RhdGU6Omhhc09ubHlTZWN1cmVDb250ZW50KTogSWYgdGhlIHN0YXRlIGlz IHByb3Zpc2lvbmFsLCBjaGVjayB0aGUgcHJvdmlzaW9uYWwgVVJMIGluc3RlYWQuCisKIDIwMTct MDUtMDIgIFNpbW9uIEZyYXNlciAgPHNpbW9uLmZyYXNlckBhcHBsZS5jb20+CiAKICAgICAgICAg RHluYW1pY2FsbHkgYWRkZWQgcG9zaXRpb246Zml4ZWQgZWxlbWVudCBpcyBpbiB0aGUgd3Jvbmcg cGxhY2UKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9QYWdlTG9hZFN0YXRl LmNwcCBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9QYWdlTG9hZFN0YXRlLmNwcAppbmRleCBk ZDlkNGM3ZDliZTM0MDc1ZDNkYmYwMzY0MTRiYmQ0YzZhZjIzNzFkLi4zYWRhMGZiOGFjY2MyMDhk MjAxNmI3YTA2OGI4ZGJjZDQ0M2M3ZWVjIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVBy b2Nlc3MvUGFnZUxvYWRTdGF0ZS5jcHAKKysrIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL1Bh Z2VMb2FkU3RhdGUuY3BwCkBAIC0yMDUsNiArMjA1LDkgQEAgYm9vbCBQYWdlTG9hZFN0YXRlOjpo YXNPbmx5U2VjdXJlQ29udGVudChjb25zdCBEYXRhJiBkYXRhKQogICAgIGlmIChkYXRhLmhhc0lu c2VjdXJlQ29udGVudCkKICAgICAgICAgcmV0dXJuIGZhbHNlOwogCisgICAgaWYgKGRhdGEuc3Rh dGUgPT0gU3RhdGU6OlByb3Zpc2lvbmFsKQorICAgICAgICByZXR1cm4gV2ViQ29yZTo6cHJvdG9j b2xJcyhkYXRhLnByb3Zpc2lvbmFsVVJMLCAiaHR0cHMiKTsKKwogICAgIHJldHVybiBXZWJDb3Jl Ojpwcm90b2NvbElzKGRhdGEudXJsLCAiaHR0cHMiKTsKIH0KIAo=