171604 2017-05-03 09:45:50 -0700 Cleanup: Remove out-of-date comment and null check from DocumentLoader::detachFromFrame() 2018-05-29 21:09:41 -0700 1 1 1 Unclassified WebKit Page Loading WebKit Local Build All All RESOLVED FIXED P2 Normal --- 186081 1 dbates dbates beidson buildbot cdumez japhet oldest_to_newest 1304062 0 dbates 2017-05-03 09:45:50 -0700 We no longer want to passively allow DocumentLoader::detachFromFrame() to be called twice as it never makes sense to for it to be called twice and indicates a bug that we want to fix. A release assert in DocumentLoader::cancelPolicyCheckIfNeeded() (added in r187558) called by DocumentLoader::detachFromFrame() enforces this invariant. We should remove the unnecessary null check of DocumentLoader::m_frameand the comment that explains this null check from DocumentLoader::detachFromFrame(). 1304063 1 dbates 2017-05-03 09:46:12 -0700 (In reply to Daniel Bates from comment #0) > [...] > the unnecessary null check of DocumentLoader::m_frameand the comment that > explains this null check from DocumentLoader::detachFromFrame(). *DocumentLoader::m_frame and 1304064 2 308915 dbates 2017-05-03 09:46:52 -0700 Created attachment 308915 Patch 1304070 3 308915 dbates 2017-05-03 09:52:45 -0700 Comment on attachment 308915 Patch Clearing flags on attachment: 308915 Committed r216119: <http://trac.webkit.org/changeset/216119> 1304071 4 dbates 2017-05-03 09:52:47 -0700 All reviewed patches have been landed. Closing bug. 308915 2017-05-03 09:46:52 -0700 2017-05-03 09:52:45 -0700 Patch bug-171604-20170503094651.patch text/plain 2259 dbates U3VidmVyc2lvbiBSZXZpc2lvbjogMjE2MTE3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYTI3ZDA1YmU2OWJkNWJh MjVjNTI1ZDI2YjU0NjI4NmExZWUwMTc5ZS4uMDI0OTRlOWQxYWVkNjllNDJiZjIwNWY3NWQ1MDYy NTMyYWYzMWMwYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDE3LTA1LTAzICBEYW5p ZWwgQmF0ZXMgIDxkYWJhdGVzQGFwcGxlLmNvbT4KKworICAgICAgICBDbGVhbnVwOiBSZW1vdmUg b3V0LW9mLWRhdGUgY29tbWVudCBhbmQgbnVsbCBjaGVjayBmcm9tIERvY3VtZW50TG9hZGVyOjpk ZXRhY2hGcm9tRnJhbWUoKQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MTcxNjA0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgV2Ugbm8gbG9uZ2VyIHdhbnQgdG8gcGFzc2l2ZWx5IGFsbG93IERvY3VtZW50TG9h ZGVyOjpkZXRhY2hGcm9tRnJhbWUoKSB0byBiZSBjYWxsZWQgdHdpY2UuCisgICAgICAgIEl0IGRv ZXMgbm90IG1ha2Ugc2Vuc2UgdG8gYmUgY2FsbGVkIHR3aWNlIGFuZCBzaG91bGQgbmV2ZXIgYmUg Y2FsbGVkIHR3aWNlLiBBIHJlbGVhc2UgYXNzZXJ0CisgICAgICAgIGluIERvY3VtZW50TG9hZGVy OjpjYW5jZWxQb2xpY3lDaGVja0lmTmVlZGVkKCkgKGFkZGVkIGluIHIxODc1NTgpIGNhbGxlZCBi eSBEb2N1bWVudExvYWRlcjo6ZGV0YWNoRnJvbUZyYW1lKCkKKyAgICAgICAgZW5mb3JjZXMgdGhp cyBpbnZhcmlhbnQuIFRoZXJlZm9yZSB3ZSBjYW4gcmVtb3ZlIHRoZSBudWxsIGNoZWNrIG9mIERv Y3VtZW50TG9hZGVyOjptX2ZyYW1lCisgICAgICAgIGFuZCB0aGUgY29tbWVudCB0aGF0IGV4cGxh aW5zIHRoZSBwdXJwb3NlIG9mIHRoaXMgbnVsbCBjaGVjayBmcm9tIERvY3VtZW50TG9hZGVyOjpk ZXRhY2hGcm9tRnJhbWUoKS4KKworICAgICAgICAqIGxvYWRlci9Eb2N1bWVudExvYWRlci5jcHA6 CisgICAgICAgIChXZWJDb3JlOjpEb2N1bWVudExvYWRlcjo6ZGV0YWNoRnJvbUZyYW1lKToKKwog MjAxNy0wNS0wMyAgQW50dGkgS29pdmlzdG8gIDxhbnR0aUBhcHBsZS5jb20+CiAKICAgICAgICAg UmVuYW1lIFN0eWxlSW52YWxpZGF0aW9uQW5hbHlzaXMgdG8gU3R5bGU6OkludmFsaWRhdG9yCmRp ZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9sb2FkZXIvRG9jdW1lbnRMb2FkZXIuY3BwIGIvU291 cmNlL1dlYkNvcmUvbG9hZGVyL0RvY3VtZW50TG9hZGVyLmNwcAppbmRleCA4YzU0ZDk2NGZmOGU1 NWM5MDllOWE0YWQxMDZhNWZjYzRkYzE0MTQyLi40NDg3ODU5NzczYzYzYWJmMzMzYWYzMGQxMmNj MDY3NjdkYTRlZTY5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9sb2FkZXIvRG9jdW1lbnRM b2FkZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2xvYWRlci9Eb2N1bWVudExvYWRlci5jcHAK QEAgLTEwMjEsMTIgKzEwMjEsNyBAQCB2b2lkIERvY3VtZW50TG9hZGVyOjpkZXRhY2hGcm9tRnJh bWUoKQogCiAgICAgY2FuY2VsUG9saWN5Q2hlY2tJZk5lZWRlZCgpOwogCi0gICAgLy8gRXZlbiB0 aG91Z2ggd2UgQVNTRVJUIGF0IHRoZSB0b3Agb2YgdGhpcyBtZXRob2QgdGhhdCB3ZSBoYXZlIGFu IG1fZnJhbWUsIHdlJ3JlIHNlZWluZyBjcmFzaGVzIHdoZXJlIG1fZnJhbWUgaXMgbnVsbC4KLSAg ICAvLyBUaGlzIG1lYW5zIGVpdGhlciB0aGF0IGEgRG9jdW1lbnRMb2FkZXIgaXMgZGV0YWNoaW5n IHR3aWNlLCBvciBpcyBkZXRhY2hpbmcgYmVmb3JlIGV2ZXIgaGF2aW5nIGF0dGFjaGVkLgotICAg IC8vIFVudGlsIHdlIGZpZ3VyZSBvdXQgaG93IHRoYXQgaXMgaGFwcGVuaW5nLCBudWxsIGNoZWNr IG1fZnJhbWUgYmVmb3JlIGRlcmVmZXJlbmNpbmcgaXQgaGVyZS4KLSAgICAvLyA8cmRhcjovL3By b2JsZW0vMjEyOTMwODI+IGFuZCBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MTQ2Nzg2Ci0gICAgaWYgKG1fZnJhbWUpCi0gICAgICAgIEluc3BlY3Rvckluc3RydW1lbnRh dGlvbjo6bG9hZGVyRGV0YWNoZWRGcm9tRnJhbWUoKm1fZnJhbWUsICp0aGlzKTsKKyAgICBJbnNw ZWN0b3JJbnN0cnVtZW50YXRpb246OmxvYWRlckRldGFjaGVkRnJvbUZyYW1lKCptX2ZyYW1lLCAq dGhpcyk7CiAKICAgICBtX2ZyYW1lID0gbnVsbHB0cjsKIH0K