171596 2017-05-03 03:56:35 -0700 [Cairo] Handle extended colors in gradients 2017-05-03 10:06:48 -0700 1 1 1 Unclassified WebKit Platform WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED Gtk, LayoutTestFailure P2 Normal --- 1 cgarcia webkit-unassigned bugs-noreply mcatanzaro oldest_to_newest 1303982 0 cgarcia 2017-05-03 03:56:35 -0700 Will fix css3/color/gradients.html 1303984 1 308893 cgarcia 2017-05-03 03:58:55 -0700 Created attachment 308893 Patch 1304058 2 308893 mcatanzaro 2017-05-03 09:42:21 -0700 Comment on attachment 308893 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=308893&action=review > Source/WebCore/ChangeLog:8 > + Check if every gradient color step is an extended color and use asExtended() instead og getRGBA() in such case. og -> of > Source/WebCore/ChangeLog:10 > + Fixes: css3/color/gradients.html Yay! 1304089 3 cgarcia 2017-05-03 10:06:48 -0700 Committed r216121: <http://trac.webkit.org/changeset/216121> 308893 2017-05-03 03:58:55 -0700 2017-05-03 09:42:21 -0700 Patch wk-cr-gradient-extended-color.diff text/plain 2065 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA3ODIzZjhkNzQwYi4uNjY2ZjM4OTg2NDAgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNyBAQAorMjAxNy0wNS0wMyAgQ2FybG9zIEdhcmNpYSBDYW1wb3MgIDxjZ2FyY2lhQGln YWxpYS5jb20+CisKKyAgICAgICAgW0NhaXJvXSBIYW5kbGUgZXh0ZW5kZWQgY29sb3JzIGluIGdy YWRpZW50cworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MTcxNTk2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg Q2hlY2sgaWYgZXZlcnkgZ3JhZGllbnQgY29sb3Igc3RlcCBpcyBhbiBleHRlbmRlZCBjb2xvciBh bmQgdXNlIGFzRXh0ZW5kZWQoKSBpbnN0ZWFkIG9nIGdldFJHQkEoKSBpbiBzdWNoIGNhc2UuCisK KyAgICAgICAgRml4ZXM6IGNzczMvY29sb3IvZ3JhZGllbnRzLmh0bWwKKworICAgICAgICAqIHBs YXRmb3JtL2dyYXBoaWNzL2NhaXJvL0dyYWRpZW50Q2Fpcm8uY3BwOgorICAgICAgICAoV2ViQ29y ZTo6R3JhZGllbnQ6OnBsYXRmb3JtR3JhZGllbnQpOgorCiAyMDE3LTA1LTAyICBBbmRyZXcgR29s ZCAgPGFnb2xkQGFwcGxlLmNvbT4KIAogICAgICAgICBUeXBvIGluIEFWQXVkaW9TZXNzaW9uQ2Fw dHVyZURldmljZU1hbmFnZXIubW0KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3Jt L2dyYXBoaWNzL2NhaXJvL0dyYWRpZW50Q2Fpcm8uY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZv cm0vZ3JhcGhpY3MvY2Fpcm8vR3JhZGllbnRDYWlyby5jcHAKaW5kZXggYTNlNDBkZmNiMTkuLmM0 Yjc2OWQyYzBkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9j YWlyby9HcmFkaWVudENhaXJvLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFw aGljcy9jYWlyby9HcmFkaWVudENhaXJvLmNwcApAQCAtNjEsMTUgKzYxLDE1IEBAIGNhaXJvX3Bh dHRlcm5fdCogR3JhZGllbnQ6OnBsYXRmb3JtR3JhZGllbnQoZmxvYXQgZ2xvYmFsQWxwaGEpCiAg ICAgZWxzZQogICAgICAgICBtX2dyYWRpZW50ID0gY2Fpcm9fcGF0dGVybl9jcmVhdGVfbGluZWFy KG1fcDAueCgpLCBtX3AwLnkoKSwgbV9wMS54KCksIG1fcDEueSgpKTsKIAotICAgIC8vIEZJWE1F OiBBZGQgc3VwcG9ydCBmb3IgRXh0ZW5kZWRDb2xvci4KICAgICBmb3IgKGNvbnN0IGF1dG8mIHN0 b3AgOiBtX3N0b3BzKSB7Ci0gICAgICAgIGZsb2F0IHI7Ci0gICAgICAgIGZsb2F0IGc7Ci0gICAg ICAgIGZsb2F0IGI7Ci0gICAgICAgIGZsb2F0IGE7Ci0gICAgICAgIHN0b3AuY29sb3IuZ2V0UkdC QShyLCBnLCBiLCBhKTsKLSAgICAgICAgY2Fpcm9fcGF0dGVybl9hZGRfY29sb3Jfc3RvcF9yZ2Jh KG1fZ3JhZGllbnQsIHN0b3Aub2Zmc2V0LAotICAgICAgICAgICAgciwgZywgYiwgYSAqIGdsb2Jh bEFscGhhKTsKKyAgICAgICAgaWYgKHN0b3AuY29sb3IuaXNFeHRlbmRlZCgpKSB7CisgICAgICAg ICAgICBjYWlyb19wYXR0ZXJuX2FkZF9jb2xvcl9zdG9wX3JnYmEobV9ncmFkaWVudCwgc3RvcC5v ZmZzZXQsIHN0b3AuY29sb3IuYXNFeHRlbmRlZCgpLnJlZCgpLCBzdG9wLmNvbG9yLmFzRXh0ZW5k ZWQoKS5ncmVlbigpLCBzdG9wLmNvbG9yLmFzRXh0ZW5kZWQoKS5ibHVlKCksCisgICAgICAgICAg ICAgICAgc3RvcC5jb2xvci5hc0V4dGVuZGVkKCkuYWxwaGEoKSAqIGdsb2JhbEFscGhhKTsKKyAg ICAgICAgfSBlbHNlIHsKKyAgICAgICAgICAgIGZsb2F0IHIsIGcsIGIsIGE7CisgICAgICAgICAg ICBzdG9wLmNvbG9yLmdldFJHQkEociwgZywgYiwgYSk7CisgICAgICAgICAgICBjYWlyb19wYXR0 ZXJuX2FkZF9jb2xvcl9zdG9wX3JnYmEobV9ncmFkaWVudCwgc3RvcC5vZmZzZXQsIHIsIGcsIGIs IGEgKiBnbG9iYWxBbHBoYSk7CisgICAgICAgIH0KICAgICB9CiAKICAgICBzd2l0Y2ggKG1fc3By ZWFkTWV0aG9kKSB7Cg==