171583 2017-05-02 17:50:40 -0700 ews should indicate in logs when it fails to fetch the attachment 2017-05-02 19:48:29 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Local Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=169927 P2 Normal --- 1 aakash_jain aakash_jain aakash_jain ap buildbot commit-queue glenn lforschler oldest_to_newest 1303897 0 aakash_jain 2017-05-02 17:50:40 -0700 Recently debugged an issue <rdar://problem/31894087> which was silently failing because of this problem. Having logs would have helped in debugging. 1303903 1 308872 aakash_jain 2017-05-02 18:01:43 -0700 Created attachment 308872 Proposed patch 1303932 2 308872 commit-queue 2017-05-02 19:48:28 -0700 Comment on attachment 308872 Proposed patch Clearing flags on attachment: 308872 Committed r216108: <http://trac.webkit.org/changeset/216108> 1303933 3 commit-queue 2017-05-02 19:48:29 -0700 All reviewed patches have been landed. Closing bug. 308872 2017-05-02 18:01:43 -0700 2017-05-02 19:48:28 -0700 Proposed patch patch_ews_log_fetch_attachment text/plain 1587 aakash_jain SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDIxNjEwNykKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDEzIEBACisyMDE3LTA1LTAyICBBYWthc2ggSmFpbiAgPGFha2FzaF9qYWluQGFwcGxlLmNv bT4KKworICAgICAgICBld3Mgc2hvdWxkIGluZGljYXRlIGluIGxvZ3Mgd2hlbiBpdCBmYWlscyB0 byBmZXRjaCB0aGUgYXR0YWNobWVudAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MTcxNTgzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L2NvbW1vbi9uZXQvYnVnemlsbGEvYnVn emlsbGEucHk6CisgICAgICAgIChCdWd6aWxsYS5mZXRjaF9hdHRhY2htZW50KTogQWRkZWQgbG9n IHN0YXRlbWVudC4KKwogMjAxNy0wNS0wMiAgRGF2aWQgS2lsemVyICA8ZGRraWx6ZXJAYXBwbGUu Y29tPgogCiAgICAgICAgIFJvbGxpbmcgb3V0IGpzdGVzdF91bml0dGVzdC5weSBzbyBpdCBjYW4g YmUgcmV2aWV3ZWQKSW5kZXg6IFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvY29tbW9uL25ldC9idWd6 aWxsYS9idWd6aWxsYS5weQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9TY3JpcHRzL3dlYmtpdHB5L2Nv bW1vbi9uZXQvYnVnemlsbGEvYnVnemlsbGEucHkJKHJldmlzaW9uIDIxNjEwNykKKysrIFRvb2xz L1NjcmlwdHMvd2Via2l0cHkvY29tbW9uL25ldC9idWd6aWxsYS9idWd6aWxsYS5weQkod29ya2lu ZyBjb3B5KQpAQCAtNTEzLDExICs1MTMsMTMgQEAgY2xhc3MgQnVnemlsbGEob2JqZWN0KToKICAg ICAgICAgIyBzbyByZS11c2UgdGhhdC4KICAgICAgICAgYnVnX2lkID0gc2VsZi5idWdfaWRfZm9y X2F0dGFjaG1lbnRfaWQoYXR0YWNobWVudF9pZCkKICAgICAgICAgaWYgbm90IGJ1Z19pZDoKKyAg ICAgICAgICAgIF9sb2cud2FybmluZygiVW5hYmxlIHRvIHBhcnNlIGJ1Z19pZCBmcm9tIGF0dGFj aG1lbnQge30iLmZvcm1hdChhdHRhY2htZW50X2lkKSkKICAgICAgICAgICAgIHJldHVybiBOb25l CiAgICAgICAgIGF0dGFjaG1lbnRzID0gc2VsZi5mZXRjaF9idWcoYnVnX2lkKS5hdHRhY2htZW50 cyhpbmNsdWRlX29ic29sZXRlPVRydWUpCiAgICAgICAgIGZvciBhdHRhY2htZW50IGluIGF0dGFj aG1lbnRzOgogICAgICAgICAgICAgaWYgYXR0YWNobWVudC5pZCgpID09IGludChhdHRhY2htZW50 X2lkKToKICAgICAgICAgICAgICAgICByZXR1cm4gYXR0YWNobWVudAorICAgICAgICBfbG9nLmVy cm9yKCJFcnJvciBpbiBmZXRjaGluZyBhdHRhY2htZW50IHt9LCBidWdfaWQ6IHt9Ii5mb3JtYXQo YXR0YWNobWVudF9pZCwgYnVnX2lkKSkKICAgICAgICAgcmV0dXJuIE5vbmUgICMgVGhpcyBzaG91 bGQgbmV2ZXIgYmUgaGl0LgogCiAgICAgZGVmIGF1dGhlbnRpY2F0ZShzZWxmKToK