171569 2017-05-02 14:02:36 -0700 REGRESSION (r215630): Web Inspector: Option-Click on URL in Styles sidebar does not work 2017-05-03 18:39:50 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED https://webkit.org/ InRadar P2 Normal --- 1 nvasilyev hi commit-queue hi inspector-bugzilla-changes joepeck webkit-bug-importer oldest_to_newest 1303800 0 nvasilyev 2017-05-02 14:02:36 -0700 ------- Inspected URL: https://webkit.org/ Loading completed: true Frontend User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_12_4) AppleWebKit/604.1.21+ (KHTML, like Gecko) Uncaught Exceptions: - TypeError: frame.resourceForURL is not a function. (In 'frame.resourceForURL(simplifiedURL, searchChildFrames)', 'frame.resourceForURL' is undefined) (at Main.js:856:91) openURL @ Main.js:856:91 tokenTrackingControllerHighlightedRangeWasClicked @ CSSStyleDeclarationTextEditor.js:1717:33 _mouseButtonWasReleasedOverEditor @ CodeMirrorTokenTrackingController.js:425:89 handleEvent @ CodeMirrorTokenTrackingController.js:253:51 ------- * STEPS TO REPRODUCE 1. Open https://webkit.org/. 2. Inspect the WebKit logo in top left corner (h1.logo). 3. In the Styles sidebar, find "background-image: url('images/webkit.svg');" and option-click on the image URL. * EXPECTED Image opens in the Resources tab. 1303801 1 webkit-bug-importer 2017-05-02 14:02:51 -0700 <rdar://problem/31946367> 1303940 2 hi 2017-05-02 19:56:23 -0700 I think this regressed in r215630 <https://webkit.org/b/168709>. It looks like I forgot the `frame` parameter of `WebInspector.openURL` in CSSStyleDeclarationTextEditor.js:1717. It should be: // Special case option-clicking url(...) links. if (token && /\blink\b/.test(token.type)) { let url = token.string; let baseURL = sourceCodeLocation ? sourceCodeLocation.sourceCode.url : this._style.node.ownerDocument.documentURL; const frame = null; WebInspector.openURL(absoluteURL(url, baseURL), frame, options); return; } 1304280 3 nvasilyev 2017-05-03 15:00:28 -0700 I confirm it regressed in https://trac.webkit.org/changeset/215630/webkit. 1304287 4 nvasilyev 2017-05-03 15:06:17 -0700 (In reply to Devin Rousso from comment #2) > I think this regressed in r215630 <https://webkit.org/b/168709>. It looks > like I forgot the `frame` parameter of `WebInspector.openURL` in > CSSStyleDeclarationTextEditor.js:1717. It should be: > > // Special case option-clicking url(...) links. > if (token && /\blink\b/.test(token.type)) { > let url = token.string; > let baseURL = sourceCodeLocation ? > sourceCodeLocation.sourceCode.url : > this._style.node.ownerDocument.documentURL; > > const frame = null; > WebInspector.openURL(absoluteURL(url, baseURL), frame, options); > return; > } Yes, this solves the problem. Since you just wrote the fix, do you want to post a patch? 1304436 5 308994 hi 2017-05-03 17:57:27 -0700 Created attachment 308994 Patch 1304447 6 308994 joepeck 2017-05-03 18:18:17 -0700 Comment on attachment 308994 Patch r=me 1304459 7 308994 commit-queue 2017-05-03 18:39:49 -0700 Comment on attachment 308994 Patch Clearing flags on attachment: 308994 Committed r216166: <http://trac.webkit.org/changeset/216166> 1304460 8 commit-queue 2017-05-03 18:39:50 -0700 All reviewed patches have been landed. Closing bug. 308994 2017-05-03 17:57:27 -0700 2017-05-03 18:39:49 -0700 Patch bug-171569-20170503175727.patch text/plain 1884 hi ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IDkyNGRlZDYxNjBjNzExM2EyNzBiMTgzMjc4YzI3 NTI0MDM4NDE1ZTUuLjhjYmNkMmExYjg2OGUzNjNkYmMyMjM3YmViZGUzM2Y2YjA5NzAwYTggMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dl Ykluc3BlY3RvclVJL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDE3LTA1LTAzICBEZXZp biBSb3Vzc28gIDx3ZWJraXRAZGV2aW5yb3Vzc28uY29tPgorCisgICAgICAgIFJFR1JFU1NJT04g KHIyMTU2MzApOiBXZWIgSW5zcGVjdG9yOiBPcHRpb24tQ2xpY2sgb24gVVJMIGluIFN0eWxlcyBz aWRlYmFyIGRvZXMgbm90IHdvcmsKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTE3MTU2OQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgICogVXNlckludGVyZmFjZS9WaWV3cy9DU1NTdHlsZURlY2xhcmF0aW9uVGV4 dEVkaXRvci5qczoKKyAgICAgICAgKFdlYkluc3BlY3Rvci5Tb3VyY2VDb2RlVGV4dEVkaXRvci5w cm90b3R5cGUudG9rZW5UcmFja2luZ0NvbnRyb2xsZXJIaWdobGlnaHRlZFJhbmdlV2FzQ2xpY2tl ZCk6CisgICAgICAgIEFkZCBtaXNzaW5nIGBmcmFtZWAgcGFyYW1ldGVyIHRvIGBXZWJJbnNwZWN0 b3Iub3BlblVSTGAuCisKIDIwMTctMDUtMDMgIE5pa2l0YSBWYXNpbHlldiAgPG52YXNpbHlldkBh cHBsZS5jb20+CiAKICAgICAgICAgVW5jYXVnaHQgRXhjZXB0aW9uOiBDYW4ndCBtYWtlIGEgQ29u dGVudFZpZXcgZm9yIGFuIHVua25vd24gcmVwcmVzZW50ZWRPYmplY3Qgb2YgdHlwZTogSW5kZXhl ZERhdGFiYXNlCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFj ZS9WaWV3cy9DU1NTdHlsZURlY2xhcmF0aW9uVGV4dEVkaXRvci5qcyBiL1NvdXJjZS9XZWJJbnNw ZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL0NTU1N0eWxlRGVjbGFyYXRpb25UZXh0RWRpdG9y LmpzCmluZGV4IGQwZTYxZWNhYzI1OGJjOGQ5ODQwNDVjNmJjNjdiMzYwOTI4NzM1ODIuLmE4OWM4 NjMyNzk0N2RmNTBkNzk4NmZhODI2NThkMzU4MjUyODMzZTAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9X ZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL0NTU1N0eWxlRGVjbGFyYXRpb25UZXh0 RWRpdG9yLmpzCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdz L0NTU1N0eWxlRGVjbGFyYXRpb25UZXh0RWRpdG9yLmpzCkBAIC0xNzE0LDcgKzE3MTQsOSBAQCBX ZWJJbnNwZWN0b3IuQ1NTU3R5bGVEZWNsYXJhdGlvblRleHRFZGl0b3IgPSBjbGFzcyBDU1NTdHls ZURlY2xhcmF0aW9uVGV4dEVkaXRvcgogICAgICAgICBpZiAodG9rZW4gJiYgL1xibGlua1xiLy50 ZXN0KHRva2VuLnR5cGUpKSB7CiAgICAgICAgICAgICBsZXQgdXJsID0gdG9rZW4uc3RyaW5nOwog ICAgICAgICAgICAgbGV0IGJhc2VVUkwgPSBzb3VyY2VDb2RlTG9jYXRpb24gPyBzb3VyY2VDb2Rl TG9jYXRpb24uc291cmNlQ29kZS51cmwgOiB0aGlzLl9zdHlsZS5ub2RlLm93bmVyRG9jdW1lbnQu ZG9jdW1lbnRVUkw7Ci0gICAgICAgICAgICBXZWJJbnNwZWN0b3Iub3BlblVSTChhYnNvbHV0ZVVS TCh1cmwsIGJhc2VVUkwpLCBvcHRpb25zKTsKKworICAgICAgICAgICAgY29uc3QgZnJhbWUgPSBu dWxsOworICAgICAgICAgICAgV2ViSW5zcGVjdG9yLm9wZW5VUkwoYWJzb2x1dGVVUkwodXJsLCBi YXNlVVJMKSwgZnJhbWUsIG9wdGlvbnMpOwogICAgICAgICAgICAgcmV0dXJuOwogICAgICAgICB9 CiAK