171558 2017-05-02 11:06:41 -0700 Mac cmake buildfix after r216037 2017-05-05 11:10:45 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Local Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 dschuff webkit-unassigned achristensen commit-queue jfbastien oldest_to_newest 1303726 0 dschuff 2017-05-02 11:06:41 -0700 UIProcess/API/Cocoa/WKURLSchemeHandlerTask.mm was renamed in r216037 and the CMake build was not updated. 1303727 1 dschuff 2017-05-02 11:08:13 -0700 Log at https://wasm-stat.us/builders/mac/builds/4733/steps/JSC/logs/stdio 1303743 2 jfbastien 2017-05-02 11:54:54 -0700 got baby on me. can't fix now 1303796 3 dschuff 2017-05-02 13:53:51 -0700 I don't have my mac with me today, might be able to get to it tomorrow if nobody else does. 1304767 4 309086 dschuff 2017-05-04 12:31:35 -0700 Created attachment 309086 Patch 1304904 5 309086 jfbastien 2017-05-04 17:27:00 -0700 Comment on attachment 309086 Patch r=me 1304905 6 309086 commit-queue 2017-05-04 17:27:47 -0700 Comment on attachment 309086 Patch Rejecting attachment 309086 from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-01', 'validate-changelog', '--check-oops', '--non-interactive', 309086, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit /Volumes/Data/EWS/WebKit/Source/WebKit2/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive). Full output: http://webkit-queues.webkit.org/results/3675629 1304907 7 jfbastien 2017-05-04 17:29:55 -0700 The patch is missing the review boiler plate. Can you update with my name? Usually CQ would update the default Unreviewed but since it's not the it is le sad. 1305124 8 309170 dschuff 2017-05-05 08:53:21 -0700 Created attachment 309170 Patch 1305125 9 dschuff 2017-05-05 08:54:14 -0700 Yeah sorry the webkit-patch script kept crashing, so i just added the incomplete boilerplate myself . 1305203 10 309170 commit-queue 2017-05-05 11:10:44 -0700 Comment on attachment 309170 Patch Clearing flags on attachment: 309170 Committed r216248: <http://trac.webkit.org/changeset/216248> 1305204 11 commit-queue 2017-05-05 11:10:45 -0700 All reviewed patches have been landed. Closing bug. 309086 2017-05-04 12:31:35 -0700 2017-05-05 08:53:19 -0700 Patch bug-171558-20170504123135.patch text/plain 1209 dschuff U3VidmVyc2lvbiBSZXZpc2lvbjogMjE2MTkwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggMWFjZTEyNDQwMjFmMzlk Y2VkNmIwMDlkZmNjMjk0NWZjMTFhZDVmMi4uNjYxZjkzNmU3ZDQzYTBjZTBjM2YyYzA2MDQ4YmIz NGU1YjEyZDgyMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEwIEBACisyMDE3LTA1LTA0ICBEZXJl ayBTY2h1ZmYgIDxkc2NodWZmQGNocm9taXVtLm9yZz4KKworICAgICAgICBNYWMgY21ha2UgYnVp bGRmaXggYWZ0ZXIgcjIxNjAzNworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MTcxNTU4CisKKyAgICAgICAgKiBQbGF0Zm9ybU1hYy5jbWFrZToKKwogMjAx Ny0wNS0wNCAgS29uc3RhbnRpbiBUb2thcmV2ICA8YW5udWxlbkB5YW5kZXgucnU+CiAKICAgICAg ICAgRml4IGNvbXBpbGF0aW9uIHdpdGggSUNVIDU5LjEKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJL aXQyL1BsYXRmb3JtTWFjLmNtYWtlIGIvU291cmNlL1dlYktpdDIvUGxhdGZvcm1NYWMuY21ha2UK aW5kZXggMDQ5Nzc4MDU5ZTYxZDgyMjk3Njc5ZGY0NDk0OTYwMjI3MWU0ZTk3Zi4uMjc5NWU0NjQz MWFjZTY3NzY5OTQ5YjExOWYzMzIzODhiMDAxMzYxNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktp dDIvUGxhdGZvcm1NYWMuY21ha2UKKysrIGIvU291cmNlL1dlYktpdDIvUGxhdGZvcm1NYWMuY21h a2UKQEAgLTIxMiw3ICsyMTIsNyBAQCBsaXN0KEFQUEVORCBXZWJLaXQyX1NPVVJDRVMKICAgICBV SVByb2Nlc3MvQVBJL0NvY29hL1dLU2NyaXB0TWVzc2FnZS5tbQogICAgIFVJUHJvY2Vzcy9BUEkv Q29jb2EvV0tTZWN1cml0eU9yaWdpbi5tbQogICAgIFVJUHJvY2Vzcy9BUEkvQ29jb2EvV0tUeXBl UmVmV3JhcHBlci5tbQotICAgIFVJUHJvY2Vzcy9BUEkvQ29jb2EvV0tVUkxTY2hlbWVIYW5kbGVy VGFzay5tbQorICAgIFVJUHJvY2Vzcy9BUEkvQ29jb2EvV0tVUkxTY2hlbWVUYXNrLm1tCiAgICAg VUlQcm9jZXNzL0FQSS9Db2NvYS9XS1VzZXJDb250ZW50Q29udHJvbGxlci5tbQogICAgIFVJUHJv Y2Vzcy9BUEkvQ29jb2EvV0tVc2VyU2NyaXB0Lm1tCiAgICAgVUlQcm9jZXNzL0FQSS9Db2NvYS9X S1dlYlZpZXcubW0K 309170 2017-05-05 08:53:21 -0700 2017-05-05 11:10:44 -0700 Patch bug-171558-20170505085321.patch text/plain 1244 dschuff U3VidmVyc2lvbiBSZXZpc2lvbjogMjE2MTkwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggMWFjZTEyNDQwMjFmMzlk Y2VkNmIwMDlkZmNjMjk0NWZjMTFhZDVmMi4uMDhiMDM0ZWMyMmU4NTgwMTYzMzA5NmJmMzE4YWQ0 MzZkODQxZTZhMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEyIEBACisyMDE3LTA1LTA0ICBEZXJl ayBTY2h1ZmYgIDxkc2NodWZmQGNocm9taXVtLm9yZz4KKworICAgICAgICBNYWMgY21ha2UgYnVp bGRmaXggYWZ0ZXIgcjIxNjAzNworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MTcxNTU4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgSkYgQmFzdGllbi4KKwor ICAgICAgICAqIFBsYXRmb3JtTWFjLmNtYWtlOgorCiAyMDE3LTA1LTA0ICBLb25zdGFudGluIFRv a2FyZXYgIDxhbm51bGVuQHlhbmRleC5ydT4KIAogICAgICAgICBGaXggY29tcGlsYXRpb24gd2l0 aCBJQ1UgNTkuMQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvUGxhdGZvcm1NYWMuY21ha2Ug Yi9Tb3VyY2UvV2ViS2l0Mi9QbGF0Zm9ybU1hYy5jbWFrZQppbmRleCAwNDk3NzgwNTllNjFkODIy OTc2NzlkZjQ0OTQ5NjAyMjcxZTRlOTdmLi4yNzk1ZTQ2NDMxYWNlNjc3Njk5NDliMTE5ZjMzMjM4 OGIwMDEzNjE1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9QbGF0Zm9ybU1hYy5jbWFrZQor KysgYi9Tb3VyY2UvV2ViS2l0Mi9QbGF0Zm9ybU1hYy5jbWFrZQpAQCAtMjEyLDcgKzIxMiw3IEBA IGxpc3QoQVBQRU5EIFdlYktpdDJfU09VUkNFUwogICAgIFVJUHJvY2Vzcy9BUEkvQ29jb2EvV0tT Y3JpcHRNZXNzYWdlLm1tCiAgICAgVUlQcm9jZXNzL0FQSS9Db2NvYS9XS1NlY3VyaXR5T3JpZ2lu Lm1tCiAgICAgVUlQcm9jZXNzL0FQSS9Db2NvYS9XS1R5cGVSZWZXcmFwcGVyLm1tCi0gICAgVUlQ cm9jZXNzL0FQSS9Db2NvYS9XS1VSTFNjaGVtZUhhbmRsZXJUYXNrLm1tCisgICAgVUlQcm9jZXNz L0FQSS9Db2NvYS9XS1VSTFNjaGVtZVRhc2subW0KICAgICBVSVByb2Nlc3MvQVBJL0NvY29hL1dL VXNlckNvbnRlbnRDb250cm9sbGVyLm1tCiAgICAgVUlQcm9jZXNzL0FQSS9Db2NvYS9XS1VzZXJT Y3JpcHQubW0KICAgICBVSVByb2Nlc3MvQVBJL0NvY29hL1dLV2ViVmlldy5tbQo=