<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>171555</bug_id>
          
          <creation_ts>2017-05-02 10:26:02 -0700</creation_ts>
          <short_desc>REGRESSION(r215555-215557): [GTK] Several performance tests abort with GLib-CRITICAL **: g_source_set_ready_time: assertion &apos;source-&gt;ref_count &gt; 0&apos; failed</short_desc>
          <delta_ts>2017-11-27 02:57:43 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebKitGTK</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>DUPLICATE</resolution>
          <dup_id>176806</dup_id>
          <see_also>https://bugs.webkit.org/show_bug.cgi?id=170775</see_also>
    
    <see_also>https://bugs.webkit.org/show_bug.cgi?id=176806</see_also>
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Carlos Alberto Lopez Perez">clopez</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>bugs-noreply</cc>
    
    <cc>cgarcia</cc>
    
    <cc>mcatanzaro</cc>
    
    <cc>ysuzuki</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1303701</commentid>
    <comment_count>0</comment_count>
    <who name="Carlos Alberto Lopez Perez">clopez</who>
    <bug_when>2017-05-02 10:26:02 -0700</bug_when>
    <thetext>This started to happen on build 199 https://build.webkit.org/builders/GTK%20Linux%2064-bit%20Release%20%28Perf%29/builds/199

Several tests fail https://build.webkit.org/builders/GTK%20Linux%2064-bit%20Release%20%28Perf%29/builds/199/steps/perf-test/logs/stdio

Running Canvas/compositing-fillRect.html (34 of 160)
error: Canvas/compositing-fillRect.html
g_source_set_ready_time: assertion &apos;source-&gt;ref_count &gt; 0&apos; failed

FAILED
Finished: 17.294655 s

Running Dromaeo/dom-query.html (58 of 160)
timeout: Dromaeo/dom-query.html
FAILED
Finished: 698.050056 s


Running Dromaeo/jslib-event-jquery.html (68 of 160)
error: Dromaeo/jslib-event-jquery.html
g_source_set_ready_time: assertion &apos;source-&gt;ref_count &gt; 0&apos; failed

FAILED
Finished: 31.161938 s

[...]

The exact tests that fail change from run to run. 



My initial suspect is the GLib/GLib-networking upgrade in r215556 &lt;https://trac.webkit.org/r215556&gt;.
I will try to reproduce it locally and see if I can confirm this.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1315052</commentid>
    <comment_count>1</comment_count>
    <who name="Carlos Alberto Lopez Perez">clopez</who>
    <bug_when>2017-06-02 08:23:18 -0700</bug_when>
    <thetext>This got much worse between r217669-r217689

r217669 5 failures : https://build.webkit.org/builders/GTK%20Linux%2064-bit%20Release%20%28Perf%29/builds/470
r217689 14 failures : https://build.webkit.org/builders/GTK%20Linux%2064-bit%20Release%20%28Perf%29/builds/471


Maybe it was the GTK+ upgrade?

I&apos;m able to reproduce it on my laptop but its hard to reproduce.. I have to run the whole perf test suite and maybe I get one failure like those at the end, not 14 like on the bot.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1315523</commentid>
    <comment_count>2</comment_count>
    <who name="Yusuke Suzuki">ysuzuki</who>
    <bug_when>2017-06-04 03:22:46 -0700</bug_when>
    <thetext>Can we know which g_source_set_ready_time causes this assertion?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1315641</commentid>
    <comment_count>3</comment_count>
    <who name="Carlos Garcia Campos">cgarcia</who>
    <bug_when>2017-06-05 00:27:22 -0700</bug_when>
    <thetext>Carlos, would it be possible to run the perf tests with G_DEBUG=fatal-criticals and get a bt?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1368894</commentid>
    <comment_count>4</comment_count>
    <who name="Michael Catanzaro">mcatanzaro</who>
    <bug_when>2017-11-06 18:57:58 -0800</bug_when>
    <thetext>There&apos;s one in bug #176806 that might be related. It&apos;s not simple.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1374872</commentid>
    <comment_count>5</comment_count>
    <who name="Carlos Garcia Campos">cgarcia</who>
    <bug_when>2017-11-27 02:57:43 -0800</bug_when>
    <thetext>I think this was caused by the glib upgrade and fixed in glib, see https://git.gnome.org/browse/glib/commit/?id=281e301. I&apos;m marking this as duplicate of #176806 because that bug has a bt, let&apos;s handle it there.

*** This bug has been marked as a duplicate of bug 176806 ***</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>