<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>171524</bug_id>
          
          <creation_ts>2017-05-01 17:03:10 -0700</creation_ts>
          <short_desc>[PAL] Make &quot;PAL/pal&quot; and &quot;PAL/pal/crypto&quot; directories private</short_desc>
          <delta_ts>2017-05-02 11:00:26 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>New Bugs</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Yoshiaki Jitsukawa">yoshiaki.jitsukawa</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>commit-queue</cc>
    
    <cc>mmaxfield</cc>
    
    <cc>yoshiaki.jitsukawa</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1303504</commentid>
    <comment_count>0</comment_count>
    <who name="Yoshiaki Jitsukawa">yoshiaki.jitsukawa</who>
    <bug_when>2017-05-01 17:03:10 -0700</bug_when>
    <thetext>Currently the &quot;PAL/pal&quot; and &quot;PAL/pal/crypto&quot; directories are on the list of framework public include directories.  

These should be private to force WebCore sources to include PAL headers in &quot;#include &lt;pal/***.h&gt;&quot; style.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1303508</commentid>
    <comment_count>1</comment_count>
      <attachid>308789</attachid>
    <who name="Yoshiaki Jitsukawa">yoshiaki.jitsukawa</who>
    <bug_when>2017-05-01 17:09:54 -0700</bug_when>
    <thetext>Created attachment 308789
patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1303720</commentid>
    <comment_count>2</comment_count>
      <attachid>308789</attachid>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2017-05-02 11:00:25 -0700</bug_when>
    <thetext>Comment on attachment 308789
patch

Clearing flags on attachment: 308789

Committed r216077: &lt;http://trac.webkit.org/changeset/216077&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1303721</commentid>
    <comment_count>3</comment_count>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2017-05-02 11:00:26 -0700</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>308789</attachid>
            <date>2017-05-01 17:09:54 -0700</date>
            <delta_ts>2017-05-02 11:00:25 -0700</delta_ts>
            <desc>patch</desc>
            <filename>diff.patch</filename>
            <type>text/plain</type>
            <size>1118</size>
            <attacher name="Yoshiaki Jitsukawa">yoshiaki.jitsukawa</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL1BBTC9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29y
ZS9QQUwvQ2hhbmdlTG9nCmluZGV4IDA2NGYzYTcuLmI0ZmY0MzQgMTAwNjQ0Ci0tLSBhL1NvdXJj
ZS9XZWJDb3JlL1BBTC9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvUEFML0NoYW5nZUxv
ZwpAQCAtMSwzICsxLDE1IEBACisyMDE3LTA1LTAxICBZb3NoaWFraSBKaXRzdWthd2EgIDxZb3No
aWFraS5KaXRzdWthd2FAc29ueS5jb20+CisKKyAgICAgICAgTWFrZSAiUEFML3BhbCIgYW5kICJQ
QUwvcGFsL2NyeXB0byIgZGlyZWN0b3JpZXMgcHJpdmF0ZQorICAgICAgICBodHRwczovL2J1Z3Mu
d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTcxNTI0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg
Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgTWFrZSB0aGUgIlBBTC9wYWwiIGFuZCAiUEFML3Bh
bC9jcnlwdG8iIGRpcmVjdG9yaWVzIHByaXZhdGUgdG8gZm9yY2UgV2ViQ29yZSBzb3VyY2VzIAor
ICAgICAgICB0byBpbmNsdWRlIFBBTCBoZWFkZXJzIGluICIjaW5jbHVkZSA8cGFsLyoqKi5oPiIg
c3R5bGUuCisKKyAgICAgICAgKiBwYWwvQ01ha2VMaXN0cy50eHQ6CisKIDIwMTctMDQtMjUgIERh
bmllbCBCYXRlcyAgPGRhYmF0ZXNAYXBwbGUuY29tPgogCiAgICAgICAgIFtDb2NvYV1bV2luXSBF
bmFibGUgb2YgWC1Db250ZW50LVR5cGUtT3B0aW9uczogbm9zbmlmZiBoZWFkZXIKZGlmZiAtLWdp
dCBhL1NvdXJjZS9XZWJDb3JlL1BBTC9wYWwvQ01ha2VMaXN0cy50eHQgYi9Tb3VyY2UvV2ViQ29y
ZS9QQUwvcGFsL0NNYWtlTGlzdHMudHh0CmluZGV4IDNiNWYxZWEuLjlhMDIzZjMgMTAwNjQ0Ci0t
LSBhL1NvdXJjZS9XZWJDb3JlL1BBTC9wYWwvQ01ha2VMaXN0cy50eHQKKysrIGIvU291cmNlL1dl
YkNvcmUvUEFML3BhbC9DTWFrZUxpc3RzLnR4dApAQCAtMyw2ICszLDkgQEAgc2V0KFBBTF9TT1VS
Q0VTCiAKIHNldChQQUxfSU5DTFVERV9ESVJFQ1RPUklFUwogICAgICIke1BBTF9ESVJ9IgorKQor
CitzZXQoUEFMX1BSSVZBVEVfSU5DTFVERV9ESVJFQ1RPUklFUwogICAgICIke1BBTF9ESVJ9L3Bh
bCIKICAgICAiJHtQQUxfRElSfS9wYWwvY3J5cHRvIgogKQo=
</data>

          </attachment>
      

    </bug>

</bugzilla>