171522 2017-05-01 16:10:32 -0700 Only try to get sandbox extension handle for IndexedDB directory if it is set 2017-08-13 09:19:08 -0700 1 1 1 Unclassified WebKit WebKit2 WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 beidson beidson aestes commit-queue thorton webkit-bug-importer oldest_to_newest 1303476 0 beidson 2017-05-01 16:10:32 -0700 Only try to get sandbox extension handle for IndexedDB directory if it is set 1303477 1 webkit-bug-importer 2017-05-01 16:11:14 -0700 <rdar://problem/31925828> 1303480 2 308784 beidson 2017-05-01 16:18:30 -0700 Created attachment 308784 Patch 1303481 3 308784 aestes 2017-05-01 16:20:57 -0700 Comment on attachment 308784 Patch Is this API-testable? 1303482 4 beidson 2017-05-01 16:22:16 -0700 (In reply to Andy Estes from comment #3) > Comment on attachment 308784 [details] > Patch > > Is this API-testable? No, but testing infrastructure already caught this! (NSLogging causing perf tests to fail) 1303537 5 308784 commit-queue 2017-05-01 18:28:08 -0700 Comment on attachment 308784 Patch Clearing flags on attachment: 308784 Committed r216053: <http://trac.webkit.org/changeset/216053> 1303538 6 commit-queue 2017-05-01 18:28:09 -0700 All reviewed patches have been landed. Closing bug. 1338232 7 thorton 2017-08-13 08:57:50 -0700 Question! Why didn't you apply the same change to all the other directories? (AppCache/MediaCache/MediaKeys/WebSQL)? 1338241 8 beidson 2017-08-13 09:19:08 -0700 (In reply to Tim Horton from comment #7) > Question! Why didn't you apply the same change to all the other directories? > (AppCache/MediaCache/MediaKeys/WebSQL)? Because: 1 - it wasn't happening to them 2 - IndexedDB directory can optionally be null, but I'm sure at least some of those always get default directories I'm guessing you're asking because one of my above answers is not true in some configuration. Make that configuration fail in a test, then we'll have to fix the test :) 308784 2017-05-01 16:18:30 -0700 2017-05-01 18:28:08 -0700 Patch bug-171522-20170501161829.patch text/plain 2240 beidson U3VidmVyc2lvbiBSZXZpc2lvbjogMjE2MDEzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggYTIyNmZmMjY4YmIyMjZj YzY5ZWU4MzRlMTYyNDA5NmYyNjgwOGM0Yy4uMmQxMWY0ZjJlNWQ3MWVlZTU2YzdlMWZjMzQ1MzA3 Yzk4ZDczNzdhZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDE3LTA1LTAxICBCcmFk eSBFaWRzb24gIDxiZWlkc29uQGFwcGxlLmNvbT4KKworICAgICAgICBPbmx5IHRyeSB0byBnZXQg c2FuZGJveCBleHRlbnNpb24gaGFuZGxlIGZvciBJbmRleGVkREIgZGlyZWN0b3J5IGlmIGl0IGlz IHNldC4KKyAgICAgICAgcmRhcjovL3Byb2JsZW0vMzE5MjU4MjggYW5kIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNzE1MjIKKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFVJUHJvY2Vzcy9XZWJzaXRlRGF0YS9XZWJzaXRl RGF0YVN0b3JlLmNwcDoKKyAgICAgICAgKFdlYktpdDo6V2Vic2l0ZURhdGFTdG9yZTo6cmVzb2x2 ZURpcmVjdG9yaWVzSWZOZWNlc3NhcnkpOgorCiAyMDE3LTA1LTAxICBDYXJsb3MgR2FyY2lhIENh bXBvcyAgPGNnYXJjaWFAaWdhbGlhLmNvbT4KIAogICAgICAgICBbR1RLXSBBZGQgYXV0b21hdGlv biBzZXNzaW9uIEFQSQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL1dlYnNp dGVEYXRhL1dlYnNpdGVEYXRhU3RvcmUuY3BwIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL1dl YnNpdGVEYXRhL1dlYnNpdGVEYXRhU3RvcmUuY3BwCmluZGV4IDg0ZWU0ZDI3Y2M5YzY5MjEyMGUz ZDc1MjJmY2IzOGVmNWY5MmI1ZGYuLjVjZDFlNTg2NTBhOTFlYjYxOWZlMzg5NzM0NDhjOGJlMTkw YzU1YWMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9XZWJzaXRlRGF0YS9X ZWJzaXRlRGF0YVN0b3JlLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvV2Vic2l0 ZURhdGEvV2Vic2l0ZURhdGFTdG9yZS5jcHAKQEAgLTExOCw3ICsxMTgsOSBAQCB2b2lkIFdlYnNp dGVEYXRhU3RvcmU6OnJlc29sdmVEaXJlY3Rvcmllc0lmTmVjZXNzYXJ5KCkKICAgICBtX3Jlc29s dmVkQ29uZmlndXJhdGlvbi5tZWRpYUNhY2hlRGlyZWN0b3J5ID0gcmVzb2x2ZUFuZENyZWF0ZVJl YWRXcml0ZURpcmVjdG9yeUZvclNhbmRib3hFeHRlbnNpb24obV9jb25maWd1cmF0aW9uLm1lZGlh Q2FjaGVEaXJlY3RvcnkpOwogICAgIG1fcmVzb2x2ZWRDb25maWd1cmF0aW9uLm1lZGlhS2V5c1N0 b3JhZ2VEaXJlY3RvcnkgPSByZXNvbHZlQW5kQ3JlYXRlUmVhZFdyaXRlRGlyZWN0b3J5Rm9yU2Fu ZGJveEV4dGVuc2lvbihtX2NvbmZpZ3VyYXRpb24ubWVkaWFLZXlzU3RvcmFnZURpcmVjdG9yeSk7 CiAgICAgbV9yZXNvbHZlZENvbmZpZ3VyYXRpb24ud2ViU1FMRGF0YWJhc2VEaXJlY3RvcnkgPSBy ZXNvbHZlQW5kQ3JlYXRlUmVhZFdyaXRlRGlyZWN0b3J5Rm9yU2FuZGJveEV4dGVuc2lvbihtX2Nv bmZpZ3VyYXRpb24ud2ViU1FMRGF0YWJhc2VEaXJlY3RvcnkpOwotICAgIG1fcmVzb2x2ZWRDb25m aWd1cmF0aW9uLmluZGV4ZWREQkRhdGFiYXNlRGlyZWN0b3J5ID0gcmVzb2x2ZUFuZENyZWF0ZVJl YWRXcml0ZURpcmVjdG9yeUZvclNhbmRib3hFeHRlbnNpb24obV9jb25maWd1cmF0aW9uLmluZGV4 ZWREQkRhdGFiYXNlRGlyZWN0b3J5KTsKKworICAgIGlmICghbV9jb25maWd1cmF0aW9uLmluZGV4 ZWREQkRhdGFiYXNlRGlyZWN0b3J5LmlzRW1wdHkoKSkKKyAgICAgICAgbV9yZXNvbHZlZENvbmZp Z3VyYXRpb24uaW5kZXhlZERCRGF0YWJhc2VEaXJlY3RvcnkgPSByZXNvbHZlQW5kQ3JlYXRlUmVh ZFdyaXRlRGlyZWN0b3J5Rm9yU2FuZGJveEV4dGVuc2lvbihtX2NvbmZpZ3VyYXRpb24uaW5kZXhl ZERCRGF0YWJhc2VEaXJlY3RvcnkpOwogCiAgICAgaWYgKCFtX2NvbmZpZ3VyYXRpb24uamF2YVNj cmlwdENvbmZpZ3VyYXRpb25EaXJlY3RvcnkuaXNFbXB0eSgpKQogICAgICAgICBtX3Jlc29sdmVk Q29uZmlndXJhdGlvbi5qYXZhU2NyaXB0Q29uZmlndXJhdGlvbkRpcmVjdG9yeSA9IHJlc29sdmVQ YXRoRm9yU2FuZGJveEV4dGVuc2lvbihtX2NvbmZpZ3VyYXRpb24uamF2YVNjcmlwdENvbmZpZ3Vy YXRpb25EaXJlY3RvcnkpOwo=