171517 2017-05-01 15:26:12 -0700 Stop using strcpy() in fullyQualifiedInfoTableName() from Database.cpp 2017-05-01 15:55:42 -0700 1 1 1 Unclassified WebKit WebCore Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 171494 1 ddkilzer ddkilzer beidson bfulgham commit-queue oldest_to_newest 1303441 0 ddkilzer 2017-05-01 15:26:12 -0700 $ ./Tools/Scripts/check-webkit-style --filter="-,+security/" Source/WebCore ERROR: Source/WebCore/Modules/webdatabase/Database.cpp:102: Almost always, snprintf is better than strcpy. [security/printf] [4] ERROR: Source/WebCore/Modules/webdatabase/Database.cpp:103: Almost always, snprintf is better than strcpy. [security/printf] [4] Total errors found: 2 in 8492 files 1303443 1 308777 ddkilzer 2017-05-01 15:28:43 -0700 Created attachment 308777 Patch v1 1303465 2 308777 commit-queue 2017-05-01 15:55:41 -0700 Comment on attachment 308777 Patch v1 Clearing flags on attachment: 308777 Committed r216040: <http://trac.webkit.org/changeset/216040> 1303466 3 commit-queue 2017-05-01 15:55:42 -0700 All reviewed patches have been landed. Closing bug. 308777 2017-05-01 15:28:43 -0700 2017-05-01 15:55:41 -0700 Patch v1 bug-171517-20170501152843.patch text/plain 1553 ddkilzer U3VidmVyc2lvbiBSZXZpc2lvbjogMjE2MDIyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOGQwMzBiYTliZjFhNGI1 ODM1MTY0MThiMzI5ZWQwMmU5Y2Q5NDUwMS4uZjc5NjdkZjZlMDU1YmNiOTE5NjkyNGRjNDQxZDBi OGQyZjgyNTJkNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE2IEBACiAyMDE3LTA1LTAxICBEYXZp ZCBLaWx6ZXIgIDxkZGtpbHplckBhcHBsZS5jb20+CiAKKyAgICAgICAgU3RvcCB1c2luZyBzdHJj cHkoKSBpbiBmdWxseVF1YWxpZmllZEluZm9UYWJsZU5hbWUoKSBmcm9tIERhdGFiYXNlLmNwcAor ICAgICAgICA8aHR0cHM6Ly93ZWJraXQub3JnL2IvMTcxNTE3PgorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogTW9kdWxlcy93ZWJkYXRhYmFzZS9EYXRh YmFzZS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpmdWxseVF1YWxpZmllZEluZm9UYWJsZU5hbWUp OiBTd2l0Y2ggZnJvbSBzdHJjcHkoKSB0bworICAgICAgICBzbnByaW50ZigpLgorCisyMDE3LTA1 LTAxICBEYXZpZCBLaWx6ZXIgIDxkZGtpbHplckBhcHBsZS5jb20+CisKICAgICAgICAgW0NvY29h XSBSZXBsYWNlIHVzZXMgb2YgW2dldOKApkNsYXNzKCkgYWxsb2NdIGluIFNvdXJjZS9XZWJDb3Jl L3BsYXRmb3JtL2lvcy9XZWJWaWRlb0Z1bGxzY3JlZW5JbnRlcmZhY2VBVktpdC5tbQogICAgICAg ICA8aHR0cHM6Ly93ZWJraXQub3JnL2IvMTcxNTE0PgogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi Q29yZS9Nb2R1bGVzL3dlYmRhdGFiYXNlL0RhdGFiYXNlLmNwcCBiL1NvdXJjZS9XZWJDb3JlL01v ZHVsZXMvd2ViZGF0YWJhc2UvRGF0YWJhc2UuY3BwCmluZGV4IDhjOTJkNmU1Mzk2YWRmMTJmYmRk NjhkN2FjOTdmOWVkMTlhZGMwMTUuLjBmZjU4NmMyOWRjNjg2ZjZkMzQ3YTk0NDg4OTBkN2YxYWFk NTk2OWUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvd2ViZGF0YWJhc2UvRGF0 YWJhc2UuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvd2ViZGF0YWJhc2UvRGF0YWJh c2UuY3BwCkBAIC05OSw4ICs5OSw3IEBAIHN0YXRpYyBjb25zdCBjaGFyKiBmdWxseVF1YWxpZmll ZEluZm9UYWJsZU5hbWUoKQogCiAgICAgc3RhdGljIHN0ZDo6b25jZV9mbGFnIG9uY2VGbGFnOwog ICAgIHN0ZDo6Y2FsbF9vbmNlKG9uY2VGbGFnLCBbXSB7Ci0gICAgICAgIHN0cmNweShxdWFsaWZp ZWROYW1lLCBxdWFsaWZpZXIpOwotICAgICAgICBzdHJjcHkocXVhbGlmaWVkTmFtZSArIHNpemVv ZihxdWFsaWZpZXIpIC0gMSwgdW5xdWFsaWZpZWRJbmZvVGFibGVOYW1lKTsKKyAgICAgICAgc25w cmludGYocXVhbGlmaWVkTmFtZSwgc2l6ZW9mKHF1YWxpZmllZE5hbWUpLCAiJXMlcyIsIHF1YWxp ZmllciwgdW5xdWFsaWZpZWRJbmZvVGFibGVOYW1lKTsKICAgICB9KTsKIAogICAgIHJldHVybiBx dWFsaWZpZWROYW1lOwo=