171514 2017-05-01 14:27:47 -0700 [Cocoa] Replace uses of [get…Class() alloc] in Source/WebCore/platform/ios/WebVideoFullscreenInterfaceAVKit.mm 2017-05-01 15:41:03 -0700 1 1 1 Unclassified WebKit WebCore Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED WONTFIX P2 Normal --- 146862 171486 1 ddkilzer ddkilzer cdumez ggaren mitz sam ysuzuki oldest_to_newest 1303407 0 ddkilzer 2017-05-01 14:27:47 -0700 $ ./Tools/Scripts/check-webkit-style --filter=-,+runtime/soft-linked-alloc Source/WebCore ERROR: Source/WebCore/platform/ios/WebVideoFullscreenInterfaceAVKit.mm:447: Using +alloc with a soft-linked class. Use allocWebAVPictureInPicturePlayerLayerViewInstance() instead. [runtime/soft-linked-alloc] [4] ERROR: Source/WebCore/platform/ios/WebVideoFullscreenInterfaceAVKit.mm:616: Using +alloc with a soft-linked class. Use allocWebAVPlayerLayerViewInstance() instead. [runtime/soft-linked-alloc] [4] Total errors found: 2 in 8492 files 1303411 1 308769 ddkilzer 2017-05-01 14:35:04 -0700 Created attachment 308769 Patch v1 1303448 2 ddkilzer 2017-05-01 15:37:52 -0700 Oh dear, I wonder why WebAVPictureInPicturePlayerLayerView and WebAVPlayerLayerView were soft-linked differently here? <https://trac.webkit.org/r187044> 1303449 3 ddkilzer 2017-05-01 15:41:03 -0700 (In reply to David Kilzer (:ddkilzer) from comment #2) > Oh dear, I wonder why WebAVPictureInPicturePlayerLayerView and > WebAVPlayerLayerView were soft-linked differently here? > > <https://trac.webkit.org/r187044> Ah, for compatibility reasons. Okay, there's nothing to do here. 308769 2017-05-01 14:35:04 -0700 2017-05-01 15:33:21 -0700 Patch v1 bug-171514-20170501143503.patch text/plain 2337 ddkilzer U3VidmVyc2lvbiBSZXZpc2lvbjogMjE2MDIyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMzVlYjM0MDVkYjkyMjky ZDlhZWFjZjJmNGM0MWVlZGY3MWFmNmM0Yi4uOGQwMzBiYTliZjFhNGI1ODM1MTY0MThiMzI5ZWQw MmU5Y2Q5NDUwMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDE3LTA1LTAxICBEYXZp ZCBLaWx6ZXIgIDxkZGtpbHplckBhcHBsZS5jb20+CisKKyAgICAgICAgW0NvY29hXSBSZXBsYWNl IHVzZXMgb2YgW2dldOKApkNsYXNzKCkgYWxsb2NdIGluIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3Jt L2lvcy9XZWJWaWRlb0Z1bGxzY3JlZW5JbnRlcmZhY2VBVktpdC5tbQorICAgICAgICA8aHR0cHM6 Ly93ZWJraXQub3JnL2IvMTcxNTE0PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgICogcGxhdGZvcm0vaW9zL1dlYlZpZGVvRnVsbHNjcmVlbkludGVyZmFj ZUFWS2l0Lm1tOgorICAgICAgICAoV2ViQVZQbGF5ZXJMYXllclZpZXdfcGljdHVyZUluUGljdHVy ZVBsYXllckxheWVyVmlldyk6CisgICAgICAgIChXZWJWaWRlb0Z1bGxzY3JlZW5JbnRlcmZhY2VB VktpdDo6c2V0dXBGdWxsc2NyZWVuKToKKyAgICAgICAgLSBTd2l0Y2ggZnJvbSBbZ2V04oCmQ2xh c3MoKSBhbGxvY10gdG8gYWxsb2PigKZJbnN0YW5jZSgpLgorCiAyMDE3LTA1LTAxICBDaHJpcyBE dW1leiAgPGNkdW1lekBhcHBsZS5jb20+CiAKICAgICAgICAgUmVtb3ZlIHNvbWUgdXNhZ2Ugb2Yg UGFzc1JlZlB0ciBpbiBlZGl0aW5nIGNvZGUKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3Bs YXRmb3JtL2lvcy9XZWJWaWRlb0Z1bGxzY3JlZW5JbnRlcmZhY2VBVktpdC5tbSBiL1NvdXJjZS9X ZWJDb3JlL3BsYXRmb3JtL2lvcy9XZWJWaWRlb0Z1bGxzY3JlZW5JbnRlcmZhY2VBVktpdC5tbQpp bmRleCAyOGM5MmQ5MjFhZjQ5MmY1ZTYxYmRhNDAwMjBlMGE3ZTYyNDZmN2MzLi42Y2I2MzczYzZi MWU0ZTJmOTBkZTQ4Y2FjMzcwZjU3OGZhOGYzMWQ0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9wbGF0Zm9ybS9pb3MvV2ViVmlkZW9GdWxsc2NyZWVuSW50ZXJmYWNlQVZLaXQubW0KKysrIGIv U291cmNlL1dlYkNvcmUvcGxhdGZvcm0vaW9zL1dlYlZpZGVvRnVsbHNjcmVlbkludGVyZmFjZUFW S2l0Lm1tCkBAIC00NDQsNyArNDQ0LDcgQEAgc3RhdGljIFdlYkFWUGljdHVyZUluUGljdHVyZVBs YXllckxheWVyVmlldyAqV2ViQVZQbGF5ZXJMYXllclZpZXdfcGljdHVyZUluUGljdHUKICAgICBX ZWJBVlBsYXllckxheWVyVmlldyAqcGxheWVyTGF5ZXJWaWV3ID0gYVNlbGY7CiAgICAgV2ViQVZQ aWN0dXJlSW5QaWN0dXJlUGxheWVyTGF5ZXJWaWV3ICpwaXBWaWV3ID0gW3BsYXllckxheWVyVmll dyB2YWx1ZUZvcktleTpAIl9waWN0dXJlSW5QaWN0dXJlUGxheWVyTGF5ZXJWaWV3Il07CiAgICAg aWYgKCFwaXBWaWV3KSB7Ci0gICAgICAgIHBpcFZpZXcgPSBbW2dldFdlYkFWUGljdHVyZUluUGlj dHVyZVBsYXllckxheWVyVmlld0NsYXNzKCkgYWxsb2NdIGluaXRXaXRoRnJhbWU6Q0dSZWN0WmVy b107CisgICAgICAgIHBpcFZpZXcgPSBbYWxsb2NXZWJBVlBpY3R1cmVJblBpY3R1cmVQbGF5ZXJM YXllclZpZXdJbnN0YW5jZSgpIGluaXRXaXRoRnJhbWU6Q0dSZWN0WmVyb107CiAgICAgICAgIFtw bGF5ZXJMYXllclZpZXcgc2V0VmFsdWU6cGlwVmlldyBmb3JLZXk6QCJfcGljdHVyZUluUGljdHVy ZVBsYXllckxheWVyVmlldyJdOwogICAgIH0KICAgICByZXR1cm4gcGlwVmlldzsKQEAgLTYxMyw3 ICs2MTMsNyBAQCB2b2lkIFdlYlZpZGVvRnVsbHNjcmVlbkludGVyZmFjZUFWS2l0OjpzZXR1cEZ1 bGxzY3JlZW4oVUlWaWV3JiB2aWRlb1ZpZXcsIGNvbnN0CiAgICAgfQogCiAgICAgaWYgKCFtX3Bs YXllckxheWVyVmlldykKLSAgICAgICAgbV9wbGF5ZXJMYXllclZpZXcgPSBhZG9wdE5TKFtbZ2V0 V2ViQVZQbGF5ZXJMYXllclZpZXdDbGFzcygpIGFsbG9jXSBpbml0XSk7CisgICAgICAgIG1fcGxh eWVyTGF5ZXJWaWV3ID0gYWRvcHROUyhbYWxsb2NXZWJBVlBsYXllckxheWVyVmlld0luc3RhbmNl KCkgaW5pdF0pOwogICAgIFttX3BsYXllckxheWVyVmlldyBzZXRIaWRkZW46W3BsYXllckNvbnRy b2xsZXIoKSBpc0V4dGVybmFsUGxheWJhY2tBY3RpdmVdXTsKICAgICBbbV9wbGF5ZXJMYXllclZp ZXcgc2V0QmFja2dyb3VuZENvbG9yOltnZXRVSUNvbG9yQ2xhc3MoKSBjbGVhckNvbG9yXV07CiAK