171494 2017-05-01 06:47:38 -0700 check-webkit-style: Enable sprintf(), strcat(), strcpy() and printf() format checks 2017-05-01 15:49:24 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=170994 P2 Normal --- 171512 171517 171520 1 ddkilzer ddkilzer beidson bfulgham buildbot commit-queue dbates ddkilzer glenn joepeck mitz sam wilander oldest_to_newest 1303223 0 ddkilzer 2017-05-01 06:47:38 -0700 I'm guessing these checks were disabled because all of the "runtime/printf" checks together were too verbose when the original check-webkit-style was committed in 2009 in r45857. However, this meant that functions like strcat() and strcpy() were allowed to be committed into the WebKit tree at various times (see Bug 170994). We should turn these checks back on under a new category. 1303227 1 308719 ddkilzer 2017-05-01 06:54:43 -0700 Created attachment 308719 Patch v1 1303250 2 308719 bfulgham 2017-05-01 09:36:29 -0700 Comment on attachment 308719 Patch v1 r=me. 1303273 3 308719 commit-queue 2017-05-01 10:06:43 -0700 Comment on attachment 308719 Patch v1 Clearing flags on attachment: 308719 Committed r216017: <http://trac.webkit.org/changeset/216017> 1303274 4 commit-queue 2017-05-01 10:06:45 -0700 All reviewed patches have been landed. Closing bug. 308719 2017-05-01 06:54:43 -0700 2017-05-01 10:06:43 -0700 Patch v1 bug-171494-20170501065458.patch text/plain 5498 ddkilzer U3VidmVyc2lvbiBSZXZpc2lvbjogMjE2MDEzCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggMDQ1NWE1NTYwMDhlOGU2ZmEzNjQxNTQxMGY2MzNhN2M0 NGFkNTkxMi4uODBkZjZhMTUyOWJjOTNlZTM2OGVmMjRlZGE2MDRlNWUzNGJkNmMzOSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDIz IEBACiAyMDE3LTA1LTAxICBEYXZpZCBLaWx6ZXIgIDxkZGtpbHplckBhcHBsZS5jb20+CiAKKyAg ICAgICAgY2hlY2std2Via2l0LXN0eWxlOiBFbmFibGUgc3ByaW50ZigpLCBzdHJjYXQoKSwgc3Ry Y3B5KCkgYW5kIHByaW50ZigpIGZvcm1hdCBjaGVja3MKKyAgICAgICAgPGh0dHBzOi8vd2Via2l0 Lm9yZy9iLzE3MTQ5ND4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkvc3R5bGUvY2hlY2tlcnMvY3BwLnB5OgorICAgICAg ICAoY2hlY2tfbGFuZ3VhZ2UpOiBDaGFuZ2UgY2F0ZWdvcmllcyBmb3IgY2VydGFpbiBjaGVja2Vy cyBmcm9tCisgICAgICAgICdydW50aW1lL3ByaW50ZicgdG8gJ3NlY3VyaXR5L3ByaW50Zicgc28g dGhleSBhcmUgbm8gbG9uZ2VyCisgICAgICAgIGZpbHRlcmVkLgorICAgICAgICAoQ3BwQ2hlY2tl ci5jYXRlZ29yaWVzKTogQWRkICdzZWN1cml0eS9wcmludGYnLgorICAgICAgICAqIFNjcmlwdHMv d2Via2l0cHkvc3R5bGUvY2hlY2tlcnMvY3BwX3VuaXR0ZXN0LnB5OgorICAgICAgICAoQ3BwU3R5 bGVUZXN0LnRlc3RfaW5zZWN1cmVfc3RyaW5nX29wZXJhdGlvbnMpOiBBZGQgbmV3IHRlc3QgZm9y CisgICAgICAgIHNwcmludGYoKSwgc3RyY2F0KCkgYW5kIHN0cmNweSgpLgorICAgICAgICAoQ3Bw U3R5bGVUZXN0LnRlc3RfZm9ybWF0X3N0cmluZ3MpOiBVcGRhdGUgdGVzdCByZXN1bHRzIGZvciBu ZXcKKyAgICAgICAgJ3NlY3VyaXR5L3ByaW50ZicgY2F0ZWdvcnkgdXNlLgorCisyMDE3LTA1LTAx ICBEYXZpZCBLaWx6ZXIgIDxkZGtpbHplckBhcHBsZS5jb20+CisKICAgICAgICAgW0NvY29hXSBS ZXBsYWNlIHVzZXMgb2YgW2dldOKApkNsYXNzKCkgYWxsb2NdIHdpdGggYWxsb2PigKZJbnN0YW5j ZSgpIGluIFRlc3RXZWJLaXRBUEkKICAgICAgICAgPGh0dHBzOi8vd2Via2l0Lm9yZy9iLzE3MTQ5 Mz4KIApkaWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9zdHlsZS9jaGVja2Vycy9j cHAucHkgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3N0eWxlL2NoZWNrZXJzL2NwcC5weQppbmRl eCA1MzRiMTkzN2M4Y2QwOTdmNGUzZTdlM2Q0ZmFkNGIwZDkzNTdmYWYzLi5hNjI5NGI0YTBjNWIy NTY3NzQ3Mjk5MTA3NWY0NjY5NmE2ZThkYjhiIDEwMDY0NAotLS0gYS9Ub29scy9TY3JpcHRzL3dl YmtpdHB5L3N0eWxlL2NoZWNrZXJzL2NwcC5weQorKysgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5 L3N0eWxlL2NoZWNrZXJzL2NwcC5weQpAQCAtMzE4MCwxMiArMzE4MCwxMiBAQCBkZWYgY2hlY2tf bGFuZ3VhZ2UoZmlsZW5hbWUsIGNsZWFuX2xpbmVzLCBsaW5lX251bWJlciwgZmlsZV9leHRlbnNp b24sIGluY2x1ZGVfcwogCiAgICAgIyBDaGVjayBpZiBzb21lIHZlcmJvdGVuIEMgZnVuY3Rpb25z IGFyZSBiZWluZyB1c2VkLgogICAgIGlmIHNlYXJjaChyJ1xic3ByaW50ZlxiJywgbGluZSk6Ci0g ICAgICAgIGVycm9yKGxpbmVfbnVtYmVyLCAncnVudGltZS9wcmludGYnLCA1LAorICAgICAgICBl cnJvcihsaW5lX251bWJlciwgJ3NlY3VyaXR5L3ByaW50ZicsIDUsCiAgICAgICAgICAgICAgICdO ZXZlciB1c2Ugc3ByaW50Zi4gIFVzZSBzbnByaW50ZiBpbnN0ZWFkLicpCiAgICAgbWF0Y2hlZCA9 IHNlYXJjaChyJ1xiKHN0cmNweXxzdHJjYXQpXGInLCBsaW5lKQogICAgIGlmIG1hdGNoZWQ6Ci0g ICAgICAgIGVycm9yKGxpbmVfbnVtYmVyLCAncnVudGltZS9wcmludGYnLCA0LAotICAgICAgICAg ICAgICAnQWxtb3N0IGFsd2F5cywgc25wcmludGYgaXMgYmV0dGVyIHRoYW4gJXMnICUgbWF0Y2hl ZC5ncm91cCgxKSkKKyAgICAgICAgZXJyb3IobGluZV9udW1iZXIsICdzZWN1cml0eS9wcmludGYn LCA0LAorICAgICAgICAgICAgICAnQWxtb3N0IGFsd2F5cywgc25wcmludGYgaXMgYmV0dGVyIHRo YW4gJXMuJyAlIG1hdGNoZWQuZ3JvdXAoMSkpCiAKICAgICBpZiBzZWFyY2gocidcYnNzY2FuZlxi JywgbGluZSk6CiAgICAgICAgIGVycm9yKGxpbmVfbnVtYmVyLCAncnVudGltZS9wcmludGYnLCAx LApAQCAtMzIwMiw3ICszMjAyLDcgQEAgZGVmIGNoZWNrX2xhbmd1YWdlKGZpbGVuYW1lLCBjbGVh bl9saW5lcywgbGluZV9udW1iZXIsIGZpbGVfZXh0ZW5zaW9uLCBpbmNsdWRlX3MKICAgICAjIE5v dCBwZXJmZWN0IGJ1dCBpdCBjYW4gY2F0Y2ggcHJpbnRmKGZvby5jX3N0cigpKSBhbmQgcHJpbnRm KGZvby0+Y19zdHIoKSkKICAgICBtYXRjaGVkID0gcmUuc2VhcmNoKHInXGIoKD86c3RyaW5nKT9w cmludGYpXHMqXCgoW1x3LlwtPigpXSspXCknLCBsaW5lLCByZS5JKQogICAgIGlmIG1hdGNoZWQ6 Ci0gICAgICAgIGVycm9yKGxpbmVfbnVtYmVyLCAncnVudGltZS9wcmludGYnLCA0LAorICAgICAg ICBlcnJvcihsaW5lX251bWJlciwgJ3NlY3VyaXR5L3ByaW50ZicsIDQsCiAgICAgICAgICAgICAg ICdQb3RlbnRpYWwgZm9ybWF0IHN0cmluZyBidWcuIERvICVzKCIlJXMiLCAlcykgaW5zdGVhZC4n CiAgICAgICAgICAgICAgICUgKG1hdGNoZWQuZ3JvdXAoMSksIG1hdGNoZWQuZ3JvdXAoMikpKQog CkBAIC0zOTI2LDYgKzM5MjYsNyBAQCBjbGFzcyBDcHBDaGVja2VyKG9iamVjdCk6CiAgICAgICAg ICdydW50aW1lL3Vuc2lnbmVkJywKICAgICAgICAgJ3J1bnRpbWUvdmlydHVhbCcsCiAgICAgICAg ICdydW50aW1lL3d0Zl9tb3ZlJywKKyAgICAgICAgJ3NlY3VyaXR5L3ByaW50ZicsCiAgICAgICAg ICd3aGl0ZXNwYWNlL2JsYW5rX2xpbmUnLAogICAgICAgICAnd2hpdGVzcGFjZS9icmFjZXMnLAog ICAgICAgICAnd2hpdGVzcGFjZS9icmFja2V0cycsCmRpZmYgLS1naXQgYS9Ub29scy9TY3JpcHRz L3dlYmtpdHB5L3N0eWxlL2NoZWNrZXJzL2NwcF91bml0dGVzdC5weSBiL1Rvb2xzL1NjcmlwdHMv d2Via2l0cHkvc3R5bGUvY2hlY2tlcnMvY3BwX3VuaXR0ZXN0LnB5CmluZGV4IDhjM2EwMzc5YjUx ZWU5OTAxMTJlYTc5N2NkZGU5N2NmOWJhNWM4MWYuLjk0NDk4MGRjYjk4Mjg4NTNkNzBmNDk0YWE3 ODBiYTQyYThiNDMzMjMgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvc3R5bGUv Y2hlY2tlcnMvY3BwX3VuaXR0ZXN0LnB5CisrKyBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvc3R5 bGUvY2hlY2tlcnMvY3BwX3VuaXR0ZXN0LnB5CkBAIC0xNTI4LDYgKzE1MjgsMjIgQEAgY2xhc3Mg Q3BwU3R5bGVUZXN0KENwcFN0eWxlVGVzdEJhc2UpOgogICAgICAgICAgICAgICAgICAgICAgICAg ICcgZm9yIGltcHJvdmVkIHRocmVhZCBzYWZldHkuJwogICAgICAgICAgICAgICAgICAgICAgICAg ICcgIFtydW50aW1lL3RocmVhZHNhZmVfZm5dIFsyXScpCiAKKyAgICAjIFRlc3QgZm9yIGluc2Vj dXJlIHN0cmluZyBmdW5jdGlvbnMgbGlrZSBzdHJjcHkoKS9zdHJjYXQoKS4KKyAgICBkZWYgdGVz dF9pbnNlY3VyZV9zdHJpbmdfb3BlcmF0aW9ucyhzZWxmKToKKyAgICAgICAgc2VsZi5hc3NlcnRf bGludCgKKyAgICAgICAgICAgICdzcHJpbnRmKGRlc3RpbmF0aW9uLCAiJXMiLCBhcmcpJywKKyAg ICAgICAgICAgICdOZXZlciB1c2Ugc3ByaW50Zi4gIFVzZSBzbnByaW50ZiBpbnN0ZWFkLicKKyAg ICAgICAgICAgICcgIFtzZWN1cml0eS9wcmludGZdIFs1XScpCisgICAgICAgIHNlbGYuYXNzZXJ0 X2xpbnQoCisgICAgICAgICAgICAnc3RyY2F0KGRlc3RpbmF0aW9uLCBhcHBlbmQpJywKKyAgICAg ICAgICAgICdBbG1vc3QgYWx3YXlzLCBzbnByaW50ZiBpcyBiZXR0ZXIgdGhhbiBzdHJjYXQuJwor ICAgICAgICAgICAgJyAgW3NlY3VyaXR5L3ByaW50Zl0gWzRdJykKKyAgICAgICAgc2VsZi5hc3Nl cnRfbGludCgKKyAgICAgICAgICAgICdzdHJjcHkoZGVzdGluYXRpb24sIHNvdXJjZSknLAorICAg ICAgICAgICAgJ0FsbW9zdCBhbHdheXMsIHNucHJpbnRmIGlzIGJldHRlciB0aGFuIHN0cmNweS4n CisgICAgICAgICAgICAnICBbc2VjdXJpdHkvcHJpbnRmXSBbNF0nKQorICAgICAgICBzZWxmLmFz c2VydF9saW50KCdzdHJzdHIoaGF5c3RhY2ssICJuZWVkbGUiKScsICcnKQorCiAgICAgIyBUZXN0 IHBvdGVudGlhbCBmb3JtYXQgc3RyaW5nIGJ1Z3MgbGlrZSBwcmludGYoZm9vKS4KICAgICBkZWYg dGVzdF9mb3JtYXRfc3RyaW5ncyhzZWxmKToKICAgICAgICAgc2VsZi5hc3NlcnRfbGludCgncHJp bnRmKCJmb28iKScsICcnKQpAQCAtMTUzNiwyMiArMTU1MiwyMiBAQCBjbGFzcyBDcHBTdHlsZVRl c3QoQ3BwU3R5bGVUZXN0QmFzZSk6CiAgICAgICAgIHNlbGYuYXNzZXJ0X2xpbnQoCiAgICAgICAg ICAgICAncHJpbnRmKGZvbyknLAogICAgICAgICAgICAgJ1BvdGVudGlhbCBmb3JtYXQgc3RyaW5n IGJ1Zy4gRG8gcHJpbnRmKCIlcyIsIGZvbykgaW5zdGVhZC4nCi0gICAgICAgICAgICAnICBbcnVu dGltZS9wcmludGZdIFs0XScpCisgICAgICAgICAgICAnICBbc2VjdXJpdHkvcHJpbnRmXSBbNF0n KQogICAgICAgICBzZWxmLmFzc2VydF9saW50KAogICAgICAgICAgICAgJ3ByaW50Zihmb28uY19z dHIoKSknLAogICAgICAgICAgICAgJ1BvdGVudGlhbCBmb3JtYXQgc3RyaW5nIGJ1Zy4gJwogICAg ICAgICAgICAgJ0RvIHByaW50ZigiJXMiLCBmb28uY19zdHIoKSkgaW5zdGVhZC4nCi0gICAgICAg ICAgICAnICBbcnVudGltZS9wcmludGZdIFs0XScpCisgICAgICAgICAgICAnICBbc2VjdXJpdHkv cHJpbnRmXSBbNF0nKQogICAgICAgICBzZWxmLmFzc2VydF9saW50KAogICAgICAgICAgICAgJ3By aW50Zihmb28tPmNfc3RyKCkpJywKICAgICAgICAgICAgICdQb3RlbnRpYWwgZm9ybWF0IHN0cmlu ZyBidWcuICcKICAgICAgICAgICAgICdEbyBwcmludGYoIiVzIiwgZm9vLT5jX3N0cigpKSBpbnN0 ZWFkLicKLSAgICAgICAgICAgICcgIFtydW50aW1lL3ByaW50Zl0gWzRdJykKKyAgICAgICAgICAg ICcgIFtzZWN1cml0eS9wcmludGZdIFs0XScpCiAgICAgICAgIHNlbGYuYXNzZXJ0X2xpbnQoCiAg ICAgICAgICAgICAnU3RyaW5nUHJpbnRmKGZvbyknLAogICAgICAgICAgICAgJ1BvdGVudGlhbCBm b3JtYXQgc3RyaW5nIGJ1Zy4gRG8gU3RyaW5nUHJpbnRmKCIlcyIsIGZvbykgaW5zdGVhZC4nCiAg ICAgICAgICAgICAnJwotICAgICAgICAgICAgJyAgW3J1bnRpbWUvcHJpbnRmXSBbNF0nKQorICAg ICAgICAgICAgJyAgW3NlY3VyaXR5L3ByaW50Zl0gWzRdJykKIAogICAgICMgVmFyaWFibGUtbGVu Z3RoIGFycmF5cyBhcmUgbm90IHBlcm1pdHRlZC4KICAgICBkZWYgdGVzdF92YXJpYWJsZV9sZW5n dGhfYXJyYXlfZGV0ZWN0aW9uKHNlbGYpOgo=