171493 2017-05-01 06:26:14 -0700 [Cocoa] Replace uses of [get…Class() alloc] in TestWebKitAPI 2017-05-01 16:00:43 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 171486 1 ddkilzer ddkilzer commit-queue lforschler mitz oldest_to_newest 1303220 0 ddkilzer 2017-05-01 06:26:14 -0700 $ ./Tools/Scripts/check-webkit-style --filter=-,+runtime/soft-linked-alloc Tools/TestWebKitAPI ERROR: Tools/TestWebKitAPI/Tests/WebKit/ios/AudioSessionCategoryIOS.mm:69: Using +alloc with a soft-linked class. Use allocUIWindowInstance() instead. [runtime/soft-linked-alloc] [4] ERROR: Tools/TestWebKitAPI/Tests/WebKit/ios/AudioSessionCategoryIOS.mm:70: Using +alloc with a soft-linked class. Use allocUIWebViewInstance() instead. [runtime/soft-linked-alloc] [4] ERROR: Tools/TestWebKitAPI/Tests/WebKit2Cocoa/RequiresUserActionForPlayback.mm:76: Using +alloc with a soft-linked class. Use allocUIWindowInstance() instead. [runtime/soft-linked-alloc] [4] Total errors found: 3 in 755 files 1303222 1 308717 ddkilzer 2017-05-01 06:30:24 -0700 Created attachment 308717 Patch v1 1303228 2 308717 ddkilzer 2017-05-01 07:20:15 -0700 Comment on attachment 308717 Patch v1 Patch doesn't build on iOS. 1303367 3 308760 ddkilzer 2017-05-01 13:35:51 -0700 Created attachment 308760 Patch v2 1303368 4 ddkilzer 2017-05-01 13:37:01 -0700 (In reply to David Kilzer (:ddkilzer) from comment #2) > Comment on attachment 308717 [details] > Patch v1 > > Patch doesn't build on iOS. Because I'm dumb and didn't replace …Class() with …Instance()! Too early in the morning. 1303382 5 308760 mitz 2017-05-01 14:04:25 -0700 Comment on attachment 308760 Patch v2 Why not just use UIWindow and UIWebView directly? TestWebKitAPI links against UIKit. 1303404 6 ddkilzer 2017-05-01 14:24:21 -0700 (In reply to mitz from comment #5) > Comment on attachment 308760 [details] > Patch v2 > > Why not just use UIWindow and UIWebView directly? TestWebKitAPI links > against UIKit. Forest vs. trees. 1303406 7 308767 ddkilzer 2017-05-01 14:25:16 -0700 Created attachment 308767 Patch v3 1303470 8 308767 commit-queue 2017-05-01 16:00:42 -0700 Comment on attachment 308767 Patch v3 Clearing flags on attachment: 308767 Committed r216041: <http://trac.webkit.org/changeset/216041> 1303471 9 commit-queue 2017-05-01 16:00:43 -0700 All reviewed patches have been landed. Closing bug. 308717 2017-05-01 06:30:24 -0700 2017-05-01 13:35:50 -0700 Patch v1 bug-171493-20170501063039.patch text/plain 2955 ddkilzer U3VidmVyc2lvbiBSZXZpc2lvbjogMjE2MDEzCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggN2RhZmU4ZjdhYzY4Njg1Yzg0YWY5MzMyZGUzMWUwNDZj ODNhMTBlYS4uMDQ1NWE1NTYwMDhlOGU2ZmEzNjQxNTQxMGY2MzNhN2M0NGFkNTkxMiAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE3 IEBACiAyMDE3LTA1LTAxICBEYXZpZCBLaWx6ZXIgIDxkZGtpbHplckBhcHBsZS5jb20+CiAKKyAg ICAgICAgW0NvY29hXSBSZXBsYWNlIHVzZXMgb2YgW2dldOKApkNsYXNzKCkgYWxsb2NdIHdpdGgg YWxsb2PigKZJbnN0YW5jZSgpIGluIFRlc3RXZWJLaXRBUEkKKyAgICAgICAgPGh0dHBzOi8vd2Vi a2l0Lm9yZy9iLzE3MTQ5Mz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICAqIFRlc3RXZWJLaXRBUEkvVGVzdHMvV2ViS2l0L2lvcy9BdWRpb1Nlc3Npb25D YXRlZ29yeUlPUy5tbToKKyAgICAgICAgKFRlc3RXZWJLaXRBUEk6OlRFU1QpOgorICAgICAgICAq IFRlc3RXZWJLaXRBUEkvVGVzdHMvV2ViS2l0MkNvY29hL1JlcXVpcmVzVXNlckFjdGlvbkZvclBs YXliYWNrLm1tOgorICAgICAgICAoUmVxdWlyZXNVc2VyQWN0aW9uRm9yUGxheWJhY2tUZXN0Ojpj cmVhdGVXZWJWaWV3KToKKworMjAxNy0wNS0wMSAgRGF2aWQgS2lsemVyICA8ZGRraWx6ZXJAYXBw bGUuY29tPgorCiAgICAgICAgIFJFR1JFU1NJT04gKHIyMTYwMDApOiB0ZXN0LXdlYmtpdHB5IGZh aWxzIGFmdGVyIGFkZGluZyBuZXcgc29mdC1saW5rZWQgY2xhc3MgY2hlY2tlcgogCiAgICAgICAg IFVucmV2aWV3ZWQuCmRpZmYgLS1naXQgYS9Ub29scy9UZXN0V2ViS2l0QVBJL1Rlc3RzL1dlYktp dC9pb3MvQXVkaW9TZXNzaW9uQ2F0ZWdvcnlJT1MubW0gYi9Ub29scy9UZXN0V2ViS2l0QVBJL1Rl c3RzL1dlYktpdC9pb3MvQXVkaW9TZXNzaW9uQ2F0ZWdvcnlJT1MubW0KaW5kZXggOTRjMDA4NDM1 MjA5ZjAyMjM3OGRiOWU2OWM4NzZjYWI5ZmUwNzdmYy4uOWU3OTM0ZjQzYjAzOTFlYjhkYjk4OTY4 ZTQ4NDRiMjdmM2FjZDFiOCAxMDA2NDQKLS0tIGEvVG9vbHMvVGVzdFdlYktpdEFQSS9UZXN0cy9X ZWJLaXQvaW9zL0F1ZGlvU2Vzc2lvbkNhdGVnb3J5SU9TLm1tCisrKyBiL1Rvb2xzL1Rlc3RXZWJL aXRBUEkvVGVzdHMvV2ViS2l0L2lvcy9BdWRpb1Nlc3Npb25DYXRlZ29yeUlPUy5tbQpAQCAtNjYs OCArNjYsOCBAQCBuYW1lc3BhY2UgVGVzdFdlYktpdEFQSSB7CiBURVNUKFdlYktpdDEsIEF1ZGlv U2Vzc2lvbkNhdGVnb3J5SU9TKQogewogICAgIFdlYkNvcmU6OlNldHRpbmdzOjpzZXRTaG91bGRN YW5hZ2VBdWRpb1Nlc3Npb25DYXRlZ29yeSh0cnVlKTsKLSAgICBSZXRhaW5QdHI8VUlXaW5kb3c+ IHVpV2luZG93ID0gYWRvcHROUyhbW2dldFVJV2luZG93Q2xhc3MoKSBhbGxvY10gaW5pdFdpdGhG cmFtZTpOU01ha2VSZWN0KDAsIDAsIDgwMCwgNjAwKV0pOwotICAgIFJldGFpblB0cjxVSVdlYlZp ZXc+IHVpV2ViVmlldyA9IGFkb3B0TlMoW1tnZXRVSVdlYlZpZXdDbGFzcygpIGFsbG9jXSBpbml0 V2l0aEZyYW1lOk5TTWFrZVJlY3QoMCwgMCwgODAwLCA2MDApXSk7CisgICAgUmV0YWluUHRyPFVJ V2luZG93PiB1aVdpbmRvdyA9IGFkb3B0TlMoW2FsbG9jVUlXaW5kb3dDbGFzcygpIGluaXRXaXRo RnJhbWU6TlNNYWtlUmVjdCgwLCAwLCA4MDAsIDYwMCldKTsKKyAgICBSZXRhaW5QdHI8VUlXZWJW aWV3PiB1aVdlYlZpZXcgPSBhZG9wdE5TKFthbGxvY1VJV2ViVmlld0NsYXNzKCkgaW5pdFdpdGhG cmFtZTpOU01ha2VSZWN0KDAsIDAsIDgwMCwgNjAwKV0pOwogICAgIFt1aVdpbmRvdyBhZGRTdWJ2 aWV3OnVpV2ViVmlldy5nZXQoKV07CiAKICAgICB1aVdlYlZpZXcuZ2V0KCkubWVkaWFQbGF5YmFj a1JlcXVpcmVzVXNlckFjdGlvbiA9IE5POwpkaWZmIC0tZ2l0IGEvVG9vbHMvVGVzdFdlYktpdEFQ SS9UZXN0cy9XZWJLaXQyQ29jb2EvUmVxdWlyZXNVc2VyQWN0aW9uRm9yUGxheWJhY2subW0gYi9U b29scy9UZXN0V2ViS2l0QVBJL1Rlc3RzL1dlYktpdDJDb2NvYS9SZXF1aXJlc1VzZXJBY3Rpb25G b3JQbGF5YmFjay5tbQppbmRleCAxNmRmMDJiOWI3NTE2NWUwNjY2YTNjOWMzZWJjZWI4ODY3Y2M4 YmM2Li5lZDMxM2JhYmRiNWQ2YWQ5ZmEwZjJjYjhiNzQ5ZWJlYjU0NDMyYTQyIDEwMDY0NAotLS0g YS9Ub29scy9UZXN0V2ViS2l0QVBJL1Rlc3RzL1dlYktpdDJDb2NvYS9SZXF1aXJlc1VzZXJBY3Rp b25Gb3JQbGF5YmFjay5tbQorKysgYi9Ub29scy9UZXN0V2ViS2l0QVBJL1Rlc3RzL1dlYktpdDJD b2NvYS9SZXF1aXJlc1VzZXJBY3Rpb25Gb3JQbGF5YmFjay5tbQpAQCAtNzMsNyArNzMsNyBAQCBw dWJsaWM6CiAgICAgewogICAgICAgICB3ZWJWaWV3ID0gYWRvcHROUyhbW1dLV2ViVmlldyBhbGxv Y10gaW5pdFdpdGhGcmFtZTpOU01ha2VSZWN0KDAsIDAsIDgwMCwgNjAwKSBjb25maWd1cmF0aW9u OmNvbmZpZ3VyYXRpb24uZ2V0KCldKTsKICNpZiBUQVJHRVRfT1NfSVBIT05FCi0gICAgICAgIHdp bmRvdyA9IGFkb3B0TlMoW1tnZXRVSVdpbmRvd0NsYXNzKCkgYWxsb2NdIGluaXRXaXRoRnJhbWU6 TlNNYWtlUmVjdCgwLCAwLCA4MDAsIDYwMCldKTsKKyAgICAgICAgd2luZG93ID0gYWRvcHROUyhb YWxsb2NVSVdpbmRvd0NsYXNzKCkgaW5pdFdpdGhGcmFtZTpOU01ha2VSZWN0KDAsIDAsIDgwMCwg NjAwKV0pOwogICAgICAgICBbd2luZG93IGFkZFN1YnZpZXc6d2ViVmlldy5nZXQoKV07CiAjZWxz ZQogICAgICAgICB3aW5kb3cgPSBhZG9wdE5TKFtbTlNXaW5kb3cgYWxsb2NdIGluaXRXaXRoQ29u dGVudFJlY3Q6d2ViVmlldy5nZXQoKS5mcmFtZSBzdHlsZU1hc2s6TlNCb3JkZXJsZXNzV2luZG93 TWFzayBiYWNraW5nOk5TQmFja2luZ1N0b3JlQnVmZmVyZWQgZGVmZXI6Tk9dKTsK 308760 2017-05-01 13:35:51 -0700 2017-05-01 14:25:15 -0700 Patch v2 bug-171493-20170501133550.patch text/plain 2934 ddkilzer U3VidmVyc2lvbiBSZXZpc2lvbjogMjE2MDIyCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggNDVjMTc5ZTViYWY2NGQyMjJmYWM2MDMzZjE5MDk3MjM2 ZjUxNGMyYy4uODI2ODdkYjM0ZjMzMjI2MGIwNjdjODU2NGU3Mjc3MThhYWU5ODM1ZCAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1 IEBACisyMDE3LTA1LTAxICBEYXZpZCBLaWx6ZXIgIDxkZGtpbHplckBhcHBsZS5jb20+CisKKyAg ICAgICAgW0NvY29hXSBSZXBsYWNlIHVzZXMgb2YgW2dldOKApkNsYXNzKCkgYWxsb2NdIHdpdGgg YWxsb2PigKZJbnN0YW5jZSgpIGluIFRlc3RXZWJLaXRBUEkKKyAgICAgICAgPGh0dHBzOi8vd2Vi a2l0Lm9yZy9iLzE3MTQ5Mz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICAqIFRlc3RXZWJLaXRBUEkvVGVzdHMvV2ViS2l0L2lvcy9BdWRpb1Nlc3Npb25D YXRlZ29yeUlPUy5tbToKKyAgICAgICAgKFRlc3RXZWJLaXRBUEk6OlRFU1QpOgorICAgICAgICAq IFRlc3RXZWJLaXRBUEkvVGVzdHMvV2ViS2l0MkNvY29hL1JlcXVpcmVzVXNlckFjdGlvbkZvclBs YXliYWNrLm1tOgorICAgICAgICAoUmVxdWlyZXNVc2VyQWN0aW9uRm9yUGxheWJhY2tUZXN0Ojpj cmVhdGVXZWJWaWV3KToKKwogMjAxNy0wNS0wMSAgQmV0aCBEYWtpbiAgPGJkYWtpbkBhcHBsZS5j b20+CiAKICAgICAgICAgT24tc2NyZWVuIHBhbmVsIGZvciBjYW5kaWRhdGUgYmFyIGlzIGluIHRo ZSB3cm9uZyBwbGFjZSB3aGVuIHRoZSBjYXJldCBpcyBhdCB0aGUgCmRpZmYgLS1naXQgYS9Ub29s cy9UZXN0V2ViS2l0QVBJL1Rlc3RzL1dlYktpdC9pb3MvQXVkaW9TZXNzaW9uQ2F0ZWdvcnlJT1Mu bW0gYi9Ub29scy9UZXN0V2ViS2l0QVBJL1Rlc3RzL1dlYktpdC9pb3MvQXVkaW9TZXNzaW9uQ2F0 ZWdvcnlJT1MubW0KaW5kZXggOTRjMDA4NDM1MjA5ZjAyMjM3OGRiOWU2OWM4NzZjYWI5ZmUwNzdm Yy4uMDhiMDA1Zjg3YWRkODJlMTBlNDA0MzI3ZjVlMTU4NTI1NWE1YmY2MSAxMDA2NDQKLS0tIGEv VG9vbHMvVGVzdFdlYktpdEFQSS9UZXN0cy9XZWJLaXQvaW9zL0F1ZGlvU2Vzc2lvbkNhdGVnb3J5 SU9TLm1tCisrKyBiL1Rvb2xzL1Rlc3RXZWJLaXRBUEkvVGVzdHMvV2ViS2l0L2lvcy9BdWRpb1Nl c3Npb25DYXRlZ29yeUlPUy5tbQpAQCAtNjYsOCArNjYsOCBAQCBuYW1lc3BhY2UgVGVzdFdlYktp dEFQSSB7CiBURVNUKFdlYktpdDEsIEF1ZGlvU2Vzc2lvbkNhdGVnb3J5SU9TKQogewogICAgIFdl YkNvcmU6OlNldHRpbmdzOjpzZXRTaG91bGRNYW5hZ2VBdWRpb1Nlc3Npb25DYXRlZ29yeSh0cnVl KTsKLSAgICBSZXRhaW5QdHI8VUlXaW5kb3c+IHVpV2luZG93ID0gYWRvcHROUyhbW2dldFVJV2lu ZG93Q2xhc3MoKSBhbGxvY10gaW5pdFdpdGhGcmFtZTpOU01ha2VSZWN0KDAsIDAsIDgwMCwgNjAw KV0pOwotICAgIFJldGFpblB0cjxVSVdlYlZpZXc+IHVpV2ViVmlldyA9IGFkb3B0TlMoW1tnZXRV SVdlYlZpZXdDbGFzcygpIGFsbG9jXSBpbml0V2l0aEZyYW1lOk5TTWFrZVJlY3QoMCwgMCwgODAw LCA2MDApXSk7CisgICAgUmV0YWluUHRyPFVJV2luZG93PiB1aVdpbmRvdyA9IGFkb3B0TlMoW2Fs bG9jVUlXaW5kb3dJbnN0YW5jZSgpIGluaXRXaXRoRnJhbWU6TlNNYWtlUmVjdCgwLCAwLCA4MDAs IDYwMCldKTsKKyAgICBSZXRhaW5QdHI8VUlXZWJWaWV3PiB1aVdlYlZpZXcgPSBhZG9wdE5TKFth bGxvY1VJV2ViVmlld0luc3RhbmNlKCkgaW5pdFdpdGhGcmFtZTpOU01ha2VSZWN0KDAsIDAsIDgw MCwgNjAwKV0pOwogICAgIFt1aVdpbmRvdyBhZGRTdWJ2aWV3OnVpV2ViVmlldy5nZXQoKV07CiAK ICAgICB1aVdlYlZpZXcuZ2V0KCkubWVkaWFQbGF5YmFja1JlcXVpcmVzVXNlckFjdGlvbiA9IE5P OwpkaWZmIC0tZ2l0IGEvVG9vbHMvVGVzdFdlYktpdEFQSS9UZXN0cy9XZWJLaXQyQ29jb2EvUmVx dWlyZXNVc2VyQWN0aW9uRm9yUGxheWJhY2subW0gYi9Ub29scy9UZXN0V2ViS2l0QVBJL1Rlc3Rz L1dlYktpdDJDb2NvYS9SZXF1aXJlc1VzZXJBY3Rpb25Gb3JQbGF5YmFjay5tbQppbmRleCAxNmRm MDJiOWI3NTE2NWUwNjY2YTNjOWMzZWJjZWI4ODY3Y2M4YmM2Li5kNzA1ZTliOGY0YTI5NWY2M2Yx NTRjNjE5MmRmMjYyODlmYmMzZGZlIDEwMDY0NAotLS0gYS9Ub29scy9UZXN0V2ViS2l0QVBJL1Rl c3RzL1dlYktpdDJDb2NvYS9SZXF1aXJlc1VzZXJBY3Rpb25Gb3JQbGF5YmFjay5tbQorKysgYi9U b29scy9UZXN0V2ViS2l0QVBJL1Rlc3RzL1dlYktpdDJDb2NvYS9SZXF1aXJlc1VzZXJBY3Rpb25G b3JQbGF5YmFjay5tbQpAQCAtNzMsNyArNzMsNyBAQCBwdWJsaWM6CiAgICAgewogICAgICAgICB3 ZWJWaWV3ID0gYWRvcHROUyhbW1dLV2ViVmlldyBhbGxvY10gaW5pdFdpdGhGcmFtZTpOU01ha2VS ZWN0KDAsIDAsIDgwMCwgNjAwKSBjb25maWd1cmF0aW9uOmNvbmZpZ3VyYXRpb24uZ2V0KCldKTsK ICNpZiBUQVJHRVRfT1NfSVBIT05FCi0gICAgICAgIHdpbmRvdyA9IGFkb3B0TlMoW1tnZXRVSVdp bmRvd0NsYXNzKCkgYWxsb2NdIGluaXRXaXRoRnJhbWU6TlNNYWtlUmVjdCgwLCAwLCA4MDAsIDYw MCldKTsKKyAgICAgICAgd2luZG93ID0gYWRvcHROUyhbYWxsb2NVSVdpbmRvd0luc3RhbmNlKCkg aW5pdFdpdGhGcmFtZTpOU01ha2VSZWN0KDAsIDAsIDgwMCwgNjAwKV0pOwogICAgICAgICBbd2lu ZG93IGFkZFN1YnZpZXc6d2ViVmlldy5nZXQoKV07CiAjZWxzZQogICAgICAgICB3aW5kb3cgPSBh ZG9wdE5TKFtbTlNXaW5kb3cgYWxsb2NdIGluaXRXaXRoQ29udGVudFJlY3Q6d2ViVmlldy5nZXQo KS5mcmFtZSBzdHlsZU1hc2s6TlNCb3JkZXJsZXNzV2luZG93TWFzayBiYWNraW5nOk5TQmFja2lu Z1N0b3JlQnVmZmVyZWQgZGVmZXI6Tk9dKTsK 308767 2017-05-01 14:25:16 -0700 2017-05-01 16:00:42 -0700 Patch v3 bug-171493-20170501142516.patch text/plain 4218 ddkilzer U3VidmVyc2lvbiBSZXZpc2lvbjogMjE2MDIyCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggNDVjMTc5ZTViYWY2NGQyMjJmYWM2MDMzZjE5MDk3MjM2 ZjUxNGMyYy4uMWU0YzYxNWFiOGQ1YzMxMTFhMzkyYWQwNDRkMTE3YzAxZjIxODE1YiAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIx IEBACisyMDE3LTA1LTAxICBEYXZpZCBLaWx6ZXIgIDxkZGtpbHplckBhcHBsZS5jb20+CisKKyAg ICAgICAgW0NvY29hXSBSZXBsYWNlIHVzZXMgb2YgW2dldOKApkNsYXNzKCkgYWxsb2NdIGluIFRl c3RXZWJLaXRBUEkKKyAgICAgICAgPGh0dHBzOi8vd2Via2l0Lm9yZy9iLzE3MTQ5Mz4KKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFRlc3RXZWJLaXRB UEkvVGVzdHMvV2ViS2l0L2lvcy9BdWRpb1Nlc3Npb25DYXRlZ29yeUlPUy5tbToKKyAgICAgICAg UmVtb3ZlIFVJS2l0IHNvZnQtbGluayBzaW5jZSBUZXN0V2ViS2l0QVBJIGxpbmtzIHRvCisgICAg ICAgIFVJS2l0LmZyYW1ld29yay4KKyAgICAgICAgKFRlc3RXZWJLaXRBUEk6OldlYktpdDFfQXVk aW9TZXNzaW9uQ2F0ZWdvcnlJT1NfVGVzdCk6IFVzZQorICAgICAgICBVSVdpbmRvdyBhbmQgVUlX ZWJWaWV3IGNsYXNzZXMgZGlyZWN0bHkuCisgICAgICAgICogVGVzdFdlYktpdEFQSS9UZXN0cy9X ZWJLaXQyQ29jb2EvUmVxdWlyZXNVc2VyQWN0aW9uRm9yUGxheWJhY2subW06CisgICAgICAgIFJl bW92ZSBVSUtpdCBzb2Z0LWxpbmsgc2luY2UgVGVzdFdlYktpdEFQSSBsaW5rcyB0bworICAgICAg ICBVSUtpdC5mcmFtZXdvcmsuCisgICAgICAgIChSZXF1aXJlc1VzZXJBY3Rpb25Gb3JQbGF5YmFj a1Rlc3Q6OmNyZWF0ZVdlYlZpZXcpOiBVc2UgVUlXaW5kb3cKKyAgICAgICAgY2xhc3MgZGlyZWN0 bHkuCisKIDIwMTctMDUtMDEgIEJldGggRGFraW4gIDxiZGFraW5AYXBwbGUuY29tPgogCiAgICAg ICAgIE9uLXNjcmVlbiBwYW5lbCBmb3IgY2FuZGlkYXRlIGJhciBpcyBpbiB0aGUgd3JvbmcgcGxh Y2Ugd2hlbiB0aGUgY2FyZXQgaXMgYXQgdGhlIApkaWZmIC0tZ2l0IGEvVG9vbHMvVGVzdFdlYktp dEFQSS9UZXN0cy9XZWJLaXQvaW9zL0F1ZGlvU2Vzc2lvbkNhdGVnb3J5SU9TLm1tIGIvVG9vbHMv VGVzdFdlYktpdEFQSS9UZXN0cy9XZWJLaXQvaW9zL0F1ZGlvU2Vzc2lvbkNhdGVnb3J5SU9TLm1t CmluZGV4IDk0YzAwODQzNTIwOWYwMjIzNzhkYjllNjljODc2Y2FiOWZlMDc3ZmMuLjk1ZGRmZWFk ZWNiODVkZDJkYTc2OTM4N2VjMTdhYzIyNGJkNTBlZWEgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1Rlc3RX ZWJLaXRBUEkvVGVzdHMvV2ViS2l0L2lvcy9BdWRpb1Nlc3Npb25DYXRlZ29yeUlPUy5tbQorKysg Yi9Ub29scy9UZXN0V2ViS2l0QVBJL1Rlc3RzL1dlYktpdC9pb3MvQXVkaW9TZXNzaW9uQ2F0ZWdv cnlJT1MubW0KQEAgLTI5LDE2ICsyOSwxMiBAQAogCiAjaW1wb3J0ICJQbGF0Zm9ybVV0aWxpdGll cy5oIgogI2ltcG9ydCA8QVZGb3VuZGF0aW9uL0FWQXVkaW9TZXNzaW9uLmg+Ci0jaW1wb3J0IDxX ZWJDb3JlL1NldHRpbmdzLmg+CiAjaW1wb3J0IDxVSUtpdC9VSUtpdC5oPgorI2ltcG9ydCA8V2Vi Q29yZS9TZXR0aW5ncy5oPgogI2ltcG9ydCA8V2ViQ29yZS9Tb2Z0TGlua2luZy5oPgogI2ltcG9y dCA8V2ViS2l0L1dlYktpdExlZ2FjeS5oPgogI2ltcG9ydCA8d3RmL1JldGFpblB0ci5oPgogCi1T T0ZUX0xJTktfRlJBTUVXT1JLKFVJS2l0KQotU09GVF9MSU5LX0NMQVNTKFVJS2l0LCBVSVdlYlZp ZXcpCi1TT0ZUX0xJTktfQ0xBU1MoVUlLaXQsIFVJV2luZG93KQotCiBTT0ZUX0xJTktfRlJBTUVX T1JLKEFWRm91bmRhdGlvbikKIFNPRlRfTElOS19DTEFTUyhBVkZvdW5kYXRpb24sIEFWQXVkaW9T ZXNzaW9uKQogU09GVF9MSU5LX0NPTlNUQU5UKEFWRm91bmRhdGlvbiwgQVZBdWRpb1Nlc3Npb25D YXRlZ29yeUFtYmllbnQsIE5TU3RyaW5nICopCkBAIC02Niw4ICs2Miw4IEBAIG5hbWVzcGFjZSBU ZXN0V2ViS2l0QVBJIHsKIFRFU1QoV2ViS2l0MSwgQXVkaW9TZXNzaW9uQ2F0ZWdvcnlJT1MpCiB7 CiAgICAgV2ViQ29yZTo6U2V0dGluZ3M6OnNldFNob3VsZE1hbmFnZUF1ZGlvU2Vzc2lvbkNhdGVn b3J5KHRydWUpOwotICAgIFJldGFpblB0cjxVSVdpbmRvdz4gdWlXaW5kb3cgPSBhZG9wdE5TKFtb Z2V0VUlXaW5kb3dDbGFzcygpIGFsbG9jXSBpbml0V2l0aEZyYW1lOk5TTWFrZVJlY3QoMCwgMCwg ODAwLCA2MDApXSk7Ci0gICAgUmV0YWluUHRyPFVJV2ViVmlldz4gdWlXZWJWaWV3ID0gYWRvcHRO UyhbW2dldFVJV2ViVmlld0NsYXNzKCkgYWxsb2NdIGluaXRXaXRoRnJhbWU6TlNNYWtlUmVjdCgw LCAwLCA4MDAsIDYwMCldKTsKKyAgICBSZXRhaW5QdHI8VUlXaW5kb3c+IHVpV2luZG93ID0gYWRv cHROUyhbW1VJV2luZG93IGFsbG9jXSBpbml0V2l0aEZyYW1lOk5TTWFrZVJlY3QoMCwgMCwgODAw LCA2MDApXSk7CisgICAgUmV0YWluUHRyPFVJV2ViVmlldz4gdWlXZWJWaWV3ID0gYWRvcHROUyhb W1VJV2ViVmlldyBhbGxvY10gaW5pdFdpdGhGcmFtZTpOU01ha2VSZWN0KDAsIDAsIDgwMCwgNjAw KV0pOwogICAgIFt1aVdpbmRvdyBhZGRTdWJ2aWV3OnVpV2ViVmlldy5nZXQoKV07CiAKICAgICB1 aVdlYlZpZXcuZ2V0KCkubWVkaWFQbGF5YmFja1JlcXVpcmVzVXNlckFjdGlvbiA9IE5POwpkaWZm IC0tZ2l0IGEvVG9vbHMvVGVzdFdlYktpdEFQSS9UZXN0cy9XZWJLaXQyQ29jb2EvUmVxdWlyZXNV c2VyQWN0aW9uRm9yUGxheWJhY2subW0gYi9Ub29scy9UZXN0V2ViS2l0QVBJL1Rlc3RzL1dlYktp dDJDb2NvYS9SZXF1aXJlc1VzZXJBY3Rpb25Gb3JQbGF5YmFjay5tbQppbmRleCAxNmRmMDJiOWI3 NTE2NWUwNjY2YTNjOWMzZWJjZWI4ODY3Y2M4YmM2Li43OTE5MzBmNjZjN2M1OTRjMzU1MmRiOGY3 MTQ4MDI1ZjVjZjk5MGQwIDEwMDY0NAotLS0gYS9Ub29scy9UZXN0V2ViS2l0QVBJL1Rlc3RzL1dl YktpdDJDb2NvYS9SZXF1aXJlc1VzZXJBY3Rpb25Gb3JQbGF5YmFjay5tbQorKysgYi9Ub29scy9U ZXN0V2ViS2l0QVBJL1Rlc3RzL1dlYktpdDJDb2NvYS9SZXF1aXJlc1VzZXJBY3Rpb25Gb3JQbGF5 YmFjay5tbQpAQCAtMjgsMTggKzI4LDE2IEBACiAjaW1wb3J0ICJQbGF0Zm9ybVV0aWxpdGllcy5o IgogI2ltcG9ydCAiVGVzdC5oIgogI2ltcG9ydCAiVGVzdE5hdmlnYXRpb25EZWxlZ2F0ZS5oIgot I2ltcG9ydCA8V2ViQ29yZS9Tb2Z0TGlua2luZy5oPgogI2ltcG9ydCA8V2ViS2l0L1dLV2ViVmll d0NvbmZpZ3VyYXRpb25Qcml2YXRlLmg+CiAjaW1wb3J0IDxXZWJLaXQvV2ViS2l0Lmg+CiAjaW1w b3J0IDx3dGYvUmV0YWluUHRyLmg+CiAKLSNpZiBXS19BUElfRU5BQkxFRAotCiAjaWYgVEFSR0VU X09TX0lQSE9ORQotU09GVF9MSU5LX0ZSQU1FV09SSyhVSUtpdCkKLVNPRlRfTElOS19DTEFTUyhV SUtpdCwgVUlXaW5kb3cpCisjaW1wb3J0IDxVSUtpdC9VSUtpdC5oPgogI2VuZGlmCiAKKyNpZiBX S19BUElfRU5BQkxFRAorCiBzdGF0aWMgYm9vbCByZWNlaXZlZFNjcmlwdE1lc3NhZ2U7CiBzdGF0 aWMgUmV0YWluUHRyPFdLU2NyaXB0TWVzc2FnZT4gbGFzdFNjcmlwdE1lc3NhZ2U7CiAKQEAgLTcz LDcgKzcxLDcgQEAgcHVibGljOgogICAgIHsKICAgICAgICAgd2ViVmlldyA9IGFkb3B0TlMoW1tX S1dlYlZpZXcgYWxsb2NdIGluaXRXaXRoRnJhbWU6TlNNYWtlUmVjdCgwLCAwLCA4MDAsIDYwMCkg Y29uZmlndXJhdGlvbjpjb25maWd1cmF0aW9uLmdldCgpXSk7CiAjaWYgVEFSR0VUX09TX0lQSE9O RQotICAgICAgICB3aW5kb3cgPSBhZG9wdE5TKFtbZ2V0VUlXaW5kb3dDbGFzcygpIGFsbG9jXSBp bml0V2l0aEZyYW1lOk5TTWFrZVJlY3QoMCwgMCwgODAwLCA2MDApXSk7CisgICAgICAgIHdpbmRv dyA9IGFkb3B0TlMoW1tVSVdpbmRvdyBhbGxvY10gaW5pdFdpdGhGcmFtZTpOU01ha2VSZWN0KDAs IDAsIDgwMCwgNjAwKV0pOwogICAgICAgICBbd2luZG93IGFkZFN1YnZpZXc6d2ViVmlldy5nZXQo KV07CiAjZWxzZQogICAgICAgICB3aW5kb3cgPSBhZG9wdE5TKFtbTlNXaW5kb3cgYWxsb2NdIGlu aXRXaXRoQ29udGVudFJlY3Q6d2ViVmlldy5nZXQoKS5mcmFtZSBzdHlsZU1hc2s6TlNCb3JkZXJs ZXNzV2luZG93TWFzayBiYWNraW5nOk5TQmFja2luZ1N0b3JlQnVmZmVyZWQgZGVmZXI6Tk9dKTsK