171482 2017-04-29 22:02:23 -0700 Regression (r215941) Unexpected logging causes perf tests to fail 2017-05-01 16:11:55 -0700 1 1 1 Unclassified WebKit WebKit2 WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 beidson beidson ap commit-queue ryanhaddad webkit-bug-importer oldest_to_newest 1303069 0 beidson 2017-04-29 22:02:23 -0700 Regression (r215941) Unexpected logging causes perf tests to fail 1303072 1 webkit-bug-importer 2017-04-29 22:02:52 -0700 <rdar://problem/31907269> 1303073 2 webkit-bug-importer 2017-04-29 22:02:53 -0700 <rdar://problem/31907270> 1303074 3 308684 beidson 2017-04-29 22:06:43 -0700 Created attachment 308684 Patch 1303083 4 308684 commit-queue 2017-04-30 00:21:26 -0700 Comment on attachment 308684 Patch Clearing flags on attachment: 308684 Committed r215983: <http://trac.webkit.org/changeset/215983> 1303084 5 commit-queue 2017-04-30 00:21:27 -0700 All reviewed patches have been landed. Closing bug. 1303417 6 ryanhaddad 2017-05-01 14:44:49 -0700 (In reply to WebKit Commit Bot from comment #4) > Comment on attachment 308684 [details] > Patch > > Clearing flags on attachment: 308684 > > Committed r215983: <http://trac.webkit.org/changeset/215983> It appears that perf tests are still failing after this change: 2017-05-01 13:53:04.797 WebKitTestRunner[24779:798669] could not create directory "" for future sandbox extension, error Error Domain=NSCocoaErrorDomain Code=512 "The file “” couldn’t be saved." UserInfo={NSFilePath=} https://build.webkit.org/builders/Apple%20El%20Capitan%20Release%20WK2%20(Perf)/builds/319 1303450 7 beidson 2017-05-01 15:41:06 -0700 (In reply to Ryan Haddad from comment #6) > (In reply to WebKit Commit Bot from comment #4) > > Comment on attachment 308684 [details] > > Patch > > > > Clearing flags on attachment: 308684 > > > > Committed r215983: <http://trac.webkit.org/changeset/215983> > > It appears that perf tests are still failing after this change: > > 2017-05-01 13:53:04.797 WebKitTestRunner[24779:798669] could not create > directory "" for future sandbox extension, error Error > Domain=NSCocoaErrorDomain Code=512 "The file “” couldn’t be saved." > UserInfo={NSFilePath=} > > https://build.webkit.org/builders/ > Apple%20El%20Capitan%20Release%20WK2%20(Perf)/builds/319 hmmmm based on code inspection that's quite surprising. Will have to run locally with more logging to explore. 1303469 8 beidson 2017-05-01 15:57:33 -0700 (In reply to Brady Eidson from comment #7) > (In reply to Ryan Haddad from comment #6) > > (In reply to WebKit Commit Bot from comment #4) > > > Comment on attachment 308684 [details] > > > Patch > > > > > > Clearing flags on attachment: 308684 > > > > > > Committed r215983: <http://trac.webkit.org/changeset/215983> > > > > It appears that perf tests are still failing after this change: > > > > 2017-05-01 13:53:04.797 WebKitTestRunner[24779:798669] could not create > > directory "" for future sandbox extension, error Error > > Domain=NSCocoaErrorDomain Code=512 "The file “” couldn’t be saved." > > UserInfo={NSFilePath=} > > > > https://build.webkit.org/builders/ > > Apple%20El%20Capitan%20Release%20WK2%20(Perf)/builds/319 > > hmmmm based on code inspection that's quite surprising. > > Will have to run locally with more logging to explore. So far I've determined it's *not* my original cookie file change that's doing this. Huh 1303474 9 beidson 2017-05-01 16:05:57 -0700 (In reply to Brady Eidson from comment #8) > (In reply to Brady Eidson from comment #7) > > (In reply to Ryan Haddad from comment #6) > > > (In reply to WebKit Commit Bot from comment #4) > > > > Comment on attachment 308684 [details] > > > > Patch > > > > > > > > Clearing flags on attachment: 308684 > > > > > > > > Committed r215983: <http://trac.webkit.org/changeset/215983> > > > > > > It appears that perf tests are still failing after this change: > > > > > > 2017-05-01 13:53:04.797 WebKitTestRunner[24779:798669] could not create > > > directory "" for future sandbox extension, error Error > > > Domain=NSCocoaErrorDomain Code=512 "The file “” couldn’t be saved." > > > UserInfo={NSFilePath=} > > > > > > https://build.webkit.org/builders/ > > > Apple%20El%20Capitan%20Release%20WK2%20(Perf)/builds/319 > > > > hmmmm based on code inspection that's quite surprising. > > > > Will have to run locally with more logging to explore. > > So far I've determined it's *not* my original cookie file change that's > doing this. Huh Fallout from my later IndexedDB change! Hah! 1303478 10 beidson 2017-05-01 16:11:55 -0700 Following up in https://bugs.webkit.org/show_bug.cgi?id=171522 308684 2017-04-29 22:06:43 -0700 2017-04-30 00:21:26 -0700 Patch bug-171482-20170429220642.patch text/plain 4856 beidson U3VidmVyc2lvbiBSZXZpc2lvbjogMjE1OTc3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggNzQ4NmIzOWNiNDNiMjEy ZTgwYWU4OWMyOTNhZWVkMTBjZDNmYTVjZi4uZDU5ODc3NTdmYjNiMWVlMjY1NDQ1NDIwYzk4ZGMw Y2YxNjJiNjc5MCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDE3LTA0LTI5ICBCcmFk eSBFaWRzb24gIDxiZWlkc29uQGFwcGxlLmNvbT4KKworICAgICAgICBSZWdyZXNzaW9uIChyMjE1 OTQxKSBVbmV4cGVjdGVkIGxvZ2dpbmcgY2F1c2VzIHBlcmYgdGVzdHMgdG8gZmFpbC4KKyAgICAg ICAgPHJkYXI6Ly9wcm9ibGVtLzMxOTA3MjY5PiBhbmQgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTE3MTQ4MgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgICogU2hhcmVkL21hYy9TYW5kYm94RXh0ZW5zaW9uTWFjLm1tOgorICAg ICAgICAoV2ViS2l0OjpyZXNvbHZlQW5kQ3JlYXRlUmVhZFdyaXRlRGlyZWN0b3J5Rm9yU2FuZGJv eEV4dGVuc2lvbik6CisKKyAgICAgICAgKiBVSVByb2Nlc3MvQ29jb2EvV2ViUHJvY2Vzc1Bvb2xD b2NvYS5tbToKKyAgICAgICAgKFdlYktpdDo6V2ViUHJvY2Vzc1Bvb2w6Om5ldHdvcmtpbmdDYWNo ZXNEaXJlY3RvcnkpOgorICAgICAgICAoV2ViS2l0OjpXZWJQcm9jZXNzUG9vbDo6d2ViQ29udGVu dENhY2hlc0RpcmVjdG9yeSk6CisKKyAgICAgICAgKiBVSVByb2Nlc3MvV2Vic2l0ZURhdGEvV2Vi c2l0ZURhdGFTdG9yZS5jcHA6CisgICAgICAgIChXZWJLaXQ6OldlYnNpdGVEYXRhU3RvcmU6OnJl c29sdmVEaXJlY3Rvcmllc0lmTmVjZXNzYXJ5KTogT25seSByZXNvbHZlIHRoZSBjb29raWUgc3Rv cmFnZSBkaXJlY3RvcnkKKyAgICAgICAgICBpZiBhIGN1c3RvbSBvbmUgaGFzIGJlZW4gc2V0Lgor CiAyMDE3LTA0LTI5ICBZdXN1a2UgU3V6dWtpICA8dXRhdGFuZS50ZWFAZ21haWwuY29tPgogCiAg ICAgICAgIE1vdmUgV2ViQ29yZSBDUFVUaW1lIHRvIFdURiBhbmQgaW1wbGVtZW50IGl0IGluIGFs bCB0aGUgcGxhdGZvcm1zCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9TaGFyZWQvbWFjL1Nh bmRib3hFeHRlbnNpb25NYWMubW0gYi9Tb3VyY2UvV2ViS2l0Mi9TaGFyZWQvbWFjL1NhbmRib3hF eHRlbnNpb25NYWMubW0KaW5kZXggNmJlODQ2YjUxYmIyZDY5ODI3OTQ5NzkzZTBjMDJjM2JlZGZm OTJmOC4uNDQxZWIxZTE0ODA4MjMwYWFiNDA0ZjJkNjM5OGQ1MmZlNjRjNDA4OSAxMDA2NDQKLS0t IGEvU291cmNlL1dlYktpdDIvU2hhcmVkL21hYy9TYW5kYm94RXh0ZW5zaW9uTWFjLm1tCisrKyBi L1NvdXJjZS9XZWJLaXQyL1NoYXJlZC9tYWMvU2FuZGJveEV4dGVuc2lvbk1hYy5tbQpAQCAtMjIx LDcgKzIyMSw3IEBAIFN0cmluZyByZXNvbHZlQW5kQ3JlYXRlUmVhZFdyaXRlRGlyZWN0b3J5Rm9y U2FuZGJveEV4dGVuc2lvbihjb25zdCBTdHJpbmcmIHBhdGgpCiAgICAgTlNTdHJpbmcgKm5zUGF0 aCA9IHBhdGg7CiAKICAgICBpZiAoIVtbTlNGaWxlTWFuYWdlciBkZWZhdWx0TWFuYWdlcl0gY3Jl YXRlRGlyZWN0b3J5QXRQYXRoOm5zUGF0aCB3aXRoSW50ZXJtZWRpYXRlRGlyZWN0b3JpZXM6WUVT IGF0dHJpYnV0ZXM6bmlsIGVycm9yOiZlcnJvcl0pIHsKLSAgICAgICAgTlNMb2coQCJjb3VsZCBu b3QgY3JlYXRlIFwiJUBcIiwgZXJyb3IgJUAiLCBuc1BhdGgsIGVycm9yKTsKKyAgICAgICAgTlNM b2coQCJjb3VsZCBub3QgY3JlYXRlIGRpcmVjdG9yeSBcIiVAXCIgZm9yIGZ1dHVyZSBzYW5kYm94 IGV4dGVuc2lvbiwgZXJyb3IgJUAiLCBuc1BhdGgsIGVycm9yKTsKICAgICAgICAgcmV0dXJuIHsg fTsKICAgICB9CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9Db2NvYS9X ZWJQcm9jZXNzUG9vbENvY29hLm1tIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0NvY29hL1dl YlByb2Nlc3NQb29sQ29jb2EubW0KaW5kZXggYjI3Y2NlYTg4NTQ2YmVjMTk2ZmE3ZWE0OTRlMzlk NjBjYmI4YTk0Mi4uZjMxYTQxYTI2MWZlMjU1OGM4YTI4M2IxYTQ5ZjQ2ZDM3ZmE0NzViNiAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0NvY29hL1dlYlByb2Nlc3NQb29sQ29j b2EubW0KKysrIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0NvY29hL1dlYlByb2Nlc3NQb29s Q29jb2EubW0KQEAgLTMzOCw3ICszMzgsNyBAQCBTdHJpbmcgV2ViUHJvY2Vzc1Bvb2w6Om5ldHdv cmtpbmdDYWNoZXNEaXJlY3RvcnkoKSBjb25zdAogICAgIE5TRXJyb3IgKmVycm9yID0gbmlsOwog ICAgIE5TU3RyaW5nKiBuc1BhdGggPSBwYXRoOwogICAgIGlmICghW1tOU0ZpbGVNYW5hZ2VyIGRl ZmF1bHRNYW5hZ2VyXSBjcmVhdGVEaXJlY3RvcnlBdFBhdGg6bnNQYXRoIHdpdGhJbnRlcm1lZGlh dGVEaXJlY3RvcmllczpZRVMgYXR0cmlidXRlczpuaWwgZXJyb3I6JmVycm9yXSkgewotICAgICAg ICBOU0xvZyhAImNvdWxkIG5vdCBjcmVhdGUgXCIlQFwiLCBlcnJvciAlQCIsIG5zUGF0aCwgZXJy b3IpOworICAgICAgICBOU0xvZyhAImNvdWxkIG5vdCBjcmVhdGUgbmV0d29ya2luZyBjYWNoZXMg ZGlyZWN0b3J5IFwiJUBcIiwgZXJyb3IgJUAiLCBuc1BhdGgsIGVycm9yKTsKICAgICAgICAgcmV0 dXJuIFN0cmluZygpOwogICAgIH0KIApAQCAtMzU3LDcgKzM1Nyw3IEBAIFN0cmluZyBXZWJQcm9j ZXNzUG9vbDo6d2ViQ29udGVudENhY2hlc0RpcmVjdG9yeSgpIGNvbnN0CiAgICAgTlNFcnJvciAq ZXJyb3IgPSBuaWw7CiAgICAgTlNTdHJpbmcqIG5zUGF0aCA9IHBhdGg7CiAgICAgaWYgKCFbW05T RmlsZU1hbmFnZXIgZGVmYXVsdE1hbmFnZXJdIGNyZWF0ZURpcmVjdG9yeUF0UGF0aDpuc1BhdGgg d2l0aEludGVybWVkaWF0ZURpcmVjdG9yaWVzOllFUyBhdHRyaWJ1dGVzOm5pbCBlcnJvcjomZXJy b3JdKSB7Ci0gICAgICAgIE5TTG9nKEAiY291bGQgbm90IGNyZWF0ZSBcIiVAXCIsIGVycm9yICVA IiwgbnNQYXRoLCBlcnJvcik7CisgICAgICAgIE5TTG9nKEAiY291bGQgbm90IGNyZWF0ZSB3ZWIg Y29udGVudCBjYWNoZXMgZGlyZWN0b3J5IFwiJUBcIiwgZXJyb3IgJUAiLCBuc1BhdGgsIGVycm9y KTsKICAgICAgICAgcmV0dXJuIFN0cmluZygpOwogICAgIH0KIApkaWZmIC0tZ2l0IGEvU291cmNl L1dlYktpdDIvVUlQcm9jZXNzL1dlYnNpdGVEYXRhL1dlYnNpdGVEYXRhU3RvcmUuY3BwIGIvU291 cmNlL1dlYktpdDIvVUlQcm9jZXNzL1dlYnNpdGVEYXRhL1dlYnNpdGVEYXRhU3RvcmUuY3BwCmlu ZGV4IGQ0MjU2MzM4NzViNzI2YTVlZjA5MjhjYTE3MTNhNGVkMWEwNGNiMGYuLjE1ZDQ2Yzc4MDMy MTIzZGM5ZTBjYzE2MGM5YmUwMzlmOTUyZThhNDkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQy L1VJUHJvY2Vzcy9XZWJzaXRlRGF0YS9XZWJzaXRlRGF0YVN0b3JlLmNwcAorKysgYi9Tb3VyY2Uv V2ViS2l0Mi9VSVByb2Nlc3MvV2Vic2l0ZURhdGEvV2Vic2l0ZURhdGFTdG9yZS5jcHAKQEAgLTEx Niw5ICsxMTYsMTEgQEAgdm9pZCBXZWJzaXRlRGF0YVN0b3JlOjpyZXNvbHZlRGlyZWN0b3JpZXNJ Zk5lY2Vzc2FyeSgpCiAgICAgbV9yZXNvbHZlZENvbmZpZ3VyYXRpb24ubWVkaWFDYWNoZURpcmVj dG9yeSA9IHJlc29sdmVBbmRDcmVhdGVSZWFkV3JpdGVEaXJlY3RvcnlGb3JTYW5kYm94RXh0ZW5z aW9uKG1fY29uZmlndXJhdGlvbi5tZWRpYUNhY2hlRGlyZWN0b3J5KTsKICAgICBtX3Jlc29sdmVk Q29uZmlndXJhdGlvbi5tZWRpYUtleXNTdG9yYWdlRGlyZWN0b3J5ID0gcmVzb2x2ZUFuZENyZWF0 ZVJlYWRXcml0ZURpcmVjdG9yeUZvclNhbmRib3hFeHRlbnNpb24obV9jb25maWd1cmF0aW9uLm1l ZGlhS2V5c1N0b3JhZ2VEaXJlY3RvcnkpOwogICAgIG1fcmVzb2x2ZWRDb25maWd1cmF0aW9uLndl YlNRTERhdGFiYXNlRGlyZWN0b3J5ID0gcmVzb2x2ZUFuZENyZWF0ZVJlYWRXcml0ZURpcmVjdG9y eUZvclNhbmRib3hFeHRlbnNpb24obV9jb25maWd1cmF0aW9uLndlYlNRTERhdGFiYXNlRGlyZWN0 b3J5KTsKLSAgICBtX3Jlc29sdmVkQ29uZmlndXJhdGlvbi5jb29raWVTdG9yYWdlRGlyZWN0b3J5 ID0gcmVzb2x2ZUFuZENyZWF0ZVJlYWRXcml0ZURpcmVjdG9yeUZvclNhbmRib3hFeHRlbnNpb24o bV9jb25maWd1cmF0aW9uLmNvb2tpZVN0b3JhZ2VEaXJlY3RvcnkpOwogICAgIG1fcmVzb2x2ZWRD b25maWd1cmF0aW9uLmluZGV4ZWREQkRhdGFiYXNlRGlyZWN0b3J5ID0gcmVzb2x2ZUFuZENyZWF0 ZVJlYWRXcml0ZURpcmVjdG9yeUZvclNhbmRib3hFeHRlbnNpb24obV9jb25maWd1cmF0aW9uLmlu ZGV4ZWREQkRhdGFiYXNlRGlyZWN0b3J5KTsKIAorICAgIGlmICghbV9jb25maWd1cmF0aW9uLmNv b2tpZVN0b3JhZ2VEaXJlY3RvcnkuaXNFbXB0eSgpKQorICAgICAgICBtX3Jlc29sdmVkQ29uZmln dXJhdGlvbi5jb29raWVTdG9yYWdlRGlyZWN0b3J5ID0gcmVzb2x2ZUFuZENyZWF0ZVJlYWRXcml0 ZURpcmVjdG9yeUZvclNhbmRib3hFeHRlbnNpb24obV9jb25maWd1cmF0aW9uLmNvb2tpZVN0b3Jh Z2VEaXJlY3RvcnkpOworCiAgICAgaWYgKCFtX2NvbmZpZ3VyYXRpb24uamF2YVNjcmlwdENvbmZp Z3VyYXRpb25EaXJlY3RvcnkuaXNFbXB0eSgpKQogICAgICAgICBtX3Jlc29sdmVkQ29uZmlndXJh dGlvbi5qYXZhU2NyaXB0Q29uZmlndXJhdGlvbkRpcmVjdG9yeSA9IHJlc29sdmVQYXRoRm9yU2Fu ZGJveEV4dGVuc2lvbihtX2NvbmZpZ3VyYXRpb24uamF2YVNjcmlwdENvbmZpZ3VyYXRpb25EaXJl Y3RvcnkpOwogfQo=