<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>171478</bug_id>
          
          <creation_ts>2017-04-29 09:34:07 -0700</creation_ts>
          <short_desc>[Xcode] libwebrtc SRCROOT includes examples</short_desc>
          <delta_ts>2024-03-09 10:18:21 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebCore Misc.</component>
          <version>WebKit Local Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          <see_also>https://bugs.webkit.org/show_bug.cgi?id=270747</see_also>
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter>mitz</reporter>
          <assigned_to>mitz</assigned_to>
          <cc>jmarcell</cc>
    
    <cc>sam</cc>
    
    <cc>thorton</cc>
    
    <cc>webkit-bug-importer</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1303009</commentid>
    <comment_count>0</comment_count>
    <who name="">mitz</who>
    <bug_when>2017-04-29 09:34:07 -0700</bug_when>
    <thetext>The libwebrtc SRCROOT includes content from Source/webrtc/examples, some of the which is incompatible with Apple’s build system. Since the examples subdirectory is not used in building any of the targets in the Xcode project, it can be safely excluded from SRCROOT. Patch forthcoming.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1303010</commentid>
    <comment_count>1</comment_count>
      <attachid>308670</attachid>
    <who name="">mitz</who>
    <bug_when>2017-04-29 09:35:59 -0700</bug_when>
    <thetext>Created attachment 308670
Exclude examples from installsrc</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1303014</commentid>
    <comment_count>2</comment_count>
    <who name="Radar WebKit Bug Importer">webkit-bug-importer</who>
    <bug_when>2017-04-29 10:41:08 -0700</bug_when>
    <thetext>&lt;rdar://problem/31905250&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1303023</commentid>
    <comment_count>3</comment_count>
    <who name="">mitz</who>
    <bug_when>2017-04-29 11:33:23 -0700</bug_when>
    <thetext>Fixed in &lt;https://trac.webkit.org/r215974&gt;.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>308670</attachid>
            <date>2017-04-29 09:35:59 -0700</date>
            <delta_ts>2017-04-29 11:31:51 -0700</delta_ts>
            <desc>Exclude examples from installsrc</desc>
            <filename>bug-171478-20170429093558.patch</filename>
            <type>text/plain</type>
            <size>1439</size>
            <attacher>mitz</attacher>
            
              <data encoding="base64">SW5kZXg6IFNvdXJjZS9UaGlyZFBhcnR5L2xpYndlYnJ0Yy9DaGFuZ2VMb2cKPT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQot
LS0gU291cmNlL1RoaXJkUGFydHkvbGlid2VicnRjL0NoYW5nZUxvZwkocmV2aXNpb24gMjE1OTcy
KQorKysgU291cmNlL1RoaXJkUGFydHkvbGlid2VicnRjL0NoYW5nZUxvZwkod29ya2luZyBjb3B5
KQpAQCAtMSwzICsxLDEzIEBACisyMDE3LTA0LTI5ICBEYW4gQmVybnN0ZWluICA8bWl0ekBhcHBs
ZS5jb20+CisKKyAgICAgICAgW1hjb2RlXSBsaWJ3ZWJydGMgU1JDUk9PVCBpbmNsdWRlcyBleGFt
cGxlcworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTcx
NDc4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBD
b25maWd1cmF0aW9ucy9CYXNlLnhjY29uZmlnOiBFeGNsdWRlIHRoZSBTb3VyY2Uvd2VicnRjL2V4
YW1wbGVzIHN1YmRpcmVjdG9yeSBmcm9tCisgICAgICAgICAgaW5zdGFsbHNyYy4gSXRzIGNvbnRl
bnRzIGFyZSBub3QgdXNlZCBmb3IgYnVpbGRpbmcgYW55IG9mIHRoZSB0YXJnZXRzIGluIHRoZSBw
cm9qZWN0LgorCiAyMDE3LTA0LTE5ICBZb3Vlbm4gRmFibGV0ICA8eW91ZW5uQGFwcGxlLmNvbT4K
IAogICAgICAgICBbTWFjXSBBbGxvdyBjdXN0b21pemluZyBIMjY0IGVuY29kZXIKSW5kZXg6IFNv
dXJjZS9UaGlyZFBhcnR5L2xpYndlYnJ0Yy9Db25maWd1cmF0aW9ucy9CYXNlLnhjY29uZmlnCj09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT0KLS0tIFNvdXJjZS9UaGlyZFBhcnR5L2xpYndlYnJ0Yy9Db25maWd1cmF0aW9ucy9C
YXNlLnhjY29uZmlnCShyZXZpc2lvbiAyMTU5NjkpCisrKyBTb3VyY2UvVGhpcmRQYXJ0eS9saWJ3
ZWJydGMvQ29uZmlndXJhdGlvbnMvQmFzZS54Y2NvbmZpZwkod29ya2luZyBjb3B5KQpAQCAtODEs
NiArODEsOCBAQCBPVEhFUl9MREZMQUdTID0gJChBU0FOX09USEVSX0xERkxBR1MpOwogCiBHQ0Nf
UFJFUFJPQ0VTU09SX0RFRklOSVRJT05TID0gJChERUJVR19ERUZJTkVTKSAkKGluaGVyaXRlZCk7
CiAKK0VYQ0xVREVEX0lOU1RBTExTUkNfU1VCRElSRUNUT1JZX1BBVFRFUk5TID0gJChpbmhlcml0
ZWQpICIkKFBST0pFQ1RfRElSKS9Tb3VyY2Uvd2VicnRjL2V4YW1wbGVzIjsKKwogTk9STUFMX1dF
QkNPUkVfRlJBTUVXT1JLU19ESVIgPSAkKFNZU1RFTV9MSUJSQVJZX0RJUikvUHJpdmF0ZUZyYW1l
d29ya3M7CiBOT1JNQUxfV0VCQ09SRV9GUkFNRVdPUktTX0RJUltzZGs9bWFjb3N4Kl0gPSAkKFNZ
U1RFTV9MSUJSQVJZX0RJUikvRnJhbWV3b3Jrcy9XZWJLaXQuZnJhbWV3b3JrL1ZlcnNpb25zL0Ev
RnJhbWV3b3JrczsKIAo=
</data>
<flag name="review"
          id="329805"
          type_id="1"
          status="+"
          setter="thorton"
    />
          </attachment>
      

    </bug>

</bugzilla>