171445 2017-04-28 12:55:08 -0700 LayoutTests/js/dom/Promise-static-all/race.html are flakey - Unhandled Promise Rejection messages 2017-04-28 18:19:55 -0700 1 1 1 Unclassified WebKit WebCore JavaScript WebKit Nightly Build All All RESOLVED FIXED P2 Normal --- 1 joepeck joepeck commit-queue jlewis3 joepeck ryanhaddad saam ysuzuki oldest_to_newest 1302724 0 joepeck 2017-04-28 12:55:08 -0700 Summary: LayoutTests/js/dom/Promise-static-all/race.html are flakey - Unhandled Promise Rejection messages The layout tests creates two rejected promises p7, and p8 but does nothing with them. They are legitimate unhandled promise rejections. These promises can get garbage collected during the test run. So the logs depend on whether or not they get GC'd before the RejectionTracker's task happens. I'm going to silence the unhandledrejection errors in these tests. 1302733 1 joepeck 2017-04-28 13:02:42 -0700 > These promises can get garbage collected during the test run. Hmm, actually I don't think thats true. They are in window.p7 and window.p8. Either way, I think disabling the messages is the right thing to do but I'll look into this a bit more. 1302736 2 joepeck 2017-04-28 13:06:06 -0700 Running the test in the browser I always see the unhandled rejection errors, which is the behavior I would expect. The messages are not important for this test so I'm going to silence them. There may be some subtle issue here regarding the order of operations between microtasks and tasks, but again not important for this test and not particularly important in general for these optional events. 1302737 3 308585 joepeck 2017-04-28 13:07:14 -0700 Created attachment 308585 [PATCH] Proposed Fix 1302738 4 joepeck 2017-04-28 13:07:40 -0700 For reference: https://build.webkit.org/results/Apple%20iOS%2010%20Simulator%20Release%20WK2%20(Tests)/r215929%20(1023)/results.html The diffs look like: --- /Volumes/Data/slave/ios-simulator-10-release-tests-wk2/build/layout-test-results/js/dom/Promise-static-all-expected.txt +++ /Volumes/Data/slave/ios-simulator-10-release-tests-wk2/build/layout-test-results/js/dom/Promise-static-all-actual.txt @@ -1,3 +1,5 @@ +CONSOLE MESSAGE: line 1: Unhandled Promise Rejection: p7 +CONSOLE MESSAGE: line 1: Unhandled Promise Rejection: p8 Test Promise.all On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE". 1302743 5 joepeck 2017-04-28 13:14:32 -0700 <https://trac.webkit.org/r215938> 1302897 6 jlewis3 2017-04-28 17:34:03 -0700 I'm still seeing LayoutTest js/dom/Promise-static-all.html fail as of revision r215953 History: https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=js%2Fdom%2FPromise-static-all.html Build Log https://build.webkit.org/results/Apple%20iOS%2010%20Simulator%20Release%20WK2%20(Tests)/r215953%20(1036)/results.html 1302916 7 ryanhaddad 2017-04-28 17:47:33 -0700 Reopening this per Matt's comment. 1302929 8 308585 joepeck 2017-04-28 18:14:31 -0700 Comment on attachment 308585 [PATCH] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=308585&action=review > LayoutTests/js/dom/Promise-static-all.html:13 > +// window.onunhandledrejection = () => false; Oops, this line was commented out by accident. 1302930 9 joepeck 2017-04-28 18:19:55 -0700 Fixed in: https://trac.webkit.org/r215966 Thanks for pointing it out! 308585 2017-04-28 13:07:14 -0700 2017-04-28 13:12:43 -0700 [PATCH] Proposed Fix mute-1.patch text/plain 1799 joepeck ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCA0ZDVhYWNlYmE5Ny4uYzU3YzJhNzE2ZjUgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3Rz L0NoYW5nZUxvZworKysgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNyBAQAor MjAxNy0wNC0yOCAgSm9zZXBoIFBlY29yYXJvICA8cGVjb3Jhcm9AYXBwbGUuY29tPgorCisgICAg ICAgIExheW91dFRlc3RzL2pzL2RvbS9Qcm9taXNlLXN0YXRpYy1hbGwvcmFjZS5odG1sIGFyZSBm bGFrZXkgLSBVbmhhbmRsZWQgUHJvbWlzZSBSZWplY3Rpb24gbWVzc2FnZXMKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE3MTQ0NQorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICoganMvZG9tL1Byb21pc2Utc3Rh dGljLWFsbC5odG1sOgorICAgICAgICAqIGpzL2RvbS9Qcm9taXNlLXN0YXRpYy1yYWNlLmh0bWw6 CisgICAgICAgIFNpbGVuY2UgdGhlIGNvbnNvbGUgbWVzc2FnZXMgZm9yIHVuaGFuZGxlZCByZWpl Y3Rpb25zIGluIHRoaXMgdGVzdC4KKyAgICAgICAgVGhlcmUgYXJlIHVuaGFuZGxlZCByZWplY3Rp b25zIGFuZCBtZXNzYWdlcyBzb21ldGltZXMgYXBwZWFyCisgICAgICAgIGRlcGVuZGluZyBvbiB0 aGUgb3JkZXIgb2YgZXZlbnRzIG9uIHRoZSBwYWdlLiBUaGUgbWVzc2FnZXMgYXJlIG5vdAorICAg ICAgICBpbXBvcnRhbnQgZm9yIHRoaXMgdGVzdCBzbyBqdXN0IG11dGUgdGhlbS4KKwogMjAxNy0w NC0yNyAgSm9zZXBoIFBlY29yYXJvICA8cGVjb3Jhcm9AYXBwbGUuY29tPgogCiAgICAgICAgIFN1 cHBvcnQgZm9yIHByb21pc2UgcmVqZWN0aW9uIGV2ZW50cyAodW5oYW5kbGVkcmVqZWN0aW9uKQpk aWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvanMvZG9tL1Byb21pc2Utc3RhdGljLWFsbC5odG1sIGIv TGF5b3V0VGVzdHMvanMvZG9tL1Byb21pc2Utc3RhdGljLWFsbC5odG1sCmluZGV4IGRmNDZmNDc2 YTM5Li4xNDE3OTQ1ZGRmYiAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvanMvZG9tL1Byb21pc2Ut c3RhdGljLWFsbC5odG1sCisrKyBiL0xheW91dFRlc3RzL2pzL2RvbS9Qcm9taXNlLXN0YXRpYy1h bGwuaHRtbApAQCAtOSw2ICs5LDkgQEAKIDxzY3JpcHQ+CiBkZXNjcmlwdGlvbignVGVzdCBQcm9t aXNlLmFsbCcpOwogCisvLyBTaWxlbmNlIHVuaGFuZGxlZCByZWplY3Rpb24gbWVzc2FnZXMuCisv LyB3aW5kb3cub251bmhhbmRsZWRyZWplY3Rpb24gPSAoKSA9PiBmYWxzZTsKKwogd2luZG93Lmpz VGVzdElzQXN5bmMgPSB0cnVlOwogcmVzdWx0ID0gdW5kZWZpbmVkOwogCmRpZmYgLS1naXQgYS9M YXlvdXRUZXN0cy9qcy9kb20vUHJvbWlzZS1zdGF0aWMtcmFjZS5odG1sIGIvTGF5b3V0VGVzdHMv anMvZG9tL1Byb21pc2Utc3RhdGljLXJhY2UuaHRtbAppbmRleCBkM2I3YTkwZDBjMC4uNWRiNDAz MTFhMWYgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL2pzL2RvbS9Qcm9taXNlLXN0YXRpYy1yYWNl Lmh0bWwKKysrIGIvTGF5b3V0VGVzdHMvanMvZG9tL1Byb21pc2Utc3RhdGljLXJhY2UuaHRtbApA QCAtOSw2ICs5LDkgQEAKIDxzY3JpcHQ+CiBkZXNjcmlwdGlvbignVGVzdCBQcm9taXNlLnJhY2Un KTsKIAorLy8gU2lsZW5jZSB1bmhhbmRsZWQgcmVqZWN0aW9uIG1lc3NhZ2VzLgord2luZG93Lm9u dW5oYW5kbGVkcmVqZWN0aW9uID0gKCkgPT4gZmFsc2U7CisKIHdpbmRvdy5qc1Rlc3RJc0FzeW5j ID0gdHJ1ZTsKIHJlc3VsdCA9IHVuZGVmaW5lZDsKIAo=