171439 2017-04-28 11:05:59 -0700 Use PEP8 style guide for raising exceptions in webkitpy. 2017-05-01 13:23:15 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Local Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 aakash_jain aakash_jain aakash_jain ap buildbot commit-queue dbates dean_johnson dewei_zhu glenn lforschler oldest_to_newest 1302672 0 aakash_jain 2017-04-28 11:05:59 -0700 As per https://www.python.org/dev/peps/pep-0008/ "When raising an exception in Python 2, use raise ValueError('message') instead of the older form raise ValueError, 'message'" in webkitpy we are still using older folrm to raise exception. We should switch to new form. 1302675 1 308559 aakash_jain 2017-04-28 11:07:38 -0700 Created attachment 308559 Proposed path 1303037 2 308559 dbates 2017-04-29 15:40:36 -0700 Comment on attachment 308559 Proposed path View in context: https://bugs.webkit.org/attachment.cgi?id=308559&action=review > Tools/ChangeLog:9 > + "When raising an exception in Python 2, use raise ValueError('message') Does check-webkit-style check for this? If not, we should teach it to check for this style. > Tools/Scripts/webkitpy/common/net/irc/ircbot.py:-38 > - raise NotImplementedError, "subclasses must implement" We should also take this opportunity to switch to single quoted string literals. > Tools/Scripts/webkitpy/common/net/irc/ircbot.py:41 > + raise NotImplementedError("subclasses must implement") Ditto. > Tools/Scripts/webkitpy/common/net/irc/ircbot.py:44 > + raise NotImplementedError("subclasses must implement") Ditto. > Tools/Scripts/webkitpy/common/thread/messagepump.py:32 > + raise NotImplementedError("subclasses must implement") Ditto. > Tools/Scripts/webkitpy/common/thread/messagepump.py:35 > + raise NotImplementedError("subclasses must implement") Ditto. > Tools/Scripts/webkitpy/common/thread/messagepump.py:38 > + raise NotImplementedError("subclasses must implement") Ditto. > Tools/Scripts/webkitpy/tool/multicommandtool.py:133 > + raise NotImplementedError("subclasses must implement") Ditto. > Tools/Scripts/webkitpy/tool/multicommandtool.py:265 > + raise NotImplementedError("subclasses must implement") Ditto. > Tools/Scripts/webkitpy/tool/bot/queueengine.py:52 > + raise NotImplementedError("subclasses must implement") Ditto. > Tools/Scripts/webkitpy/tool/bot/queueengine.py:55 > + raise NotImplementedError("subclasses must implement") Ditto. > Tools/Scripts/webkitpy/tool/bot/queueengine.py:58 > + raise NotImplementedError("subclasses must implement") Ditto. > Tools/Scripts/webkitpy/tool/bot/queueengine.py:61 > + raise NotImplementedError("subclasses must implement") Ditto. > Tools/Scripts/webkitpy/tool/bot/queueengine.py:64 > + raise NotImplementedError("subclasses must implement") Ditto. > Tools/Scripts/webkitpy/tool/bot/queueengine.py:67 > + raise NotImplementedError("subclasses must implement") Ditto. > Tools/Scripts/webkitpy/tool/bot/queueengine.py:70 > + raise NotImplementedError("subclasses must implement") Ditto. > Tools/Scripts/webkitpy/tool/commands/queues.py:121 > + raise NotImplementedError("subclasses must implement") Ditto. > Tools/Scripts/webkitpy/tool/commands/queues.py:141 > + raise NotImplementedError("subclasses must implement") Ditto. > Tools/Scripts/webkitpy/tool/commands/queues.py:144 > + raise NotImplementedError("subclasses must implement") Ditto. > Tools/Scripts/webkitpy/tool/commands/queues.py:147 > + raise NotImplementedError("subclasses must implement") Ditto. > Tools/Scripts/webkitpy/tool/commands/stepsequence.py:43 > + raise NotImplementedError("subclasses must implement") Ditto. > Tools/Scripts/webkitpy/tool/commands/stepsequence.py:47 > + raise NotImplementedError("subclasses must implement") Ditto. > Tools/Scripts/webkitpy/tool/steps/abstractstep.py:79 > + raise NotImplementedError("subclasses must implement") Ditto. 1303063 3 308681 aakash_jain 2017-04-29 20:46:09 -0700 Created attachment 308681 Updated patch. (In reply to Daniel Bates from comment #2) > Does check-webkit-style check for this? If not, we should teach it to check > for this style. Yes, it does. e.g. : "ERROR: Tools/Scripts/webkitpy/tool/bot/queueengine.py:52: deprecated form of raising exception [pep8/W602] [5]" > We should also take this opportunity to switch to single quoted string > literals. switched. 1303070 4 308681 commit-queue 2017-04-29 22:02:24 -0700 Comment on attachment 308681 Updated patch. Clearing flags on attachment: 308681 Committed r215982: <http://trac.webkit.org/changeset/215982> 1303071 5 commit-queue 2017-04-29 22:02:25 -0700 All reviewed patches have been landed. Closing bug. 1303358 6 ap 2017-05-01 13:20:40 -0700 I think that the rule we used to have was to give WebKit coding style a higher priority than PEP8. 1303360 7 ap 2017-05-01 13:23:15 -0700 But can't really find a record of that. The latest discussion of PEP8 was here, it seems: https://lists.webkit.org/pipermail/webkit-dev/2010-April/012435.html 308559 2017-04-28 11:07:38 -0700 2017-04-29 20:46:09 -0700 Proposed path patch_style_exceptions_v1 text/plain 8262 aakash_jain SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDIxNTkwOCkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDIyIEBACisyMDE3LTA0LTI3ICBBYWthc2ggSmFpbiAgPGFha2FzaF9qYWluQGFwcGxlLmNv bT4KKworICAgICAgICBVc2UgUEVQOCBzdHlsZSBndWlkZSBmb3IgcmFpc2luZyBleGNlcHRpb25z IGluIHdlYmtpdHB5LgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MTcxNDM5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgQXMgcGVyIGh0dHBzOi8vd3d3LnB5dGhvbi5vcmcvZGV2L3BlcHMvcGVwLTAwMDgvCisg ICAgICAgICJXaGVuIHJhaXNpbmcgYW4gZXhjZXB0aW9uIGluIFB5dGhvbiAyLCB1c2UgcmFpc2Ug VmFsdWVFcnJvcignbWVzc2FnZScpIAorICAgICAgICBpbnN0ZWFkIG9mIHRoZSBvbGRlciBmb3Jt IHJhaXNlIFZhbHVlRXJyb3IsICdtZXNzYWdlJyIKKworICAgICAgICAqIFNjcmlwdHMvd2Via2l0 cHkvY29tbW9uL25ldC9pcmMvaXJjYm90LnB5OiBVc2luZyBuZXcgc3R5bGUgZm9yIHJhaXNpbmcg ZXhjZXB0aW9ucy4KKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L2NvbW1vbi90aHJlYWQvbWVz c2FnZXB1bXAucHk6IFNhbWUuCisgICAgICAgICogU2NyaXB0cy93ZWJraXRweS90b29sL2JvdC9x dWV1ZWVuZ2luZS5weTogU2FtZS4KKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L3Rvb2wvY29t bWFuZHMvcXVldWVzLnB5OiBTYW1lLgorICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkvdG9vbC9j b21tYW5kcy9zdGVwc2VxdWVuY2UucHk6IFNhbWUuCisgICAgICAgICogU2NyaXB0cy93ZWJraXRw eS90b29sL211bHRpY29tbWFuZHRvb2wucHk6IFNhbWUuCisgICAgICAgICogU2NyaXB0cy93ZWJr aXRweS90b29sL3N0ZXBzL2Fic3RyYWN0c3RlcC5weTogU2FtZS4KKwogMjAxNy0wNC0yNyAgQWxl eCBDaHJpc3RlbnNlbiAgPGFjaHJpc3RlbnNlbkB3ZWJraXQub3JnPgogCiAgICAgICAgIEFkZCBz dHViIFNQSSBmb3Igc2V0dGluZyBjb29raWUgc3RvcmFnZSBwYXRoIG9uIF9XS1dlYnNpdGVEYXRh U3RvcmVDb25maWd1cmF0aW9uCkluZGV4OiBUb29scy9TY3JpcHRzL3dlYmtpdHB5L2NvbW1vbi9u ZXQvaXJjL2lyY2JvdC5weQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9TY3JpcHRzL3dlYmtpdHB5L2Nv bW1vbi9uZXQvaXJjL2lyY2JvdC5weQkocmV2aXNpb24gMjE1OTA4KQorKysgVG9vbHMvU2NyaXB0 cy93ZWJraXRweS9jb21tb24vbmV0L2lyYy9pcmNib3QucHkJKHdvcmtpbmcgY29weSkKQEAgLTM1 LDEzICszNSwxMyBAQCBmcm9tIHdlYmtpdHB5LnRoaXJkcGFydHkuaXJjIGltcG9ydCBpcmNsCiAK IGNsYXNzIElSQ0JvdERlbGVnYXRlKG9iamVjdCk6CiAgICAgZGVmIGlyY19tZXNzYWdlX3JlY2Vp dmVkKHNlbGYsIG5pY2ssIG1lc3NhZ2UpOgotICAgICAgICByYWlzZSBOb3RJbXBsZW1lbnRlZEVy cm9yLCAic3ViY2xhc3NlcyBtdXN0IGltcGxlbWVudCIKKyAgICAgICAgcmFpc2UgTm90SW1wbGVt ZW50ZWRFcnJvcigic3ViY2xhc3NlcyBtdXN0IGltcGxlbWVudCIpCiAKICAgICBkZWYgaXJjX25p Y2tuYW1lKHNlbGYpOgotICAgICAgICByYWlzZSBOb3RJbXBsZW1lbnRlZEVycm9yLCAic3ViY2xh c3NlcyBtdXN0IGltcGxlbWVudCIKKyAgICAgICAgcmFpc2UgTm90SW1wbGVtZW50ZWRFcnJvcigi c3ViY2xhc3NlcyBtdXN0IGltcGxlbWVudCIpCiAKICAgICBkZWYgaXJjX3Bhc3N3b3JkKHNlbGYp OgotICAgICAgICByYWlzZSBOb3RJbXBsZW1lbnRlZEVycm9yLCAic3ViY2xhc3NlcyBtdXN0IGlt cGxlbWVudCIKKyAgICAgICAgcmFpc2UgTm90SW1wbGVtZW50ZWRFcnJvcigic3ViY2xhc3NlcyBt dXN0IGltcGxlbWVudCIpCiAKIAogY2xhc3MgSVJDQm90KGlyY2JvdC5TaW5nbGVTZXJ2ZXJJUkNC b3QsIE1lc3NhZ2VQdW1wRGVsZWdhdGUpOgpJbmRleDogVG9vbHMvU2NyaXB0cy93ZWJraXRweS9j b21tb24vdGhyZWFkL21lc3NhZ2VwdW1wLnB5Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFRvb2xzL1NjcmlwdHMv d2Via2l0cHkvY29tbW9uL3RocmVhZC9tZXNzYWdlcHVtcC5weQkocmV2aXNpb24gMjE1OTA4KQor KysgVG9vbHMvU2NyaXB0cy93ZWJraXRweS9jb21tb24vdGhyZWFkL21lc3NhZ2VwdW1wLnB5CSh3 b3JraW5nIGNvcHkpCkBAIC0yOSwxMyArMjksMTMgQEAKIAogY2xhc3MgTWVzc2FnZVB1bXBEZWxl Z2F0ZShvYmplY3QpOgogICAgIGRlZiBzY2hlZHVsZShzZWxmLCBpbnRlcnZhbCwgY2FsbGJhY2sp OgotICAgICAgICByYWlzZSBOb3RJbXBsZW1lbnRlZEVycm9yLCAic3ViY2xhc3NlcyBtdXN0IGlt cGxlbWVudCIKKyAgICAgICAgcmFpc2UgTm90SW1wbGVtZW50ZWRFcnJvcigic3ViY2xhc3NlcyBt dXN0IGltcGxlbWVudCIpCiAKICAgICBkZWYgbWVzc2FnZV9hdmFpbGFibGUoc2VsZiwgbWVzc2Fn ZSk6Ci0gICAgICAgIHJhaXNlIE5vdEltcGxlbWVudGVkRXJyb3IsICJzdWJjbGFzc2VzIG11c3Qg aW1wbGVtZW50IgorICAgICAgICByYWlzZSBOb3RJbXBsZW1lbnRlZEVycm9yKCJzdWJjbGFzc2Vz IG11c3QgaW1wbGVtZW50IikKIAogICAgIGRlZiBmaW5hbF9tZXNzYWdlX2RlbGl2ZXJlZChzZWxm KToKLSAgICAgICAgcmFpc2UgTm90SW1wbGVtZW50ZWRFcnJvciwgInN1YmNsYXNzZXMgbXVzdCBp bXBsZW1lbnQiCisgICAgICAgIHJhaXNlIE5vdEltcGxlbWVudGVkRXJyb3IoInN1YmNsYXNzZXMg bXVzdCBpbXBsZW1lbnQiKQogCiAKIGNsYXNzIE1lc3NhZ2VQdW1wKG9iamVjdCk6CkluZGV4OiBU b29scy9TY3JpcHRzL3dlYmtpdHB5L3Rvb2wvbXVsdGljb21tYW5kdG9vbC5weQo9PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 Ci0tLSBUb29scy9TY3JpcHRzL3dlYmtpdHB5L3Rvb2wvbXVsdGljb21tYW5kdG9vbC5weQkocmV2 aXNpb24gMjE1OTA4KQorKysgVG9vbHMvU2NyaXB0cy93ZWJraXRweS90b29sL211bHRpY29tbWFu ZHRvb2wucHkJKHdvcmtpbmcgY29weSkKQEAgLTEzMCw3ICsxMzAsNyBAQCBjbGFzcyBDb21tYW5k KG9iamVjdCk6CiAgICAgICAgIHJldHVybiBoZWxwX3RleHQKIAogICAgIGRlZiBleGVjdXRlKHNl bGYsIG9wdGlvbnMsIGFyZ3MsIHRvb2wpOgotICAgICAgICByYWlzZSBOb3RJbXBsZW1lbnRlZEVy cm9yLCAic3ViY2xhc3NlcyBtdXN0IGltcGxlbWVudCIKKyAgICAgICAgcmFpc2UgTm90SW1wbGVt ZW50ZWRFcnJvcigic3ViY2xhc3NlcyBtdXN0IGltcGxlbWVudCIpCiAKICAgICAjIG1haW4oKSBl eGlzdHMgc28gdGhhdCBDb21tYW5kcyBjYW4gYmUgdHVybmVkIGludG8gc3RhbmQtYWxvbmUgc2Ny aXB0cy4KICAgICAjIE90aGVyIHBhcnRzIG9mIHRoZSBjb2RlIHdpbGwgbGlrZWx5IHJlcXVpcmUg bW9kaWZpY2F0aW9uIHRvIHdvcmsgc3RhbmQtYWxvbmUuCkBAIC0yNjIsNyArMjYyLDcgQEAgY2xh c3MgTXVsdGlDb21tYW5kVG9vbChvYmplY3QpOgogICAgICAgICByZXR1cm4gTm9uZQogCiAgICAg ZGVmIHBhdGgoc2VsZik6Ci0gICAgICAgIHJhaXNlIE5vdEltcGxlbWVudGVkRXJyb3IsICJzdWJj bGFzc2VzIG11c3QgaW1wbGVtZW50IgorICAgICAgICByYWlzZSBOb3RJbXBsZW1lbnRlZEVycm9y KCJzdWJjbGFzc2VzIG11c3QgaW1wbGVtZW50IikKIAogICAgIGRlZiBjb21tYW5kX2NvbXBsZXRl ZChzZWxmKToKICAgICAgICAgcGFzcwpJbmRleDogVG9vbHMvU2NyaXB0cy93ZWJraXRweS90b29s L2JvdC9xdWV1ZWVuZ2luZS5weQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9TY3JpcHRzL3dlYmtpdHB5 L3Rvb2wvYm90L3F1ZXVlZW5naW5lLnB5CShyZXZpc2lvbiAyMTU5MDgpCisrKyBUb29scy9TY3Jp cHRzL3dlYmtpdHB5L3Rvb2wvYm90L3F1ZXVlZW5naW5lLnB5CSh3b3JraW5nIGNvcHkpCkBAIC00 OSwyNSArNDksMjUgQEAgY2xhc3MgVGVybWluYXRlUXVldWUoRXhjZXB0aW9uKToKIAogY2xhc3Mg UXVldWVFbmdpbmVEZWxlZ2F0ZToKICAgICBkZWYgcXVldWVfbG9nX3BhdGgoc2VsZik6Ci0gICAg ICAgIHJhaXNlIE5vdEltcGxlbWVudGVkRXJyb3IsICJzdWJjbGFzc2VzIG11c3QgaW1wbGVtZW50 IgorICAgICAgICByYWlzZSBOb3RJbXBsZW1lbnRlZEVycm9yKCJzdWJjbGFzc2VzIG11c3QgaW1w bGVtZW50IikKIAogICAgIGRlZiB3b3JrX2l0ZW1fbG9nX3BhdGgoc2VsZiwgd29ya19pdGVtKToK LSAgICAgICAgcmFpc2UgTm90SW1wbGVtZW50ZWRFcnJvciwgInN1YmNsYXNzZXMgbXVzdCBpbXBs ZW1lbnQiCisgICAgICAgIHJhaXNlIE5vdEltcGxlbWVudGVkRXJyb3IoInN1YmNsYXNzZXMgbXVz dCBpbXBsZW1lbnQiKQogCiAgICAgZGVmIGJlZ2luX3dvcmtfcXVldWUoc2VsZik6Ci0gICAgICAg IHJhaXNlIE5vdEltcGxlbWVudGVkRXJyb3IsICJzdWJjbGFzc2VzIG11c3QgaW1wbGVtZW50Igor ICAgICAgICByYWlzZSBOb3RJbXBsZW1lbnRlZEVycm9yKCJzdWJjbGFzc2VzIG11c3QgaW1wbGVt ZW50IikKIAogICAgIGRlZiBzaG91bGRfY29udGludWVfd29ya19xdWV1ZShzZWxmKToKLSAgICAg ICAgcmFpc2UgTm90SW1wbGVtZW50ZWRFcnJvciwgInN1YmNsYXNzZXMgbXVzdCBpbXBsZW1lbnQi CisgICAgICAgIHJhaXNlIE5vdEltcGxlbWVudGVkRXJyb3IoInN1YmNsYXNzZXMgbXVzdCBpbXBs ZW1lbnQiKQogCiAgICAgZGVmIG5leHRfd29ya19pdGVtKHNlbGYpOgotICAgICAgICByYWlzZSBO b3RJbXBsZW1lbnRlZEVycm9yLCAic3ViY2xhc3NlcyBtdXN0IGltcGxlbWVudCIKKyAgICAgICAg cmFpc2UgTm90SW1wbGVtZW50ZWRFcnJvcigic3ViY2xhc3NlcyBtdXN0IGltcGxlbWVudCIpCiAK ICAgICBkZWYgcHJvY2Vzc193b3JrX2l0ZW0oc2VsZiwgd29ya19pdGVtKToKLSAgICAgICAgcmFp c2UgTm90SW1wbGVtZW50ZWRFcnJvciwgInN1YmNsYXNzZXMgbXVzdCBpbXBsZW1lbnQiCisgICAg ICAgIHJhaXNlIE5vdEltcGxlbWVudGVkRXJyb3IoInN1YmNsYXNzZXMgbXVzdCBpbXBsZW1lbnQi KQogCiAgICAgZGVmIGhhbmRsZV91bmV4cGVjdGVkX2Vycm9yKHNlbGYsIHdvcmtfaXRlbSwgbWVz c2FnZSk6Ci0gICAgICAgIHJhaXNlIE5vdEltcGxlbWVudGVkRXJyb3IsICJzdWJjbGFzc2VzIG11 c3QgaW1wbGVtZW50IgorICAgICAgICByYWlzZSBOb3RJbXBsZW1lbnRlZEVycm9yKCJzdWJjbGFz c2VzIG11c3QgaW1wbGVtZW50IikKIAogCiBjbGFzcyBRdWV1ZUVuZ2luZToKSW5kZXg6IFRvb2xz L1NjcmlwdHMvd2Via2l0cHkvdG9vbC9jb21tYW5kcy9xdWV1ZXMucHkKPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0g VG9vbHMvU2NyaXB0cy93ZWJraXRweS90b29sL2NvbW1hbmRzL3F1ZXVlcy5weQkocmV2aXNpb24g MjE1OTA4KQorKysgVG9vbHMvU2NyaXB0cy93ZWJraXRweS90b29sL2NvbW1hbmRzL3F1ZXVlcy5w eQkod29ya2luZyBjb3B5KQpAQCAtMTE4LDcgKzExOCw3IEBAIGNsYXNzIEFic3RyYWN0UXVldWUo Q29tbWFuZCwgUXVldWVFbmdpbmUKICAgICAgICAgcmV0dXJuIG9zLnBhdGguam9pbihzZWxmLl9s b2dfZGlyZWN0b3J5KCksICIlcy5sb2ciICUgc2VsZi5uYW1lKQogCiAgICAgZGVmIHdvcmtfaXRl bV9sb2dfcGF0aChzZWxmLCB3b3JrX2l0ZW0pOgotICAgICAgICByYWlzZSBOb3RJbXBsZW1lbnRl ZEVycm9yLCAic3ViY2xhc3NlcyBtdXN0IGltcGxlbWVudCIKKyAgICAgICAgcmFpc2UgTm90SW1w bGVtZW50ZWRFcnJvcigic3ViY2xhc3NlcyBtdXN0IGltcGxlbWVudCIpCiAKICAgICBkZWYgYmVn aW5fd29ya19xdWV1ZShzZWxmKToKICAgICAgICAgX2xvZy5pbmZvKCJDQVVUSU9OOiAlcyB3aWxs IGRpc2NhcmQgYWxsIGxvY2FsIGNoYW5nZXMgaW4gXCIlc1wiIiAlIChzZWxmLm5hbWUsIHNlbGYu X3Rvb2wuc2NtKCkuY2hlY2tvdXRfcm9vdCkpCkBAIC0xMzgsMTMgKzEzOCwxMyBAQCBjbGFzcyBB YnN0cmFjdFF1ZXVlKENvbW1hbmQsIFF1ZXVlRW5naW5lCiAgICAgICAgIHJldHVybiBub3Qgc2Vs Zi5fb3B0aW9ucy5pdGVyYXRpb25zIG9yIHNlbGYuX2l0ZXJhdGlvbl9jb3VudCA8PSBzZWxmLl9v cHRpb25zLml0ZXJhdGlvbnMKIAogICAgIGRlZiBuZXh0X3dvcmtfaXRlbShzZWxmKToKLSAgICAg ICAgcmFpc2UgTm90SW1wbGVtZW50ZWRFcnJvciwgInN1YmNsYXNzZXMgbXVzdCBpbXBsZW1lbnQi CisgICAgICAgIHJhaXNlIE5vdEltcGxlbWVudGVkRXJyb3IoInN1YmNsYXNzZXMgbXVzdCBpbXBs ZW1lbnQiKQogCiAgICAgZGVmIHByb2Nlc3Nfd29ya19pdGVtKHNlbGYsIHdvcmtfaXRlbSk6Ci0g ICAgICAgIHJhaXNlIE5vdEltcGxlbWVudGVkRXJyb3IsICJzdWJjbGFzc2VzIG11c3QgaW1wbGVt ZW50IgorICAgICAgICByYWlzZSBOb3RJbXBsZW1lbnRlZEVycm9yKCJzdWJjbGFzc2VzIG11c3Qg aW1wbGVtZW50IikKIAogICAgIGRlZiBoYW5kbGVfdW5leHBlY3RlZF9lcnJvcihzZWxmLCB3b3Jr X2l0ZW0sIG1lc3NhZ2UpOgotICAgICAgICByYWlzZSBOb3RJbXBsZW1lbnRlZEVycm9yLCAic3Vi Y2xhc3NlcyBtdXN0IGltcGxlbWVudCIKKyAgICAgICAgcmFpc2UgTm90SW1wbGVtZW50ZWRFcnJv cigic3ViY2xhc3NlcyBtdXN0IGltcGxlbWVudCIpCiAKICAgICAjIENvbW1hbmQgbWV0aG9kcwog CkluZGV4OiBUb29scy9TY3JpcHRzL3dlYmtpdHB5L3Rvb2wvY29tbWFuZHMvc3RlcHNlcXVlbmNl LnB5Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT0KLS0tIFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvdG9vbC9jb21tYW5kcy9z dGVwc2VxdWVuY2UucHkJKHJldmlzaW9uIDIxNTkwOCkKKysrIFRvb2xzL1NjcmlwdHMvd2Via2l0 cHkvdG9vbC9jb21tYW5kcy9zdGVwc2VxdWVuY2UucHkJKHdvcmtpbmcgY29weSkKQEAgLTQwLDEx ICs0MCwxMSBAQCBfbG9nID0gbG9nZ2luZy5nZXRMb2dnZXIoX19uYW1lX18pCiBjbGFzcyBTdGVw U2VxdWVuY2VFcnJvckhhbmRsZXIoKToKICAgICBAY2xhc3NtZXRob2QKICAgICBkZWYgaGFuZGxl X3NjcmlwdF9lcnJvcihjbHMsIHRvb2wsIHBhdGNoLCBzY3JpcHRfZXJyb3IpOgotICAgICAgICBy YWlzZSBOb3RJbXBsZW1lbnRlZEVycm9yLCAic3ViY2xhc3NlcyBtdXN0IGltcGxlbWVudCIKKyAg ICAgICAgcmFpc2UgTm90SW1wbGVtZW50ZWRFcnJvcigic3ViY2xhc3NlcyBtdXN0IGltcGxlbWVu dCIpCiAKICAgICBAY2xhc3NtZXRob2QKICAgICBkZWYgaGFuZGxlX2NoZWNrb3V0X25lZWRzX3Vw ZGF0ZShjbHMsIHRvb2wsIHN0YXRlLCBvcHRpb25zLCBlcnJvcik6Ci0gICAgICAgIHJhaXNlIE5v dEltcGxlbWVudGVkRXJyb3IsICJzdWJjbGFzc2VzIG11c3QgaW1wbGVtZW50IgorICAgICAgICBy YWlzZSBOb3RJbXBsZW1lbnRlZEVycm9yKCJzdWJjbGFzc2VzIG11c3QgaW1wbGVtZW50IikKIAog CiBjbGFzcyBTdGVwU2VxdWVuY2Uob2JqZWN0KToKSW5kZXg6IFRvb2xzL1NjcmlwdHMvd2Via2l0 cHkvdG9vbC9zdGVwcy9hYnN0cmFjdHN0ZXAucHkKPT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gVG9vbHMvU2NyaXB0 cy93ZWJraXRweS90b29sL3N0ZXBzL2Fic3RyYWN0c3RlcC5weQkocmV2aXNpb24gMjE1OTA4KQor KysgVG9vbHMvU2NyaXB0cy93ZWJraXRweS90b29sL3N0ZXBzL2Fic3RyYWN0c3RlcC5weQkod29y a2luZyBjb3B5KQpAQCAtNzYsNCArNzYsNCBAQCBjbGFzcyBBYnN0cmFjdFN0ZXAob2JqZWN0KToK ICAgICAgICAgXQogCiAgICAgZGVmIHJ1bihzZWxmLCBzdGF0ZSk6Ci0gICAgICAgIHJhaXNlIE5v dEltcGxlbWVudGVkRXJyb3IsICJzdWJjbGFzc2VzIG11c3QgaW1wbGVtZW50IgorICAgICAgICBy YWlzZSBOb3RJbXBsZW1lbnRlZEVycm9yKCJzdWJjbGFzc2VzIG11c3QgaW1wbGVtZW50IikK 308681 2017-04-29 20:46:09 -0700 2017-04-29 22:02:24 -0700 Updated patch. patch_style_exceptions_v3 text/plain 8240 aakash_jain SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDIxNTk4MSkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDIyIEBACisyMDE3LTA0LTI5ICBBYWthc2ggSmFpbiAgPGFha2FzaF9qYWluQGFwcGxlLmNv bT4KKworICAgICAgICBVc2UgUEVQOCBzdHlsZSBndWlkZSBmb3IgcmFpc2luZyBleGNlcHRpb25z IGluIHdlYmtpdHB5LgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MTcxNDM5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgQXMgcGVyIGh0dHBzOi8vd3d3LnB5dGhvbi5vcmcvZGV2L3BlcHMvcGVwLTAwMDgvCisg ICAgICAgICJXaGVuIHJhaXNpbmcgYW4gZXhjZXB0aW9uIGluIFB5dGhvbiAyLCB1c2UgcmFpc2Ug VmFsdWVFcnJvcignbWVzc2FnZScpIAorICAgICAgICBpbnN0ZWFkIG9mIHRoZSBvbGRlciBmb3Jt IHJhaXNlIFZhbHVlRXJyb3IsICdtZXNzYWdlJyIKKworICAgICAgICAqIFNjcmlwdHMvd2Via2l0 cHkvY29tbW9uL25ldC9pcmMvaXJjYm90LnB5OiBVc2luZyBuZXcgc3R5bGUgZm9yIHJhaXNpbmcg ZXhjZXB0aW9ucy4KKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L2NvbW1vbi90aHJlYWQvbWVz c2FnZXB1bXAucHk6IFNhbWUuCisgICAgICAgICogU2NyaXB0cy93ZWJraXRweS90b29sL2JvdC9x dWV1ZWVuZ2luZS5weTogU2FtZS4KKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L3Rvb2wvY29t bWFuZHMvcXVldWVzLnB5OiBTYW1lLgorICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkvdG9vbC9j b21tYW5kcy9zdGVwc2VxdWVuY2UucHk6IFNhbWUuCisgICAgICAgICogU2NyaXB0cy93ZWJraXRw eS90b29sL211bHRpY29tbWFuZHRvb2wucHk6IFNhbWUuCisgICAgICAgICogU2NyaXB0cy93ZWJr aXRweS90b29sL3N0ZXBzL2Fic3RyYWN0c3RlcC5weTogU2FtZS4KKwogMjAxNy0wNC0yOCAgU2lt b24gRnJhc2VyICA8c2ltb24uZnJhc2VyQGFwcGxlLmNvbT4KIAogICAgICAgICBBZGQgc3lzdGVt IHRyYWNlIHBvaW50cyBmb3IgRG9jdW1lbnQ6OnVwZGF0ZVRvdWNoRXZlbnRSZWdpb25zKCkKSW5k ZXg6IFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvY29tbW9uL25ldC9pcmMvaXJjYm90LnB5Cj09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT0KLS0tIFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvY29tbW9uL25ldC9pcmMvaXJjYm90LnB5 CShyZXZpc2lvbiAyMTU5ODEpCisrKyBUb29scy9TY3JpcHRzL3dlYmtpdHB5L2NvbW1vbi9uZXQv aXJjL2lyY2JvdC5weQkod29ya2luZyBjb3B5KQpAQCAtMzUsMTMgKzM1LDEzIEBAIGZyb20gd2Vi a2l0cHkudGhpcmRwYXJ0eS5pcmMgaW1wb3J0IGlyY2wKIAogY2xhc3MgSVJDQm90RGVsZWdhdGUo b2JqZWN0KToKICAgICBkZWYgaXJjX21lc3NhZ2VfcmVjZWl2ZWQoc2VsZiwgbmljaywgbWVzc2Fn ZSk6Ci0gICAgICAgIHJhaXNlIE5vdEltcGxlbWVudGVkRXJyb3IsICJzdWJjbGFzc2VzIG11c3Qg aW1wbGVtZW50IgorICAgICAgICByYWlzZSBOb3RJbXBsZW1lbnRlZEVycm9yKCdzdWJjbGFzc2Vz IG11c3QgaW1wbGVtZW50JykKIAogICAgIGRlZiBpcmNfbmlja25hbWUoc2VsZik6Ci0gICAgICAg IHJhaXNlIE5vdEltcGxlbWVudGVkRXJyb3IsICJzdWJjbGFzc2VzIG11c3QgaW1wbGVtZW50Igor ICAgICAgICByYWlzZSBOb3RJbXBsZW1lbnRlZEVycm9yKCdzdWJjbGFzc2VzIG11c3QgaW1wbGVt ZW50JykKIAogICAgIGRlZiBpcmNfcGFzc3dvcmQoc2VsZik6Ci0gICAgICAgIHJhaXNlIE5vdElt cGxlbWVudGVkRXJyb3IsICJzdWJjbGFzc2VzIG11c3QgaW1wbGVtZW50IgorICAgICAgICByYWlz ZSBOb3RJbXBsZW1lbnRlZEVycm9yKCdzdWJjbGFzc2VzIG11c3QgaW1wbGVtZW50JykKIAogCiBj bGFzcyBJUkNCb3QoaXJjYm90LlNpbmdsZVNlcnZlcklSQ0JvdCwgTWVzc2FnZVB1bXBEZWxlZ2F0 ZSk6CkluZGV4OiBUb29scy9TY3JpcHRzL3dlYmtpdHB5L2NvbW1vbi90aHJlYWQvbWVzc2FnZXB1 bXAucHkKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PQotLS0gVG9vbHMvU2NyaXB0cy93ZWJraXRweS9jb21tb24vdGhyZWFk L21lc3NhZ2VwdW1wLnB5CShyZXZpc2lvbiAyMTU5ODEpCisrKyBUb29scy9TY3JpcHRzL3dlYmtp dHB5L2NvbW1vbi90aHJlYWQvbWVzc2FnZXB1bXAucHkJKHdvcmtpbmcgY29weSkKQEAgLTI5LDEz ICsyOSwxMyBAQAogCiBjbGFzcyBNZXNzYWdlUHVtcERlbGVnYXRlKG9iamVjdCk6CiAgICAgZGVm IHNjaGVkdWxlKHNlbGYsIGludGVydmFsLCBjYWxsYmFjayk6Ci0gICAgICAgIHJhaXNlIE5vdElt cGxlbWVudGVkRXJyb3IsICJzdWJjbGFzc2VzIG11c3QgaW1wbGVtZW50IgorICAgICAgICByYWlz ZSBOb3RJbXBsZW1lbnRlZEVycm9yKCdzdWJjbGFzc2VzIG11c3QgaW1wbGVtZW50JykKIAogICAg IGRlZiBtZXNzYWdlX2F2YWlsYWJsZShzZWxmLCBtZXNzYWdlKToKLSAgICAgICAgcmFpc2UgTm90 SW1wbGVtZW50ZWRFcnJvciwgInN1YmNsYXNzZXMgbXVzdCBpbXBsZW1lbnQiCisgICAgICAgIHJh aXNlIE5vdEltcGxlbWVudGVkRXJyb3IoJ3N1YmNsYXNzZXMgbXVzdCBpbXBsZW1lbnQnKQogCiAg ICAgZGVmIGZpbmFsX21lc3NhZ2VfZGVsaXZlcmVkKHNlbGYpOgotICAgICAgICByYWlzZSBOb3RJ bXBsZW1lbnRlZEVycm9yLCAic3ViY2xhc3NlcyBtdXN0IGltcGxlbWVudCIKKyAgICAgICAgcmFp c2UgTm90SW1wbGVtZW50ZWRFcnJvcignc3ViY2xhc3NlcyBtdXN0IGltcGxlbWVudCcpCiAKIAog Y2xhc3MgTWVzc2FnZVB1bXAob2JqZWN0KToKSW5kZXg6IFRvb2xzL1NjcmlwdHMvd2Via2l0cHkv dG9vbC9tdWx0aWNvbW1hbmR0b29sLnB5Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFRvb2xzL1NjcmlwdHMvd2Vi a2l0cHkvdG9vbC9tdWx0aWNvbW1hbmR0b29sLnB5CShyZXZpc2lvbiAyMTU5ODEpCisrKyBUb29s cy9TY3JpcHRzL3dlYmtpdHB5L3Rvb2wvbXVsdGljb21tYW5kdG9vbC5weQkod29ya2luZyBjb3B5 KQpAQCAtMTMwLDcgKzEzMCw3IEBAIGNsYXNzIENvbW1hbmQob2JqZWN0KToKICAgICAgICAgcmV0 dXJuIGhlbHBfdGV4dAogCiAgICAgZGVmIGV4ZWN1dGUoc2VsZiwgb3B0aW9ucywgYXJncywgdG9v bCk6Ci0gICAgICAgIHJhaXNlIE5vdEltcGxlbWVudGVkRXJyb3IsICJzdWJjbGFzc2VzIG11c3Qg aW1wbGVtZW50IgorICAgICAgICByYWlzZSBOb3RJbXBsZW1lbnRlZEVycm9yKCdzdWJjbGFzc2Vz IG11c3QgaW1wbGVtZW50JykKIAogICAgICMgbWFpbigpIGV4aXN0cyBzbyB0aGF0IENvbW1hbmRz IGNhbiBiZSB0dXJuZWQgaW50byBzdGFuZC1hbG9uZSBzY3JpcHRzLgogICAgICMgT3RoZXIgcGFy dHMgb2YgdGhlIGNvZGUgd2lsbCBsaWtlbHkgcmVxdWlyZSBtb2RpZmljYXRpb24gdG8gd29yayBz dGFuZC1hbG9uZS4KQEAgLTI2Miw3ICsyNjIsNyBAQCBjbGFzcyBNdWx0aUNvbW1hbmRUb29sKG9i amVjdCk6CiAgICAgICAgIHJldHVybiBOb25lCiAKICAgICBkZWYgcGF0aChzZWxmKToKLSAgICAg ICAgcmFpc2UgTm90SW1wbGVtZW50ZWRFcnJvciwgInN1YmNsYXNzZXMgbXVzdCBpbXBsZW1lbnQi CisgICAgICAgIHJhaXNlIE5vdEltcGxlbWVudGVkRXJyb3IoJ3N1YmNsYXNzZXMgbXVzdCBpbXBs ZW1lbnQnKQogCiAgICAgZGVmIGNvbW1hbmRfY29tcGxldGVkKHNlbGYpOgogICAgICAgICBwYXNz CkluZGV4OiBUb29scy9TY3JpcHRzL3dlYmtpdHB5L3Rvb2wvYm90L3F1ZXVlZW5naW5lLnB5Cj09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT0KLS0tIFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvdG9vbC9ib3QvcXVldWVlbmdpbmUu cHkJKHJldmlzaW9uIDIxNTk4MSkKKysrIFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvdG9vbC9ib3Qv cXVldWVlbmdpbmUucHkJKHdvcmtpbmcgY29weSkKQEAgLTQ5LDI1ICs0OSwyNSBAQCBjbGFzcyBU ZXJtaW5hdGVRdWV1ZShFeGNlcHRpb24pOgogCiBjbGFzcyBRdWV1ZUVuZ2luZURlbGVnYXRlOgog ICAgIGRlZiBxdWV1ZV9sb2dfcGF0aChzZWxmKToKLSAgICAgICAgcmFpc2UgTm90SW1wbGVtZW50 ZWRFcnJvciwgInN1YmNsYXNzZXMgbXVzdCBpbXBsZW1lbnQiCisgICAgICAgIHJhaXNlIE5vdElt cGxlbWVudGVkRXJyb3IoJ3N1YmNsYXNzZXMgbXVzdCBpbXBsZW1lbnQnKQogCiAgICAgZGVmIHdv cmtfaXRlbV9sb2dfcGF0aChzZWxmLCB3b3JrX2l0ZW0pOgotICAgICAgICByYWlzZSBOb3RJbXBs ZW1lbnRlZEVycm9yLCAic3ViY2xhc3NlcyBtdXN0IGltcGxlbWVudCIKKyAgICAgICAgcmFpc2Ug Tm90SW1wbGVtZW50ZWRFcnJvcignc3ViY2xhc3NlcyBtdXN0IGltcGxlbWVudCcpCiAKICAgICBk ZWYgYmVnaW5fd29ya19xdWV1ZShzZWxmKToKLSAgICAgICAgcmFpc2UgTm90SW1wbGVtZW50ZWRF cnJvciwgInN1YmNsYXNzZXMgbXVzdCBpbXBsZW1lbnQiCisgICAgICAgIHJhaXNlIE5vdEltcGxl bWVudGVkRXJyb3IoJ3N1YmNsYXNzZXMgbXVzdCBpbXBsZW1lbnQnKQogCiAgICAgZGVmIHNob3Vs ZF9jb250aW51ZV93b3JrX3F1ZXVlKHNlbGYpOgotICAgICAgICByYWlzZSBOb3RJbXBsZW1lbnRl ZEVycm9yLCAic3ViY2xhc3NlcyBtdXN0IGltcGxlbWVudCIKKyAgICAgICAgcmFpc2UgTm90SW1w bGVtZW50ZWRFcnJvcignc3ViY2xhc3NlcyBtdXN0IGltcGxlbWVudCcpCiAKICAgICBkZWYgbmV4 dF93b3JrX2l0ZW0oc2VsZik6Ci0gICAgICAgIHJhaXNlIE5vdEltcGxlbWVudGVkRXJyb3IsICJz dWJjbGFzc2VzIG11c3QgaW1wbGVtZW50IgorICAgICAgICByYWlzZSBOb3RJbXBsZW1lbnRlZEVy cm9yKCdzdWJjbGFzc2VzIG11c3QgaW1wbGVtZW50JykKIAogICAgIGRlZiBwcm9jZXNzX3dvcmtf aXRlbShzZWxmLCB3b3JrX2l0ZW0pOgotICAgICAgICByYWlzZSBOb3RJbXBsZW1lbnRlZEVycm9y LCAic3ViY2xhc3NlcyBtdXN0IGltcGxlbWVudCIKKyAgICAgICAgcmFpc2UgTm90SW1wbGVtZW50 ZWRFcnJvcignc3ViY2xhc3NlcyBtdXN0IGltcGxlbWVudCcpCiAKICAgICBkZWYgaGFuZGxlX3Vu ZXhwZWN0ZWRfZXJyb3Ioc2VsZiwgd29ya19pdGVtLCBtZXNzYWdlKToKLSAgICAgICAgcmFpc2Ug Tm90SW1wbGVtZW50ZWRFcnJvciwgInN1YmNsYXNzZXMgbXVzdCBpbXBsZW1lbnQiCisgICAgICAg IHJhaXNlIE5vdEltcGxlbWVudGVkRXJyb3IoJ3N1YmNsYXNzZXMgbXVzdCBpbXBsZW1lbnQnKQog CiAKIGNsYXNzIFF1ZXVlRW5naW5lOgpJbmRleDogVG9vbHMvU2NyaXB0cy93ZWJraXRweS90b29s L2NvbW1hbmRzL3F1ZXVlcy5weQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9TY3JpcHRzL3dlYmtpdHB5 L3Rvb2wvY29tbWFuZHMvcXVldWVzLnB5CShyZXZpc2lvbiAyMTU5ODEpCisrKyBUb29scy9TY3Jp cHRzL3dlYmtpdHB5L3Rvb2wvY29tbWFuZHMvcXVldWVzLnB5CSh3b3JraW5nIGNvcHkpCkBAIC0x MTgsNyArMTE4LDcgQEAgY2xhc3MgQWJzdHJhY3RRdWV1ZShDb21tYW5kLCBRdWV1ZUVuZ2luZQog ICAgICAgICByZXR1cm4gb3MucGF0aC5qb2luKHNlbGYuX2xvZ19kaXJlY3RvcnkoKSwgIiVzLmxv ZyIgJSBzZWxmLm5hbWUpCiAKICAgICBkZWYgd29ya19pdGVtX2xvZ19wYXRoKHNlbGYsIHdvcmtf aXRlbSk6Ci0gICAgICAgIHJhaXNlIE5vdEltcGxlbWVudGVkRXJyb3IsICJzdWJjbGFzc2VzIG11 c3QgaW1wbGVtZW50IgorICAgICAgICByYWlzZSBOb3RJbXBsZW1lbnRlZEVycm9yKCdzdWJjbGFz c2VzIG11c3QgaW1wbGVtZW50JykKIAogICAgIGRlZiBiZWdpbl93b3JrX3F1ZXVlKHNlbGYpOgog ICAgICAgICBfbG9nLmluZm8oIkNBVVRJT046ICVzIHdpbGwgZGlzY2FyZCBhbGwgbG9jYWwgY2hh bmdlcyBpbiBcIiVzXCIiICUgKHNlbGYubmFtZSwgc2VsZi5fdG9vbC5zY20oKS5jaGVja291dF9y b290KSkKQEAgLTEzOCwxMyArMTM4LDEzIEBAIGNsYXNzIEFic3RyYWN0UXVldWUoQ29tbWFuZCwg UXVldWVFbmdpbmUKICAgICAgICAgcmV0dXJuIG5vdCBzZWxmLl9vcHRpb25zLml0ZXJhdGlvbnMg b3Igc2VsZi5faXRlcmF0aW9uX2NvdW50IDw9IHNlbGYuX29wdGlvbnMuaXRlcmF0aW9ucwogCiAg ICAgZGVmIG5leHRfd29ya19pdGVtKHNlbGYpOgotICAgICAgICByYWlzZSBOb3RJbXBsZW1lbnRl ZEVycm9yLCAic3ViY2xhc3NlcyBtdXN0IGltcGxlbWVudCIKKyAgICAgICAgcmFpc2UgTm90SW1w bGVtZW50ZWRFcnJvcignc3ViY2xhc3NlcyBtdXN0IGltcGxlbWVudCcpCiAKICAgICBkZWYgcHJv Y2Vzc193b3JrX2l0ZW0oc2VsZiwgd29ya19pdGVtKToKLSAgICAgICAgcmFpc2UgTm90SW1wbGVt ZW50ZWRFcnJvciwgInN1YmNsYXNzZXMgbXVzdCBpbXBsZW1lbnQiCisgICAgICAgIHJhaXNlIE5v dEltcGxlbWVudGVkRXJyb3IoJ3N1YmNsYXNzZXMgbXVzdCBpbXBsZW1lbnQnKQogCiAgICAgZGVm IGhhbmRsZV91bmV4cGVjdGVkX2Vycm9yKHNlbGYsIHdvcmtfaXRlbSwgbWVzc2FnZSk6Ci0gICAg ICAgIHJhaXNlIE5vdEltcGxlbWVudGVkRXJyb3IsICJzdWJjbGFzc2VzIG11c3QgaW1wbGVtZW50 IgorICAgICAgICByYWlzZSBOb3RJbXBsZW1lbnRlZEVycm9yKCdzdWJjbGFzc2VzIG11c3QgaW1w bGVtZW50JykKIAogICAgICMgQ29tbWFuZCBtZXRob2RzCiAKSW5kZXg6IFRvb2xzL1NjcmlwdHMv d2Via2l0cHkvdG9vbC9jb21tYW5kcy9zdGVwc2VxdWVuY2UucHkKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gVG9v bHMvU2NyaXB0cy93ZWJraXRweS90b29sL2NvbW1hbmRzL3N0ZXBzZXF1ZW5jZS5weQkocmV2aXNp b24gMjE1OTgxKQorKysgVG9vbHMvU2NyaXB0cy93ZWJraXRweS90b29sL2NvbW1hbmRzL3N0ZXBz ZXF1ZW5jZS5weQkod29ya2luZyBjb3B5KQpAQCAtNDAsMTEgKzQwLDExIEBAIF9sb2cgPSBsb2dn aW5nLmdldExvZ2dlcihfX25hbWVfXykKIGNsYXNzIFN0ZXBTZXF1ZW5jZUVycm9ySGFuZGxlcigp OgogICAgIEBjbGFzc21ldGhvZAogICAgIGRlZiBoYW5kbGVfc2NyaXB0X2Vycm9yKGNscywgdG9v bCwgcGF0Y2gsIHNjcmlwdF9lcnJvcik6Ci0gICAgICAgIHJhaXNlIE5vdEltcGxlbWVudGVkRXJy b3IsICJzdWJjbGFzc2VzIG11c3QgaW1wbGVtZW50IgorICAgICAgICByYWlzZSBOb3RJbXBsZW1l bnRlZEVycm9yKCdzdWJjbGFzc2VzIG11c3QgaW1wbGVtZW50JykKIAogICAgIEBjbGFzc21ldGhv ZAogICAgIGRlZiBoYW5kbGVfY2hlY2tvdXRfbmVlZHNfdXBkYXRlKGNscywgdG9vbCwgc3RhdGUs IG9wdGlvbnMsIGVycm9yKToKLSAgICAgICAgcmFpc2UgTm90SW1wbGVtZW50ZWRFcnJvciwgInN1 YmNsYXNzZXMgbXVzdCBpbXBsZW1lbnQiCisgICAgICAgIHJhaXNlIE5vdEltcGxlbWVudGVkRXJy b3IoJ3N1YmNsYXNzZXMgbXVzdCBpbXBsZW1lbnQnKQogCiAKIGNsYXNzIFN0ZXBTZXF1ZW5jZShv YmplY3QpOgpJbmRleDogVG9vbHMvU2NyaXB0cy93ZWJraXRweS90b29sL3N0ZXBzL2Fic3RyYWN0 c3RlcC5weQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9TY3JpcHRzL3dlYmtpdHB5L3Rvb2wvc3RlcHMv YWJzdHJhY3RzdGVwLnB5CShyZXZpc2lvbiAyMTU5ODEpCisrKyBUb29scy9TY3JpcHRzL3dlYmtp dHB5L3Rvb2wvc3RlcHMvYWJzdHJhY3RzdGVwLnB5CSh3b3JraW5nIGNvcHkpCkBAIC03Niw0ICs3 Niw0IEBAIGNsYXNzIEFic3RyYWN0U3RlcChvYmplY3QpOgogICAgICAgICBdCiAKICAgICBkZWYg cnVuKHNlbGYsIHN0YXRlKToKLSAgICAgICAgcmFpc2UgTm90SW1wbGVtZW50ZWRFcnJvciwgInN1 YmNsYXNzZXMgbXVzdCBpbXBsZW1lbnQiCisgICAgICAgIHJhaXNlIE5vdEltcGxlbWVudGVkRXJy b3IoJ3N1YmNsYXNzZXMgbXVzdCBpbXBsZW1lbnQnKQo=