171436 2017-04-28 10:24:07 -0700 [Win] Set CMake args in build-webkit 2017-05-10 03:04:41 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 don.olmstead don.olmstead bfulgham commit-queue fujii lforschler pvollan oldest_to_newest 1302642 0 don.olmstead 2017-04-28 10:24:07 -0700 Currently any values passed in --cmakeargs to build-webkit are ignored on Windows builds. 1302651 1 308554 don.olmstead 2017-04-28 10:35:32 -0700 Created attachment 308554 Fix 1304532 2 308554 pvollan 2017-05-03 23:34:20 -0700 Comment on attachment 308554 Fix View in context: https://bugs.webkit.org/attachment.cgi?id=308554&action=review Looks good, but please remove the incorrect entries in the Changelog. > Tools/ChangeLog:9 > + (cMakeArgsFromFeatures): Deleted. This function have not been deleted. > Tools/ChangeLog:10 > + (writeCongrats): Deleted. Ditto. 1305357 3 309222 don.olmstead 2017-05-05 15:22:22 -0700 Created attachment 309222 Patch I just manually removed the lines. The script seems to be confused since its all in the root. 1305536 4 pvollan 2017-05-06 00:07:37 -0700 It seems the patch does not merge successfully on trunk. 1306668 5 309561 don.olmstead 2017-05-09 16:45:46 -0700 Created attachment 309561 Patch 1306775 6 309561 pvollan 2017-05-10 02:35:29 -0700 Comment on attachment 309561 Patch R=me. 1306780 7 309561 commit-queue 2017-05-10 03:04:40 -0700 Comment on attachment 309561 Patch Clearing flags on attachment: 309561 Committed r216577: <http://trac.webkit.org/changeset/216577> 1306781 8 commit-queue 2017-05-10 03:04:41 -0700 All reviewed patches have been landed. Closing bug. 308554 2017-04-28 10:35:32 -0700 2017-05-05 15:22:22 -0700 Fix bug171436.diff text/plain 1164 don.olmstead ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCA3YmY1 ZDU1Li4zNjYxOGYxIDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTctMDQtMjggIERvbiBPbG1zdGVhZCAgPGRvbi5v bG1zdGVhZEBhbS5zb255LmNvbT4KKworICAgICAgICBbV2luXSBTZXQgQ01ha2UgYXJncyBpbiBi dWlsZC13ZWJraXQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTE3MTQzNgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgICogU2NyaXB0cy9idWlsZC13ZWJraXQ6CisgICAgICAgIChjTWFrZUFyZ3NGcm9tRmVhdHVy ZXMpOiBEZWxldGVkLgorICAgICAgICAod3JpdGVDb25ncmF0cyk6IERlbGV0ZWQuCisKIDIwMTct MDQtMjggIEpvYW5tYXJpZSBEaWdncyAgPGpkaWdnc0BpZ2FsaWEuY29tPgogCiAgICAgICAgIFtB VEtdIEdyaWRDZWxsUm9sZSBzaG91bGQgaW1wbGVtZW50IEF0a1RhYmxlQ2VsbCAocmVncmVzc2lv bj8pCmRpZmYgLS1naXQgYS9Ub29scy9TY3JpcHRzL2J1aWxkLXdlYmtpdCBiL1Rvb2xzL1Njcmlw dHMvYnVpbGQtd2Via2l0CmluZGV4IDcxNDJhZTYuLmM4NDNlZmIgMTAwNzU1Ci0tLSBhL1Rvb2xz L1NjcmlwdHMvYnVpbGQtd2Via2l0CisrKyBiL1Rvb2xzL1NjcmlwdHMvYnVpbGQtd2Via2l0CkBA IC0yNTcsNyArMjU3LDcgQEAgaWYgKGlzQXBwbGVXaW5XZWJLaXQoKSB8fCBpc1dpbkNhaXJvKCkp IHsKICAgICByZW1vdmVDTWFrZUNhY2hlKEBmZWF0dXJlQXJncyk7CiAKICAgICBjaGRpcldlYktp dCgpOwotICAgIGlmIChleGl0U3RhdHVzKGdlbmVyYXRlQnVpbGRTeXN0ZW1Gcm9tQ01ha2VQcm9q ZWN0KCkpKSB7CisgICAgaWYgKGV4aXRTdGF0dXMoZ2VuZXJhdGVCdWlsZFN5c3RlbUZyb21DTWFr ZVByb2plY3QoJHByZWZpeFBhdGgsIEBjbWFrZUFyZ3MpKSkgewogICAgICAgICBkaWUgIlJ1biBc IkM6L1Byb2dyYW0gRmlsZXMgKHg4NikvTWljcm9zb2Z0IFZpc3VhbCBTdHVkaW8gMTQuMC9WQy92 Y3ZhcnNhbGwuYmF0XCIgYmVmb3JlIGJ1aWxkLXdlYmtpdCB3aGVuIHVzaW5nIG5pbmphIjsKICAg ICB9CiAgICAgY2hkaXJXZWJLaXQoKTsK 309222 2017-05-05 15:22:22 -0700 2017-05-09 16:45:46 -0700 Patch bug-171436.diff text/plain 1113 don.olmstead ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCAzOWQy N2QzLi5mYzFmZjVmIDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTctMDUtMDUgIERvbiBPbG1zdGVhZCAgPGRvbi5v bG1zdGVhZEBhbS5zb255LmNvbT4KKworICAgICAgICBbV2luXSBTZXQgQ01ha2UgYXJncyBpbiBi dWlsZC13ZWJraXQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTE3MTQzNgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgICogU2NyaXB0cy9idWlsZC13ZWJraXQ6CisKIDIwMTctMDUtMDUgIEJyaWFuIEJ1cmcgIDxi YnVyZ0BhcHBsZS5jb20+CiAKICAgICAgICAgQVBJIHRlc3QgV2ViS2l0Mi5XS0hUVFBDb29raWVT dG9yZSBmYWlscyBkdWUgdG8gcG9zc2libGUgaXNzdWUgd2l0aCBoYW5kbGluZyBub24tc2Vzc2lv biBjb29raWVzCmRpZmYgLS1naXQgYS9Ub29scy9TY3JpcHRzL2J1aWxkLXdlYmtpdCBiL1Rvb2xz L1NjcmlwdHMvYnVpbGQtd2Via2l0CmluZGV4IDcxNDJhZTYuLmM4NDNlZmIgMTAwNzU1Ci0tLSBh L1Rvb2xzL1NjcmlwdHMvYnVpbGQtd2Via2l0CisrKyBiL1Rvb2xzL1NjcmlwdHMvYnVpbGQtd2Vi a2l0CkBAIC0yNTcsNyArMjU3LDcgQEAgaWYgKGlzQXBwbGVXaW5XZWJLaXQoKSB8fCBpc1dpbkNh aXJvKCkpIHsKICAgICByZW1vdmVDTWFrZUNhY2hlKEBmZWF0dXJlQXJncyk7CiAKICAgICBjaGRp cldlYktpdCgpOwotICAgIGlmIChleGl0U3RhdHVzKGdlbmVyYXRlQnVpbGRTeXN0ZW1Gcm9tQ01h a2VQcm9qZWN0KCkpKSB7CisgICAgaWYgKGV4aXRTdGF0dXMoZ2VuZXJhdGVCdWlsZFN5c3RlbUZy b21DTWFrZVByb2plY3QoJHByZWZpeFBhdGgsIEBjbWFrZUFyZ3MpKSkgewogICAgICAgICBkaWUg IlJ1biBcIkM6L1Byb2dyYW0gRmlsZXMgKHg4NikvTWljcm9zb2Z0IFZpc3VhbCBTdHVkaW8gMTQu MC9WQy92Y3ZhcnNhbGwuYmF0XCIgYmVmb3JlIGJ1aWxkLXdlYmtpdCB3aGVuIHVzaW5nIG5pbmph IjsKICAgICB9CiAgICAgY2hkaXJXZWJLaXQoKTsK 309561 2017-05-09 16:45:46 -0700 2017-05-10 03:04:40 -0700 Patch bug-171436.diff text/plain 1118 don.olmstead ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCBhODJk NTdhOGYzYi4uZmI1M2I3ODM0MGUgMTAwNjQ0Ci0tLSBhL1Rvb2xzL0NoYW5nZUxvZworKysgYi9U b29scy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMiBAQAorMjAxNy0wNS0wOSAgRG9uIE9sbXN0ZWFk ICA8ZG9uLm9sbXN0ZWFkQGFtLnNvbnkuY29tPgorCisgICAgICAgIFtXaW5dIFNldCBDTWFrZSBh cmdzIGluIGJ1aWxkLXdlYmtpdAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MTcxNDM2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgKiBTY3JpcHRzL2J1aWxkLXdlYmtpdDoKKwogMjAxNy0wNS0wOSAgSm9uYXRo YW4gQmVkYXJkICA8amJlZGFyZEBhcHBsZS5jb20+CiAKICAgICAgICAgd2Via2l0cHk6IFJlbW92 ZSB1bm5lZWRlZCBjcmFzaCBsb2cgcmV0cmlldmFsLCByZWZhY3RvciBEYXJ3aW4gY3Jhc2ggcmV0 cmlldmFsCmRpZmYgLS1naXQgYS9Ub29scy9TY3JpcHRzL2J1aWxkLXdlYmtpdCBiL1Rvb2xzL1Nj cmlwdHMvYnVpbGQtd2Via2l0CmluZGV4IDJmZWVjNjY1Y2ExLi5kYWQ3OTBmZjAxMiAxMDA3NTUK LS0tIGEvVG9vbHMvU2NyaXB0cy9idWlsZC13ZWJraXQKKysrIGIvVG9vbHMvU2NyaXB0cy9idWls ZC13ZWJraXQKQEAgLTI1OCw3ICsyNTgsNyBAQCBpZiAoaXNBcHBsZVdpbldlYktpdCgpIHx8IGlz V2luQ2Fpcm8oKSkgewogICAgIHJlbW92ZUNNYWtlQ2FjaGUoQGZlYXR1cmVBcmdzKTsKIAogICAg IGNoZGlyV2ViS2l0KCk7Ci0gICAgaWYgKGV4aXRTdGF0dXMoZ2VuZXJhdGVCdWlsZFN5c3RlbUZy b21DTWFrZVByb2plY3QoKSkpIHsKKyAgICBpZiAoZXhpdFN0YXR1cyhnZW5lcmF0ZUJ1aWxkU3lz dGVtRnJvbUNNYWtlUHJvamVjdCgkcHJlZml4UGF0aCwgQGNtYWtlQXJncykpKSB7CiAgICAgICAg IGRpZSAiUnVuIFwiQzovUHJvZ3JhbSBGaWxlcyAoeDg2KS9NaWNyb3NvZnQgVmlzdWFsIFN0dWRp byAxNC4wL1ZDL3ZjdmFyc2FsbC5iYXRcIiBiZWZvcmUgYnVpbGQtd2Via2l0IHdoZW4gdXNpbmcg bmluamEiOwogICAgIH0KICAgICBjaGRpcldlYktpdCgpOwo=