171401 2017-04-27 16:14:15 -0700 Web Inspector: Remove unused ToggleControlToolbarItem.js 2017-04-27 19:07:45 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED P2 Normal --- 1 nvasilyev nvasilyev commit-queue inspector-bugzilla-changes joepeck oldest_to_newest 1302368 0 nvasilyev 2017-04-27 16:14:15 -0700 It isn't used anywhere in our code. I searched and the only mentions I found were in Changelog files: Source ⮀ack -Q 'ToggleControlToolbarItem' WebInspectorUI/ChangeLog-2013-06-11 519: * UserInterface/ToggleControlToolbarItem.js: 3431: ToggleControlToolbarItem regenerates its images every time 'toggled' is set, even 5763: (WebInspector.contentLoaded): Use ToggleControlToolbarItem for undock button. 15393: * UserInterface/ToggleControlToolbarItem.js: Added. 15394: (WebInspector.ToggleControlToolbarItem): WebInspectorUI/ChangeLog-2015-11-21 8792: * UserInterface/Views/ToggleControlToolbarItem.js: 8793: (WebInspector.ToggleControlToolbarItem): 8794: (WebInspector.ToggleControlToolbarItem.prototype.get additionalClassNames): 1302372 1 308471 nvasilyev 2017-04-27 16:19:20 -0700 Created attachment 308471 Patch 1302439 2 308471 joepeck 2017-04-27 18:38:20 -0700 Comment on attachment 308471 Patch r=me 1302446 3 308471 commit-queue 2017-04-27 19:07:43 -0700 Comment on attachment 308471 Patch Clearing flags on attachment: 308471 Committed r215915: <http://trac.webkit.org/changeset/215915> 1302447 4 commit-queue 2017-04-27 19:07:45 -0700 All reviewed patches have been landed. Closing bug. 308471 2017-04-27 16:19:20 -0700 2017-04-27 19:07:43 -0700 Patch patch.txt text/plain 3487 nvasilyev ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IGY2ZWJlZGIuLjc2N2NiM2YgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkluc3BlY3Rv clVJL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDE3LTA0LTI3ICBOaWtpdGEgVmFzaWx5 ZXYgIDxudmFzaWx5ZXZAYXBwbGUuY29tPgorCisgICAgICAgIFdlYiBJbnNwZWN0b3I6IFJlbW92 ZSB1bnVzZWQgVG9nZ2xlQ29udHJvbFRvb2xiYXJJdGVtLmpzCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNzE0MDEKKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFVzZXJJbnRlcmZhY2UvTWFpbi5odG1sOgor ICAgICAgICAqIFVzZXJJbnRlcmZhY2UvVmlld3MvVG9nZ2xlQ29udHJvbFRvb2xiYXJJdGVtLmpz OiBSZW1vdmVkLgorCiAyMDE3LTA0LTI3ICBCcmlhbiBCdXJnICA8YmJ1cmdAYXBwbGUuY29tPgog CiAgICAgICAgIFdlYiBJbnNwZWN0b3I6IGZpeCB0b29sdGlwIHdvcmRpbmcgZm9yIFJlbG9hZCBi dXR0b24KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL01h aW4uaHRtbCBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL01haW4uaHRtbApp bmRleCBlYmNmNTk1Li4yNjM4NTJkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkv VXNlckludGVyZmFjZS9NYWluLmh0bWwKKysrIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJ bnRlcmZhY2UvTWFpbi5odG1sCkBAIC02ODcsNyArNjg3LDYgQEAKICAgICA8c2NyaXB0IHNyYz0i Vmlld3MvVGltZWxpbmVSdWxlci5qcyI+PC9zY3JpcHQ+CiAgICAgPHNjcmlwdCBzcmM9IlZpZXdz L1RpdGxlVmlldy5qcyI+PC9zY3JpcHQ+CiAgICAgPHNjcmlwdCBzcmM9IlZpZXdzL1RvZ2dsZUJ1 dHRvbk5hdmlnYXRpb25JdGVtLmpzIj48L3NjcmlwdD4KLSAgICA8c2NyaXB0IHNyYz0iVmlld3Mv VG9nZ2xlQ29udHJvbFRvb2xiYXJJdGVtLmpzIj48L3NjcmlwdD4KICAgICA8c2NyaXB0IHNyYz0i Vmlld3MvVG9vbGJhci5qcyI+PC9zY3JpcHQ+CiAgICAgPHNjcmlwdCBzcmM9IlZpZXdzL1RyZWVF bGVtZW50U3RhdHVzQnV0dG9uLmpzIj48L3NjcmlwdD4KICAgICA8c2NyaXB0IHNyYz0iVmlld3Mv VHJlZU91dGxpbmVEYXRhR3JpZFN5bmNocm9uaXplci5qcyI+PC9zY3JpcHQ+CmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9Ub2dnbGVDb250cm9s VG9vbGJhckl0ZW0uanMgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3 cy9Ub2dnbGVDb250cm9sVG9vbGJhckl0ZW0uanMKZGVsZXRlZCBmaWxlIG1vZGUgMTAwNjQ0Cmlu ZGV4IDdhNjhmNjEuLjAwMDAwMDAKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRl cmZhY2UvVmlld3MvVG9nZ2xlQ29udHJvbFRvb2xiYXJJdGVtLmpzCisrKyAvZGV2L251bGwKQEAg LTEsMzkgKzAsMCBAQAotLyoKLSAqIENvcHlyaWdodCAoQykgMjAxMywgMjAxNSBBcHBsZSBJbmMu IEFsbCByaWdodHMgcmVzZXJ2ZWQuCi0gKgotICogUmVkaXN0cmlidXRpb24gYW5kIHVzZSBpbiBz b3VyY2UgYW5kIGJpbmFyeSBmb3Jtcywgd2l0aCBvciB3aXRob3V0Ci0gKiBtb2RpZmljYXRpb24s IGFyZSBwZXJtaXR0ZWQgcHJvdmlkZWQgdGhhdCB0aGUgZm9sbG93aW5nIGNvbmRpdGlvbnMKLSAq IGFyZSBtZXQ6Ci0gKiAxLiBSZWRpc3RyaWJ1dGlvbnMgb2Ygc291cmNlIGNvZGUgbXVzdCByZXRh aW4gdGhlIGFib3ZlIGNvcHlyaWdodAotICogICAgbm90aWNlLCB0aGlzIGxpc3Qgb2YgY29uZGl0 aW9ucyBhbmQgdGhlIGZvbGxvd2luZyBkaXNjbGFpbWVyLgotICogMi4gUmVkaXN0cmlidXRpb25z IGluIGJpbmFyeSBmb3JtIG11c3QgcmVwcm9kdWNlIHRoZSBhYm92ZSBjb3B5cmlnaHQKLSAqICAg IG5vdGljZSwgdGhpcyBsaXN0IG9mIGNvbmRpdGlvbnMgYW5kIHRoZSBmb2xsb3dpbmcgZGlzY2xh aW1lciBpbiB0aGUKLSAqICAgIGRvY3VtZW50YXRpb24gYW5kL29yIG90aGVyIG1hdGVyaWFscyBw cm92aWRlZCB3aXRoIHRoZSBkaXN0cmlidXRpb24uCi0gKgotICogVEhJUyBTT0ZUV0FSRSBJUyBQ Uk9WSURFRCBCWSBBUFBMRSBJTkMuIEFORCBJVFMgQ09OVFJJQlVUT1JTIGBgQVMgSVMnJwotICog QU5EIEFOWSBFWFBSRVNTIE9SIElNUExJRUQgV0FSUkFOVElFUywgSU5DTFVESU5HLCBCVVQgTk9U IExJTUlURUQgVE8sCi0gKiBUSEUgSU1QTElFRCBXQVJSQU5USUVTIE9GIE1FUkNIQU5UQUJJTElU WSBBTkQgRklUTkVTUyBGT1IgQSBQQVJUSUNVTEFSCi0gKiBQVVJQT1NFIEFSRSBESVNDTEFJTUVE LiBJTiBOTyBFVkVOVCBTSEFMTCBBUFBMRSBJTkMuIE9SIElUUyBDT05UUklCVVRPUlMKLSAqIEJF IExJQUJMRSBGT1IgQU5ZIERJUkVDVCwgSU5ESVJFQ1QsIElOQ0lERU5UQUwsIFNQRUNJQUwsIEVY RU1QTEFSWSwgT1IKLSAqIENPTlNFUVVFTlRJQUwgREFNQUdFUyAoSU5DTFVESU5HLCBCVVQgTk9U IExJTUlURUQgVE8sIFBST0NVUkVNRU5UIE9GCi0gKiBTVUJTVElUVVRFIEdPT0RTIE9SIFNFUlZJ Q0VTOyBMT1NTIE9GIFVTRSwgREFUQSwgT1IgUFJPRklUUzsgT1IgQlVTSU5FU1MKLSAqIElOVEVS UlVQVElPTikgSE9XRVZFUiBDQVVTRUQgQU5EIE9OIEFOWSBUSEVPUlkgT0YgTElBQklMSVRZLCBX SEVUSEVSIElOCi0gKiBDT05UUkFDVCwgU1RSSUNUIExJQUJJTElUWSwgT1IgVE9SVCAoSU5DTFVE SU5HIE5FR0xJR0VOQ0UgT1IgT1RIRVJXSVNFKQotICogQVJJU0lORyBJTiBBTlkgV0FZIE9VVCBP RiBUSEUgVVNFIE9GIFRISVMgU09GVFdBUkUsIEVWRU4gSUYgQURWSVNFRCBPRgotICogVEhFIFBP U1NJQklMSVRZIE9GIFNVQ0ggREFNQUdFLgotICovCi0KLVdlYkluc3BlY3Rvci5Ub2dnbGVDb250 cm9sVG9vbGJhckl0ZW0gPSBjbGFzcyBUb2dnbGVDb250cm9sVG9vbGJhckl0ZW0gZXh0ZW5kcyBX ZWJJbnNwZWN0b3IuVG9nZ2xlQnV0dG9uTmF2aWdhdGlvbkl0ZW0KLXsKLSAgICBjb25zdHJ1Y3Rv cihpZGVudGlmaWVyLCBkZWZhdWx0VG9vbFRpcCwgYWx0ZXJuYXRlVG9vbFRpcCwgZGVmYXVsdElt YWdlLCBhbHRlcm5hdGVJbWFnZSwgaW1hZ2VXaWR0aCwgaW1hZ2VIZWlnaHQpCi0gICAgewotICAg ICAgICBzdXBlcihpZGVudGlmaWVyLCBkZWZhdWx0VG9vbFRpcCwgYWx0ZXJuYXRlVG9vbFRpcCwg ZGVmYXVsdEltYWdlLCBhbHRlcm5hdGVJbWFnZSwgaW1hZ2VXaWR0aCwgaW1hZ2VIZWlnaHQsIGZh bHNlKTsKLSAgICB9Ci0KLSAgICAvLyBQcm90ZWN0ZWQKLQotICAgIGdldCBhZGRpdGlvbmFsQ2xh c3NOYW1lcygpCi0gICAgewotICAgICAgICByZXR1cm4gWyJ0b2dnbGUiLCAiY29udHJvbCJdOwot ICAgIH0KLX07Cg==