17139 2008-02-01 09:46:46 -0800 Add support for height property on <tbody> element 2022-07-11 16:14:47 -0700 1 1 1 Unclassified WebKit CSS 528+ (Nightly build) All All NEW HasReduction, InRadar P3 Normal --- 3239 1 mikel.walters webkit-unassigned bfulgham hyatt jamie.pate jornh mikel.walters mitz phiw2 posenato rendezvouscp webkit webkit-bug-importer webkit oldest_to_newest 69060 0 mikel.walters 2008-02-01 09:46:46 -0800 tbody works as it should in firefox... IE works but now how expected tbody.myCss { height: 100px; } This should result in the tbody (including all subsequent rows together) to be 100px. IE does not impliment this correctly and results in every subsequent row height = 100px. Very bad. Correct result exampel: tbody = 100px row1 = 25px row2 = 50px row3 = 75px 69445 1 18932 rendezvouscp 2008-02-04 23:38:30 -0800 Created attachment 18932 Test case Firefox respects the height given to tbody while nightly r29955 does not (confirmed). 69549 2 18954 rendezvouscp 2008-02-05 22:34:51 -0800 Created attachment 18954 Test case Improved test case. 69577 3 mikel.walters 2008-02-06 07:50:27 -0800 Correct result exampel: tbody = 100px row1 = 25px row2 = 50px row3 = 75px <-- I meant for this to be 25px 71133 4 webkit 2008-02-19 06:10:27 -0800 *** Bug 13017 has been marked as a duplicate of this bug. *** 80138 5 21071 magic 2008-05-11 14:32:05 -0700 Created attachment 21071 Patch This patch fix the attached test case (but contrary to the previous comments, the test case has 4 rows, doesn't it?) 80286 6 21071 mitz 2008-05-13 11:27:31 -0700 Comment on attachment 21071 Patch + int ch = max(m_grid[r].height.calcMinValue(0), style()->height().calcMinValue(0) / m_gridRows); Looks like the row heights may not add up to the section height due to rounding. 81407 7 21071 darin 2008-05-24 23:06:52 -0700 Comment on attachment 21071 Patch This seems wrong. It assumes that the height of the <tbody> can be evenly divided by the number of rows. That's clearly not correct when some rows have explicit heights themselves. For example, consider a <tbody> with a height of 100px, containing five rows where the first four rows all are 10px tall. It doesn't make sense to have the fifth row by 20px tall. It should be 60px tall. We'll need more than one test case for this, too. The test patch needs to include the expected results for the test case. Does this change affect the results of any other test cases? I'd be amazed if it didn't affect any of the hundreds of table test cases we imported from the Mozilla project. I want to hear Hyatt's take on this too. What is the correct behavior for table sections? 1882191 8 bfulgham 2022-07-11 16:14:25 -0700 WebKit still fails this test. 1882192 9 webkit-bug-importer 2022-07-11 16:14:47 -0700 <rdar://problem/96849302> 18932 2008-02-04 23:38:30 -0800 2008-02-05 22:34:51 -0800 Test case 17139.html text/html 290 rendezvouscp PCFET0NUWVBFIGh0bWw+CjxodG1sPgoJPGhlYWQ+CgkJPHRpdGxlPkJ1ZyAxNzEzOTwvdGl0bGU+ CgkJPHN0eWxlIHR5cGU9InRleHQvY3NzIj50Ym9keSB7aGVpZ2h0OiAyMDBweH08L3N0eWxlPgoJ PC9oZWFkPgoJPGJvZHk+CgkJPHRhYmxlPgoJCQk8dGJvZHk+CgkJCQk8dHI+PHRkPiMxPC90ZD48 L3RyPgoJCQkJPHRyPjx0ZD4jMjwvdGQ+PC90cj4KCQkJCTx0cj48dGQ+IzM8L3RkPjwvdHI+CgkJ CQk8dHI+PHRkPiM0PC90ZD48L3RyPgoJCQk8L3Rib2R5PgoJCTwvdGFibGU+Cgk8L2JvZHk+Cjwv aHRtbD4= 18954 2008-02-05 22:34:51 -0800 2008-02-05 22:34:51 -0800 Test case 17139.html text/html 739 rendezvouscp PCFET0NUWVBFIGh0bWw+CjxodG1sPgoJPGhlYWQ+CgkJPHRpdGxlPldlYktpdCBCdWcgMTcxMzk6 IHRib2R5IGhlaWdodCBzdXBwb3J0PC90aXRsZT4KCQk8bGluayBocmVmPSJodHRwOi8vY2hhc2Vu bGVoYXJhLmNvbS8iIHJlbD0iYXV0aG9yIiB0aXRsZT0iQ2hhc2VuIExlIEhhcmEiIC8+CgkJPHN0 eWxlIHR5cGU9InRleHQvY3NzIj4KZGl2LCB0YWJsZSB7CglsZWZ0OiAxZW07Cglwb3NpdGlvbjog YWJzb2x1dGU7Cgl0b3A6IDFlbTsKCXdpZHRoOiA1ZW0KfQpkaXYsIHRib2R5IHtoZWlnaHQ6IDEw ZW19CmRpdiB7YmFja2dyb3VuZC1jb2xvcjogcmVkfQpkaXYgc3BhbiB7Cglib3R0b206IDA7Cglw b3NpdGlvbjogYWJzb2x1dGU7Cgl0ZXh0LWFsaWduOiBjZW50ZXI7Cgl3aWR0aDogMTAwJTsKCXot aW5kZXg6IDEKfQp0YWJsZSB7Cglib3JkZXItc3BhY2luZzogMDsKCXRleHQtYWxpZ246IGNlbnRl cjsKCXotaW5kZXg6IDIKfQp0ZCB7cGFkZGluZzogMH0KdGJvZHkge2JhY2tncm91bmQtY29sb3I6 IGdyZWVufQoJPC9zdHlsZT4KCTwvaGVhZD4KCTxib2R5PgoJCTxkaXY+PHNwYW4+RkFJTDwvc3Bh bj48L2Rpdj4KCQk8dGFibGU+CgkJCTx0Ym9keT4KCQkJCTx0cj48dGQ+IzE8L3RkPjwvdHI+CgkJ CQk8dHI+PHRkPiMyPC90ZD48L3RyPgoJCQkJPHRyPjx0ZD4jMzwvdGQ+PC90cj4KCQkJCTx0cj48 dGQ+IzQ8L3RkPjwvdHI+CgkJCTwvdGJvZHk+CgkJPC90YWJsZT4KCTwvYm9keT4KPC9odG1sPg== 21071 2008-05-11 14:32:05 -0700 2010-06-10 19:22:19 -0700 Patch 17139.diff text/plain 2879 magic SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiAzMzAzMykKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTQgQEAKKzIwMDgtMDUtMTEgIFZpbmNlbnQgUmljYXJkICA8bWFnaWNAbWFnaWNu aW5qYS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgQnVnIDE3MTM5OiBBZGQgc3VwcG9ydCBmb3IgaGVpZ2h0IHByb3BlcnR5IG9uIDx0Ym9keT4g ZWxlbWVudAorCisgICAgICAgIFRlc3Q6IGZhc3QvdGFibGUvaGVpZ2h0LXByb3BlcnR5LW9uLXRi b2R5Lmh0bWwKKworICAgICAgICAqIHJlbmRlcmluZy9SZW5kZXJUYWJsZVNlY3Rpb24uY3BwOgor ICAgICAgICAoV2ViQ29yZTo6UmVuZGVyVGFibGVTZWN0aW9uOjpjYWxjUm93SGVpZ2h0KToKKwog MjAwOC0wNS0xMSAgU2FtIFdlaW5pZyAgPHNhbUB3ZWJraXQub3JnPgogCiAgICAgICAgIFJldmll d2VkIGJ5IERhbiBCZXJuc3RlaW4uCkluZGV4OiBXZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJUYWJs ZVNlY3Rpb24uY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvcmVuZGVyaW5nL1JlbmRlclRhYmxl U2VjdGlvbi5jcHAJKHJldmlzaW9uIDMzMDMxKQorKysgV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVy VGFibGVTZWN0aW9uLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMzIyLDcgKzMyMiw3IEBAIGludCBS ZW5kZXJUYWJsZVNlY3Rpb246OmNhbGNSb3dIZWlnaHQoKQogICAgICAgICBtX2dyaWRbcl0uYmFz ZWxpbmUgPSAwOwogICAgICAgICBpbnQgYmFzZWxpbmUgPSAwOwogICAgICAgICBpbnQgYmRlc2Mg PSAwOwotICAgICAgICBpbnQgY2ggPSBtX2dyaWRbcl0uaGVpZ2h0LmNhbGNNaW5WYWx1ZSgwKTsK KyAgICAgICAgaW50IGNoID0gbWF4KG1fZ3JpZFtyXS5oZWlnaHQuY2FsY01pblZhbHVlKDApLCBz dHlsZSgpLT5oZWlnaHQoKS5jYWxjTWluVmFsdWUoMCkgLyBtX2dyaWRSb3dzKTsKICAgICAgICAg aW50IHBvcyA9IG1fcm93UG9zW3JdICsgY2ggKyAobV9ncmlkW3JdLnJvd1JlbmRlcmVyID8gc3Bh Y2luZyA6IDApOwogCiAgICAgICAgIG1fcm93UG9zW3IgKyAxXSA9IG1heChtX3Jvd1Bvc1tyICsg MV0sIHBvcyk7CkluZGV4OiBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5 b3V0VGVzdHMvQ2hhbmdlTG9nCShyZXZpc2lvbiAzMzAzMykKKysrIExheW91dFRlc3RzL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEyIEBACisyMDA4LTA1LTExICBWaW5jZW50 IFJpY2FyZCAgPG1hZ2ljQG1hZ2ljbmluamEub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgIFRlc3RjYXNlIGZvcgorICAgICAgICAxNzEzOTogQWRk IHN1cHBvcnQgZm9yIGhlaWdodCBwcm9wZXJ0eSBvbiA8dGJvZHk+IGVsZW1lbnQKKworICAgICAg ICAqIGZhc3QvdGFibGUvaGVpZ2h0LXByb3BlcnR5LW9uLXRib2R5Lmh0bWw6IEFkZGVkLgorCiAy MDA4LTA1LTA5ICBTYW0gV2VpbmlnICA8c2FtQHdlYmtpdC5vcmc+CiAKICAgICAgICAgUmV2aWV3 ZWQgYnkgTWFyayBSb3dlLgpJbmRleDogTGF5b3V0VGVzdHMvZmFzdC90YWJsZS9oZWlnaHQtcHJv cGVydHktb24tdGJvZHkuaHRtbAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9mYXN0L3RhYmxl L2hlaWdodC1wcm9wZXJ0eS1vbi10Ym9keS5odG1sCShyZXZpc2lvbiAwKQorKysgTGF5b3V0VGVz dHMvZmFzdC90YWJsZS9oZWlnaHQtcHJvcGVydHktb24tdGJvZHkuaHRtbAkocmV2aXNpb24gMCkK QEAgLTAsMCArMSw0MiBAQAorPCFET0NUWVBFIGh0bWw+Cis8aHRtbD4KKwk8aGVhZD4KKwkJPHRp dGxlPldlYktpdCBCdWcgMTcxMzk6IHRib2R5IGhlaWdodCBzdXBwb3J0PC90aXRsZT4KKwkJPGxp bmsgaHJlZj0iaHR0cDovL2NoYXNlbmxlaGFyYS5jb20vIiByZWw9ImF1dGhvciIgdGl0bGU9IkNo YXNlbiBMZSBIYXJhIiAvPgorCQk8c3R5bGUgdHlwZT0idGV4dC9jc3MiPgorZGl2LCB0YWJsZSB7 CisJbGVmdDogMWVtOworCXBvc2l0aW9uOiBhYnNvbHV0ZTsKKwl0b3A6IDFlbTsKKwl3aWR0aDog NWVtCit9CitkaXYsIHRib2R5IHtoZWlnaHQ6IDEwZW19CitkaXYge2JhY2tncm91bmQtY29sb3I6 IHJlZH0KK2RpdiBzcGFuIHsKKwlib3R0b206IDA7CisJcG9zaXRpb246IGFic29sdXRlOworCXRl eHQtYWxpZ246IGNlbnRlcjsKKwl3aWR0aDogMTAwJTsKKwl6LWluZGV4OiAxCit9Cit0YWJsZSB7 CisJYm9yZGVyLXNwYWNpbmc6IDA7CisJdGV4dC1hbGlnbjogY2VudGVyOworCXotaW5kZXg6IDIK K30KK3RkIHtwYWRkaW5nOiAwfQordGJvZHkge2JhY2tncm91bmQtY29sb3I6IGdyZWVufQorCTwv c3R5bGU+CisJPC9oZWFkPgorCTxib2R5PgorCQk8ZGl2PjxzcGFuPkZBSUw8L3NwYW4+PC9kaXY+ CisJCTx0YWJsZT4KKwkJCTx0Ym9keT4KKwkJCQk8dHI+PHRkPiMxPC90ZD48L3RyPgorCQkJCTx0 cj48dGQ+IzI8L3RkPjwvdHI+CisJCQkJPHRyPjx0ZD4jMzwvdGQ+PC90cj4KKwkJCQk8dHI+PHRk PiM0PC90ZD48L3RyPgorCQkJPC90Ym9keT4KKwkJPC90YWJsZT4KKwk8L2JvZHk+Cis8L2h0bWw+ ClwgTm8gbmV3bGluZSBhdCBlbmQgb2YgZmlsZQo=